uia 0.4.1 → 0.4.2

data/ChangeLog

@@ -1,3 +1,14 @@
+===	Version 0.4.2 / 2014-05-21
+*	Enhancements
+		*		Exceptions on the .NET side of things now include stack trace
+		information
+		*		Better errors when elements that are expected to exist are no longer
+		there
+
+*	Bug Fixes
+		*		Fixes a potential memory leak if an ElementNotAvailableException
+		occurs when grabbing elements
+
 === Version 0.4.1 / 2014-05-14
 *   Enhancements
     *   Element#help_text

data/ext/UiaDll/UiaDll.Test/ElementInformationTest.cpp

@@ -133,3 +133,107 @@ TEST_F(ElementInformationTest, ItIsNullIfThereAreNoElements) {
   array<Element^>^ nullElements = nullptr;
   ASSERT_EQ(NULL, ElementInformation::From(nullElements));
 }
+
+TEST_F(ElementInformationTest,  BadThingsHappenInChildren_ItCleansUpWhatItAllocated) {
+  auto badElement = gcnew ElementStub("Bad element", 123);
+  badElement->SetupBoundingRectangleToThrow();
+
+  Exception^ caughtException = nullptr;
+
+  try {
+    ElementInformation::From(gcnew ElementStub("Good element", 456), badElement);
+  } catch(Exception^ e) { caughtException = e; }
+
+  ASSERT_TRUE(caughtException != nullptr);
+}
+
+TEST_F(ElementInformationTest, BadThingsHappenForSingleElement_ItCleansUp) {
+  auto badElement = gcnew ElementStub("Bad element", 123);
+  badElement->SetupBoundingRectangleToThrow();
+
+  Exception^ caughtException = nullptr;
+
+  try {
+    ElementInformation::From(badElement);
+  } catch(Exception^ e) { caughtException = e; }
+
+  // should have cleaned up memory
+  ASSERT_TRUE(caughtException != nullptr);
+}
+
+#define GRAB_VARARGS(argument_list, arg_type, arg_count) \
+   va_list arguments;\
+   va_start(arguments, arg0);\
+   list<##arg_type##> ##argument_list##;\
+   ##argument_list##.push_back(arg0);\
+   for(auto index = 1; index < ##arg_count##; ++index) {\
+     auto value = va_arg(arguments, ##arg_type##);\
+     ##argument_list##.push_back(value);\
+   }
+
+#define ASSERT_EXPECTED_EL_TO_STRING(expectedValue) \
+  auto length = 0; \
+  auto expectedLength = strlen(expectedValue) + 1; \
+  ASSERT_EQ(expectedLength, length = el.ToString(NULL, 0)); \
+  auto actual = new char[expectedLength]; \
+  el.ToString(actual, expectedLength); \
+  ASSERT_STREQ(expectedValue, actual); \
+  delete[] actual;
+
+TEST(ElementInformation, ToString_AllEmpty)
+{
+  ElementInformation el;
+  ASSERT_EXPECTED_EL_TO_STRING("id: (null), name: (null), handle: 0x0, runtime_id: (null)");
+}
+
+TEST(ElementInformation, ToString_HasId)
+{
+  ElementInformation el;
+  el.id = StringHelper::ToUnmanaged("someId");
+  ASSERT_EXPECTED_EL_TO_STRING("id: someId, name: (null), handle: 0x0, runtime_id: (null)");
+}
+
+TEST(ElementInformation, ToString_HasName)
+{
+  ElementInformation el;
+  el.name = StringHelper::ToUnmanaged("someName");
+  ASSERT_EXPECTED_EL_TO_STRING("id: (null), name: someName, handle: 0x0, runtime_id: (null)");
+}
+
+TEST(ElementInformation, ToString_HasHandle)
+{
+  ElementInformation el;
+  el.nativeWindowHandle = 0x123;
+  ASSERT_EXPECTED_EL_TO_STRING("id: (null), name: (null), handle: 0x123, runtime_id: (null)");
+}
+
+TEST(ElementInformation, ToString_HasRuntimeId)
+{
+  ElementInformation el;
+  el.runtimeId = new int[2];
+  el.runtimeId[0] = 123; el.runtimeId[1] = 456;
+  el.runtimeIdLength = 2;
+  ASSERT_EXPECTED_EL_TO_STRING("id: (null), name: (null), handle: 0x0, runtime_id: [123, 456]");
+}
+
+TEST(ElementInformation, ToString_AllTheThings)
+{
+  ElementInformation el;
+  el.name = StringHelper::ToUnmanaged("someName");
+  el.id = StringHelper::ToUnmanaged("someId");
+  el.nativeWindowHandle = 0xffff;
+  el.runtimeId = new int[1];
+  el.runtimeId[0] = 42789;
+  el.runtimeIdLength = 1;
+  ASSERT_EXPECTED_EL_TO_STRING("id: someId, name: someName, handle: 0xffff, runtime_id: [42789]");
+}
+
+TEST(ElementInformation, ToManagedString)
+{
+  ElementInformation el;
+  el.name = StringHelper::ToUnmanaged("someName");
+
+  auto actual = StringHelper::ToUnmanaged(el.ToManagedString());
+  ASSERT_STREQ("id: (null), name: someName, handle: 0x0, runtime_id: (null)", actual);
+  delete[] actual;
+}

data/ext/UiaDll/UiaDll.Test/ElementStub.h

@@ -59,7 +59,16 @@ public:
 
   virtual property array<int>^ BoundingRectangle
   {
-    array<int>^ get() override { return gcnew array<int> {0, 0, 0, 0}; }
+    array<int>^ get() override {
+      if( _throwOnBoundingRectangle ) {
+        throw gcnew System::Windows::Automation::ElementNotAvailableException("oops");
+      }
+      return gcnew array<int> {0, 0, 0, 0};
+    }
+  }
+
+  void SetupBoundingRectangleToThrow() {
+    _throwOnBoundingRectangle = true;
   }
 
   virtual property int NativeWindowHandle
@@ -96,4 +105,5 @@ private:
   bool _isEnabled;
   bool _isVisible;
   bool _hasKeyboardFocus;
+  bool _throwOnBoundingRectangle;
 };

data/ext/UiaDll/UiaDll/ConditionMethods.cpp

@@ -25,7 +25,7 @@ extern "C" {
 
       return new SearchCondition(patternIds);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }

data/ext/UiaDll/UiaDll/ElementMethods.cpp

@@ -5,12 +5,22 @@ using namespace UIA::Helper;
 
 extern "C" {
   Element^ ElementFrom(ElementInformationPtr element) {
-    if( element->nativeWindowHandle > 0 ) {
-      return Element::ByHandle(IntPtr(element->nativeWindowHandle));
+    Element^ foundElement = nullptr;
+
+    try {
+      if( element->nativeWindowHandle > 0 ) {
+        foundElement = Element::ByHandle(IntPtr(element->nativeWindowHandle));
+      } else {
+        foundElement = Element::ByRuntimeId(ArrayHelper::ToArray(element->runtimeId, element->runtimeIdLength));
+      }
+    } catch(Exception^) { }
+
+    if( nullptr == foundElement ) {
+      throw gcnew Exception(String::Format("Element no longer exists ({0})", element->ToManagedString()));
     }
 
-  return Element::ByRuntimeId(ArrayHelper::ToArray(element->runtimeId, element->runtimeIdLength));
-}
+    return foundElement;
+  }
   __declspec(dllexport) void Element_Release(ElementInformationPtr elementInformation) {
     delete elementInformation;
   }
@@ -19,7 +29,7 @@ extern "C" {
     try {
       element->Refresh(ElementFrom(element));
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 
@@ -27,7 +37,7 @@ extern "C" {
     try {
       ElementFrom(element)->SendKeys(gcnew String(keysToSend));
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 
@@ -36,18 +46,18 @@ extern "C" {
       auto scope = (TreeScope) Enum::Parse(TreeScope::typeid, gcnew String(treeScope));
       return ElementInformation::From(ElementFrom(element)->FindFirst(scope, ConditionHelper::ConditionFrom(conditions)));
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
 
     return NULL;
   }
 
-  #pragma managed(push, off)
+#pragma managed(push, off)
   __declspec(dllexport) ElementInformationPtr FindFirst(ElementInformationPtr element, const char* treeScope, char* errorInfo, const int errorInfoLength, const int count, SearchConditionPtr arg0, ...) {
     GRAB_VARARGS(conditions, SearchConditionPtr, count);
     return ManagedFindFirst(element, treeScope, conditions, errorInfo, errorInfoLength);
   }
-  #pragma managed(pop)
+#pragma managed(pop)
 
   int ManagedFindAll(ElementInformationPtr element, ElementInformation** elements, const char* treeScope, list<SearchConditionPtr>& conditions, char* errorInfo, const int errorInfoLength) {
     try {
@@ -56,24 +66,24 @@ extern "C" {
       *elements = ElementInformation::From(foundElements);
       return foundElements->Length;
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message + Environment::NewLine + e->StackTrace, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
 
     return 0;
   }
 
-  #pragma managed(push, off)
+#pragma managed(push, off)
   __declspec(dllexport) int FindAll(ElementInformationPtr parent, ElementInformation** elements, const char* treeScope, char* errorInfo, const int errorInfoLength, const int count, SearchConditionPtr arg0, ...) {
     GRAB_VARARGS(conditions, SearchConditionPtr, count);
     return ManagedFindAll(parent, elements, treeScope, conditions, errorInfo, errorInfoLength);
   }
-  #pragma managed(pop)
+#pragma managed(pop)
 
   __declspec(dllexport) ElementInformationPtr Element_FindById(const char* automationId, char* errorInfo, const int errorLength) {
     try {
       return ElementInformation::From(Element::ById(gcnew String(automationId)));
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
     }
 
     return NULL;
@@ -83,7 +93,7 @@ extern "C" {
     try {
       return ElementInformation::From(Element::ByName(gcnew String(name)));
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
     }
 
     return NULL;
@@ -93,7 +103,7 @@ extern "C" {
     try {
       return ElementInformation::From(Element::ByProcessId(processId));
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
     }
 
     return NULL;
@@ -103,7 +113,7 @@ extern "C" {
     try {
       return new ElementInformation(Element::ByHandle(IntPtr(windowHandle)));
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
     }
 
     return NULL;
@@ -113,7 +123,7 @@ extern "C" {
     try {
       return ElementInformation::From(Element::ByRuntimeId(ArrayHelper::ToArray(runtimeIds, numberOfIds)));
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
     }
 
     return NULL;
@@ -125,7 +135,7 @@ extern "C" {
       *children = ElementInformation::From(windows);
       return windows->Length;
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return 0;
     }
   }
@@ -136,7 +146,7 @@ extern "C" {
       *children = ElementInformation::From(elements);
       return elements->Length;
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
       return 0;
     }
   }
@@ -147,7 +157,7 @@ extern "C" {
       *descendants = ElementInformation::From(elements);
       return elements->Length;
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
       return 0;
     }
   }
@@ -156,7 +166,7 @@ extern "C" {
     try {
       ElementFrom(element)->ClickClickablePoint();
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
     }
   }
 
@@ -164,7 +174,7 @@ extern "C" {
     try {
       ElementFrom(element)->ClickCenter();
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
     }
   }
 
@@ -172,7 +182,7 @@ extern "C" {
     try {
       ElementFrom(element)->SetFocus();
     } catch(Exception^ error) {
-      StringHelper::CopyToUnmanagedString(error->Message, errorInfo, errorLength);
+      StringHelper::CopyToUnmanagedString(error, errorInfo, errorLength);
     }
   }
 

data/ext/UiaDll/UiaDll/ElementStructures.h

@@ -1,6 +1,7 @@
 #pragma once
 #include "ArrayHelper.h"
 #include "StringHelper.h"
+#include <stdio.h>
 
 typedef struct _ElementInformation {
   int nativeWindowHandle;
@@ -34,8 +35,14 @@ typedef struct _ElementInformation {
 
     auto elementInformation = new _ElementInformation[elements->Length];
     auto index = 0;
-    for each(auto element in elements) {
-      elementInformation[index++].Refresh(element);
+
+    try {
+      for each(auto element in elements) {
+        elementInformation[index++].Refresh(element);
+      }
+    } catch(Exception^) {
+      delete[] elementInformation;
+      throw;
     }
 
     return elementInformation;
@@ -43,28 +50,52 @@ typedef struct _ElementInformation {
 
   void Refresh(Element^ element) {
     Reset();
-    id = StringHelper::ToUnmanaged(element->Id);
-    name = StringHelper::ToUnmanaged(element->Name);
-    className = StringHelper::ToUnmanaged(element->ClassName);
-    nativeWindowHandle = element->NativeWindowHandle;
-    runtimeId = ArrayHelper::FromArray(element->RuntimeId);
-    runtimeIdLength = element->RuntimeId->Length;
-    controlTypeId = element->ControlTypeId;
-    patterns = ArrayHelper::FromArray(element->SupportedPatternIds);
-    patternsLength = element->SupportedPatternIds->Length;
-
-    isEnabled = element->IsEnabled;
-    isVisible = element->IsVisible;
-    hasKeyboardFocus = element->HasKeyboardFocus;
-
-    helpText = StringHelper::ToUnmanaged(element->HelpText);
-
-    auto r = element->BoundingRectangle;
-    for(auto coord = 0; coord < 4; coord++) {
-      boundingRectangle[coord] = r[coord];
+
+    try {
+      id = StringHelper::ToUnmanaged(element->Id);
+      name = StringHelper::ToUnmanaged(element->Name);
+      className = StringHelper::ToUnmanaged(element->ClassName);
+      nativeWindowHandle = element->NativeWindowHandle;
+      runtimeId = ArrayHelper::FromArray(element->RuntimeId);
+      runtimeIdLength = element->RuntimeId->Length;
+      controlTypeId = element->ControlTypeId;
+      patterns = ArrayHelper::FromArray(element->SupportedPatternIds);
+      patternsLength = element->SupportedPatternIds->Length;
+
+      isEnabled = element->IsEnabled;
+      isVisible = element->IsVisible;
+      hasKeyboardFocus = element->HasKeyboardFocus;
+
+      helpText = StringHelper::ToUnmanaged(element->HelpText);
+
+      auto r = element->BoundingRectangle;
+      for(auto coord = 0; coord < 4; coord++) {
+        boundingRectangle[coord] = r[coord];
+      }
+    } catch(Exception^) {
+      Reset();
+      throw;
     }
   }
 
+  const int ToString(char* s, const int length) {
+    const char* format = "id: %s, name: %s, handle: 0x%x, runtime_id: %s";
+    auto runtimeIdString = RuntimeIdString();
+    auto neededLength = _snprintf(s, length, format, id, name, nativeWindowHandle, runtimeIdString) + 1;
+    delete[] runtimeIdString;
+    return neededLength;
+  }
+
+  String^ ToManagedString() {
+    auto length = ToString(NULL, 0);
+    auto s = new char[length];
+    ToString(s, length);
+
+    auto managedString = gcnew String(s);
+    delete[] s;
+    return managedString;
+  }
+
   ~_ElementInformation() {
     Reset();
   }
@@ -75,4 +106,24 @@ private:
     name = NULL; runtimeId = NULL; patterns = NULL; id = NULL; className = NULL; helpText = NULL;
   }
 
+  char* RuntimeIdString() {
+    if(NULL == runtimeId || runtimeIdLength == 0) return NULL;
+    
+    auto max = 1000;
+    auto s = new char[max];
+    strcpy(s, "[");
+
+    char current[20] = {0};
+
+    for(auto index = 0; index < runtimeIdLength; ++index) {
+      _snprintf(current, 20, "%d, ", runtimeId[index]);
+      strncat_s(s, max, current, _TRUNCATE);
+    }
+    s[strlen(s) - 2] = NULL;
+
+    strncat_s(s, max, "]", _TRUNCATE);
+
+    return s;
+  }
+
 } ElementInformation, *ElementInformationPtr;

data/ext/UiaDll/UiaDll/ExpandCollapseMethods.cpp

@@ -10,7 +10,7 @@ extern "C" {
       auto info = ElementFrom(element)->As<ExpandCollapsePattern^>(ExpandCollapsePattern::Pattern)->Current;
       return new ExpandCollapseInfo(info.ExpandCollapseState.ToString());
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }
@@ -19,7 +19,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<ExpandCollapsePattern^>(ExpandCollapsePattern::Pattern)->Expand();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 
@@ -27,7 +27,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<ExpandCollapsePattern^>(ExpandCollapsePattern::Pattern)->Collapse();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 }

data/ext/UiaDll/UiaDll/InvokePatternMethods.cpp

@@ -5,7 +5,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<InvokePattern^>(InvokePattern::Pattern)->Invoke();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 }

data/ext/UiaDll/UiaDll/MenuItemMethods.cpp

@@ -24,7 +24,7 @@ extern "C" {
     try {
       MenuItemPath(element, items)->As<InvokePattern^>(InvokePattern::Pattern)->Invoke();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 
@@ -34,7 +34,7 @@ extern "C" {
     } catch(MenuItemNotFound^) {
       return NULL;
     } catch(Exception^ e) { 
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }

data/ext/UiaDll/UiaDll/MouseMethods.cpp

@@ -7,7 +7,7 @@ extern "C" {
     try {
       Mouse::Drag(startX, startY, endX, endY);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInformation, errorInformationLength);
+      StringHelper::CopyToUnmanagedString(e, errorInformation, errorInformationLength);
     }
   }
 }

data/ext/UiaDll/UiaDll/RangeValueMethods.cpp

@@ -9,7 +9,7 @@ extern "C" {
     try {
       return new RangeValueInformation(ElementFrom(element)->As<RangeValuePattern^>(RangeValuePattern::Pattern)->Current);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }
@@ -18,7 +18,7 @@ extern "C" {
     try {
       return ElementFrom(element)->As<RangeValuePattern^>(RangeValuePattern::Pattern)->SetValue(value);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 

data/ext/UiaDll/UiaDll/SelectionItemMethods.cpp

@@ -10,7 +10,7 @@ extern "C" {
       auto info = ElementFrom(element)->As<SelectionItemPattern^>(SelectionItemPattern::Pattern)->Current;
       return new SelectionItemInformation(info);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }
@@ -19,7 +19,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<SelectionItemPattern^>(SelectionItemPattern::Pattern)->Select();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 
@@ -27,7 +27,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<SelectionItemPattern^>(SelectionItemPattern::Pattern)->AddToSelection();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 
@@ -35,7 +35,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<SelectionItemPattern^>(SelectionItemPattern::Pattern)->RemoveFromSelection();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 }

data/ext/UiaDll/UiaDll/SelectionMethods.cpp

@@ -9,7 +9,7 @@ extern "C" {
     try {
       return new SelectionInformation(ElementFrom(element)->As<SelectionPattern^>(SelectionPattern::Pattern)->Current);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }
@@ -20,7 +20,7 @@ extern "C" {
       *selections = ElementInformation::From(selectedElements);
       return selectedElements->Length;
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return 0;
     }
   }

data/ext/UiaDll/UiaDll/StringHelper.h

@@ -5,6 +5,11 @@ using namespace System::Runtime::InteropServices;
 ref class StringHelper
 {
 public:
+  static void CopyToUnmanagedString(Exception^ e, char* destination, const int destinationSize)
+  {
+    CopyToUnmanagedString(e->Message + e->StackTrace, destination, destinationSize);
+  }
+
   static void CopyToUnmanagedString(String^ source, char* destination, const int destinationSize)
   {
     auto unmanagedString = Marshal::StringToHGlobalAnsi(source);

data/ext/UiaDll/UiaDll/TableItemMethods.cpp

@@ -9,7 +9,7 @@ extern "C" {
     try {
       return new TableItemInformation(ElementFrom(element)->As<TableItemPattern^>(TableItemPattern::Pattern)->Current);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }

data/ext/UiaDll/UiaDll/TableMethods.cpp

@@ -9,7 +9,7 @@ extern "C" {
     try {
       return new TableInformation(ElementFrom(element)->As<TablePattern^>(TablePattern::Pattern)->Current);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }
@@ -20,7 +20,7 @@ extern "C" {
       *headers = ElementInformation::From(Element::From(headerElements));
       return headerElements->Length;
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return 0;
     }
   }
@@ -30,7 +30,7 @@ extern "C" {
       auto table = ElementFrom(element);
       return ElementInformation::From(table->Find(TreeScope::Children, gcnew PropertyCondition(AutomationElement::ControlTypeProperty, ControlType::DataItem))[index]);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }

data/ext/UiaDll/UiaDll/TextMethods.cpp

@@ -10,7 +10,7 @@ extern "C" {
 
       return theText->Length;
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return 0;
     }
   }

data/ext/UiaDll/UiaDll/ToggleMethods.cpp

@@ -10,7 +10,7 @@ extern "C" {
       auto info = ElementFrom(element)->As<TogglePattern^>(TogglePattern::Pattern)->Current;
       return new ToggleInformation(info.ToggleState.ToString());
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }
@@ -19,7 +19,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<TogglePattern^>(TogglePattern::Pattern)->Toggle();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 }

data/ext/UiaDll/UiaDll/ValuePatternMethods.cpp

@@ -9,7 +9,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<ValuePattern^>(ValuePattern::Pattern)->SetValue(gcnew String(value));
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 
@@ -18,7 +18,7 @@ extern "C" {
       auto valuePattern = ElementFrom(element)->As<ValuePattern^>(ValuePattern::Pattern);
       return new ValuePatternInformation(valuePattern->Current);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }

data/ext/UiaDll/UiaDll/WindowMethods.cpp

@@ -9,7 +9,7 @@ extern "C" {
     try {
       return new WindowInformation(ElementFrom(element)->As<WindowPattern^>(WindowPattern::Pattern)->Current);
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
       return NULL;
     }
   }
@@ -18,7 +18,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<WindowPattern^>(WindowPattern::Pattern)->SetWindowVisualState((WindowVisualState) Enum::Parse(WindowVisualState::typeid, gcnew String(visualState), false));
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 
@@ -26,7 +26,7 @@ extern "C" {
     try {
       ElementFrom(element)->As<WindowPattern^>(WindowPattern::Pattern)->Close();
     } catch(Exception^ e) {
-      StringHelper::CopyToUnmanagedString(e->Message, errorInfo, errorInfoLength);
+      StringHelper::CopyToUnmanagedString(e, errorInfo, errorInfoLength);
     }
   }
 }

data/lib/uia/library.rb

@@ -172,8 +172,9 @@ module Uia
     end
 
     def self.try_catch(&block)
-      string_buffer = FFI::MemoryPointer.new :char, 1024
-      result = block.call(string_buffer, 1024)
+      buffer_size = 4096
+      string_buffer = FFI::MemoryPointer.new :char, buffer_size
+      result = block.call(string_buffer, buffer_size)
       error_info = string_buffer.read_string
       raise error_info unless error_info.empty?
       result

data/lib/uia/version.rb

@@ -1,3 +1,3 @@
 module Uia
-  VERSION = '0.4.1'
+  VERSION = '0.4.2'
 end

data/spec/uia/element_spec.rb

@@ -128,7 +128,7 @@ describe Uia::Element do
     context 'pattern' do
       Then { element.find(pattern: :range_value).id == 'numericUpDown1' }
       Then { element.find(pattern: [:selection_item, :range_value]).id == 'numericUpDown1' }
-      Then { expect { element.find(pattern: [:not_valid, :range_value]) }.to raise_error RuntimeError, 'IsNotValidPatternAvailableProperty is not a valid AutomationProperty' }
+      Then { expect { element.find(pattern: [:not_valid, :range_value]) }.to raise_error RuntimeError, /IsNotValidPatternAvailableProperty is not a valid AutomationProperty/ }
     end
 
     context 'combinations' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: uia
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-14 00:00:00.000000000 Z
+date: 2014-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -262,7 +262,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1027979665
+      hash: -370470925
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -271,7 +271,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1027979665
+      hash: -370470925
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.28