ufo 6.3.2 → 6.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee25a6ee92c06422088b489aa3f9d27d8fb0dfd229b7bb6e0b0eb2241a4d3902
-  data.tar.gz: f4a8043b8ab3bbb33794d3002d58890d8aa4753ffe3ac4b029432599195e5289
+  metadata.gz: c7412fed5f36c54bd78f76bfb6debb841d3f867ea25ef4625a31c9e205a1e955
+  data.tar.gz: a0d91c95a050d2fbce2731c10387651fb2909c3dc65a4e2af60a6cf780d3e1b7
 SHA512:
-  metadata.gz: 76beccace3016451330c40b589fa7c3f95680eff187a667f520eed80c7d4cd90b91667dd06d58288cabf4c5d5acb699cf53ecc6c296dcb48e66504a0c02147ad
-  data.tar.gz: 22700e11a6de03b489deacf6fbde1e7b5652b4048b078b1d3750dfc0f1b083e5e3bbc417057f04d9fe73e48ac609139aea92bc526ae4c33cfdee16253f341db8
+  metadata.gz: 6ee413ef0571f90417c37327d78fbb86c8fab10584746dfcbec86d292ce3f8dad8d31d53d3a939db6b9a2f91639d50ed4f876262d84c40c453ad22e610a7b46f
+  data.tar.gz: c8fe10ab749b98820faa9105584175b1c97cfcd7ecee92a1bf75e7d1623ed158c86b2ac32a834a8f4b617e252dca6c28682f8a3e4664f8dac03785117ab26bb8

data/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 This project *tries* to adhere to [Semantic Versioning](http://semver.org/), even before v1.0.
 
+## [6.3.5] - 2022-04-28
+- [#171](https://github.com/tongueroo/ufo/pull/171) default unhealthy_threshold_count = 3
+
+## [6.3.4] - 2022-04-27
+- [#168](https://github.com/tongueroo/ufo/pull/168) ufo ps: show multiple container names
+- [#169](https://github.com/tongueroo/ufo/pull/169) ufo logs improvements
+- [#170](https://github.com/tongueroo/ufo/pull/170) infer ecs managed sg based on awsvpc network mode
+
+## [6.3.3] - 2022-03-27
+- [#167](https://github.com/tongueroo/ufo/pull/167) fix edge case include_dir for ruby 2.7
+- remove update_dockerignore
+
 ## [6.3.2] - 2022-03-26
 - [#164](https://github.com/tongueroo/ufo/pull/164) existing elb target group support
 - [#165](https://github.com/tongueroo/ufo/pull/165) improve secrets support

data/lib/ufo/cfn/stack/builder/base.rb

@@ -18,22 +18,23 @@ class Ufo::Cfn::Stack::Builder
     def security_groups(type)
       group_ids = Ufo.config.vpc.security_groups[type] || []
       # no security groups at all
-      return if !managed_security_groups? && group_ids.blank?
+      return if type == :ecs && !manage_ecs_security_group? && group_ids.blank?
 
       groups = []
       groups += group_ids
-      groups += [managed_security_group(type.to_s.camelize)] if managed_security_groups?
+      groups += [managed_security_group(type)] if manage_ecs_security_group? || type == :elb
       groups
     end
 
     def managed_security_group(type)
-      logical_id = managed_security_groups? ? "#{type.camelize}SecurityGroup" : "AWS::NoValue"
+      logical_id = type == :elb || manage_ecs_security_group? ? "#{type.to_s.camelize}SecurityGroup" : "AWS::NoValue"
       {Ref: logical_id}
     end
 
-    def managed_security_groups?
-      managed = Ufo.config.vpc.security_groups.managed
-      managed.nil? ? true : managed
+    # With network mode is awsvpc always create UFO managed ECS security group
+    # With bridge mode, never create as there's no point.
+    def manage_ecs_security_group?
+      vars[:container][:network_mode].to_s == 'awsvpc'
     end
 
     def self.build(options={})

data/lib/ufo/cfn/stack/builder/resources/security_group/ecs.rb

@@ -1,7 +1,8 @@
 module Ufo::Cfn::Stack::Builder::Resources::SecurityGroup
   class Ecs < Base
     def build
-      return unless managed_security_groups?
+      return unless manage_ecs_security_group?
+      return unless vars[:container][:network_mode].to_s == 'awsvpc'
 
       {
         Type: "AWS::EC2::SecurityGroup",

data/lib/ufo/cfn/stack/builder/resources/security_group/ecs_rule.rb

@@ -1,8 +1,7 @@
 module Ufo::Cfn::Stack::Builder::Resources::SecurityGroup
   class EcsRule < Base
     def build
-      return unless managed_security_groups?
-      return unless vars[:elb_type] == "application"
+      return unless manage_ecs_security_group?
 
       {
         Type: "AWS::EC2::SecurityGroupIngress",

data/lib/ufo/cfn/stack/builder/resources/security_group/elb.rb

@@ -1,7 +1,7 @@
 module Ufo::Cfn::Stack::Builder::Resources::SecurityGroup
   class Elb < Base
     def build
-      return unless managed_security_groups?
+      # Always create elb security group it seems like its required
       return unless vars[:elb_type] == "application"
 
       {

data/lib/ufo/cli/logs.rb

@@ -6,11 +6,11 @@ class Ufo::CLI
 
     def run
       log = find_log_group_name
-      puts "Showing logs for stack: #{@stack_name} log group: #{log["awslogs-group"]} and stream prefix: #{log["awslogs-stream-prefix"]}"
+      logger.info "Showing logs for stack: #{@stack_name} log group: #{log["awslogs-group"]} and stream prefix: #{log["awslogs-stream-prefix"]}"
       if log
         cloudwatch_tail(log)
       else
-        puts "Unable to find log group for service: #{service.service_name}"
+        logger.info "Unable to find log group for service: #{service.service_name}"
       end
     end
 
@@ -24,22 +24,40 @@ class Ufo::CLI
 
       container_definitions = resp.task_definition.container_definitions
 
-      unless container_definitions.size == 1
-        puts "ERROR: ufo logs command only supports 1 container definition in the ECS task definition".color(:red)
-        return
+      if container_definitions.size > 1 && !@options[:container]
+        logger.info "Multiple containers found. ufo logs will use the first container."
+        logger.info "You can also use the --container option to set the container to use."
+      end
+
+      definition = if @options[:container]
+                     container_definitions.find do |c|
+                       c.name == @options[:container]
+                     end
+                   else
+                     container_definitions.first
+                   end
+
+      unless definition
+        logger.error "ERROR: unable to find a container".color(:red)
+        logger.error "You specified --container #{@options[:container]}" if @options[:container]
+        exit
       end
 
-      definition = container_definitions.first
       log_conf = definition.log_configuration
+      unless log_conf
+        logger.error "ERROR: Unable to find a log_configuration for container: #{definition.name}".color(:red)
+        logger.error "You specified --container #{@options[:container]}" if @options[:container]
+        exit 1
+      end
 
-      if log_conf && log_conf.log_driver == "awslogs"
+      if log_conf.log_driver == "awslogs"
         # options["awslogs-group"]
         # options["awslogs-region"]
         # options["awslogs-stream-prefix"]
         log_conf.options
       else
-        puts "Only supports awslogs driver. Detected log_driver: #{log_conf.log_driver}"
-        return
+        logger.error "ERROR: Only supports awslogs driver. Detected log_driver: #{log_conf.log_driver}".color(:red)
+        exit 1 unless ENV['UFO_TEST']
       end
     end
 

data/lib/ufo/cli/new/init.rb

@@ -39,15 +39,6 @@ class Ufo::CLI::New
       end
     end
 
-    def update_dockerignore
-      text = ".ufo\n"
-      if File.exist?(".dockerignore")
-        append_to_file ".dockerignore", text
-      else
-        create_file ".dockerignore", text
-      end
-    end
-
     def create_dockefile
       return if File.exist?("Dockerfile")
       set_template_source("docker")

data/lib/ufo/cli/ps/task.rb

@@ -16,12 +16,36 @@ class Ufo::CLI::Ps
 
     def name
       container_overrides = @task.dig("overrides", "container_overrides")
-      overrides = container_overrides.first # assume first is one we want
-      overrides["name"] if overrides # PENDING wont yet have info
+      overrides = container_overrides # assume first is one we want
+      if !overrides.empty? # PENDING wont yet have info
+        overrides.map { |i| i["name"]  }.join(',')
+      else
+        container_names
+      end
     rescue NoMethodError
-      container = @task["containers"].first
-      container["name"] if container # PENDING wont yet have info
+      container_names
+    end
+
+    # PENDING wont yet have any containers yet but since using task definition we're ok
+    def container_names
+      task_definition = task_definition(@task.task_definition_arn)
+      names = task_definition.container_definitions.map do |container_definition|
+        container_definition.name
+      end
+      names.join(',')
+    end
+
+    # ECS inconsistently returns the container names in random order
+    # Look up the names from the task definition to try and get right order
+    # This still seems to return inconsistently.
+    # IE: Not the order that was defined in the task definition originally
+    def task_definition(task_definition_arn)
+      resp = ecs.describe_task_definition(
+        task_definition: task_definition_arn,
+      )
+      resp.task_definition
     end
+    memoize :task_definition
 
     def container_instance_arn
       @task['container_instance_arn'].split('/').last

data/lib/ufo/cli.rb

@@ -64,6 +64,7 @@ module Ufo
     option :since, desc: "From what time to begin displaying logs.  By default, logs will be displayed starting from 1 minutes in the past. The value provided can be an ISO 8601 timestamp or a relative time."
     option :format, default: "short", desc: "The format to display the logs. IE: detailed or short.  With detailed, the log stream name is also shown."
     option :filter_pattern, desc: "The filter pattern to use. If not provided, all the events are matched"
+    option :container, aliases: :c, desc: "Container name to show logs for. Only needed when ECS task multiple containers"
     def logs
       Logs.new(options).run
     end

data/lib/ufo/config.rb

@@ -70,7 +70,7 @@ module Ufo
       config.elb.health_check_interval_seconds = 10 # keep at 10 in case of network ELB, which is min 10
       config.elb.health_check_path = nil # When nil its AWS default /
       config.elb.healthy_threshold_count = 3 # The AWS usual default is 5
-      config.elb.unhealthy_threshold_count = 2
+      config.elb.unhealthy_threshold_count = 3
 
       config.elb.port = 80 # default listener port
       config.elb.redirect = ActiveSupport::OrderedOptions.new
@@ -138,7 +138,6 @@ module Ufo
       config.vpc.security_groups = ActiveSupport::OrderedOptions.new
       config.vpc.security_groups.ecs = nil
       config.vpc.security_groups.elb = nil
-      config.vpc.security_groups.managed = true
       config.vpc.subnets = ActiveSupport::OrderedOptions.new
       config.vpc.subnets.ecs = nil
       config.vpc.subnets.elb = nil

data/lib/ufo/ext/core/module.rb

@@ -17,10 +17,21 @@ class Module
     parent_dir = File.dirname(calling_file)
 
     full_dir = "#{parent_dir}/#{dir}"
-    paths = Dir.glob("#{full_dir}/**/*.rb")
+    # Tricky: Only include top-level dir. Do not include subdirs.
+    # Fixes ruby 2.7 issue where just calling constantize on Vars::Builder
+    # triggers Ufo::Config::CallableOption::Concern to load and causes
+    # And causes some helper methods to be missing. Error looks like this:
+    #
+    #    undefined method `stack_output' for #<Ufo::Config:0x0000000006585268>
+    #
+    # This is because stack_output is loaded after afterwards.
+    #
+    paths = Dir.glob("#{full_dir}/*.rb")
     if paths.empty?
       raise "Empty include_modules full_dir: #{full_dir}"
     end
+
+    paths.sort_by! { |p| p.size }
     paths.each do |path|
       regexp = Regexp.new(".*/lib/")
       mod = path.sub(regexp, '').sub('.rb','').camelize

data/lib/ufo/info.rb

@@ -23,9 +23,18 @@ module Ufo
       load_balancer = service.load_balancers.first
       return unless load_balancer
 
-      resp = elb.describe_target_groups(
-        target_group_arns: [load_balancer.target_group_arn]
-      )
+      begin
+        resp = elb.describe_target_groups(
+          target_group_arns: [load_balancer.target_group_arn]
+        )
+      rescue Aws::ElasticLoadBalancingV2::Errors::TargetGroupNotFound
+        # Super edge case when:
+        # 1. deploy with ELB
+        # 2. deploy again without ELB
+        # 3. ECS service sometimes still thinks there's an ELB
+        # Error: https://gist.github.com/tongueroo/dc41f408e65414ab5ee864d0d738d81a
+        return
+      end
       target_group = resp.target_groups.first
       load_balancer_arn = target_group.load_balancer_arns.first # assume first only
       return unless load_balancer_arn # can occur while stack is being deleted

data/lib/ufo/task_definition/helpers/{vars/aws_helper.rb → aws_helper.rb}

@@ -1,4 +1,4 @@
-module Ufo::TaskDefinition::Helpers::Vars
+module Ufo::TaskDefinition::Helpers
   # Named AwsHelper to avoid possible conflict with Aws elsewhere
   module AwsHelper
     extend Memoist

data/lib/ufo/task_definition/helpers/vars/builder.rb

@@ -3,9 +3,9 @@ require "aws_data"
 module Ufo::TaskDefinition::Helpers::Vars
   class Builder
     extend Memoist
-    include AwsHelper
     include Ufo::Concerns::Names
     include Ufo::Config::CallableOption::Concern
+    include Ufo::TaskDefinition::Helpers::AwsHelper
     include Ufo::Utils::CallLine
     include Ufo::Utils::Logging
     include Ufo::Utils::Pretty

data/lib/ufo/version.rb

@@ -1,3 +1,3 @@
 module Ufo
-  VERSION = "6.3.2"
+  VERSION = "6.3.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ufo
 version: !ruby/object:Gem::Version
-  version: 6.3.2
+  version: 6.3.5
 platform: ruby
 authors:
 - Tung Nguyen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-03-26 00:00:00.000000000 Z
+date: 2022-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-logs
@@ -648,6 +648,7 @@ files:
 - lib/ufo/task_definition/erb/yaml.rb
 - lib/ufo/task_definition/helpers.rb
 - lib/ufo/task_definition/helpers/acm.rb
+- lib/ufo/task_definition/helpers/aws_helper.rb
 - lib/ufo/task_definition/helpers/docker.rb
 - lib/ufo/task_definition/helpers/ecr.rb
 - lib/ufo/task_definition/helpers/expansion.rb
@@ -655,7 +656,6 @@ files:
 - lib/ufo/task_definition/helpers/ssm/fetcher.rb
 - lib/ufo/task_definition/helpers/stack_output.rb
 - lib/ufo/task_definition/helpers/vars.rb
-- lib/ufo/task_definition/helpers/vars/aws_helper.rb
 - lib/ufo/task_definition/helpers/vars/builder.rb
 - lib/ufo/task_definition/helpers/vpc.rb
 - lib/ufo/task_definition/helpers/waf.rb
@@ -716,7 +716,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.3.12
 signing_key: 
 specification_version: 4
 summary: AWS ECS Deploy Tool