ufo 6.0.0 → 6.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f7705c4016b08dd205ad9209ee255b6cd3411fea731183b6c859b28cf900990
-  data.tar.gz: 4eb918b33c3a87ed71fbc64e3a0dbac8766a02ccbf15d7e35b863a26f7fd78a3
+  metadata.gz: 2ddf01cabd60971596b36544d0e7e91484e935143d83fa1410eb6a5d29e06dff
+  data.tar.gz: 5bc24a9f42c06fb4ee486fbda776c2d8ffe4f7f35b3fce74f3837dfcded1c7b8
 SHA512:
-  metadata.gz: c65f585f02f1a54afa5c3c2c0a36378e219b8490eec8321d1dd18f9cec4026108f39e11215d0ec964b1842dbca8ade66d4f7e0b256c41386f86eb0db60f931b2
-  data.tar.gz: 16226423b75d58394e9e92dcd4562629e9defc5ed46a2acad4e0f049deca9e0c525e2ddaec984eaac616edebe996c1e8e154f3ea3fbb73ae8dfd108bd68958cf
+  metadata.gz: 8a0ca12fac2697a82bb8b2930a5d20eef0dba27ac7c9be684a221b271d765fd923fd32f91b5fb5bf7aeafb416a4479e42be770055575451bae5102c0aba64a54
+  data.tar.gz: fd9c668daf4d70bc37f6898ea224578cfd3d47e87aa3d691f903664083fe3fd7083dabb8b279a2082a3283e4fd8a3d83413806a0e6c208e1489362b81041ac6f

data/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 This project *tries* to adhere to [Semantic Versioning](http://semver.org/), even before v1.0.
 
+## [6.0.3] - 2022-03-07
+- [#133](https://github.com/tongueroo/ufo/pull/133) improve ufo central and add helpers
+
+## [6.0.2] - 2022-03-06
+- [#128](https://github.com/tongueroo/ufo/pull/128) cleanup region with aws_data
+- [#129](https://github.com/tongueroo/ufo/pull/129) Scale and Ps Edge Cases
+- [#130](https://github.com/tongueroo/ufo/pull/130) compiled yaml errors: print code with line number context
+- [#131](https://github.com/tongueroo/ufo/pull/131) ufo central update symlink creation
+- [#132](https://github.com/tongueroo/ufo/pull/132) ufo ps improvements better catchall error messages reporting
+
+## [6.0.1] - 2022-03-05
+- [#126](https://github.com/tongueroo/ufo/pull/126) ecs deployment_configuration options
+- [#127](https://github.com/tongueroo/ufo/pull/127) improve ps errors reporting
+
 ## [6.0.0] - 2022-03-05
 - [#125](https://github.com/tongueroo/ufo/pull/125) v6: major ufo upgrades and new structure
 

data/lib/templates/init/.ufo/resources/task_definitions/web.yml

@@ -16,6 +16,8 @@ containerDefinitions:
     protocol: tcp
 <% end -%>
   command: <%= @command.to_json %>
+  linuxParameters:
+    initProcessEnabled: true
   environment: <%= @environment.to_json if @environment %>
   secrets: <%= @secrets.to_json if @secrets %>
 <% if @awslogs_group -%>

data/lib/ufo/aws_services.rb

@@ -1,3 +1,4 @@
+require "aws-sdk-acm"
 require "aws-sdk-applicationautoscaling"
 require "aws-sdk-cloudformation"
 require "aws-sdk-cloudwatchlogs"
@@ -14,6 +15,11 @@ module Ufo
   module AwsServices
     extend Memoist
 
+    def acm
+      Aws::ACM::Client.new(aws_options)
+    end
+    memoize :acm
+
     def applicationautoscaling
       Aws::ApplicationAutoScaling::Client.new(aws_options)
     end

data/lib/ufo/cfn/stack/builder/resources/ecs_service.rb

@@ -14,6 +14,7 @@ class Ufo::Cfn::Stack::Builder::Resources
     def properties
       props = {
         Cluster: @cluster,
+        DeploymentConfiguration: deployment_configuration,
         DesiredCount: {
           "Fn::If": [
             "EcsDesiredCountIsBlank",
@@ -68,5 +69,17 @@ class Ufo::Cfn::Stack::Builder::Resources
 
       props
     end
+
+  private
+    def deployment_configuration
+      ecs = Ufo.config.ecs
+      return ecs.configuration if ecs.configuration # provide user full control
+
+      # default
+      {
+        MaximumPercent: ecs.maximum_percent,
+        MinimumHealthyPercent: ecs.minimum_healthy_percent,
+      }
+    end
   end
 end

data/lib/ufo/cfn/stack/builder/resources/target_group.rb

@@ -32,8 +32,23 @@ class Ufo::Cfn::Stack::Builder::Resources
 
       props[:TargetType] = "ip" if vars[:container][:network_mode] == "awsvpc"
       props[:HealthCheckPort] = vars[:container][:port] if vars[:elb_type] == "network" && vars[:network_mode] == "awsvpc"
+      props[:HealthCheckPath] = health_check_path
+      props[:HealthCheckIntervalSeconds] = health_check_interval_seconds
+      props[:HealthyThresholdCount] = healthy_threshold_count
+      props[:UnhealthyThresholdCount] = unhealthy_threshold_count
 
       props
     end
+
+    meths = %w[
+      health_check_interval_seconds
+      health_check_path
+      healthy_threshold_count
+      unhealthy_threshold_count
+    ]
+    delegate *meths, to: :elb
+    def elb
+      Ufo.config.elb
+    end
   end
 end

data/lib/ufo/cfn/stack/builder.rb

@@ -24,6 +24,9 @@ class Ufo::Cfn::Stack
       path = ".ufo/output/template.yml"
       IO.write("#{Ufo.root}/#{path}", text)
       logger.info "Template built:        #{path}"
+      # Only basic YAML validation. Doesnt check for everything CloudFormation checks.
+      # For CloudFormation checks handled with an exception handler in Cfn::Stack#print_code(exception)
+      Ufo::Yaml.validate!(path)
       text
     end
   end

data/lib/ufo/cfn/stack.rb

@@ -52,16 +52,7 @@ module Ufo::Cfn
 
     def perform(action)
       logger.info "#{action[0..-2].capitalize}ing stack #{@stack_name.color(:green)}"
-      # Example: cloudformation.send("update_stack", stack_options)
-
-      # o = stack_options.dup
-      # o[:template_body] = '...' if o[:template_body]
-      # puts "stack_options:"
-      # pp o
-      # puts "parameters:"
-      # pp o[:parameters]
-
-      cloudformation.send("#{action}_stack", stack_options)
+      cloudformation.send("#{action}_stack", stack_options) # Example: cloudformation.send("update_stack", stack_options)
     rescue Aws::CloudFormation::Errors::ValidationError => e
       handle_stack_error(e)
     end
@@ -117,7 +108,6 @@ module Ufo::Cfn
     memoize :rollback_task_definition
 
     def exit_with_message(stack)
-      region = `aws configure get region`.strip rescue "us-east-1"
       url = "https://console.aws.amazon.com/cloudformation/home?region=#{region}#/stacks"
       logger.info "The stack is not in an updateable state: #{stack.stack_status.color(:yellow)}."
       logger.info "Here's the CloudFormation url to check for more details #{url}"
@@ -134,13 +124,28 @@ module Ufo::Cfn
         if message.include?('UPDATE_ROLLBACK_FAILED')
           logger.info "You might be able to do a 'Continue Update Rollback' and skip some resources to get the stack back into a good state."
         end
-        region = `aws configure get region`.strip rescue 'us-east-1'
         url = "https://console.aws.amazon.com/cloudformation/home?region=#{region}"
         logger.info "Here's the CloudFormation console url: #{url}"
         exit 1
       when /No updates are to be performed/
         logger.info "There are no updates to be performed. Exiting.".color(:yellow)
         exit 1
+      when /YAML not well-formed/ # happens if a value is a serialize Ruby Object. See: https://gist.github.com/tongueroo/737531d0bc8c92d92b5cd00493e15d9e
+        # e.message: Template format error: YAML not well-formed. (line 207, column 9)
+        print_code(e)
+      else
+        raise
+      end
+    end
+
+    def print_code(exception)
+      path = ".ufo/output/template.yml"
+      md = exception.message.match(/line (\d+),/)
+      line_number = md[1]
+      logger.error "Template for debugging: #{path}"
+      if md
+        DslEvaluator.print_code(path, line_number)
+        exit 1
       else
         raise
       end
@@ -171,5 +176,11 @@ module Ufo::Cfn
         logger.info "The stack is not in a state to that is cancelable: #{stack.stack_status}"
       end
     end
+
+    delegate :region, to: :aws
+    def aws
+      AwsData.new
+    end
+    memoize :aws
   end
 end

data/lib/ufo/cli/central/base.rb

@@ -0,0 +1,12 @@
+class Ufo::CLI::Central
+  class Base
+    include Ufo::Utils::Execute
+    include Ufo::Utils::Logging
+    include Ufo::Utils::Pretty
+    include Ufo::Utils::Sure
+
+    def initialize(options={})
+      @options = options
+    end
+  end
+end

data/lib/ufo/cli/central/clean.rb

@@ -0,0 +1,10 @@
+class Ufo::CLI::Central
+  class Clean < Base
+    def run
+      path = "#{ENV['HOME']}/.ufo/central"
+      sure?("Will remove folder with repo caches: #{pretty_home(path)}")
+      FileUtils.rm_rf(path)
+      logger.info "Removed: #{pretty_home(path)}"
+    end
+  end
+end

data/lib/ufo/cli/central/update.rb

@@ -1,68 +1,102 @@
 class Ufo::CLI::Central
-  class Update
-    include Ufo::Utils::Logging
-    include Ufo::Utils::Execute
-    include Ufo::Utils::Sure
-
-    def initialize(options={})
-      @options = options
-    end
-
+  class Update < Base
     def run
-      action = File.exist?(".ufo") ? "update" : "create"
-      sure?("Will #{action} the .ufo folder.") # IE: Will create the .ufo folder.
       validate!
-      logger.info "Updating .ufo with #{repo}"
+      action = File.exist?(".ufo") ? "update" : "create"
+      sure?("Will #{action} the .ufo symlink") # IE: Will create the .ufo symlink
+      logger.info "Updating .ufo with #{central_repo}"
       FileUtils.mkdir_p(tmp_area)
       pull
-      sync
+      symlink
       check_gitignore
     end
 
     def pull
       logger.debug "Within #{tmp_area}"
       Dir.chdir(tmp_area) do
-        if File.exist?(repo_name)
-          execute "cd #{repo_name} && git pull"
+        if File.exist?(repo)
+          execute "cd #{repo} && git pull"
         else
-          execute "git clone #{repo}"
+          execute "git clone #{central_repo}"
         end
       end
     end
 
-    def sync
-      FileUtils.mv(".ufo", ".ufo.bak") if File.exist?(".ufo")
-      src = "#{tmp_area}/#{repo_name}"
-      src += "/#{folder}" if folder
-      FileUtils.cp_r(src, ".ufo")
+    # Always update the symlink in case use changes UFO_CENTRAL_REPO
+    def symlink
+      src = "#{tmp_area}/#{repo}"
+      src += "/#{central_folder}" if central_folder
+
+      FileUtils.mv(".ufo", ".ufo.bak") if File.exist?(".ufo") && File.directory?(".ufo")
+
+      # FileUtils.ln_s(target, link, options)
+      # ~/.ufo/central/repo -> .ufo
+      FileUtils.ln_sf(src, ".ufo", verbose: false) # force in case of existing broken symlink
       FileUtils.rm_rf(".ufo.bak")
-      logger.info "The .ufo folder has been updated"
+
+      report_broken_symlink
+
+      logger.info "The .ufo symlink has been updated"
+      logger.info "Symlink: .ufo -> #{pretty_home(src)}"
+    end
+
+    def report_broken_symlink
+      return unless File.symlink?('.ufo')
+
+      message =<<~EOL.color(:red)
+        ERROR: The .ufo symlink appears to pointing to a missing folder.
+        Please double check that the folder exist in the repo/
+      EOL
+      begin
+        target = File.readlink('.ufo')
+        unless File.exist?(target)
+          logger.error message
+          logger.error "Symlink: .ufo -> #{target}"
+          exit 1
+        end
+      rescue Errno::EEXIST
+        logger.error message
+        exit 1
+      end
     end
 
     def validate!
-      return if repo
+      return if central_repo
       logger.info "ERROR: Please set the env var: UFO_CENTRAL_REPO".color(:red)
+      logger.info "The ufo central update command requires it."
       exit 1
     end
 
-    def repo_name
-      File.basename(repo)
+    # Assume github.com:org/repo. May not work for private "ssh://host:repo" style repos
+    # See: https://terraspace.cloud/docs/terrafile/sources/ssh/
+    # Will consider PRs.
+    #
+    # org is used for path to ~/.ufo/central/org/repo
+    #
+    def org
+      base = central_repo.split('/')[-2] # 1. git@github.com:org/repo 2. repo (for case of https://github.com/org/repo)
+      base.gsub!(/.*:/,'') # git@github.com:org/repo => org/repo
+      base
     end
 
     def repo
+      File.basename(central_repo)
+    end
+
+    def central_repo
       ENV['UFO_CENTRAL_REPO']
     end
 
-    def folder
+    def central_folder
       ENV['UFO_CENTRAL_FOLDER']
     end
 
     def tmp_area
-      "/tmp/ufo/central"
+      "#{ENV['HOME']}/.ufo/central/#{org}"
     end
 
     def check_gitignore
-      ok = true
+      ok = false
       if File.exist?('.gitignore')
         lines = IO.readlines('.gitignore')
         ok = lines.detect do |line|

data/lib/ufo/cli/central.rb

@@ -8,5 +8,12 @@ class Ufo::CLI
     def update
       Update.new(options).run
     end
+
+    desc "clean", "remove ~/.ufo/central"
+    long_desc Help.text("central/clean")
+    opts.yes
+    def clean
+      Clean.new(options).run
+    end
   end
 end

data/lib/ufo/cli/clean.rb

@@ -1,5 +1,3 @@
-require "fileutils"
-
 class Ufo::CLI
   class Clean < Base
     def run

data/lib/ufo/cli/destroy.rb

@@ -18,7 +18,7 @@ class Ufo::CLI
       end
 
       cloudformation.delete_stack(stack_name: @stack_name)
-      puts "Deleting stack with ECS resources: #{@stack_name}"
+      puts "Deleting stack #{@stack_name.color(:green)}"
 
       return unless @options[:wait]
       status.wait

data/lib/ufo/cli/help/ship.md

@@ -17,10 +17,10 @@ Confirm to ship:
 
     Will deploy stack demo-web-dev (y/N) y
     Building Docker Image
-    => docker build -t 536766270177.dkr.ecr.us-west-2.amazonaws.com/demo:ufo-2022-03-02T20-32-33-12dc6e0 -f Dockerfile .
-    Docker Image built: 536766270177.dkr.ecr.us-west-2.amazonaws.com/demo:ufo-2022-03-02T20-32-33-12dc6e0
+    => docker build -t 111111111111.dkr.ecr.us-west-2.amazonaws.com/demo:ufo-2022-03-02T20-32-33-12dc6e0 -f Dockerfile .
+    Docker Image built: 111111111111.dkr.ecr.us-west-2.amazonaws.com/demo:ufo-2022-03-02T20-32-33-12dc6e0
     Pushing Docker Image
-    => docker push 536766270177.dkr.ecr.us-west-2.amazonaws.com/demo:ufo-2022-03-02T20-32-33-12dc6e0
+    => docker push 111111111111.dkr.ecr.us-west-2.amazonaws.com/demo:ufo-2022-03-02T20-32-33-12dc6e0
     Task Definition built: .ufo/output/task_definition.json
     Parameters built:      .ufo/output/params.json
     Template built:        .ufo/output/template.yml

data/lib/ufo/cli/logs.rb

@@ -16,7 +16,7 @@ class Ufo::CLI
 
     def find_log_group_name
       unless info.service
-        logger.info "Cannot find ECS service for #{@stack_name}"
+        logger.info "Cannot find stack: #{@stack_name}"
         exit 1
       end
       task_definition = info.service.task_definition

data/lib/ufo/cli/ps/errors.rb

@@ -0,0 +1,132 @@
+class Ufo::CLI::Ps
+  class Errors < Ufo::CLI::Ps
+    extend Memoist
+
+    def initialize(options={})
+      super
+      @tasks = options[:tasks]
+    end
+
+    def show
+      message = recent_message
+      return unless message
+      return if message =~ /has reached a steady state/
+
+      scale
+      target_group
+      deployment_configuration
+      catchall
+    end
+
+    # If running count < desired account for a long time
+    # And see was unable to place a task
+    # Probably not enough capacity
+    def scale
+      return if service.running_count >= service.desired_count
+
+      error_event = recent_events.find do |e|
+        e.message =~ /was unable to place a task/
+      end
+      return unless error_event
+
+      logger.info "There is an issue scaling the #{@stack_name.color(:green)} service to #{service.desired_count}.  Here's the error:"
+      logger.info error_event.message.color(:red)
+      if service.launch_type == "EC2"
+        logger.info <<~EOL
+          If AutoScaling is set up for the container instances,
+          it can take a little time to add additional instances.
+          You'll see this message until the capacity is added.
+        EOL
+      end
+    end
+
+    # The error currently happens to be the 5th element.
+    #
+    # Example:
+    #     (service XXX) (instance i-XXX) (port 32875) is unhealthy in (target-group arn:aws:elasticloadbalancing:us-east-1:111111111111:targetgroup/devel-Targe-1111111111111/1111111111111111) due to (reason Health checks failed with these codes: [400])">]
+    def target_group
+      error_event = recent_events.find do |e|
+        e.message =~ /is unhealthy in/ &&
+        e.message =~ /targetgroup/
+      end
+      return unless error_event
+
+      logger.error "There are targets in the target group reporting unhealthy.  This can cause containers to cycle. Here's the error:"
+      logger.error error_event.message.color(:red)
+      logger.error <<~EOL
+        Check out the ECS console and EC2 Load Balancer console for more info.
+        Sometimes they may not helpful :(
+        Docs that may help: https://ufoships.com/docs/debug/unhealthy-targets/
+      EOL
+    end
+
+    # To reproduce
+    #
+    # .ufo/config.rb
+    #
+    #     Ufo.configure do |config|
+    #       config.ecs.maximum_percent = 150 # need at least 200 to go from 1 to 2 containers
+    #       config.ecs.minimum_healthy_percent = 100
+    #     end
+    #
+    # Event message error:
+    #
+    #     ERROR: (service app1-web-dev-EcsService-8FMliG8m6M2p) was unable to stop or start tasks during a deployment because of the service deployment configuration. Update the minimumHealthyPercent or maximumPercent value and try again.
+    #
+    def deployment_configuration
+      message = recent_message
+      return unless message.include?("unable") && message.include?("deployment configuration")
+
+      logger.error "ERROR: Deployment Configuration".color(:red)
+      logger.error <<~EOL
+        You might have a Deployment Configuration that prevents the deployment from completing.
+
+        See: https://ufoships.com/docs/debug/deployment-configuration/
+
+      EOL
+    end
+
+    # Example:
+    #     (service app1-web-dev-EcsService-8FMliG8m6M2p) was unable to stop or start tasks during a deployment because of the service deployment configuration. Update the minimumHealthyPercent or maximumPercent value and try again.
+    def catchall
+      words = %w[fail unable error]
+      recent_messages = recent_events.map(&:message)
+      message = recent_messages.find  do |message|
+        words.detect { |word| message.include?(word) }
+      end
+
+      return unless message
+      logger.error "ERROR: #{message}".color(:red)
+
+      logger.error <<~EOL
+        You might have to #{cancel_actions[:cfn]} the stack with:
+
+            ufo #{cancel_actions[:ufo]}
+
+        And try again after fixing the issue.
+      EOL
+    end
+
+  private
+    def cancel_actions
+      stack = find_stack(@stack_name)
+      if stack && stack.stack_status == "CREATE_COMPLETE"
+        { cfn: "delete", ufo: "destroy" }
+      else
+        { cfn: "cancel", ufo: "cancel" }
+      end
+    end
+    memoize :cancel_actions
+
+    # only check a few most recent
+    def recent_events
+      service["events"][0..4]
+    end
+
+    def recent_message
+      recent = recent_events.first
+      return unless recent
+      recent.message ? recent.message : nil
+    end
+  end
+end

data/lib/ufo/cli/ps/task.rb

@@ -1,11 +1,8 @@
 class Ufo::CLI::Ps
-  class Task
-    def self.header
-      %w[Task Name Release Started Status Notes]
-    end
-
-    def initialize(task)
-      @task = task
+  class Task < Ufo::CLI::Base
+    def initialize(options={})
+      super
+      @task = options[:task] # task response from ecs.list_tasks
     end
 
     def to_a
@@ -52,9 +49,11 @@ class Ufo::CLI::Ps
     #  stopping_at=2018-07-05 22:03:44 -0700,
     #  stopped_at=2018-07-05 22:03:45 -0700,
     def hide?
-      stopped_at = time(@task["stopped_at"])
+      return false if @options[:status] == "stopped"
+      started_at = time(@task["started_at"])
+      return false unless started_at # edge case when started_at not yet set
       time = Time.now - 60 * Ufo.config.ps.hide_age
-      status == "STOPPED" && stopped_at < time
+      status == "STOPPED" && started_at < time
     end
 
     def status
@@ -92,5 +91,11 @@ class Ufo::CLI::Ps
           start_time.strftime("%m/%d/%Y")
       end
     end
+
+    class << self
+      def header
+        %w[Task Name Release Started Status Notes]
+      end
+    end
   end
 end

data/lib/ufo/cli/ps.rb

@@ -9,7 +9,12 @@ class Ufo::CLI
 
     def run
       unless service
-        logger.info info.no_service_message
+        stack = find_stack(@stack_name)
+        if stack && stack.stack_status == "CREATE_IN_PROGRESS"
+          logger.info "Stack is still creating. Try again after it completes."
+        else
+          logger.info info.no_service_message
+        end
         return
       end
 
@@ -25,9 +30,8 @@ class Ufo::CLI
         resp["tasks"]
       end.flatten
 
-      display_tasks(all_task_arns)
-      display_scale_help
-      display_target_group_help
+      tasks = show_tasks(all_task_arns)
+      show_errors(tasks)
     end
 
     def summary
@@ -63,50 +67,14 @@ class Ufo::CLI
       resp.scalable_targets.first # scalable_target
     end
 
-    def display_target_group_help
-      events = service["events"][0..4]
-      return if events[0].message =~ /has reached a steady state/
-
-      # The error currently happens to be the 5th element.
-      #
-      # Example:
-      #  "(service XXX) (instance i-XXX) (port 32875) is unhealthy in (target-group arn:aws:elasticloadbalancing:us-east-1:111111111111:targetgroup/devel-Targe-1111111111111/1111111111111111) due to (reason Health checks failed with these codes: [400])">]
-      error_event = events.find do |e|
-        e.message =~ /is unhealthy in/ &&
-        e.message =~ /targetgroup/
-      end
-      return unless error_event
-
-      logger.error "There are targets in the target group reporting unhealthy.  This can cause containers to cycle. Here's the error:"
-      logger.error error_event.message.color(:red)
-      logger.error <<~EOL
-        Check out the ECS console and EC2 Load Balancer console for more info.
-        Sometimes they may not helpful :(
-        Docs that may help: https://ufoships.com/docs/debug/unhealthy-targets/
-      EOL
-    end
-
-    # If the running count less than the desired account yet, check the events
-    # and show a message with helpful debugging information.
-    def display_scale_help
-      return if service.running_count >= service.desired_count
-
-      events = service["events"][0..3] # only check most recent 4 messages
-      error_event = events.find do |e|
-        e.message =~ /was unable to place a task/
-      end
-      return unless error_event
-
-      logger.info "There is an issue scaling the #{@service.color(:green)} service to #{service.desired_count}.  Here's the error:"
-      logger.info error_event.message.color(:red)
-      if service.launch_type == "EC2"
-        logger.info "If AutoScaling is set up for the container instances, it can take a little time to add additional instances. You'll see this message until the capacity is added."
-      end
+    def convert_to_task_objects(task_arns)
+      task_arns.sort_by! { |t| t["task_arn"] }
+      task_arns.map { |t| Task.new(@options.merge(task: t)) } # will have Task objects after this point
     end
 
-    def display_tasks(raw_tasks)
-      raw_tasks.sort_by! { |t| t["task_arn"] }
-      tasks = raw_tasks.map { |t| Task.new(t) } # will have Task objects after this point
+    # Note: ufo stop also uses Ps#show_tasks. Thats why convert_to_task_objects within the method
+    def show_tasks(tasks_arns)
+      tasks = convert_to_task_objects(tasks_arns)
       tasks = tasks.reject(&:hide?)
       show_notes = show_notes(tasks)
 
@@ -122,8 +90,14 @@ class Ufo::CLI
         presenter.rows << row
       end
       presenter.show
+      tasks
+    end
+
+    def show_errors(tasks)
+      Errors.new(@options.merge(tasks: tasks)).show
     end
 
+  private
     def show_notes(tasks)
       tasks.detect { |t| !t.notes.blank? }
     end

data/lib/ufo/cli/scale.rb

@@ -45,6 +45,11 @@ class Ufo::CLI
       scalable_target = stack_resources.find do |r|
         r.logical_resource_id == "ScalingTarget"
       end
+      register_scalable_target(scalable_target)
+      logger.info "Configured autoscaling to min: #{@min} max: #{@max}"
+    end
+
+    def register_scalable_target(scalable_target)
       # service/dev/app1-web-dev-EcsService-Q0XkN6VtxGWv|ecs:service:DesiredCount|ecs
       resource_id, scalable_dimension, service_namespace = scalable_target.physical_resource_id.split('|')
       applicationautoscaling.register_scalable_target(
@@ -54,7 +59,9 @@ class Ufo::CLI
         scalable_dimension: scalable_dimension,
         service_namespace: service_namespace,
       )
-      logger.info "Configured autoscaling to min: #{@min} max: #{@max}"
+    rescue Aws::ApplicationAutoScaling::Errors::ValidationException => e
+      logger.error "ERROR: #{e.class} #{e.message}".color(:red)
+      exit 1
     end
 
     def warning
@@ -68,7 +75,7 @@ class Ufo::CLI
 
         You can also turn off this warning with
 
-            config.scaling.warning = false
+            config.scale.warning = false
 
       EOL
     end

data/lib/ufo/cli/stop.rb

@@ -29,7 +29,7 @@ class Ufo::CLI
     def show(tasks, preview: true)
       logger.info "Will stop the following tasks:" if preview
       ps = Ps.new(@options)
-      ps.display_tasks(tasks)
+      ps.show_tasks(tasks)
     end
 
     # latest deployment task definition arn

data/lib/ufo/cli.rb

@@ -85,7 +85,8 @@ module Ufo
     long_desc Help.text(:ps)
     option :status, default: "all", desc: "Status filter: all, pending, stopped, running."
     # not setting format default so we can use Ufo.config.ps.format and dont want to trigger a config load this early
-    option :format, desc: "Output formats: #{CliFormat.formats.join(', ')}"
+    formats = CliFormat.formats + ["auto"]
+    option :format, desc: "Output formats: #{formats.sort.join(', ')}"
     def ps
       Ps.new(options).run
     end

data/lib/ufo/config.rb

@@ -49,24 +49,33 @@ module Ufo
 
       config.ecs = ActiveSupport::OrderedOptions.new
       config.ecs.cluster = ":ENV" # => dev
+      config.ecs.deployment_configuration = nil # full control
       config.ecs.desired_count = nil # only respected when config.autoscaling.enabled = false
+      config.ecs.maximum_percent = 200 # nil
+      config.ecs.minimum_healthy_percent = 100 # nil
       config.ecs.scheduling_strategy = "REPLICA"
 
       config.elb = ActiveSupport::OrderedOptions.new
-      config.elb.subnet_mappings = nil # static IP addresses for network load balancer
+      config.elb.default_actions = nil # full override
       config.elb.enabled = "auto" # "auto", true or false
+
+      config.elb.health_check_interval_seconds = 10
+      config.elb.health_check_path = nil # When nil its AWS default /
+      config.elb.healthy_threshold_count = 5
+      config.elb.unhealthy_threshold_count = 2
+
       config.elb.port = 80 # default listener port
-      config.elb.ssl = ActiveSupport::OrderedOptions.new
-      config.elb.ssl.certificates = nil
-      config.elb.ssl.enabled = false
-      config.elb.ssl.port = 443
-      config.elb.type = "application"
-      config.elb.default_actions = nil # full override
       config.elb.redirect = ActiveSupport::OrderedOptions.new
       config.elb.redirect.code = 302  # IE: 302 or 301
       config.elb.redirect.enabled = false
       config.elb.redirect.port = 443
       config.elb.redirect.protocol = "HTTPS"
+      config.elb.ssl = ActiveSupport::OrderedOptions.new
+      config.elb.ssl.certificates = nil
+      config.elb.ssl.enabled = false
+      config.elb.ssl.port = 443
+      config.elb.subnet_mappings = nil # static IP addresses for network load balancer
+      config.elb.type = "application"
 
       config.exec = ActiveSupport::OrderedOptions.new
       config.exec.command = "/bin/bash" # aws ecs execute-command cli

data/lib/ufo/info.rb

@@ -40,6 +40,7 @@ module Ufo
       service = stack_resources.find { |r| r.resource_type == "AWS::ECS::Service" }
       return unless service # stack is still creating
       arn = service.physical_resource_id
+      return unless arn # can be nil for a few seconds while stack is still creating it
       resp = ecs.describe_services(services: [arn], cluster: @cluster)
       resp.services.first
     end

data/lib/ufo/task_definition/erb/yaml.rb

@@ -4,15 +4,22 @@ class Ufo::TaskDefinition::Erb
       text = IO.read(@path)
       YAML.load(text)
     rescue Psych::SyntaxError => e
-      logger.error "ERROR: #{e.class}: #{e.message}"
+      logger.error "ERROR: #{e.class}: #{e.message}".color(:red)
       logger.error <<~EOL
         Rendered file contains invalid YAML. For debugging, files available at:
 
         source:   #{@task_definition.path}
-        rendered: #{@path}
+        compiled: #{@path}
 
       EOL
-      print_code(text)
+
+      md = e.message.match(/at line (\d+) column (\d+)/)
+      if md
+        line_number = md[1]
+        DslEvaluator.print_code(@path, line_number)
+      else
+        print_code(text) # fallback to simpler print code if cannot find line numbers
+      end
     end
   end
 end

data/lib/ufo/task_definition/erb.rb

@@ -21,6 +21,11 @@ class Ufo::TaskDefinition
     end
 
     def check_empty!(data)
+      if data.nil?
+        logger.error "ERROR: Unable to compile the YAML".color(:red) # invalid YAML will result in data == nil
+        exit 1
+      end
+
       return unless data == true || data == false || data.empty?
       logger.error "ERROR: Empty task definition results".color(:red)
       logger.error <<~EOL

data/lib/ufo/task_definition/helpers/acm.rb

@@ -0,0 +1,18 @@
+module Ufo::TaskDefinition::Helpers
+  module Acm
+    # returns cert arn
+    def acm_cert(domain)
+      certs = acm_certs
+      cert = certs.find do |c|
+        c.domain_name == domain
+      end
+      cert.certificate_arn if cert
+    end
+
+    # TODO: handle when there are lots of certs by paging
+    def acm_certs
+      resp = acm.list_certificates
+      resp.certificate_summary_list
+    end
+  end
+end

data/lib/ufo/task_definition/helpers/ecr.rb

@@ -0,0 +1,13 @@
+module Ufo::TaskDefinition::Helpers
+  module Ecr
+    def ecr_repo(name)
+      repository = ecr_repository(name)
+      repository.repository_uri
+    end
+
+    def ecr_repository(name)
+      resp = ecr.describe_repositories(repository_names: [name])
+      resp.repositories.first
+    end
+  end
+end

data/lib/ufo/task_definition/helpers/vars.rb

@@ -65,8 +65,8 @@ module Ufo::TaskDefinition::Helpers
       end
     end
 
-    # arn:aws:ssm:us-west-2:536766270177:parameter/demo/dev/DB-NAME
-    # arn:aws:ssm:us-west-2:536766270177:parameter/demo/dev/DB-NAME
+    # arn:aws:ssm:us-west-2:111111111111:parameter/demo/dev/DB-NAME
+    # arn:aws:ssm:us-west-2:111111111111:parameter/demo/dev/DB-NAME
     def expansion(arn)
       # performance improvement only run names.expansion on the name portion
       md = arn.match(/(.*:)(parameter\/|secret:)(.*)/)

data/lib/ufo/utils/pretty.rb

@@ -4,6 +4,11 @@ module Ufo::Utils
       path.sub("#{Ufo.root}/",'').sub(/^\.\//,'')
     end
 
+    # Replace HOME with ~ - different from the main pretty_path
+    def pretty_home(path)
+      path.sub(ENV['HOME'], '~')
+    end
+
     # http://stackoverflow.com/questions/4175733/convert-duration-to-hoursminutesseconds-or-similar-in-rails-3-or-ruby
     def pretty_time(total_seconds)
       minutes = (total_seconds / 60) % 60

data/lib/ufo/version.rb

@@ -1,3 +1,3 @@
 module Ufo
-  VERSION = "6.0.0"
+  VERSION = "6.0.3"
 end

data/lib/ufo/yaml/validator.rb

@@ -1,5 +1,7 @@
 class Ufo::Yaml
   class Validator
+    include Ufo::Utils::Logging
+
     def initialize(path)
       @path = path
     end
@@ -18,34 +20,16 @@ class Ufo::Yaml
     end
 
     def handle_yaml_syntax_error(e, path)
-      io = StringIO.new
-      io.puts "Invalid yaml. Output written for debugging: #{path}".color(:red)
-      io.puts "ERROR: #{e.message}".color(:red)
+      logger.error "ERROR: #{e.message}".color(:red)
+      logger.error "Invalid yaml. Output written for debugging: #{path}".color(:red)
 
       # Grab line info.  Example error:
       #   ERROR: (<unknown>): could not find expected ':' while scanning a simple key at line 2 column 1
       md = e.message.match(/at line (\d+) column (\d+)/)
       line = md[1].to_i
 
-      lines = IO.read(path).split("\n")
-      context = 5 # lines of context
-      top, bottom = [line-context-1, 0].max, line+context-1
-      spacing = lines.size.to_s.size
-      lines[top..bottom].each_with_index do |line_content, index|
-        line_number = top+index+1
-        if line_number == line
-          io.printf("%#{spacing}d %s\n".color(:red), line_number, line_content)
-        else
-          io.printf("%#{spacing}d %s\n", line_number, line_content)
-        end
-      end
-
-      if ENV['LONO_TEST']
-        io.string
-      else
-        puts io.string
-        exit 1
-      end
+      DslEvaluator.print_code(path, line_number)
+      exit 1
     end
   end
 end

data/lib/ufo/yaml.rb

@@ -8,6 +8,10 @@ module Ufo
         Validator.new(path).validate!
         Loader.new(text).load
       end
+
+      def validate!(path)
+        Validator.new(path).validate!
+      end
     end
   end
 end

data/ufo.gemspec

@@ -20,19 +20,20 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "aws-logs"
   spec.add_dependency "aws-mfa-secure", ">= 0.4.3"
+  spec.add_dependency "aws-sdk-acm"
   spec.add_dependency "aws-sdk-applicationautoscaling"
   spec.add_dependency "aws-sdk-cloudformation"
   spec.add_dependency "aws-sdk-cloudwatchlogs"
   spec.add_dependency "aws-sdk-ec2"
   spec.add_dependency "aws-sdk-ecr"
   spec.add_dependency "aws-sdk-ecs"
-  spec.add_dependency "aws-sdk-ssm"
   spec.add_dependency "aws-sdk-elasticloadbalancingv2"
+  spec.add_dependency "aws-sdk-ssm"
   spec.add_dependency "aws_data"
   spec.add_dependency "cfn-status"
   spec.add_dependency "cli-format"
   spec.add_dependency "deep_merge"
-  spec.add_dependency "dsl_evaluator"
+  spec.add_dependency "dsl_evaluator", ">= 0.2.5" # for DslEvaluator.print_code
   spec.add_dependency "memoist"
   spec.add_dependency "plissken"
   spec.add_dependency "rainbow"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ufo
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 6.0.3
 platform: ruby
 authors:
 - Tung Nguyen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-03-05 00:00:00.000000000 Z
+date: 2022-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-logs
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.4.3
+- !ruby/object:Gem::Dependency
+  name: aws-sdk-acm
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: aws-sdk-applicationautoscaling
   requirement: !ruby/object:Gem::Requirement
@@ -123,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: aws-sdk-ssm
+  name: aws-sdk-elasticloadbalancingv2
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,7 +151,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: aws-sdk-elasticloadbalancingv2
+  name: aws-sdk-ssm
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -212,14 +226,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.2.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.2.5
 - !ruby/object:Gem::Dependency
   name: memoist
   requirement: !ruby/object:Gem::Requirement
@@ -484,6 +498,8 @@ files:
 - lib/ufo/cli/build.rb
 - lib/ufo/cli/cancel.rb
 - lib/ufo/cli/central.rb
+- lib/ufo/cli/central/base.rb
+- lib/ufo/cli/central/clean.rb
 - lib/ufo/cli/central/update.rb
 - lib/ufo/cli/clean.rb
 - lib/ufo/cli/destroy.rb
@@ -518,6 +534,7 @@ files:
 - lib/ufo/cli/new/sequence.rb
 - lib/ufo/cli/opts.rb
 - lib/ufo/cli/ps.rb
+- lib/ufo/cli/ps/errors.rb
 - lib/ufo/cli/ps/task.rb
 - lib/ufo/cli/releases.rb
 - lib/ufo/cli/rollback.rb
@@ -569,8 +586,10 @@ files:
 - lib/ufo/task_definition/erb/json.rb
 - lib/ufo/task_definition/erb/yaml.rb
 - lib/ufo/task_definition/helpers.rb
+- lib/ufo/task_definition/helpers/acm.rb
 - lib/ufo/task_definition/helpers/aws_data_helper.rb
 - lib/ufo/task_definition/helpers/core.rb
+- lib/ufo/task_definition/helpers/ecr.rb
 - lib/ufo/task_definition/helpers/ssm.rb
 - lib/ufo/task_definition/helpers/ssm/fetcher.rb
 - lib/ufo/task_definition/helpers/stack_output.rb