uffizzi_core 0.4.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a6a5a5e07ef682bca2fc1b22a628cc093282f720f3a98a18ee290d84a05c5fc
-  data.tar.gz: 50e1ec427b2cd4227f357b57707f9151edb2e2db62a77ee8e7f149652bd66e7d
+  metadata.gz: 906801fea12b493de551c88a90e6a8fb576d76e07cca94d599387a620dcca920
+  data.tar.gz: e42b3989f0cee2e2ca4a87c7231d477cffc426d73ba26368a5ed47a60ac2c569
 SHA512:
-  metadata.gz: 0b69cbdcaa12a2800e80f5f6784813333b88fffbc1df28792cbc1c07ed78a6ba6e4ee0d7a38372db46ae99d22be36d2ef88377158145829ea2153901542f5f00
-  data.tar.gz: e121d4b060d698b4d3e07256ce7a977ec14d62a727ebd5ed9127b66d4a74ee4d29bf22327084573ae13b6d25d9a2111276610644d1f61fbb078dfa4ef01859a3
+  metadata.gz: 7ccf182b08308c44d6b62c00832cefd031b34abad8b7c5eace999d6c34ec43976b5d2c577c5044bcf83299cef80776a55a9ebdd56a4dc82e12013bee47dd9582
+  data.tar.gz: 4e6a3c3921e8d360a73eeeb615c24039b362148a9f4119f04e0bfa7f8f9cff3ab8b27ed9f5923d033d482cd668f65e669a9af60609f2b060a0ed9276b56cdee2

data/app/clients/uffizzi_core/docker_hub_client.rb

@@ -43,34 +43,6 @@ class UffizziCore::DockerHubClient
     RequestResult.new(result: response.body)
   end
 
-  def get_webhooks(slug:, registry:)
-    url = BASE_URL + "/v2/repositories/#{slug}/webhook_pipeline/"
-
-    response = connection.get(url, { registry: registry, page_size: 100 }) do |request|
-      request.headers['Authorization'] = "JWT #{jwt}"
-    end
-
-    RequestResult.new(status: response.status, result: response.body)
-  end
-
-  def create_webhook(slug:, name:, expect_final_callback:, webhooks:)
-    raise NotAuthorizedError if !authentificated?
-
-    url = BASE_URL + "/v2/repositories/#{slug}/webhook_pipeline/"
-
-    params = {
-      name: name,
-      expect_final_callback: expect_final_callback,
-      webhooks: webhooks,
-    }
-
-    response = connection.post(url, params) do |request|
-      request.headers['Authorization'] = "JWT #{jwt}"
-    end
-
-    RequestResult.new(status: response.status, result: response.body)
-  end
-
   def accounts
     raise NotAuthorizedError if !authentificated?
 
@@ -115,16 +87,6 @@ class UffizziCore::DockerHubClient
     RequestResult.new(result: response.body)
   end
 
-  def send_webhook_answer(url, params)
-    conn = Faraday.new do |c|
-      c.request(:json)
-      c.adapter(Faraday.default_adapter)
-    end
-    response = conn.post(url, params)
-
-    RequestResult.quiet.new(result: response.body)
-  end
-
   def authentificated?
     jwt.present?
   end

data/app/controllers/concerns/uffizzi_core/dependency_injection_concern.rb

@@ -7,10 +7,12 @@ module UffizziCore::DependencyInjectionConcern
     UffizziCore::UserAccessService.new(module_class(:rbac))
   end
 
-  def build_parser_module
-    return unless module_exists?(:github)
+  def find_build_parser_module
+    module_class(:build_parser)
+  end
 
-    module_class(:github)
+  def find_volume_parser_module
+    module_class(:volume_parser)
   end
 
   def password_protection_module

data/app/forms/uffizzi_core/api/cli/v1/compose_file/cli_form.rb

@@ -8,6 +8,7 @@ class UffizziCore::Api::Cli::V1::ComposeFile::CliForm
   attribute :compose_dependencies, Array
   attribute :compose_repositories, Array
   attribute :content, String
+  attribute :source_kind, Symbol
 
   validates :content, presence: true
 

data/app/services/uffizzi_core/compose_file/builders/container_builder_service.rb

@@ -19,7 +19,7 @@ class UffizziCore::ComposeFile::Builders::ContainerBuilderService
     secrets = container_data[:secrets] || []
     container_name = container_data[:container_name]
     healthcheck_data = container_data[:healthcheck] || {}
-    volumes = container_data[:volumes] || []
+    volumes_data = container_data[:volumes] || []
 
     env_file_dependencies = UffizziCore::ComposeFile::GithubDependenciesService.env_file_dependencies_for_container(compose_dependencies,
                                                                                                                     container_name)
@@ -46,7 +46,7 @@ class UffizziCore::ComposeFile::Builders::ContainerBuilderService
       service_name: container_name,
       name: container_name,
       healthcheck: healthcheck_data,
-      volumes: volumes,
+      volumes: volumes_data,
     }
   end
   # rubocop:enable Metrics/PerceivedComplexity

data/app/services/uffizzi_core/compose_file/parsers/services/{volumes_service.rb → volumes_parser_service.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class UffizziCore::ComposeFile::Parsers::Services::VolumesService
+class UffizziCore::ComposeFile::Parsers::Services::VolumesParserService
   HOST_VOLUME_TYPE = :host
   NAMED_VOLUME_TYPE = :named
   ANONYMOUS_VOLUME_TYPE = :anonymous
@@ -8,15 +8,15 @@ class UffizziCore::ComposeFile::Parsers::Services::VolumesService
   READ_WRITE_OPTION = 'rw'
 
   class << self
-    def parse(volumes, named_volumes_names, service_name)
+    def parse(volumes, volumes_payload)
       return [] if volumes.blank?
 
       volumes.map do |volume|
         volume_data = case volume
                       when String
-                        process_short_syntax(volume, named_volumes_names, service_name)
+                        process_short_syntax(volume, volumes_payload)
                       when Hash
-                        process_long_syntax(volume, named_volumes_names, service_name)
+                        process_long_syntax(volume, volumes_payload)
                       else
                         raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.invalid_type', option: :volumes)
         end
@@ -27,48 +27,49 @@ class UffizziCore::ComposeFile::Parsers::Services::VolumesService
 
     private
 
-    def process_short_syntax(volume_data, named_volumes_names, service_name)
+    def process_short_syntax(volume_data, volumes_payload)
       volume_parts = volume_data.split(':').map(&:strip)
-      has_read_only = volume_parts.include?(READONLY_OPTION)
+      read_only = volume_parts.last.to_s.downcase == READONLY_OPTION
       part1, part2 = volume_parts
       source_path = part1
       target_path = [READONLY_OPTION, READ_WRITE_OPTION].include?(part2.to_s.downcase) ? nil : part2
 
       raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.volume_prop_is_required', prop_name: 'source') if source_path.blank?
 
-      volume_type = volume_type(source_path, target_path)
-
-      check_named_volume_existence(source_path, target_path, named_volumes_names, service_name) if volume_type == NAMED_VOLUME_TYPE
-
-      {
-        source: source_path,
-        target: target_path,
-        type: volume_type,
-        read_only: has_read_only,
-      }
+      build_volume_attributes(source_path, target_path, read_only, volumes_payload)
     end
 
-    def process_long_syntax(volume_data, named_volumes_names, service_name)
+    def process_long_syntax(volume_data, volumes_payload)
       source_path = volume_data['source'].to_s.strip
       target_path = volume_data['target'].to_s.strip
-      has_read_only = volume_data['read_only'].present?
+      read_only = volume_data['read_only'].present?
 
       raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.volume_prop_is_required', prop_name: 'source') if source_path.blank?
       raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.volume_prop_is_required', prop_name: 'target') if target_path.blank?
 
-      volume_type = volume_type(source_path, target_path)
+      build_volume_attributes(source_path, target_path, read_only, volumes_payload)
+    end
 
-      check_named_volume_existence(source_path, target_path, named_volumes_names, service_name) if volume_type == NAMED_VOLUME_TYPE
+    def build_volume_attributes(source_path, target_path, read_only, params = {})
+      volume_type = build_volume_type(source_path, target_path)
+
+      if volume_type == NAMED_VOLUME_TYPE
+        validate_named_volume(source_path, target_path, params[:named_volumes_names], params[:service_name])
+      end
+
+      if volume_type == ANONYMOUS_VOLUME_TYPE
+        validate_anonymous_volume(source_path)
+      end
 
       {
         source: source_path,
         target: target_path,
         type: volume_type,
-        read_only: has_read_only,
+        read_only: read_only,
       }
     end
 
-    def volume_type(source_path, target_path)
+    def build_volume_type(source_path, target_path)
       if path?(source_path) && path?(target_path)
         raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.volume_type_not_supported', type: HOST_VOLUME_TYPE)
       end
@@ -83,12 +84,26 @@ class UffizziCore::ComposeFile::Parsers::Services::VolumesService
       /^(\/|\.\/|~\/)/.match?(path)
     end
 
-    def check_named_volume_existence(source_path, target_path, named_volumes_names, service_name)
+    def validate_named_volume(source_path, target_path, named_volumes_names, service_name)
+      if path_has_only_root?(target_path)
+        raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.invalid_volume_destination', spec: "#{source_path}:#{target_path}")
+      end
+
       return if named_volumes_names.include?(source_path)
 
       raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.named_volume_not_exists', source_path: source_path,
                                                                                             target_path: target_path,
                                                                                             service_name: service_name)
     end
+
+    def validate_anonymous_volume(path)
+      if path_has_only_root?(path)
+        raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.invalid_volume_destination', spec: path)
+      end
+    end
+
+    def path_has_only_root?(path)
+      path.size == 1 && path.include?('/')
+    end
   end
 end

data/app/services/uffizzi_core/compose_file/parsers/services_parser_service.rb

@@ -51,9 +51,9 @@ class UffizziCore::ComposeFile::Parsers::ServicesParserService
                                     when :'x-uffizzi-continuous-preview', :'x-uffizzi-continuous-previews'
                                       UffizziCore::ComposeFile::Parsers::ContinuousPreviewParserService.parse(value)
                                     when :volumes
-                                      UffizziCore::ComposeFile::Parsers::Services::VolumesService.parse(value,
-                                                                                                        global_named_volume_names,
-                                                                                                        service_name)
+                                      parse_volumes(value, named_volumes_names: global_named_volume_names,
+                                                           service_name: service_name,
+                                                           compose_payload: compose_payload)
         end
       end
 
@@ -63,9 +63,19 @@ class UffizziCore::ComposeFile::Parsers::ServicesParserService
     end
 
     def check_and_parse_build_option(value, compose_payload)
+      build_parser_module = find_build_parser_module
+
       raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.not_implemented', option: :build) unless build_parser_module
 
       build_parser_module.parse(value, compose_payload)
     end
+
+    def parse_volumes(value, volumes_payload)
+      volume_parser_module = find_volume_parser_module
+
+      return UffizziCore::ComposeFile::Parsers::Services::VolumesParserService.parse(value, volumes_payload) unless volume_parser_module
+
+      volume_parser_module.parse(value, volumes_payload)
+    end
   end
 end

data/app/services/uffizzi_core/deployment_service.rb

@@ -23,7 +23,6 @@ class UffizziCore::DeploymentService
         update_subdomain!(deployment_form)
 
         UffizziCore::Deployment::CreateJob.perform_async(deployment_form.id)
-        UffizziCore::Deployment::CreateWebhooksJob.perform_async(deployment_form.id)
       end
 
       deployment_form
@@ -38,9 +37,13 @@ class UffizziCore::DeploymentService
 
       ActiveRecord::Base.transaction do
         deployment.containers.destroy_all
-        deployment.compose_file.destroy! if deployment.compose_file.kind.temporary?
+        deployment.compose_file.destroy! if deployment.compose_file&.kind&.temporary?
 
-        deployment.update!(containers: deployment_form.containers, compose_file_id: compose_file.id)
+        deployment.update!(
+          containers: deployment_form.containers,
+          compose_file_id: compose_file.id,
+          creation_source: UffizziCore::Deployment.creation_source.compose_file_manual,
+        )
       end
 
       deployment
@@ -204,28 +207,6 @@ class UffizziCore::DeploymentService
       deployment.save!
     end
 
-    def create_webhooks(deployment)
-      credential = deployment.project.account.credentials.docker_hub.active.first
-
-      if !deployment.containers.with_docker_hub_repo.exists? || !credential.present?
-        Rails.logger.info("DEPLOYMENT_PROCESS deployment_id=#{deployment.id} create_webhooks no dockerhub containers or credential")
-        return
-      end
-
-      accounts = UffizziCore::DockerHubService.accounts(credential)
-
-      deployment.containers.with_docker_hub_repo.find_each do |container|
-        if !accounts.include?(container.repo.namespace)
-          logger_message = "DEPLOYMENT_PROCESS deployment_id=#{deployment.id} no namespace(#{container.repo.namespace})
-          in accounts(#{accounts.inspect})"
-          Rails.logger.info(logger_message)
-          next
-        end
-
-        UffizziCore::Credential::DockerHub::CreateWebhookJob.perform_async(credential.id, container.image, deployment.id)
-      end
-    end
-
     def pull_request_payload_present?(deployment)
       deployment.continuous_preview_payload.present? && deployment.continuous_preview_payload['pull_request'].present?
     end
@@ -304,7 +285,10 @@ class UffizziCore::DeploymentService
       subdomain_length_limit = Settings.deployment.subdomain.length_limit
       return rfc_subdomain if rfc_subdomain.length <= subdomain_length_limit
 
-      rfc_subdomain.slice(0, subdomain_length_limit)
+      sliced_subdomain = rfc_subdomain.slice(0, subdomain_length_limit)
+      return sliced_subdomain.chop if sliced_subdomain.end_with?('-')
+
+      sliced_subdomain
     end
   end
 end

data/app/services/uffizzi_core/docker_hub_service.rb

@@ -1,44 +1,7 @@
 # frozen_string_literal: true
 
 class UffizziCore::DockerHubService
-  HOOK_NAME = 'Uffizzi OpenSource Deploy Webhook'
-  HOOK_URL = "#{Settings.app.host}api/cli/v1/webhooks/docker_hub"
-  REGISTRY = 'registry-1.docker.io'
-
   class << self
-    def create_webhook(credential, image)
-      client = user_client(credential)
-
-      webhooks_response = client.get_webhooks(slug: image, registry: REGISTRY)
-      Rails.logger.info("DockerHubService create_webhook get_webhooks_response=#{webhooks_response.inspect}")
-
-      return false if webhooks_response.status != 200
-
-      webhooks = webhooks_response.result['results']
-
-      webhook = webhooks.detect { |hook| hook['name'] == HOOK_NAME }
-
-      return true if !webhook.nil?
-
-      params = {
-        slug: image,
-        name: HOOK_NAME,
-        expect_final_callback: false,
-        webhooks: [{ name: HOOK_NAME, hook_url: HOOK_URL, registry: REGISTRY }],
-      }
-
-      response = client.create_webhook(params)
-
-      Rails.logger.info("DockerHubService create_webhook create_webhook_response=#{response.inspect} params=#{params.inspect}")
-
-      response.status == 201
-    end
-
-    def send_webhook_answer(callback_url)
-      params = { state: 'success', description: 'Successfully deployed to Uffizzi' }
-      public_docker_hub_client.send_webhook_answer(callback_url, params)
-    end
-
     def accounts(credential)
       client = user_client(credential)
       response = client.accounts

data/config/locales/en.yml

@@ -66,6 +66,7 @@ en:
     volume_invalid_name: "Volumes value '%{name}' does not match any of the regexes: '^[a-zA-Z0-9._-]+$'"
     volume_type_not_supported: Volumes with type '%{type}' does not supported
     named_volume_not_exists: Named volume '%{source_path}:%{target_path}' is used in service '%{service_name}' but no declaration was found in the volumes section.
+    invalid_volume_destination: Invalid volume specification '%{spec}' destination can't be '/'
   secrets:
     duplicates_exists: Secret with key %{secrets} already exist.
     invalid_key_length: A secret key must be no longer than 256 characters.

data/config/routes.rb

@@ -7,14 +7,6 @@ UffizziCore::Engine.routes.draw do
   namespace :api, defaults: { format: :json } do
     namespace :cli do
       namespace :v1 do
-        resource :webhooks, only: [] do
-          post :docker_hub
-          post :github
-          post :azure
-          post :amazon
-          post :google
-        end
-
         resources :projects, only: ['index', 'show', 'create', 'destroy'], param: :slug do
           scope module: :projects do
             resource :compose_file, only: ['show', 'create', 'destroy']

data/lib/uffizzi_core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module UffizziCore
-  VERSION = '0.4.1'
+  VERSION = '0.6.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: uffizzi_core
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Josh Thurman
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-09 00:00:00.000000000 Z
+date: 2022-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aasm
@@ -754,11 +754,9 @@ files:
 - app/jobs/uffizzi_core/activity_item/docker/update_digest_job.rb
 - app/jobs/uffizzi_core/application_job.rb
 - app/jobs/uffizzi_core/config_file/apply_job.rb
-- app/jobs/uffizzi_core/credential/docker_hub/create_webhook_job.rb
 - app/jobs/uffizzi_core/deployment/create_credential_job.rb
 - app/jobs/uffizzi_core/deployment/create_credentials_job.rb
 - app/jobs/uffizzi_core/deployment/create_job.rb
-- app/jobs/uffizzi_core/deployment/create_webhooks_job.rb
 - app/jobs/uffizzi_core/deployment/delete_credential_job.rb
 - app/jobs/uffizzi_core/deployment/delete_job.rb
 - app/jobs/uffizzi_core/deployment/deploy_containers_job.rb
@@ -920,7 +918,7 @@ files:
 - app/services/uffizzi_core/compose_file/parsers/services/healthcheck_parser_service.rb
 - app/services/uffizzi_core/compose_file/parsers/services/image_parser_service.rb
 - app/services/uffizzi_core/compose_file/parsers/services/secrets_parser_service.rb
-- app/services/uffizzi_core/compose_file/parsers/services/volumes_service.rb
+- app/services/uffizzi_core/compose_file/parsers/services/volumes_parser_service.rb
 - app/services/uffizzi_core/compose_file/parsers/services_parser_service.rb
 - app/services/uffizzi_core/compose_file/parsers/variables_parser_service.rb
 - app/services/uffizzi_core/compose_file/parsers/volumes_parser_service.rb

data/app/jobs/uffizzi_core/credential/docker_hub/create_webhook_job.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-class UffizziCore::Credential::DockerHub::CreateWebhookJob < UffizziCore::ApplicationJob
-  sidekiq_options queue: :accounts, retry: 5
-
-  def perform(credential_id, image, deployment_id = nil)
-    if deployment_id.present?
-      Rails.logger.info("DEPLOYMENT_PROCESS deployment_id=#{deployment_id} DockerHub CreateWebhooksJob")
-    end
-
-    credential = UffizziCore::Credential.find(credential_id)
-
-    UffizziCore::DockerHubService.create_webhook(credential, image)
-  end
-end

data/app/jobs/uffizzi_core/deployment/create_webhooks_job.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-class UffizziCore::Deployment::CreateWebhooksJob < UffizziCore::ApplicationJob
-  sidekiq_options queue: :deployments, retry: 5
-
-  def perform(id)
-    Rails.logger.info("DEPLOYMENT_PROCESS deployment_id=#{id} CreateWebhooksJob")
-
-    deployment = UffizziCore::Deployment.find(id)
-
-    UffizziCore::DeploymentService.create_webhooks(deployment)
-  end
-end