ueki 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a26fe40e5550c573ba85ceaf58122fa63cf27c358d579b14b9c72fbe985eb637
-  data.tar.gz: e3391e1a4302b29ed51f0379f268bd4dfff89e05a1d406a04d4b87e8fcf8424d
+  metadata.gz: db67ac3ca853a1c4cfaa88e7e50a728ea818b781b3d9a35ab7a068201e8614d9
+  data.tar.gz: 66cdc2140a71b5705c81c525b6bb3327a5c60662a0df45fae5163488b1ff1168
 SHA512:
-  metadata.gz: de1e9a7eb8b7a79609ff6e78f6b0a557e85a4b907f43348aba985a3dbee989061dbf0d10a6e35060e2ea02cd2b15a5161915ee70885c12e1928bee671622b882
-  data.tar.gz: 1c6f4e75b67b4b7b9e5f77763bab3fcdd7411884fb9b0629018861831a0573602e13b6c074aa301e0ce835335663b16865cdb0e7e287eccb735f14ec96667052
+  metadata.gz: 89cce1b559f36d50bb206960a8cd0c9023dbf614fff9e61b64e85988baa4788f266bab379c809c8a0e086c18001f03a4082c4cd430fd96819da3999802b147c7
+  data.tar.gz: a91ca7b58fc2cec4a88fd8239e1c43e458f2d54c464ccc88f0c8f700031f9b7d7c9c7bc6e981daf2cdb85edbc4cb60bd9a70b09934d70da2966318fe8c697f32

data/.rubocop.yml

@@ -32,6 +32,9 @@ Metrics/CyclomaticComplexity:
 Metrics/MethodLength:
   Enabled: false
 
+Metrics/ModuleLength:
+  Enabled: false
+
 Metrics/ParameterLists:
   Enabled: false
 

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+## [1.1.0] - 2024-10-21
+
+- [DefaultRequester] Convert request headers to string keys
+  - This solves the issue that `: “Content-Type” (symbol key)` is set even if `“Content-Type” (string key)` is specified in post/put/patch.
+
 ## [1.0.0] - 2024-08-04
 
 - Initial release

data/README.md

@@ -23,7 +23,7 @@ Simply include the Module created by Ueki in your own HTTP Client Library.
 
 ```ruby
 class BookStoreClient
-  include Ueki::HttpClient.new('http://example.com')
+  include Ueki::HttpClient.new('https://example.com')
 
   # Class Method
   def self.delete_book(id)
@@ -37,7 +37,7 @@ class BookStoreClient
 
   private
 
-  def default_headers
+  def _default_headers
     h = super
     h['X-Request-Id'] = Current.request_id if Current.request_id.present?
     h
@@ -116,7 +116,7 @@ A. You can use [net_http_persistent](https://github.com/lostisland/faraday-net_h
 See [lib/ueki/http_client/default_requester.rb](https://github.com/tmimura39/ueki/blob/main/lib/ueki/http_client/default_requester.rb) for details.
 ```ruby
 class BookStoreClient
-  include Ueki::HttpClient.new('http://example.com')
+  include Ueki::HttpClient.new('https://example.com')
 
   private
 
@@ -139,7 +139,7 @@ In this case, you can use "automatic exception class definition" and "exception
 
 ```ruby
 class BookStoreClient
-  include Ueki::HttpClient.new('http://example.com', requester: CustomRequester)
+  include Ueki::HttpClient.new('https://example.com', requester: CustomRequester)
 end
 ```
 

data/lib/ueki/http_client/default_requester.rb

@@ -8,7 +8,8 @@ module Ueki
     # You can also use your own Requester class with the same I/F.
     module DefaultRequester
       UNSPECIFIED = Object.new.freeze
-      private_constant :UNSPECIFIED
+      CONTENT_TYPE_HEADER_KEY = "Content-Type"
+      private_constant :UNSPECIFIED, :CONTENT_TYPE_HEADER_KEY
 
       def get(path, params: nil, headers: {}, request_options: {}, response_body_parser: UNSPECIFIED)
         response_body_parser = default_response_body_parser_if_unspecifiied(response_body_parser)
@@ -18,27 +19,30 @@ module Ueki
       def post(path, params: nil, headers: {}, request_options: {}, request_body_converter: UNSPECIFIED, response_body_parser: UNSPECIFIED)
         response_body_parser = default_response_body_parser_if_unspecifiied(response_body_parser)
         request_body_converter = default_request_body_converter_if_unspecified(request_body_converter)
+        headers = headers.transform_keys(&:to_s)
 
-        headers[:"Content-Type"] ||= "application/json" unless params.nil?
-        params = request_body_converter.call(content_type: headers[:"Content-Type"], params:)
+        headers[CONTENT_TYPE_HEADER_KEY] ||= "application/json" unless params.nil?
+        params = request_body_converter.call(content_type: headers[CONTENT_TYPE_HEADER_KEY], params:)
         request(:post, path:, params:, headers:, request_options:, response_body_parser:)
       end
 
       def put(path, params: nil, headers: {}, request_options: {}, request_body_converter: UNSPECIFIED, response_body_parser: UNSPECIFIED)
         response_body_parser = default_response_body_parser_if_unspecifiied(response_body_parser)
         request_body_converter = default_request_body_converter_if_unspecified(request_body_converter)
+        headers = headers.transform_keys(&:to_s)
 
-        headers[:"Content-Type"] ||= "application/json" unless params.nil?
-        params = request_body_converter.call(content_type: headers[:"Content-Type"], params:)
+        headers[CONTENT_TYPE_HEADER_KEY] ||= "application/json" unless params.nil?
+        params = request_body_converter.call(content_type: headers[CONTENT_TYPE_HEADER_KEY], params:)
         request(:put, path:, params:, headers:, request_options:, response_body_parser:)
       end
 
       def patch(path, params: nil, headers: {}, request_options: {}, request_body_converter: UNSPECIFIED, response_body_parser: UNSPECIFIED)
         response_body_parser = default_response_body_parser_if_unspecifiied(response_body_parser)
         request_body_converter = default_request_body_converter_if_unspecified(request_body_converter)
+        headers = headers.transform_keys(&:to_s)
 
-        headers[:"Content-Type"] ||= "application/json" unless params.nil?
-        params = request_body_converter.call(content_type: headers[:"Content-Type"], params:)
+        headers[CONTENT_TYPE_HEADER_KEY] ||= "application/json" unless params.nil?
+        params = request_body_converter.call(content_type: headers[CONTENT_TYPE_HEADER_KEY], params:)
         request(:patch, path:, params:, headers:, request_options:, response_body_parser:)
       end
 

data/lib/ueki/http_client/request_body_converter.rb

@@ -13,7 +13,7 @@ module Ueki
 
         case content_type
         when "application/json"
-          params&.to_json
+          params.to_json
         when "application/x-www-form-urlencoded"
           URI.encode_www_form(params)
         else

data/lib/ueki/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ueki
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ueki
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Tomohiko Mimura
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-08-05 00:00:00.000000000 Z
+date: 2024-10-21 00:00:00.000000000 Z
 dependencies: []
 description: Ueki provides "simple request method" and "error exception class definition
   and handling"