ud 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d158caae202c27c348f980136587f9d4bc9f7c67
-  data.tar.gz: 2c11464fc90a9ce73392702794edb8ad4c38312d
+  metadata.gz: ef94c79592b39fe5f56775e9d08eab3ea601db08
+  data.tar.gz: 3202e4b6ce4fe9bb52b2ef984c137f714d3091d4
 SHA512:
-  metadata.gz: d2a50925ca0d07a417498deeda4d3056a1cb4e87f590707319331b9609f65c554c2c382b3ada0d30e8ff838ea02b55f5a1cc2a6fd606a629c30c6a6d921902e7
-  data.tar.gz: bd80e02b6430787d47be2893649d17447e3edae1aa947d3f324c92cb0c0fa788b28e73aefc778a0bfacf49c6af6ccb8da0b4107781195d45f35a249360f4aaf0
+  metadata.gz: dd4694a3b5970d1073129ffa8078c5727e4246161bcbd2bde9c4b02b4a4fe09248d5d9ae8a5cf6fe31bca65f3b8f82676076bbeaea1d604e928a0f8011be62b0
+  data.tar.gz: bbeede97c81c1496c534fbf8c48771f0e2145ef11506d4cb8b0ff7a0dc9c76ef2d1b6c05fa08de5846ebe435666d4edca59e02fa69cb7cd6412173c576e50938

data/lib/ud.rb

@@ -13,7 +13,7 @@ module UD
 
     # @return [String] the current gem's version
     def version
-      '0.2.4'
+      '0.2.5'
     end
 
     # Get the search URL to query for a given term.
@@ -27,7 +27,7 @@ module UD
       if api
         "http://api.urbandictionary.com/v0/define?#{param}"
       else
-        "http://www.urbandictionary.com/define.php?term=#{param}"
+        "http://www.urbandictionary.com/define.php?#{param}"
       end
     end
 

data/tests/query_tests.rb

@@ -5,7 +5,8 @@ require File.dirname(__FILE__) + '/fake_responses'
 
 class UD_Query_test < Test::Unit::TestCase
 
-  ROOT_URL = 'http://api.urbandictionary.com/v0/define'
+  API_URL = 'http://api.urbandictionary.com/v0/define'
+  ROOT_URL = 'http://www.urbandictionary.com/define.php'
 
   def setup
     @foo, @bar = [
@@ -36,30 +37,24 @@ class UD_Query_test < Test::Unit::TestCase
   # == UD#search_url == #
 
   def test_search_url_empty_term
-    assert_equal(
-      "#{ROOT_URL}?term=",
-      UD.search_url())
-      assert_equal(
-        "#{ROOT_URL}?term=",
-        UD.search_url(''))
+    assert_equal("#{API_URL}?term=", UD.search_url())
+    assert_equal("#{API_URL}?term=", UD.search_url(''))
+  end
+
+  def test_search_url_empty_term_nonapi
+    assert_equal("#{ROOT_URL}?term=", UD.search_url('', false))
   end
 
   def test_search_url_spaces_in_term
-    assert_equal(
-      "#{ROOT_URL}?term=a+b",
-      UD.search_url('a b'))
+    assert_equal("#{API_URL}?term=a+b", UD.search_url('a b'))
   end
 
   def test_search_url_encode_special_chars
-    assert_equal(
-      "#{ROOT_URL}?term=%3D",
-      UD.search_url('='))
+    assert_equal("#{API_URL}?term=%3D", UD.search_url('='))
   end
 
   def test_search_url
-    assert_equal(
-      "#{ROOT_URL}?term=foo",
-      UD.search_url('foo'))
+    assert_equal("#{API_URL}?term=foo", UD.search_url('foo'))
   end
 
   # == UD#query == #
@@ -69,29 +64,15 @@ class UD_Query_test < Test::Unit::TestCase
   end
 
   def test_query_two_results
-
-    expected = [
-      @foo, @bar
-    ]
-
-    assert_equal(expected, UD.query('two_results', :count => 2))
+    assert_equal([@foo, @bar], UD.query('two_results', :count => 2))
   end
 
   def test_query_count
-    expected = [
-      @foo
-    ]
-
-    assert_equal(expected, UD.query('two_results', :count => 1))
+    assert_equal([@foo], UD.query('two_results', :count => 1))
   end
 
   def test_query_ratio
-    expected = [
-      @foo
-    ]
-
-    assert_equal(expected, UD.query('two_results', :count => 10, :ratio => 1.5))
+    assert_equal([@foo], UD.query('two_results', :count => 10, :ratio => 1.5))
   end
-
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ud
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Baptiste Fontaine