ucb_rails_user 4.0.0 → 4.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f0be1d4383707c2e5a164251c52e869e0460acdef55ca4e2e8bdfdccbb72666
-  data.tar.gz: b9bc3be3b9fa44c998ceadcba16840b5b10a470671a684ce1da4b1f29f9d8068
+  metadata.gz: 16591e2634ccad69a102f688132f754064005db006c45a1cdc59a66f186e299a
+  data.tar.gz: 197103ec64e41e156973745bd90cf810c6ac85b1d0e945395fb300d322326f0c
 SHA512:
-  metadata.gz: 5f01d2e8adf96825c5c9ac54e6649ef1cb15945a986572a486a22873cc12302ccea6e18f9671d9d16de6ba7a8d8b75e9576db9fd492bf05ba245437a79704294
-  data.tar.gz: 7564793fe361acd435b7afb47796db81af39e8fb1e119ccb0ac709798bbb9a2c17a6351e3ec8c9d1ce24384381bfb4141000db8e81ae54ccad9257d45b464abb
+  metadata.gz: 66e533e5bcf094769bd727ef8e9c651b9e2b3720a82ab36ebcdd0e27f5403db745fe44af8931ee68295edd95cc071771cd65014123a2b972125617b14934bf14
+  data.tar.gz: 1031c24d8efe19130e8f8f4b6e961b7ef15447f27c7b0e35da5940979d848015f4099a7a7d8d41b24a921311130a87965349db2f39d314b08dcea8d74cb67891

data/README.md

@@ -16,7 +16,7 @@ This engine also includes the [Datatables](https://datatables.net/) JQuery plug-
 
 Version 2.0 and greater of this gem sets a user's `employee_id` to the new UCPath employee id, rather than the legacy HCM employee id. If you need to use the older ID, use version 1.1.3 of this gem, or lower.
 
-## Upgrading to version 3.0 from version 2.x
+## Upgrading to version 3.0+ from version 2.x
 
 See [this wiki page](https://github.com/ucb-ist-eas/ucb_rails_user/wiki/Upgrading-to-version-3.0) for details.
 

data/app/controllers/ucb_rails_user/concerns/home_controller.rb

@@ -2,7 +2,7 @@ module UcbRailsUser::Concerns::HomeController
   extend ActiveSupport::Concern
 
   included do
-    skip_before_action :ensure_authenticated_user
+    skip_before_action :ensure_authenticated_user, raise: false
   end
 
   def index

data/app/controllers/ucb_rails_user/concerns/sessions_controller.rb

@@ -2,7 +2,7 @@ module UcbRailsUser::Concerns::SessionsController
   extend ActiveSupport::Concern
 
   included do
-    skip_before_action :ensure_authenticated_user, :log_request
+    skip_before_action :ensure_authenticated_user, :log_request, raise: false
   end
 
   # Redirects to authentication provider

data/app/controllers/ucb_rails_user/concerns/users_controller.rb

@@ -4,7 +4,7 @@ module UcbRailsUser::Concerns::UsersController
   included do
     before_action :find_user, :only => [:edit, :update, :destroy]
     before_action :ensure_admin_user
-    skip_before_action :ensure_admin_user, if: ->{ action_name == "toggle_superuser" && Rails.env.development? }
+    skip_before_action :ensure_admin_user, if: ->{ action_name == "toggle_superuser" && Rails.env.development? }, raise: false
   end
 
   def index
@@ -56,7 +56,7 @@ module UcbRailsUser::Concerns::UsersController
   end
 
   def update
-    if @user.update_attributes(user_params)
+    if @user.update(user_params)
       redirect_to(admin_users_path, notice: 'Record updated')
     else
       render("edit")
@@ -76,7 +76,7 @@ module UcbRailsUser::Concerns::UsersController
   def ldap_search
     # FIXME: this was retrofitted to support typeahead ajax json queries
     if(query = params[:query])
-      @lps_entries = UcbRails::OmniUserTypeahead.new.ldap_results(query)
+      @lps_entries = UcbRailsUser::OmniUserTypeahead.new.ldap_results(query)
       @lps_entries.map!{|entry|
         attrs = entry.attributes.tap{|attrs| attrs["first_last_name"] = "#{attrs['first_name']} #{attrs['last_name']}" }
         attrs.as_json
@@ -85,13 +85,14 @@ module UcbRailsUser::Concerns::UsersController
       render json: @lps_entries
 
     else
-      @lps_entries = UcbRails::LdapPerson::Finder.find_by_first_last(
+      @lps_entries = UcbRailsUser::LdapPerson::Finder.find_by_first_last(
         params.fetch(:first_name),
         params.fetch(:last_name),
         :sort => :last_first_downcase
       )
-      @lps_existing_uids = User.where(ldap_uid: @lps_entries.map(&:uid)).pluck(:uid)
-      render 'lps/search'
+      uid_strings = @lps_entries.map { |entry| entry.uid&.to_s }.compact
+      @lps_existing_uids = User.where(ldap_uid: uid_strings).pluck(:uid)
+      render 'ucb_rails_user/lps/search'
     end
 
   end

data/app/models/concerns/user_concerns.rb

@@ -2,7 +2,8 @@ module UserConcerns
   extend ActiveSupport::Concern
 
   included do
-    has_many :impersonations, class_name: "::UcbRailsUser::Impersonation"
+    has_many :impersonations, class_name: "::UcbRailsUser::Impersonation", dependent: :delete_all
+    has_many :targets, class_name: "::UcbRailsUser::Impersonation", dependent: :delete_all
   end
 
   # Overridden by application

data/app/models/ucb_rails_user/concerns/impersonation_concerns.rb

@@ -3,8 +3,6 @@ module UcbRailsUser::Concerns::ImpersonationConcerns
 
   included do
     belongs_to :user
-    belongs_to :target, class_name: "User"
+    belongs_to :target, class_name: 'User'
   end
-
 end
-

data/config/routes.rb

@@ -17,6 +17,8 @@ Rails.application.routes.draw do
     as: "admin_user_search", via: [:get]
   match "/admin/users/impersonate_search", to: UcbRailsUser::UsersController.action(:impersonate_search),
     as: "admin_user_impersonate_search", via: [:get]
+  match "/admin/users/ldap_search", to: UcbRailsUser::UsersController.action(:ldap_search),
+    as: "admin_user_ldap_search", via: [:get]
   resources :users, controller: "ucb_rails_user/users", path: "admin/users", as: :admin_users
 
   resources :impersonations, controller: "ucb_rails_user/impersonations", path: "admin/impersonations", as: :admin_impersonations

data/lib/ucb_rails_user/version.rb

@@ -1,3 +1,3 @@
 module UcbRailsUser
-  VERSION = '4.0.0'
+  VERSION = '4.0.5'
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: ucb_rails_user
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.5
 platform: ruby
 authors:
 - Steve Downey
 - Peter Philips
 - Tyler Minard
 - Darin Wilson
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-02-27 00:00:00.000000000 Z
+date: 2021-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -47,14 +47,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: active_attr
   requirement: !ruby/object:Gem::Requirement
@@ -341,7 +341,7 @@ homepage: https://github.com/ucb-ist-eas/ucb_rails_user
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -356,8 +356,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Rails engine for UCB user accounts
 test_files: []