ucb_rails_user 4.0.0.beta1 → 4.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f3fda31e483cbb56f2ccd92276f0b549bd35af5c14b7810b5ef864261a08542
-  data.tar.gz: e6743e5b35ee617d28be206a8138da87faaa65ff76692d0b4abe910f8ba8a400
+  metadata.gz: 460c4ebc80d80dbc43a3e1f1653216dec1a5dab89a8f53ad42d073059b48af25
+  data.tar.gz: beb96b35fc53bf4d8890a71696aaf36280d92869d286ce4272b0ce21c5feaa1f
 SHA512:
-  metadata.gz: c8a2c643ca5231faf2c549fded6376838cd875a7a4be9aa33263a8cdffaed7fbfdfd975890debbee4ad082a964c9ddc8b4665237644468318992ddc12941f576
-  data.tar.gz: b6f25dad95cc9f7b88df926408c9e8b04359f34139975ce75b8d2456cd789528ec9d814327bed9a2bf0cbb5ad24a81674b0fc76016ce88eb6218e4952e991dfc
+  metadata.gz: 7ab0216db3aef410c94b8c66df26d9c1064412908645a8fa57a1fcbc0c5283e66f8e57e4220bf2ebdef7bd92af4d3b6a8e2139fad6e86b73fb2ed83229f1dc0c
+  data.tar.gz: 844cc55820bfff87edacf6bc72fb946a80e8a2f2b3ddb1bd8cc0f079209bcd6beb632831041518414b401f1882f4b0a44c9cbb2a1728c6f796db5dd596051b7e

data/README.md

@@ -16,7 +16,7 @@ This engine also includes the [Datatables](https://datatables.net/) JQuery plug-
 
 Version 2.0 and greater of this gem sets a user's `employee_id` to the new UCPath employee id, rather than the legacy HCM employee id. If you need to use the older ID, use version 1.1.3 of this gem, or lower.
 
-## Upgrading to version 3.0 from version 2.x
+## Upgrading to version 3.0+ from version 2.x
 
 See [this wiki page](https://github.com/ucb-ist-eas/ucb_rails_user/wiki/Upgrading-to-version-3.0) for details.
 

data/app/controllers/ucb_rails_user/concerns/home_controller.rb

@@ -2,7 +2,7 @@ module UcbRailsUser::Concerns::HomeController
   extend ActiveSupport::Concern
 
   included do
-    skip_before_action :ensure_authenticated_user
+    skip_before_action :ensure_authenticated_user, raise: false
   end
 
   def index

data/app/controllers/ucb_rails_user/concerns/sessions_controller.rb

@@ -2,7 +2,7 @@ module UcbRailsUser::Concerns::SessionsController
   extend ActiveSupport::Concern
 
   included do
-    skip_before_action :ensure_authenticated_user, :log_request
+    skip_before_action :ensure_authenticated_user, :log_request, raise: false
   end
 
   # Redirects to authentication provider

data/app/controllers/ucb_rails_user/concerns/users_controller.rb

@@ -4,7 +4,7 @@ module UcbRailsUser::Concerns::UsersController
   included do
     before_action :find_user, :only => [:edit, :update, :destroy]
     before_action :ensure_admin_user
-    skip_before_action :ensure_admin_user, if: ->{ action_name == "toggle_superuser" && Rails.env.development? }
+    skip_before_action :ensure_admin_user, if: ->{ action_name == "toggle_superuser" && Rails.env.development? }, raise: false
   end
 
   def index
@@ -56,7 +56,7 @@ module UcbRailsUser::Concerns::UsersController
   end
 
   def update
-    if @user.update_attributes(user_params)
+    if @user.update(user_params)
       redirect_to(admin_users_path, notice: 'Record updated')
     else
       render("edit")
@@ -76,7 +76,7 @@ module UcbRailsUser::Concerns::UsersController
   def ldap_search
     # FIXME: this was retrofitted to support typeahead ajax json queries
     if(query = params[:query])
-      @lps_entries = UcbRails::OmniUserTypeahead.new.ldap_results(query)
+      @lps_entries = UcbRailsUser::OmniUserTypeahead.new.ldap_results(query)
       @lps_entries.map!{|entry|
         attrs = entry.attributes.tap{|attrs| attrs["first_last_name"] = "#{attrs['first_name']} #{attrs['last_name']}" }
         attrs.as_json
@@ -85,13 +85,13 @@ module UcbRailsUser::Concerns::UsersController
       render json: @lps_entries
 
     else
-      @lps_entries = UcbRails::LdapPerson::Finder.find_by_first_last(
+      @lps_entries = UcbRailsUser::LdapPerson::Finder.find_by_first_last(
         params.fetch(:first_name),
         params.fetch(:last_name),
         :sort => :last_first_downcase
       )
       @lps_existing_uids = User.where(ldap_uid: @lps_entries.map(&:uid)).pluck(:uid)
-      render 'lps/search'
+      render 'ucb_rails_user/lps/search'
     end
 
   end

data/app/models/concerns/user_concerns.rb

@@ -2,7 +2,8 @@ module UserConcerns
   extend ActiveSupport::Concern
 
   included do
-    has_many :impersonations, class_name: "::UcbRailsUser::Impersonation"
+    has_many :impersonations, class_name: "::UcbRailsUser::Impersonation", dependent: :delete_all
+    has_many :targets, class_name: "::UcbRailsUser::Impersonation", dependent: :delete_all
   end
 
   # Overridden by application

data/app/models/ucb_rails_user/concerns/impersonation_concerns.rb

@@ -3,8 +3,6 @@ module UcbRailsUser::Concerns::ImpersonationConcerns
 
   included do
     belongs_to :user
-    belongs_to :target, class_name: "User"
+    belongs_to :target, class_name: 'User'
   end
-
 end
-

data/config/routes.rb

@@ -17,6 +17,8 @@ Rails.application.routes.draw do
     as: "admin_user_search", via: [:get]
   match "/admin/users/impersonate_search", to: UcbRailsUser::UsersController.action(:impersonate_search),
     as: "admin_user_impersonate_search", via: [:get]
+  match "/admin/users/ldap_search", to: UcbRailsUser::UsersController.action(:ldap_search),
+    as: "admin_user_ldap_search", via: [:get]
   resources :users, controller: "ucb_rails_user/users", path: "admin/users", as: :admin_users
 
   resources :impersonations, controller: "ucb_rails_user/impersonations", path: "admin/impersonations", as: :admin_impersonations

data/lib/ucb_rails_user/version.rb

@@ -1,3 +1,3 @@
 module UcbRailsUser
-  VERSION = '4.0.0.beta1'
+  VERSION = '4.0.4'
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: ucb_rails_user
 version: !ruby/object:Gem::Version
-  version: 4.0.0.beta1
+  version: 4.0.4
 platform: ruby
 authors:
 - Steve Downey
 - Peter Philips
 - Tyler Minard
 - Darin Wilson
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-14 00:00:00.000000000 Z
+date: 2021-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -47,14 +47,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: active_attr
   requirement: !ruby/object:Gem::Requirement
@@ -341,7 +341,7 @@ homepage: https://github.com/ucb-ist-eas/ucb_rails_user
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -352,12 +352,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.0.1
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Rails engine for UCB user accounts
 test_files: []