uc3-dmp-citation 0.0.15 → 0.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b85070e81998508a3c313105c19a0b9278cf216ef63244c66a170b43768f893f
-  data.tar.gz: 17cede8c1625c1d5cf410e66da106275f860773b6f7bff05eef34218c0ccfe04
+  metadata.gz: f0635b611ac4f1050927777a27b9dcbcdff41a44fb15bd04588b6055a86f6684
+  data.tar.gz: d4edaf1b8d51cadfbf746bcf5352502d157ab13aaa6feb038ad8a12e760546a5
 SHA512:
-  metadata.gz: 10cef531b7850fe4b3780545da0abf473b7558e606c8b3ac06d6d8f32f82ac9bf32c1f616c4672c2ab206163cabe6b7da4881f9b56e57ca08e45422cc6687666
-  data.tar.gz: 1ecc54d76b5eb89a1baea752ad7b54d5af01bb0667c4d52ec567a9cb50954f1940568ff269f5b54c0589ace8e7286ff03e298fae1b9cae2f6eec418a2b1c8d6f
+  metadata.gz: 07cb08cc43d6291d5a6ac0501c13a1ef8723c4eaee0cd43c8328e4f05c11c83ae57ccbe39044cc0735860233be6babfd59af52a37bc1d05b8406b725946e5c63
+  data.tar.gz: 2cd826e807172de65d1b32b50b555bd21692f377ae7adba18d4782b077bee87f454f54c0fb11c170108087f5e387d97dd96d2a0cbcdc33257917aa93a300c8da

data/lib/uc3-dmp-citation/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Uc3DmpCitation
-  VERSION = '0.0.15'
+  VERSION = '0.0.17'
 end

data/lib/uc3-dmp-citation.rb

@@ -23,6 +23,7 @@ module Uc3DmpCitation
 
     class << self
       # rubocop:disable Metrics/AbcSize
+
       def fetch_citation(doi:, work_type: DEFAULT_WORK_TYPE, style: DEFAULT_CITATION_STYLE, logger: nil)
         uri = _doi_to_uri(doi:)
         return nil if uri.nil? || uri.blank?
@@ -35,15 +36,17 @@ module Uc3DmpCitation
           logger&.warn(message: "Failure fetching citation for #{uri} - #{e.message}")
           return nil
         end
-        return nil if resp.nil? || resp.to_s.strip.empty? || resp.code
+        return nil if resp.nil? || resp.to_s.strip.empty?
 
         bibtex_to_citation(uri: uri, bibtex_as_string: resp)
+
       end
       # rubocop:enable Metrics/AbcSize
 
       # Convert the specified BibTex string into a citation
       def bibtex_to_citation(uri:, bibtex_as_string:)
-        return nil unless bibtex_as_string.is_a?(String) && uri.is_a?(String)
+        is_bibtex = looks_like_bibtex(bibtex_as_string)
+        return nil unless bibtex_as_string.is_a?(String) && uri.is_a?(String) && is_bibtex
 
         bibtex = BibTeX.parse(_cleanse_bibtex(text: bibtex_as_string))
         work_type = work_type.nil? ? _determine_work_type(bibtex:) : work_type
@@ -117,6 +120,12 @@ module Uc3DmpCitation
           end
         end
       end
+
+      def looks_like_bibtex(text)
+        # Check if the text contains an @ followed by a known entry type
+        bibtex_entry_types = %w[article book booklet inbook incollection inproceedings conference manual mastersthesis phdthesis techreport misc unpublished]
+        bibtex_entry_types.any? { |type| text.include?("@#{type}") }
+      end
       # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: uc3-dmp-citation
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.17
 platform: ruby
 authors:
 - Brian Riley
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-05 00:00:00.000000000 Z
+date: 2025-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug