u3d 1.2.3 → 1.3.2

data/lib/u3d/commands.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -37,7 +39,7 @@ require 'fileutils'
 
 module U3d
   # API for U3d, redirecting calls to class they concern
-  # rubocop:disable ClassLength
+  # rubocop:disable Metrics/ClassLength
   class Commands
     using ::CoreExtensions::Extractable
 
@@ -51,18 +53,18 @@ module U3d
           return
         end
         list.each do |u|
-          version_format = "Version %-15{version} [%<build_number>s] %<do_not_move>s(%<root_path>s)"
+          version_format = "Version %-15<version>s [%<build_number>s] %<do_not_move>s(%<root_path>s)"
           do_not_move = u.do_not_move? ? '!'.red.bold : ' '
           h = { version: u.version, build_number: u.build_number, root_path: u.root_path, do_not_move: do_not_move }
           UI.message version_format % h
           packages = u.packages
           next unless options[:packages] && packages && !packages.empty?
+
           UI.message 'Packages:'
           packages.each { |pack| UI.message " - #{pack}" }
         end
       end
 
-      # rubocop:disable Style/FormatStringToken
       def console
         require 'irb'
         ARGV.clear
@@ -81,7 +83,6 @@ module U3d
 
         catch(:IRB_EXIT) { @irb.eval_input }
       end
-      # rubocop:enable Style/FormatStringToken
 
       def move(args: {}, options: {})
         long_name = options[:long]
@@ -131,6 +132,7 @@ module U3d
           v = cache_versions[k]
           UI.message "Version #{k}: " + v.to_s.cyan.underline
           next unless show_packages
+
           version_packages = packages[k]
           UI.message 'Packages:'
           version_packages.each { |package| UI.message " - #{package.id.capitalize}" }
@@ -166,6 +168,7 @@ module U3d
         files = Downloader.fetch_modules(definition, packages: packages, download: options[:download])
 
         return unless options[:install]
+
         Installer.install_modules(files, definition.version, installation_path: options[:installation_path])
       end
 
@@ -222,12 +225,14 @@ module U3d
         action = args[0]
         raise "Please specify an action to perform, one of #{credentials_actions.join(',')}" unless action
         raise "Unknown action '#{action}'. Use one of #{credentials_actions.join(',')}" unless credentials_actions.include? action
-        if action == 'add'
+
+        case action
+        when 'add'
           U3dCore::Globals.use_keychain = true
           # credentials = U3dCore::Credentials.new(user: ENV['USER'])
           # credentials.login # ask password
           UI.error 'Invalid credentials' unless U3dCore::CommandExecutor.has_admin_privileges?
-        elsif action == 'remove'
+        when 'remove'
           U3dCore::Globals.use_keychain = true
           U3dCore::Credentials.new(user: ENV['USER']).forget_credentials(force: true)
         else
@@ -269,8 +274,7 @@ module U3d
       def cache_versions(os, offline: false, force_refresh: false, central_cache: true)
         cache = Cache.new(force_os: os, offline: offline, force_refresh: force_refresh, central_cache: central_cache)
         cache_os = cache[os.id2name] || {}
-        cache_versions = cache_os['versions'] || {}
-        cache_versions
+        cache_os['versions'] || {}
       end
 
       def verify_package_names(packages, definition)
@@ -418,6 +422,7 @@ module U3d
         package = definition[package_name]
         return true unless package.depends_on
         return true if unity.package_installed?(package.depends_on)
+
         installing.map { |other| definition[other] }.any? do |other|
           other.id == package.depends_on || other.name == package.depends_on
         end
@@ -430,7 +435,7 @@ module U3d
       end
     end
   end
-  # rubocop:enable ClassLength
+  # rubocop:enable Metrics/ClassLength
 end
 
 class InstallationSetupError < StandardError

data/lib/u3d/commands_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -28,12 +30,12 @@ HighLine.track_eof = false
 
 module U3d
   # CLI using commander gem for u3d
-  # rubocop:disable ClassLength
+  # rubocop:disable Metrics/ClassLength
   class CommandsGenerator
     include Commander::Methods
     UI = U3dCore::UI
 
-    UNICODE_FILE = File.expand_path('../../assets/utf8.txt', __FILE__)
+    UNICODE_FILE = File.expand_path('../assets/utf8.txt', __dir__)
 
     def self.start
       U3dCore::UpdateChecker.start_looking_for_update('u3d')
@@ -97,7 +99,7 @@ Fore more information about how the rules work, see https://github.com/DragonBox
         c.option '-u', '--unity_version STRING', String, 'Version of Unity to run with. If not specified, it runs with the version of the project (either specified as -projectPath or current)'
         c.option '-r', '--raw_logs', 'Raw Unity output, not filtered by u3d\'s log prettifier'
         c.action do |args, options|
-          UI.user_error! "Run doesn't take arguments. Did you forget '--' or did you mistake your command? (#{args})" if args.count > 0
+          UI.user_error! "Run doesn't take arguments. Did you forget '--' or did you mistake your command? (#{args})" if args.count.positive?
           U3dCore::Globals.log_timestamps = true
           Commands.run(options: convert_options(options), run_args: run_args)
         end
@@ -263,5 +265,5 @@ More on that: https://forum.unity3d.com/threads/unity-on-linux-release-notes-and
       run!
     end
   end
-  # rubocop:enable ClassLength
+  # rubocop:enable Metrics/ClassLength
 end

data/lib/u3d/compatibility.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #

data/lib/u3d/download_validator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -51,7 +53,8 @@ module U3d
 
   class LinuxValidator < DownloadValidator
     def validate(package, file, definition)
-      return size_validation(expected: definition[package].download_size, actual: File.size(file)) if definition[package] && definition[package].download_size
+      return size_validation(expected: definition[package].download_size, actual: File.size(file)) if definition[package]&.download_size
+
       UI.important "No file validation available, #{file} is assumed to be correct"
       true
     end
@@ -59,7 +62,7 @@ module U3d
 
   class MacValidator < DownloadValidator
     def validate(package, file, definition)
-      if definition[package].download_size % 1000 && definition[package].checksum.nil?
+      if (definition[package].download_size % 1000) && definition[package].checksum.nil?
         UI.verbose "File '#{definition[package].name}' seems external. Validation skipped"
         return true
       end
@@ -71,7 +74,7 @@ module U3d
   class WindowsValidator < DownloadValidator
     def validate(package, file, definition)
       # External packages have no md5 and a false size value
-      if definition[package].download_size % 1000 && definition[package].checksum.nil?
+      if (definition[package].download_size % 1000) && definition[package].checksum.nil?
         UI.verbose "File '#{definition[package].name}' seems external. Validation skipped"
         return true
       end

data/lib/u3d/downloader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -27,13 +29,13 @@ module U3d
   # Take care of downloading files and packages
   module Downloader
     # Name of the directory for the package downloading
-    DOWNLOAD_DIRECTORY = 'Unity_Packages'.freeze
+    DOWNLOAD_DIRECTORY = 'Unity_Packages'
     # Path to the directory for the package downloading
-    DOWNLOAD_PATH = "#{ENV['HOME']}/Downloads".freeze
+    DOWNLOAD_PATH = "#{ENV['HOME']}/Downloads"
     # Regex to get the name of a localization asset
-    UNITY_LANGUAGE_FILE_REGEX = %r{\/\d+/[0-9\.]+\/([\w-]+)$}
+    UNITY_LANGUAGE_FILE_REGEX = %r{/\d+/[0-9.]+/([\w-]+)$}.freeze
     # Regex to get the name of a package out of its file name
-    UNITY_MODULE_FILE_REGEX = %r{\/([\w\-_\.\+]+\.(?:pkg|dmg|exe|zip|sh|deb|msi|xz))[^\/]*$}
+    UNITY_MODULE_FILE_REGEX = %r{/([\w\-_.+]+\.(?:pkg|dmg|exe|zip|sh|deb|msi|xz))[^/]*$}.freeze
 
     class << self
       def download_directory
@@ -112,15 +114,15 @@ module U3d
             return
           else
             extension = File.extname(path)
-            new_path = File.join(File.dirname(path), File.basename(path, extension) + '_CORRUPTED' + extension)
+            new_path = File.join(File.dirname(path), "#{File.basename(path, extension)}_CORRUPTED#{extension}")
             UI.important "File present at #{path} is not correct, it has been renamed to #{new_path}"
             File.rename(path, new_path)
           end
         end
 
         UI.header "Downloading #{package_info.name} version #{definition.version}"
-        UI.message 'Downloading from ' + url.to_s.cyan.underline
-        UI.message 'Download will be found at ' + path
+        UI.message "Downloading from #{url.to_s.cyan.underline}"
+        UI.message "Download will be found at #{path}"
         download_package(path, url, size: package_info.download_size)
 
         if validator.validate(package, path, definition)
@@ -153,7 +155,7 @@ module U3d
         Utils.ensure_dir(dir)
 
         file_name = if (language_match = UNITY_LANGUAGE_FILE_REGEX.match(final_url))
-                      language_match[1] + '.po' # Unity uses PO (Portable object files) for localization
+                      "#{language_match[1]}.po" # Unity uses PO (Portable object files) for localization
                     elsif (module_match = UNITY_MODULE_FILE_REGEX.match(final_url))
                       module_match[1]
                     else
@@ -182,8 +184,10 @@ module U3d
     # for backward compatibility
     class MacDownloader < StandardPackageDownloader
     end
+
     class LinuxDownloader < StandardPackageDownloader
     end
+
     class WindowsDownloader < StandardPackageDownloader
     end
   end

data/lib/u3d/failure_reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'date'
 require 'fileutils'
 require 'json'
@@ -9,6 +11,7 @@ module U3d
     class << self
       def report(failure_type: "DEFAULT", failure_message: "", data: {})
         return unless ENV['U3D_REPORT_FAILURES']
+
         report = {
           type: failure_type,
           message: failure_message,
@@ -21,9 +24,7 @@ module U3d
           "#{failure_type}.#{Date.now.strftime('%Y%m%dT%H%M')}.failure.json"
         )
 
-        File.open(report_file, 'w') do |file|
-          file.write JSON.pretty_generate(report)
-        end
+        File.write(report_file, JSON.pretty_generate(report))
       rescue StandardError => e
         UI.important "Unable to report a #{failure_type} failure. Please use --verbose to get more information about the failure"
         UI.verbose "Unable to report failure: #{e}"

data/lib/u3d/hub_modules_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -28,19 +30,34 @@ require 'u3d_core/helper'
 module U3d
   module HubModulesParser
     class << self
-      HUB_MODULES_NAME = '%<version>s-%<os>s-modules.json'.freeze
+      HUB_MODULES_NAME = '%<version>s-%<os>s-modules.json'
 
       def load_modules(version, os: U3dCore::Helper.operating_system, offline: false)
         path = modules_path(version, os)
 
-        unless File.file?(path) && File.size(path) > 0
-          return [] if offline # Should not raise, not all versions have hub modules
-          versions = download_modules(os: os)
+        # force download if no hub file present
+        download_modules(os: os) if !Utils.file_exists_not_empty?(path) && !offline
+
+        unless Utils.file_exists_not_empty?(path)
+          UI.verbose "No modules registered for UnityHub for version #{version}"
+          # cached_versions.keys.map{|s| UnityVersionNumber.new(s)}
+          # searching for closest version
+          files = Dir.glob("#{default_modules_path}/*-#{os}-modules.json")
+
+          vn = UnityVersionNumber.new(version)
+
+          versions_and_paths = files.map do |p|
+            v = File.basename(p).split('-')[0]
+            [UnityVersionNumber.new(v), p]
+          end
+          # filtered by version major.minor.patch (same major & minor and patch higher or equal)
+          versions_and_paths = versions_and_paths.select { |a| a[0].parts[0] == vn.parts[0] && a[0].parts[1] == vn.parts[1] && a[0].parts[2] >= vn.parts[2] }
 
-          unless versions.include? version
-            UI.verbose "No modules registered for UnityHub for version #{version}"
+          if versions_and_paths.empty?
+            UI.info "No closest version from UnityHub found for version #{version}"
             return []
           end
+          path = versions_and_paths.first[1]
         end
 
         return JSON.parse(File.read(path))
@@ -81,7 +98,7 @@ module U3d
         path = modules_path(build['version'], os)
         Utils.ensure_dir(File.dirname(path))
 
-        File.open(path, 'w') { |file| file.write build['modules'].to_json }
+        File.write(path, build['modules'].to_json)
       end
     end
   end

data/lib/u3d/ini_modules_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -30,7 +32,7 @@ module U3d
     #####################################################
     # @!group INI parameters to load and save ini files
     #####################################################
-    INI_NAME = 'unity-%<version>s-%<os>s.ini'.freeze
+    INI_NAME = 'unity-%<version>s-%<os>s.ini'
 
     class << self
       def load_ini(version, cached_versions, os: U3dCore::Helper.operating_system, offline: false)
@@ -42,8 +44,9 @@ module U3d
         ini_name = format(INI_NAME, version: version, os: os)
         Utils.ensure_dir(default_ini_path)
         ini_path = File.expand_path(ini_name, default_ini_path)
-        unless File.file?(ini_path) && File.size(ini_path) > 0
+        unless Utils.file_exists_not_empty?(ini_path)
           raise "INI file does not exist at #{ini_path}" if offline
+
           download_ini(version, cached_versions, os, ini_name, ini_path)
         end
         begin
@@ -58,7 +61,8 @@ module U3d
         ini_name = format(INI_NAME, version: version, os: 'linux')
         Utils.ensure_dir(default_ini_path)
         ini_path = File.expand_path(ini_name, default_ini_path)
-        return if File.file?(ini_path) && File.size(ini_path) > 0
+        return if File.file?(ini_path) && File.size(ini_path).positive?
+
         data = %([Unity]
 ; -- NOTE --
 ; This is not an official Unity file
@@ -90,16 +94,14 @@ url=#{url}
         UI.verbose("Searching for ini file at #{uri}")
 
         data = Net::HTTP.get(uri)
-        data.tr!("\"", '')
-        data.gsub!(/Note:.+\n/, '')
+        data = data.tr("\"", '')
+        data = data.gsub(/Note:.+\n/, '')
 
         write_ini_file(ini_path, data)
       end
 
       def write_ini_file(ini_path, data)
-        File.open(ini_path, 'wb') do |f|
-          f.write(data)
-        end
+        File.binwrite(ini_path, data)
       end
 
       def default_ini_path

data/lib/u3d/installation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -25,9 +27,12 @@ require 'u3d_core/admin_tools'
 require 'fileutils'
 
 module U3d
-  UNITY_DIR_CHECK = /Unity_\d+\.\d+\.\d+[a-z]\d+/
-  UNITY_DIR_CHECK_LINUX = /unity-editor-\d+\.\d+\.\d+[a-z]\d+\z/
-  U3D_DO_NOT_MOVE = ".u3d_do_not_move".freeze
+  UNITY_DIR_CHECK = /Unity_\d+\.\d+\.\d+[a-z]\d+/.freeze
+  UNITY_DIR_CHECK_LINUX = /unity-editor-\d+\.\d+\.\d+[a-z]\d+\z/.freeze
+  # Linux unity_builtin_extra seek position for version
+  UNITY_VERSION_LINUX_POS_LE_2019 = 20
+  UNITY_VERSION_LINUX_POS_GT_2019 = 48
+  U3D_DO_NOT_MOVE = ".u3d_do_not_move"
 
   class Installation
     attr_accessor :root_path
@@ -114,6 +119,7 @@ module U3d
       require 'rexml/document'
       UI.verbose("reading #{config_path}")
       raise "File not found at #{config_path}" unless File.exist? config_path
+
       doc = REXML::Document.new(File.read(config_path))
       REXML::XPath.first(doc, node_name).value
     end
@@ -142,10 +148,19 @@ module U3d
   class InstallationUtils
     def self.read_version_from_unity_builtin_extra(file)
       File.open(file, "rb") do |f|
-        f.seek(20)
+        # Check if it is version lower or equal to 2019
+        seek_pos = UNITY_VERSION_LINUX_POS_LE_2019
+        f.seek(seek_pos)
+        z = f.read(1)
+        if z == "\x00"
+          # Version is greater than 2019
+          seek_pos = UNITY_VERSION_LINUX_POS_GT_2019
+        end
+        f.seek(seek_pos)
         s = ""
         while (c = f.read(1))
           break if c == "\x00"
+
           s += c
         end
         s
@@ -175,6 +190,7 @@ module U3d
     def path
       UI.deprecated("path is deprecated. Use root_path instead")
       return @path if @path
+
       "#{@root_path}/Unity.app"
     end
 
@@ -217,13 +233,14 @@ module U3d
         begin
           fpath = "#{root_path}/Unity.app/Contents/Info.plist"
           raise "#{fpath} doesn't exist" unless File.exist? fpath
+
           Plist.parse_xml(fpath)
         end
     end
   end
 
   class LinuxInstallationHelper
-    STRINGS_FULL_VERSION_MATCHER = /^[0-9\.abfp]+_[0-9a-f]{12}/
+    STRINGS_FULL_VERSION_MATCHER = /^[0-9.abfp]+_[0-9a-f]{12}/.freeze
 
     def find_build_number(root)
       known_rev_locations.each do |p|
@@ -236,10 +253,10 @@ module U3d
     private
 
     def strings(path)
-      if `which strings` != ''
-        binutils_strings(path)
-      else
+      if `which strings` == ''
         Utils.strings(path).to_a
+      else
+        binutils_strings(path)
       end
     end
 
@@ -258,8 +275,9 @@ module U3d
 
     def find_build_number_in(path = nil)
       return nil unless File.exist? path
+
       str = strings(path)
-      lines = str.select { |l| l =~ STRINGS_FULL_VERSION_MATCHER }
+      lines = str.grep(STRINGS_FULL_VERSION_MATCHER)
       lines.empty? ? nil : lines[0].split('_')[1]
     end
   end
@@ -347,44 +365,7 @@ module U3d
     private
 
     def unity_version_info
-      @uvf ||= string_file_info('Unity Version', @exe_path)
-    end
-
-    def string_file_info(info, path)
-      require "Win32API"
-      get_file_version_info_size = Win32API.new('version.dll', 'GetFileVersionInfoSize', 'PP', 'L')
-      get_file_version_info = Win32API.new('version.dll', 'GetFileVersionInfo', 'PIIP', 'I')
-      ver_query_value = Win32API.new('version.dll', 'VerQueryValue', 'PPPP', 'I')
-      rtl_move_memory = Win32API.new('kernel32.dll', 'RtlMoveMemory', 'PLL', 'I')
-
-      file = path.tr("/", "\\")
-
-      buf = [0].pack('L')
-      version_size = get_file_version_info_size.call(file + "\0", buf)
-      raise Exception if version_size.zero? # TODO: use GetLastError
-
-      version_info = 0.chr * version_size
-      version_ok = get_file_version_info.call(file, 0, version_size, version_info)
-      raise Exception if version_ok.zero? # TODO: use GetLastError
-
-      # hardcoding lang codepage
-      struct_path = "\\StringFileInfo\\040904b0\\#{info}"
-
-      addr = [0].pack('L')
-      size = [0].pack('L')
-      query_ok = ver_query_value.call(version_info, struct_path + "\0", addr, size)
-      raise Exception if query_ok.zero?
-
-      raddr = addr.unpack('L')[0]
-      rsize = size.unpack('L')[0]
-
-      info = Array.new(rsize, 0).pack('L*')
-      rtl_move_memory.call(info, raddr, info.length)
-      info.strip
-    rescue StandardError => e
-      UI.verbose("Failure to find '#{info}' under '#{path}': #{e}")
-      UI.verbose(e.backtrace)
-      nil
+      @unity_version_info ||= U3d::Utils.windows_fileversion('Unity Version', @exe_path)
     end
   end
 
@@ -396,6 +377,7 @@ module U3d
       path = "#{root_path}/Editor/Data/"
       package = IvyPlaybackEngineUtils.list_module_configs(path).first
       raise "Couldn't find a module under #{path}" unless package
+
       IvyPlaybackEngineUtils.unity_version(package)
     end
 
@@ -410,8 +392,8 @@ module U3d
           log_dir = File.expand_path('Unity/Editor/', loc_appdata)
           UI.important "Log directory (#{log_dir}) does not exist" unless Dir.exist? log_dir
           @logfile = File.expand_path('Editor.log', log_dir)
-        rescue RuntimeError => ex
-          UI.error "Unable to retrieve the editor logfile: #{ex}"
+        rescue RuntimeError => e
+          UI.error "Unable to retrieve the editor logfile: #{e}"
         end
       end
       @logfile