u3d 1.2.2 → 1.3.1

data/lib/u3d/installation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -25,9 +27,12 @@ require 'u3d_core/admin_tools'
 require 'fileutils'
 
 module U3d
-  UNITY_DIR_CHECK = /Unity_\d+\.\d+\.\d+[a-z]\d+/
-  UNITY_DIR_CHECK_LINUX = /unity-editor-\d+\.\d+\.\d+[a-z]\d+\z/
-  U3D_DO_NOT_MOVE = ".u3d_do_not_move".freeze
+  UNITY_DIR_CHECK = /Unity_\d+\.\d+\.\d+[a-z]\d+/.freeze
+  UNITY_DIR_CHECK_LINUX = /unity-editor-\d+\.\d+\.\d+[a-z]\d+\z/.freeze
+  # Linux unity_builtin_extra seek position for version
+  UNITY_VERSION_LINUX_POS_LE_2019 = 20
+  UNITY_VERSION_LINUX_POS_GT_2019 = 48
+  U3D_DO_NOT_MOVE = ".u3d_do_not_move"
 
   class Installation
     attr_accessor :root_path
@@ -105,7 +110,7 @@ module U3d
     end
   end
 
-  class PlaybackEngineUtils
+  class IvyPlaybackEngineUtils
     def self.list_module_configs(playbackengine_parent_path)
       Dir.glob("#{playbackengine_parent_path}/PlaybackEngines/*/ivy.xml")
     end
@@ -114,6 +119,7 @@ module U3d
       require 'rexml/document'
       UI.verbose("reading #{config_path}")
       raise "File not found at #{config_path}" unless File.exist? config_path
+
       doc = REXML::Document.new(File.read(config_path))
       REXML::XPath.first(doc, node_name).value
     end
@@ -127,6 +133,41 @@ module U3d
     end
   end
 
+  class ModulePlaybackEngineUtils
+    def self.list_module_configs(playbackengine_parent_path)
+      # this should work on all platforms, non existing paths being ignored...
+      Dir.glob("#{playbackengine_parent_path}/PlaybackEngines/*/modules.asset") |
+        Dir.glob("#{playbackengine_parent_path}/Unity.app/Contents/PlaybackEngines/*/modules.asset")
+    end
+
+    def self.module_name(config_path)
+      File.basename(File.dirname(config_path)).gsub("Support", "")
+    end
+  end
+
+  class InstallationUtils
+    def self.read_version_from_unity_builtin_extra(file)
+      File.open(file, "rb") do |f|
+        # Check if it is version lower or equal to 2019
+        seek_pos = UNITY_VERSION_LINUX_POS_LE_2019
+        f.seek(seek_pos)
+        z = f.read(1)
+        if z == "\x00"
+          # Version is greater than 2019
+          seek_pos = UNITY_VERSION_LINUX_POS_GT_2019
+        end
+        f.seek(seek_pos)
+        s = ""
+        while (c = f.read(1))
+          break if c == "\x00"
+
+          s += c
+        end
+        s
+      end
+    end
+  end
+
   class MacInstallation < Installation
     require 'plist'
 
@@ -149,14 +190,19 @@ module U3d
     def path
       UI.deprecated("path is deprecated. Use root_path instead")
       return @path if @path
+
       "#{@root_path}/Unity.app"
     end
 
     def packages
       pack = []
-      PlaybackEngineUtils.list_module_configs(root_path).each do |mpath|
-        pack << PlaybackEngineUtils.module_name(mpath)
+      IvyPlaybackEngineUtils.list_module_configs(root_path).each do |mpath|
+        pack << IvyPlaybackEngineUtils.module_name(mpath)
+      end
+      ModulePlaybackEngineUtils.list_module_configs(root_path).each do |mpath|
+        pack << ModulePlaybackEngineUtils.module_name(mpath)
       end
+
       NOT_PLAYBACKENGINE_PACKAGES.each do |module_name|
         pack << module_name unless Dir[module_name_pattern(module_name)].empty?
       end
@@ -187,13 +233,14 @@ module U3d
         begin
           fpath = "#{root_path}/Unity.app/Contents/Info.plist"
           raise "#{fpath} doesn't exist" unless File.exist? fpath
+
           Plist.parse_xml(fpath)
         end
     end
   end
 
   class LinuxInstallationHelper
-    STRINGS_FULL_VERSION_MATCHER = /^[0-9\.abfp]+_[0-9a-f]{12}/
+    STRINGS_FULL_VERSION_MATCHER = /^[0-9.abfp]+_[0-9a-f]{12}/.freeze
 
     def find_build_number(root)
       known_rev_locations.each do |p|
@@ -206,10 +253,10 @@ module U3d
     private
 
     def strings(path)
-      if `which strings` != ''
-        binutils_strings(path)
-      else
+      if `which strings` == ''
         Utils.strings(path).to_a
+      else
+        binutils_strings(path)
       end
     end
 
@@ -228,23 +275,17 @@ module U3d
 
     def find_build_number_in(path = nil)
       return nil unless File.exist? path
+
       str = strings(path)
-      lines = str.select { |l| l =~ STRINGS_FULL_VERSION_MATCHER }
+      lines = str.grep(STRINGS_FULL_VERSION_MATCHER)
       lines.empty? ? nil : lines[0].split('_')[1]
     end
   end
 
   class LinuxInstallation < Installation
     def version
-      # I don't find an easy way to extract the version on Linux
-      path = "#{root_path}/Editor/Data/"
-      package = PlaybackEngineUtils.list_module_configs(path).first
-      raise "Couldn't find a module under #{path}" unless package
-      version = PlaybackEngineUtils.unity_version(package)
-      if (m = version.match(/^(.*)x(.*)Linux$/))
-        version = "#{m[1]}#{m[2]}"
-      end
-      version
+      path = "#{root_path}/Editor/Data/Resources/unity_builtin_extra"
+      InstallationUtils.read_version_from_unity_builtin_extra(path)
     end
 
     def build_number
@@ -267,8 +308,11 @@ module U3d
     def packages
       path = "#{root_path}/Editor/Data/"
       pack = []
-      PlaybackEngineUtils.list_module_configs(path).each do |mpath|
-        pack << PlaybackEngineUtils.module_name(mpath)
+      IvyPlaybackEngineUtils.list_module_configs(path).each do |mpath|
+        pack << IvyPlaybackEngineUtils.module_name(mpath)
+      end
+      ModulePlaybackEngineUtils.list_module_configs(root_path).each do |mpath|
+        pack << ModulePlaybackEngineUtils.module_name(mpath)
       end
       NOT_PLAYBACKENGINE_PACKAGES.each do |module_name|
         pack << module_name unless Dir[module_name_pattern(module_name)].empty?
@@ -321,44 +365,7 @@ module U3d
     private
 
     def unity_version_info
-      @uvf ||= string_file_info('Unity Version', @exe_path)
-    end
-
-    def string_file_info(info, path)
-      require "Win32API"
-      get_file_version_info_size = Win32API.new('version.dll', 'GetFileVersionInfoSize', 'PP', 'L')
-      get_file_version_info = Win32API.new('version.dll', 'GetFileVersionInfo', 'PIIP', 'I')
-      ver_query_value = Win32API.new('version.dll', 'VerQueryValue', 'PPPP', 'I')
-      rtl_move_memory = Win32API.new('kernel32.dll', 'RtlMoveMemory', 'PLL', 'I')
-
-      file = path.tr("/", "\\")
-
-      buf = [0].pack('L')
-      version_size = get_file_version_info_size.call(file + "\0", buf)
-      raise Exception if version_size.zero? # TODO: use GetLastError
-
-      version_info = 0.chr * version_size
-      version_ok = get_file_version_info.call(file, 0, version_size, version_info)
-      raise Exception if version_ok.zero? # TODO: use GetLastError
-
-      # hardcoding lang codepage
-      struct_path = "\\StringFileInfo\\040904b0\\#{info}"
-
-      addr = [0].pack('L')
-      size = [0].pack('L')
-      query_ok = ver_query_value.call(version_info, struct_path + "\0", addr, size)
-      raise Exception if query_ok.zero?
-
-      raddr = addr.unpack('L')[0]
-      rsize = size.unpack('L')[0]
-
-      info = Array.new(rsize, 0).pack('L*')
-      rtl_move_memory.call(info, raddr, info.length)
-      info.strip
-    rescue StandardError => e
-      UI.verbose("Failure to find '#{info}' under '#{path}': #{e}")
-      UI.verbose(e.backtrace)
-      nil
+      @unity_version_info ||= U3d::Utils.windows_fileversion('Unity Version', @exe_path)
     end
   end
 
@@ -368,9 +375,10 @@ module U3d
       return version unless version.nil?
 
       path = "#{root_path}/Editor/Data/"
-      package = PlaybackEngineUtils.list_module_configs(path).first
+      package = IvyPlaybackEngineUtils.list_module_configs(path).first
       raise "Couldn't find a module under #{path}" unless package
-      PlaybackEngineUtils.unity_version(package)
+
+      IvyPlaybackEngineUtils.unity_version(package)
     end
 
     def build_number
@@ -384,8 +392,8 @@ module U3d
           log_dir = File.expand_path('Unity/Editor/', loc_appdata)
           UI.important "Log directory (#{log_dir}) does not exist" unless Dir.exist? log_dir
           @logfile = File.expand_path('Editor.log', log_dir)
-        rescue RuntimeError => ex
-          UI.error "Unable to retrieve the editor logfile: #{ex}"
+        rescue RuntimeError => e
+          UI.error "Unable to retrieve the editor logfile: #{e}"
         end
       end
       @logfile
@@ -403,8 +411,11 @@ module U3d
     def packages
       path = "#{root_path}/Editor/Data/"
       pack = []
-      PlaybackEngineUtils.list_module_configs(path).each do |mpath|
-        pack << PlaybackEngineUtils.module_name(mpath)
+      IvyPlaybackEngineUtils.list_module_configs(path).each do |mpath|
+        pack << IvyPlaybackEngineUtils.module_name(mpath)
+      end
+      ModulePlaybackEngineUtils.list_module_configs(root_path).each do |mpath|
+        pack << ModulePlaybackEngineUtils.module_name(mpath)
       end
       NOT_PLAYBACKENGINE_PACKAGES.each do |module_name|
         pack << module_name unless Dir[module_name_pattern(module_name)].empty?

data/lib/u3d/installer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -30,13 +32,13 @@ require 'pathname'
 require 'zip'
 
 module U3d
-  DEFAULT_LINUX_INSTALL = '/opt/'.freeze
-  DEFAULT_MAC_INSTALL = '/'.freeze
-  DEFAULT_WINDOWS_INSTALL = 'C:/Program Files/'.freeze
-  UNITY_DIR = "Unity_%<version>s".freeze
-  UNITY_DIR_LONG = "Unity_%<version>s_%<build_number>s".freeze
-  UNITY_DIR_LINUX = "unity-editor-%<version>s".freeze
-  UNITY_DIR_LINUX_LONG = "unity-editor-%<version>s_%<build_number>s".freeze
+  DEFAULT_LINUX_INSTALL = '/opt/'
+  DEFAULT_MAC_INSTALL = '/'
+  DEFAULT_WINDOWS_INSTALL = 'C:/Program Files/'
+  UNITY_DIR = "Unity_%<version>s"
+  UNITY_DIR_LONG = "Unity_%<version>s_%<build_number>s"
+  UNITY_DIR_LINUX = "unity-editor-%<version>s"
+  UNITY_DIR_LINUX_LONG = "unity-editor-%<version>s_%<build_number>s"
 
   class Installer
     def self.create
@@ -57,7 +59,7 @@ module U3d
       installer = Installer.create
       files.each do |name, file, info|
         UI.header "Installing #{info.name} (#{name})"
-        UI.message 'Installing with ' + file
+        UI.message "Installing with #{file}"
         installer.install(file, version, installation_path: installation_path, info: info)
       end
     end
@@ -71,20 +73,24 @@ module U3d
   class BaseInstaller
     def sanitize_installs
       return unless UI.interactive? || Helper.test?
+
       unclean = []
       installed.each { |unity| unclean << unity unless unity.clean_install? }
       return if unclean.empty?
+
       UI.important("u3d can optionally standardize the existing Unity installation names and locations.")
       UI.important("Check the documentation for more information:")
       UI.important("** https://github.com/DragonBox/u3d/blob/master/README.md#default-installation-paths **")
       unclean.each { |unity| sanitize_install(unity, dry_run: true) }
       return unless UI.confirm("#{unclean.count} Unity installation(s) will be moved. Proceed??")
+
       unclean.each { |unity| sanitize_install(unity) }
     end
 
     def installed_sorted_by_versions
       list = installed
       return [] if list.empty?
+
       list.sort { |a, b| UnityVersionComparator.new(a.version) <=> UnityVersionComparator.new(b.version) }
     end
 
@@ -123,7 +129,7 @@ module U3d
         end
       end
 
-      if info && info.rename_from && info.rename_to
+      if info&.rename_from && info&.rename_to
         rename_from = info.rename_from.gsub(/{UNITY_PATH}/, unity.root_path)
         rename_to = info.rename_to.gsub(/{UNITY_PATH}/, unity.root_path)
         Utils.ensure_dir(rename_to)
@@ -131,7 +137,7 @@ module U3d
         if File.file? rename_from
           FileUtils.mv(rename_from, rename_to)
         else
-          Dir.glob(rename_from + '/*').each { |path| FileUtils.mv(path, rename_to) }
+          Dir.glob("#{rename_from}/*").each { |path| FileUtils.mv(path, rename_to) }
         end
       end
 
@@ -139,7 +145,7 @@ module U3d
     end
 
     def package_destination(info, unity_root_path)
-      if info && info.destination
+      if info&.destination
         info.destination.gsub(/{UNITY_PATH}/, unity_root_path)
       else
         unity_root_path
@@ -151,14 +157,15 @@ module U3d
     # Returns an array of ruby style paths
     def extra_installation_paths
       return [] if ENV['U3D_EXTRA_PATHS'].nil?
+
       ENV['U3D_EXTRA_PATHS'].strip.split(File::PATH_SEPARATOR).map { |p| File.expand_path p }
     end
 
-    def find_installations_with_path(default_root_path: '', postfix: [])
+    def find_installations_with_path(default_root_path: '', postfix: [], &block)
       ([default_root_path] | extra_installation_paths).map do |path|
         UI.verbose "Looking for installed Unity version under #{path}"
         pattern = File.join([path] + postfix)
-        Dir.glob(pattern).map { |found_path| yield found_path }
+        Dir.glob(pattern).map(&block)
       end.flatten
     end
   end
@@ -189,14 +196,17 @@ module U3d
     end
 
     def install(file_path, version, installation_path: nil, info: nil)
-      # rubocop:enable UnusedMethodArgument
       extension = File.extname(file_path)
-      raise "Installation of #{extension} files is not supported on Mac" unless %w[.zip .po .pkg].include? extension
+      raise "Installation of #{extension} files is not supported on Mac" unless %w[.zip .po .pkg .dmg].include? extension
+
       path = installation_path || DEFAULT_MAC_INSTALL
-      if extension == '.po'
+      case extension
+      when '.po'
         install_po(file_path, version, info: info)
-      elsif extension == '.zip'
+      when '.zip'
         install_zip(file_path, version, info: info)
+      when '.dmg'
+        UI.important "Skipping installation of #{file_path} for now"
       else
         install_pkg(file_path, version: version, target_path: path)
       end
@@ -276,7 +286,7 @@ module U3d
     end
   end
 
-  # rubocop:disable ClassLength
+  # rubocop:disable Metrics/ClassLength
   class LinuxInstaller < BaseInstaller
     def sanitize_install(unity, long: false, dry_run: false)
       source_path = File.expand_path(unity.root_path)
@@ -294,26 +304,26 @@ module U3d
       paths.map { |path| LinuxInstallation.new(root_path: path) }
     end
 
-    # rubocop:disable PerceivedComplexity
     def install(file_path, version, installation_path: nil, info: nil)
-      # rubocop:enable UnusedMethodArgument, PerceivedComplexity
       extension = File.extname(file_path)
 
       raise "Installation of #{extension} files is not supported on Linux" unless ['.zip', '.po', '.sh', '.xz', '.pkg'].include? extension
-      if extension == '.sh'
+
+      case extension
+      when '.sh'
         path = installation_path || DEFAULT_LINUX_INSTALL
         install_sh(file_path, installation_path: path)
-      elsif extension == '.xz'
+      when '.xz'
         new_path = File.join(DEFAULT_LINUX_INSTALL, format(UNITY_DIR_LINUX, version: version))
         path = installation_path || new_path
         install_xz(file_path, installation_path: path)
-      elsif extension == '.pkg'
+      when '.pkg'
         new_path = File.join(DEFAULT_LINUX_INSTALL, format(UNITY_DIR_LINUX, version: version))
         path = installation_path || new_path
         install_pkg(file_path, installation_path: path)
-      elsif extension == '.po'
+      when '.po'
         install_po(file_path, version, info: info)
-      elsif extension == '.zip'
+      when '.zip'
         install_zip(file_path, version, info: info)
       end
 
@@ -397,6 +407,7 @@ module U3d
 
     def pkg_install_path(unity_root_path, pinfo_path)
       raise "PackageInfo not found under #{pinfo_path}" unless File.exist? pinfo_path
+
       pinfo = File.read(pinfo_path)
       require 'rexml/document'
       d = REXML::Document.new(pinfo)
@@ -412,6 +423,7 @@ module U3d
       else
         install_location = d.root.attributes['install-location']
         raise "Not sure how to install this module with identifier #{identifier} install-location: #{install_location}" unless install_location.start_with? '/Applications/Unity/'
+
         install_location.gsub(%(\/Applications\/Unity), "#{unity_root_path}/Editor/Data")
       end
     end
@@ -440,7 +452,7 @@ module U3d
       paths
     end
   end
-  # rubocop:enable ClassLength
+  # rubocop:enable Metrics/ClassLength
 
   class WindowsInstaller < BaseInstaller
     def sanitize_install(unity, long: false, dry_run: false)
@@ -468,10 +480,12 @@ module U3d
     def install(file_path, version, installation_path: nil, info: nil)
       extension = File.extname(file_path)
       raise "Installation of #{extension} files is not supported on Windows" unless %w[.po .zip .exe .msi].include? extension
+
       path = installation_path || File.join(DEFAULT_WINDOWS_INSTALL, format(UNITY_DIR, version: version))
-      if extension == '.po'
+      case extension
+      when '.po'
         install_po(file_path, version, info: info)
-      elsif extension == '.zip'
+      when '.zip'
         install_zip(file_path, version, info: info)
       else
         install_exe(file_path, installation_path: path, info: info)
@@ -487,14 +501,14 @@ module U3d
         if info.command
           command = info.command
           if /msiexec/ =~ command
-            command.sub!(/{FILENAME}/, '"' + U3dCore::Helper.windows_path(file_path) + '"')
+            command.sub!(/{FILENAME}/, "\"#{U3dCore::Helper.windows_path(file_path)}\"")
           else
             command.sub!(/{FILENAME}/, file_path.argescape)
           end
           command.sub!(/{INSTDIR}/, final_path)
           command.sub!(/{DOCDIR}/, final_path)
           command.sub!(/{MODULEDIR}/, final_path)
-          command.sub!(%r{\/D=}, '/S /D=') unless %r{\/S} =~ command
+          command.sub!(%r{/D=}, '/S /D=') unless %r{/S} =~ command
         end
         command ||= file_path.argescape
         U3dCore::CommandExecutor.execute(command: command, admin: true)
@@ -570,9 +584,8 @@ module U3d
         raise 'Cannot install dependencies on your Linux distribution'
       end
 
-      if UI.interactive?
-        return unless UI.confirm "Install dependencies? (#{DEPENDENCIES.length} dependency(ies) to install)"
-      end
+      return if UI.interactive? && !(UI.confirm "Install dependencies? (#{DEPENDENCIES.length} dependency(ies) to install)")
+
       U3dCore::CommandExecutor.execute(command: "#{prefix} #{DEPENDENCIES.join(' ')}", admin: true)
     end
   end

data/lib/u3d/log_analyzer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -25,9 +27,9 @@ require 'u3d/failure_reporter'
 
 module U3d
   # Analyzes log by filtering output along a set of rules
-  # rubocop:disable ClassLength, PerceivedComplexity, BlockNesting
+  # rubocop:disable Metrics/ClassLength, Metrics/PerceivedComplexity, Metrics/BlockNesting
   class LogAnalyzer
-    RULES_PATH = File.expand_path('../../../config/log_rules.json', __FILE__)
+    RULES_PATH = File.expand_path('../../config/log_rules.json', __dir__)
     MEMORY_SIZE = 10
 
     def initialize
@@ -55,6 +57,7 @@ module U3d
         # Phase parsing
         next unless phase['active']
         next if phase['phase_start_pattern'].nil?
+
         phase['phase_start_pattern'] = Regexp.new phase['phase_start_pattern']
         phase['phase_end_pattern'] = Regexp.new phase['phase_end_pattern'] if phase['phase_end_pattern']
         phase.delete('comment')
@@ -79,6 +82,7 @@ module U3d
       @phases.each do |name, phase|
         next if name == @active_phase
         next unless line =~ phase['phase_start_pattern']
+
         finish_phase if @active_phase
         @active_phase = name
         UI.verbose("--- Beginning #{name} phase ---")
@@ -116,12 +120,10 @@ module U3d
           # It's not the end of the rules, should the line be stored?
           elsif rule['store_lines']
             match = false
-            if rule['ignore_lines']
-              rule['ignore_lines'].each do |pat|
-                if line =~ pat
-                  match = true
-                  break
-                end
+            rule['ignore_lines']&.each do |pat|
+              if line =~ pat
+                match = true
+                break
               end
             end
             @rule_lines_buffer << line.chomp unless match
@@ -133,6 +135,7 @@ module U3d
           ruleset.each do |rn, r|
             pattern = r['start_pattern']
             next unless line =~ pattern
+
             @active_rule = rn if r['end_pattern']
             match = line.match(pattern)
             @context = match.names.map(&:to_sym).zip(match.captures).to_h
@@ -145,10 +148,12 @@ module U3d
                   match = false
                   r['fetch_first_line_not_matching'].each do |pat|
                     next unless l =~ pat
+
                     match = true
                     break
                   end
                   next if match
+
                   fetched_line = l
                   break
                 end
@@ -196,7 +201,7 @@ module U3d
       if @active_rule
         # Active rule should be finished
         # If it is still active during phase change, it means that something went wrong
-        context = @lines_memory.map { |l| "> #{l}" }.join('')
+        context = @lines_memory.map { |l| "> #{l}" }.join
         UI.error("[#{@active_phase}] Could not finish active rule '#{@active_rule}'. Aborting it. Context:\n#{context}")
 
         U3d::FailureReporter.report(
@@ -237,26 +242,25 @@ module U3d
       message
     end
 
-    def parse_rule(r)
-      return false unless r['active']
-      return false if r['start_pattern'].nil?
-      r['start_pattern'] = Regexp.new r['start_pattern']
-      r['end_pattern'] = Regexp.new r['end_pattern'] if r['end_pattern']
-      if r['fetch_line_at_index']
-        r.delete('fetch_line_at_index') if r['fetch_line_at_index'] >= MEMORY_SIZE
-        r.delete('fetch_line_at_index') if r['fetch_line_at_index'] <= 0
-      elsif r['fetch_first_line_not_matching']
-        r['fetch_first_line_not_matching'].map! { |pat| Regexp.new pat }
-      end
-      if r['fetch_line_at_index'] || r['fetch_first_line_not_matching']
-        r['fetched_line_pattern'] = Regexp.new r['fetched_line_pattern'] if r['fetched_line_pattern']
+    def parse_rule(rule)
+      return false unless rule['active']
+      return false if rule['start_pattern'].nil?
+
+      rule['start_pattern'] = Regexp.new rule['start_pattern']
+      rule['end_pattern'] = Regexp.new rule['end_pattern'] if rule['end_pattern']
+      if rule['fetch_line_at_index']
+        rule.delete('fetch_line_at_index') if rule['fetch_line_at_index'] >= MEMORY_SIZE
+        rule.delete('fetch_line_at_index') if rule['fetch_line_at_index'] <= 0
+      elsif rule['fetch_first_line_not_matching']
+        rule['fetch_first_line_not_matching'].map! { |pat| Regexp.new pat }
       end
-      r['type'] = 'important' if r['type'] == 'warning'
-      r['type'] = 'message' if r['type'] && r['type'] != 'error' && r['type'] != 'important' && r['type'] != 'success'
-      r['type'] ||= 'message'
-      r['ignore_lines'].map! { |pat| Regexp.new pat } if r['ignore_lines']
+      rule['fetched_line_pattern'] = Regexp.new rule['fetched_line_pattern'] if (rule['fetch_line_at_index'] || rule['fetch_first_line_not_matching']) && (rule['fetched_line_pattern'])
+      rule['type'] = 'important' if rule['type'] == 'warning'
+      rule['type'] = 'message' if rule['type'] && rule['type'] != 'error' && rule['type'] != 'important' && rule['type'] != 'success'
+      rule['type'] ||= 'message'
+      rule['ignore_lines']&.map! { |pat| Regexp.new pat }
       true
     end
   end
-  # rubocop:enable ClassLength, PerceivedComplexity, BlockNesting
+  # rubocop:enable Metrics/ClassLength, Metrics/PerceivedComplexity, Metrics/BlockNesting
 end

data/lib/u3d/unity_license.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #

data/lib/u3d/unity_module.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #

data/lib/u3d/unity_project.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## --- BEGIN LICENSE BLOCK ---
 # Copyright (c) 2016-present WeWantToKnow AS
 #
@@ -46,9 +48,10 @@ module U3d
       require 'yaml'
       project_version = File.join(project_settings_path, 'ProjectVersion.txt')
       return nil unless File.exist? project_version
+
       yaml = YAML.safe_load(File.read(project_version))
       version = yaml['m_EditorVersion']
-      version.gsub!(/(\d+\.\d+\.\d+)(?:x)?(\w\d+)(?:Linux)?/, '\1\2') if Helper.linux?
+      version = version.gsub(/(\d+\.\d+\.\d+)(?:x)?(\w\d+)(?:Linux)?/, '\1\2') if Helper.linux?
       version
     end
   end