typo 3.99.0

data/db/migrate/016_fix_is_primary_postgres.rb

@@ -0,0 +1,19 @@
+# The PostgreSQL schema for 2.0.6 differs from the MySQL schema--
+# pgsql had articles_categories.primary_item, while mysql had
+# articles_categories.is_primary.  More modenen schemas all have is_primary.
+# This will break Postgres upgrades from 2.0.6, and apparently it bit #375.
+
+class FixIsPrimaryPostgres < ActiveRecord::Migration
+  def self.up
+    config = ActiveRecord::Base.configurations
+    if not $schema_generator and config[RAILS_ENV]['adapter'] == 'postgres'
+      execute "alter table articles_categories rename primary_item to is_primary" rescue nil
+    end
+  end
+
+  def self.down
+    # don't do anything
+    # this is a one-way migration, but it's not "irreversable"
+    # because it doesn't change any code logic
+  end
+end

data/db/migrate/017_add_comment_user_id.rb

@@ -0,0 +1,23 @@
+class AddCommentUserId < ActiveRecord::Migration
+  class BareComment < ActiveRecord::Base
+    include BareMigration
+  end
+
+  class BareUser <  ActiveRecord::Base
+    include BareMigration
+  end
+
+  def self.up
+    id_for_address = BareUser.find(:all).inject({}) do |h, u|
+      h.merge({ u.email => u.id })
+    end
+
+    modify_tables_and_update(:add_column, BareComment, :user_id, :integer) do |c|
+      c.user_id = id_for_address[c.email]
+    end
+  end
+
+  def self.down
+    remove_column :comments, :user_id
+  end
+end

data/db/migrate/018_add_guids.rb

@@ -0,0 +1,13 @@
+class AddGuids < ActiveRecord::Migration
+  def self.up
+    STDERR.puts "Adding GUIDs to Comments and Trackbacks"
+
+    modify_tables_and_update([:add_column, :comments,   :guid, :string],
+                             [:add_column, :trackbacks, :guid, :string])
+  end
+
+  def self.down
+    remove_column :comments, :guid
+    remove_column :trackbacks, :guid
+  end
+end

data/db/migrate/019_add_whiteboards_to_content.rb

@@ -0,0 +1,15 @@
+class AddWhiteboardsToContent < ActiveRecord::Migration
+  def self.up
+    STDERR.puts "Adding whiteboard to articles, comments and pages"
+    modify_tables_and_update([:add_column, :articles, :whiteboard, :text],
+                             [:add_column, :comments, :whiteboard, :text],
+                             [:add_column, :pages,    :whiteboard, :text])
+  end
+
+  def self.down
+    STDERR.puts "Removing whiteboard from articles, comments and pages"
+    remove_column :articles, :whiteboard
+    remove_column :comments, :whiteboard
+    remove_column :pages, :whiteboard
+  end
+end

data/db/migrate/020_superclass_articles.rb

@@ -0,0 +1,167 @@
+class Bare20Article < ActiveRecord::Base
+  include BareMigration
+
+  # need to point the primary key somewhere else so we can manually
+  # set this field for each article.
+  set_primary_key :boguskey
+end
+
+class Bare20Content < ActiveRecord::Base
+  include BareMigration
+
+# From active_record/base.rb: "the primary key and inheritance column can
+# never be set by mass-assignment for security reasons."  Because this
+# script wants to set 'id' and 'type', we need to fool activerecord by
+# setting them to bogus values.
+  set_inheritance_column :bogustype
+  set_primary_key :boguskey
+end
+
+class SuperclassArticles < ActiveRecord::Migration
+  def self.config
+    ActiveRecord::Base.configurations
+  end
+
+  def self.up
+    STDERR.puts "Merging Articles into Contents table"
+
+    # Make sure our index is in a known state
+    add_index :articles, :permalink rescue nil
+
+    Bare20Article.transaction do
+      create_table :contents do |t|
+#       ActiveRecord::Base.connection.send(:create_table, [:contents]) do |t|
+        t.column :type, :string
+        t.column :title, :string
+        t.column :author, :string
+        t.column :body, :text
+        t.column :body_html, :text
+        t.column :extended, :text
+        t.column :excerpt, :text
+        t.column :keywords, :string
+        t.column :allow_comments, :integer
+        t.column :allow_pings, :integer
+        t.column :published, :integer, :default => 1
+        t.column :created_at, :datetime
+        t.column :updated_at, :datetime
+        t.column :extended_html, :text
+        t.column :user_id, :integer
+        t.column :permalink, :string
+        t.column :guid, :string
+        t.column :text_filter_id, :integer
+        t.column :whiteboard, :text
+      end
+
+      if config[RAILS_ENV]['adapter'] == 'postgresql'
+        execute "select nextval('contents_id_seq')"
+      end
+
+      if not $schema_generator
+
+        Bare20Article.find(:all).each do |a|
+          t = Bare20Content.new(
+            :type => 'Article',
+            :title => a.title,
+            :author => a.author,
+            :body => a.body,
+            :body_html => a.body_html,
+            :extended => a.extended,
+            :excerpt => a.excerpt,
+            :keywords => a.keywords,
+            :allow_comments => a.allow_comments,
+            :allow_pings => a.allow_pings,
+            :published => a.published,
+            :created_at => a.created_at,
+            :updated_at => a.updated_at,
+            :extended_html => a.extended_html,
+            :user_id => a.user_id,
+            :permalink => a.permalink,
+            :guid => a.guid,
+            :text_filter_id => a.text_filter_id,
+            :whiteboard => a.whiteboard)
+          # can't use id accessor because it uses the bogus primary key
+          t.send(:write_attribute, :id, a.send(:read_attribute, :id))
+          t.save!
+        end
+
+        if config[RAILS_ENV]['adapter'] == 'postgresql'
+          STDERR.puts "Resetting PostgreSQL sequences"
+          execute "select setval('contents_id_seq',max(id)) from contents"
+          execute "select nextval('contents_id_seq')"
+        end
+      end
+
+      remove_index :articles, :permalink
+      drop_table :articles
+    end
+  end
+
+  def self.down
+    Bare20Content.transaction do
+      STDERR.puts "Recreating Articles from Contents table."
+
+      create_table :articles do |t|
+        t.column :title, :string
+        t.column :author, :string
+        t.column :body, :text
+        t.column :body_html, :text
+        t.column :extended, :text
+        t.column :excerpt, :text
+        t.column :keywords, :string
+        t.column :allow_comments, :integer
+        t.column :allow_pings, :integer
+        t.column :published, :integer, :default => 1
+        t.column :created_at, :datetime
+        t.column :updated_at, :datetime
+        t.column :extended_html, :text
+        t.column :user_id, :integer
+        t.column :permalink, :string
+        t.column :guid, :string
+        t.column :text_filter_id, :integer
+        t.column :whiteboard, :text
+      end
+
+      if config[RAILS_ENV]['adapter'] == 'postgresql'
+        execute "select nextval('articles_id_seq')"
+      end
+
+      add_index :articles, :permalink
+
+      if not $schema_generator
+        Bare20Content.find(:all, :conditions => "type = 'Article'").each do |a|
+          t = Bare20Article.new(
+             :title => a.title,
+             :author => a.author,
+             :body => a.body,
+             :body_html => a.body_html,
+             :extended => a.extended,
+             :excerpt => a.excerpt,
+             :keywords => a.keywords,
+             :allow_comments => a.allow_comments,
+             :allow_pings => a.allow_pings,
+             :published => a.published,
+             :created_at => a.created_at,
+             :updated_at => a.updated_at,
+             :extended_html => a.extended_html,
+             :user_id => a.user_id,
+             :permalink => a.permalink,
+             :guid => a.guid,
+             :text_filter_id => a.text_filter_id,
+             :whiteboard => a.whiteboard)
+           # can't use id accessor because it uses the bogus primary key
+           t.send(:write_attribute, :id, a.send(:read_attribute, :id))
+           t.save!
+        end
+
+        if config[RAILS_ENV]['adapter'] == 'postgres'
+          STDERR.puts "Resetting PostgreSQL sequences"
+          execute "select setval('articles_id_seq',max(id)+1) from articles"
+        end
+
+      end
+
+      # script 21 saved the comments, this script saved the articles.
+      drop_table :contents
+    end
+  end
+end

data/db/migrate/021_superclass_comments.rb

@@ -0,0 +1,94 @@
+class SuperclassComments < ActiveRecord::Migration
+  class BareComment < ActiveRecord::Base
+    include BareMigration
+  end
+
+  class BareContent < ActiveRecord::Base
+    include BareMigration
+    set_inheritance_column :bogustype     # see migration #20 for why
+  end
+
+  def self.up
+    STDERR.puts "Merging Comments into Contents table"
+    # Get our indices into a known good state.
+    # Mutter dark imprecations at having to do this.
+    add_index(:comments, :article_id) rescue nil
+    remove_index(:contents, :article_id) rescue nil
+    modify_tables_and_update([:add_column, BareContent, :article_id, :integer],
+                             [:add_column, BareContent, :email,      :string ],
+                             [:add_column, BareContent, :url,        :string ],
+                             [:add_column, BareContent, :ip,         :string ],
+                             [:add_index,  BareContent, :article_id          ]) do
+      BareContent.transaction do
+        if not $schema_generator
+          BareComment.find(:all).each do |c|
+            BareContent.create!(:type       => 'Comment',
+                                :article_id => c.article_id,
+                                :author     => c.author,
+                                :email      => c.email,
+                                :url        => c.url,
+                                :ip         => c.ip,
+                                :body       => c.body,
+                                :body_html  => c.body_html,
+                                :created_at => c.created_at,
+                                :updated_at => c.updated_at,
+                                :user_id    => c.user_id,
+                                :guid       => c.guid,
+                                :whiteboard => c.whiteboard)
+          end
+        end
+      end
+      remove_index(:comments, :article_id)
+    end
+    drop_table :comments
+  end
+
+  def self.init_comments_table(t)
+    t.column :article_id, :integer
+    t.column :title, :string
+    t.column :author, :string
+    t.column :email, :string
+    t.column :url, :string
+    t.column :ip, :string
+    t.column :body, :text
+    t.column :body_html, :text
+    t.column :created_at, :datetime
+    t.column :updated_at, :datetime
+    t.column :user_id, :integer
+    t.column :guid, :string
+    t.column :whiteboard, :text
+  end
+
+
+  def self.down
+    STDERR.puts "Recreating Comments from Contents table"
+    modify_tables_and_update([:create_table, BareComment, lambda {|t| self.init_comments_table(t)}],
+                             [:add_index,    BareComment, :article_id           ]) do
+      BareContent.transaction do
+        BareComment.transaction do
+          BareContent.find(:all, :conditions => "type = 'Comment'").each do |c|
+            BareComment.create!(:article_id => c.article_id,
+                                :title      => c.title,
+                                :author     => c.author,
+                                :email      => c.email,
+                                :url        => c.url,
+                                :ip         => c.ip,
+                                :body       => c.body,
+                                :body_html  => c.body_html,
+                                :created_at => c.created_at,
+                                :updated_at => c.updated_at,
+                                :user_id    => c.user_id,
+                                :guid       => c.guid,
+                                :whiteboard => c.whiteboard)
+          end
+          BareContent.delete_all "type = 'Comment'"
+        end
+      end
+      remove_index  :contents, :article_id
+      remove_column :contents, :article_id
+      remove_column :contents, :email
+      remove_column :contents, :url
+      remove_column :contents, :ip
+    end
+  end
+end

data/db/migrate/022_superclass_trackbacks.rb

@@ -0,0 +1,71 @@
+class SuperclassTrackbacks < ActiveRecord::Migration
+  class BareContent < ActiveRecord::Base
+    include BareMigration
+  end
+
+  class BareTrackback < ActiveRecord::Base
+    include BareMigration
+  end
+
+  def self.up
+    STDERR.puts "Merging Trackbacks into Content table"
+    # Ensure that the index we're going to remove in the transaction
+    # is actually there (otherwise Postgres breaks)
+    add_index(:trackbacks, :article_id) rescue nil
+    modify_tables_and_update([:add_column,   BareContent,   :blog_name, :string],
+                             [:remove_index, BareTrackback, :article_id        ]) do
+      BareContent.transaction do
+        if not $schema_generator
+          BareTrackback.find(:all).each do |tb|
+            a = BareContent.find(tb.article_id)
+            BareContent.create(:type       => 'Trackback',
+                               :article_id => tb.article_id,
+                               :blog_name  => tb.blog_name,
+                               :title      => tb.title,
+                               :excerpt    => tb.excerpt,
+                               :url        => tb.url,
+                               :ip         => tb.ip,
+                               :created_at => tb.created_at,
+                               :updated_at => tb.updated_at,
+                               :guid       => tb.guid)
+          end
+        end
+      end
+    end
+    drop_table :trackbacks
+  end
+
+  def self.transactions_init(t)
+    t.column :article_id, :integer
+    t.column :blog_name, :string
+    t.column :title, :string
+    t.column :excerpt, :string
+    t.column :url, :string
+    t.column :ip, :string
+    t.column :created_at, :datetime
+    t.column :updated_at, :datetime
+    t.column :guid, :string
+  end
+
+  def self.down
+    STDOUT.puts "Recreating Trackbacks from Contents table"
+    modify_tables_and_update([:create_table, :trackbacks, lambda {|t| transactions_init(t)}],
+                             [:add_index,    :trackbacks, :article_id]) do
+      BareContent.transaction do
+        BareContent.find(:all, :conditions => ["type = ?", 'Trackback']).each do |tb|
+          BareTrackback.create(:article_id => tb.article_id,
+                               :blog_name  => tb.blog_name,
+                               :title      => tb.title,
+                               :excerpt    => tb.excerpt,
+                               :url        => tb.url,
+                               :ip         => tb.ip,
+                               :created_at => tb.created_at,
+                               :updated_at => tb.updated_at,
+                               :guid       => tb.guid)
+        end
+        BareContent.delete_all("type = 'Trackback'")
+      end
+    end
+    remove_column :contents, :blog_name
+  end
+end

data/db/migrate/023_superclass_pages.rb

@@ -0,0 +1,64 @@
+class Bare23Content < ActiveRecord::Base
+  include BareMigration
+end
+
+class Bare23Page < ActiveRecord::Base
+  include BareMigration
+end
+
+class SuperclassPages < ActiveRecord::Migration
+  def self.up
+    STDERR.puts "Merging Pages into Content table"
+    modify_tables_and_update(:add_column, :contents, :name, :string) do
+      Bare23Content.transaction do
+        if not $schema_generator
+          Bare23Page.find(:all).each do |p|
+            Bare23Content.create(:type           => 'Page',
+                                 :title          => p.name,
+                                 :user_id        => p.user_id,
+                                 :body           => p.body,
+                                 :body_html      => p.body_html,
+                                 :created_at     => p.created_at,
+                                 :updated_at     => (p.modified_at rescue p.updated_at),
+                                 :title          => p.title,
+                                 :text_filter_id => p.text_filter_id)
+          end
+        end
+      end
+    end
+    drop_table :pages
+  end
+
+  def self.init_pages(t)
+    t.column :name, :string
+    t.column :user_id, :integer
+    t.column :body, :text
+    t.column :body_html, :text
+    t.column :created_at, :datetime
+    t.column :updated_at, :datetime
+    t.column :title, :string
+    t.column :text_filter_id, :integer
+    t.column :whiteboard, :text
+  end
+
+  def self.down
+    STDERR.puts "Recreating pages table"
+    modify_tables_and_update(:create_table, :pages, lambda {|t| init_pages(t)}) do
+      Bare23Content.transaction do
+        Bare23Content.find(:all, :conditions => "type = 'Page'").each do |p|
+          Bare23Page.create(:name           => p.title,
+                            :user_id        => p.user_id,
+                            :body           => p.body,
+                            :body_html      => p.body_html,
+                            :created_at     => p.created_at,
+                            :updated_at     => p.updated_at,
+                            :title          => p.title,
+                            :text_filter_id => p.text_filter_id,
+                            :whiteboard     => p.whiteboard)
+        end
+        Bare23Content.delete_all "type = 'Page'"
+      end
+    end
+    remove_column :contents, :name
+  end
+end