typhoeus 0.1.31 → 0.2.0

data/spec/typhoeus/hydra_spec.rb

@@ -30,76 +30,6 @@ describe Typhoeus::Hydra do
     Typhoeus::Hydra.hydra = Typhoeus::Hydra.new
   end
 
-  context "#stub" do
-    before do
-      @hydra = Typhoeus::Hydra.new
-      @on_complete_handler_called = nil
-      @request  = Typhoeus::Request.new("http://localhost:3000/foo")
-      @request.on_complete do |response|
-        @on_complete_handler_called = true
-        response.code.should == 404
-        response.headers.should == "whatever"
-      end
-      @response = Typhoeus::Response.new(:code => 404, :headers => "whatever", :body => "not found", :time => 0.1)
-    end
-
-    it "stubs requests to a specific URI" do
-      @hydra.stub(:get, "http://localhost:3000/foo").and_return(@response)
-      @hydra.queue(@request)
-      @hydra.run
-      @on_complete_handler_called.should be_true
-      @response.request.should == @request
-    end
-
-    it "stubs requests to URIs matching a pattern" do
-      @hydra.stub(:get, /foo/).and_return(@response)
-      @hydra.queue(@request)
-      @hydra.run
-      @on_complete_handler_called.should be_true
-      @response.request.should == @request
-    end
-
-    it "can clear stubs" do
-      @hydra.clear_stubs
-    end
-    
-    it "clears out previously queued requests once they are called" do
-      @hydra.stub(:get, "asdf").and_return(@response)
-
-      call_count = 0
-      request = Typhoeus::Request.new("asdf")
-      request.on_complete do |response|
-        call_count += 1
-      end
-      @hydra.queue(request)
-      @hydra.run
-      call_count.should == 1
-      @hydra.run
-      call_count.should == 1
-    end
-    
-    it "calls stubs for requests that are queued up in the on_complete of a first stub" do
-      @hydra.stub(:get, "asdf").and_return(@response)
-      @hydra.stub(:get, "bar").and_return(@response)
-      
-      second_handler_called = false
-      request = Typhoeus::Request.new("asdf")
-      request.on_complete do |response|
-        r = Typhoeus::Request.new("bar")
-        r.on_complete do |res|
-          second_handler_called = true
-        end
-        @hydra.queue(r)
-      end
-      @hydra.queue(request)
-      @hydra.run
-      
-      second_handler_called.should be_true
-    end
-
-    it "matches a stub only when the HTTP method also matches"
-  end
-
   it "queues a request" do
     hydra = Typhoeus::Hydra.new
     hydra.queue Typhoeus::Request.new("http://localhost:3000")
@@ -309,3 +239,218 @@ describe Typhoeus::Hydra do
     request.response.code.should == 302
   end
 end
+
+describe Typhoeus::Hydra::Stubbing do
+  shared_examples_for "any stubbable target" do
+    before(:each) do
+      @on_complete_handler_called = nil
+      @request  = Typhoeus::Request.new("http://localhost:3000/foo",
+                                        :user_agent => 'test')
+      @request.on_complete do |response|
+        @on_complete_handler_called = true
+        response.code.should == 404
+        response.headers.should == "whatever"
+      end
+      @response = Typhoeus::Response.new(:code => 404,
+                                         :headers => "whatever",
+                                         :body => "not found",
+                                         :time => 0.1)
+    end
+
+    after(:each) do
+      @stub_target.clear_stubs
+    end
+
+    it "should provide a stubs accessor" do
+      begin
+        @stub_target.stubs.should == []
+        @stub_target.stubs = [:foo]
+      ensure
+        @stub_target.clear_stubs
+      end
+    end
+
+    it "stubs requests to a specific URI" do
+      @stub_target.stub(:get, "http://localhost:3000/foo",
+                        :headers => { 'user-agent' => 'test'}).
+                        and_return(@response)
+
+      @hydra.queue(@request)
+      @hydra.run
+      @on_complete_handler_called.should be_true
+      @response.request.should == @request
+    end
+
+    it "stubs requests to URIs matching a pattern" do
+      @stub_target.stub(:get, /foo/,
+                        :headers => { 'user-agent' => 'test' }).
+                        and_return(@response)
+      @hydra.queue(@request)
+      @hydra.run
+      @on_complete_handler_called.should be_true
+      @response.request.should == @request
+    end
+
+    it "can clear stubs" do
+      @stub_target.clear_stubs
+    end
+
+    it "clears out previously queued requests once they are called" do
+      @stub_target.stub(:get, "http://localhost:3000/asdf",
+                        :headers => { 'user-agent' => 'test' }).
+                        and_return(@response)
+
+      call_count = 0
+      request = Typhoeus::Request.new("http://localhost:3000/asdf", :user_agent => 'test')
+      request.on_complete do |response|
+        call_count += 1
+      end
+      @hydra.queue(request)
+      @hydra.run
+      call_count.should == 1
+      @hydra.run
+      call_count.should == 1
+    end
+
+    it "calls stubs for requests that are queued up in the on_complete of a first stub" do
+      @stub_target.stub(:get, "http://localhost:3000/asdf").and_return(@response)
+      @stub_target.stub(:get, "http://localhost:3000/bar").and_return(@response)
+
+      second_handler_called = false
+      request = Typhoeus::Request.new("http://localhost:3000/asdf")
+      request.on_complete do |response|
+        r = Typhoeus::Request.new("http://localhost:3000/bar")
+        r.on_complete do |res|
+          second_handler_called = true
+        end
+        @hydra.queue(r)
+      end
+      @hydra.queue(request)
+      @hydra.run
+
+      second_handler_called.should be_true
+    end
+  end
+
+  describe "global (class-level) stubbing" do
+    before(:each) do
+      @hydra = Typhoeus::Hydra.new
+      @stub_target = Typhoeus::Hydra
+    end
+
+    it_should_behave_like "any stubbable target"
+  end
+
+  describe "instance stubbing" do
+    before(:each) do
+      @hydra = Typhoeus::Hydra.new
+      @stub_target = @hydra
+    end
+
+    it_should_behave_like "any stubbable target"
+  end
+end
+
+describe Typhoeus::Hydra::Callbacks do
+  before(:all) do
+    @klass = Typhoeus::Hydra
+  end
+
+  describe "#after_request_before_on_complete" do
+    it "should provide a global hook after a request" do
+      begin
+        http_method = nil
+        @klass.after_request_before_on_complete do |request|
+          http_method = request.method
+        end
+
+        hydra = @klass.new
+        request = Typhoeus::Request.new('http://localhost:3000',
+                                        :method => :get)
+        response = Typhoeus::Response.new(:code => 404,
+                                          :headers => "whatever",
+                                          :body => "not found",
+                                          :time => 0.1)
+        hydra.stub(:get, 'http://localhost:3000').
+          and_return(response)
+
+        hydra.queue(request)
+        hydra.run
+
+        http_method.should == :get
+      ensure
+        @klass.clear_global_hooks
+      end
+    end
+  end
+end
+
+describe Typhoeus::Hydra::ConnectOptions do
+  before(:all) do
+    @klass = Typhoeus::Hydra
+  end
+
+  describe "#ignore_localhost" do
+    it "should allow localhost requests over the wire if true" do
+      begin
+        old_net_connect = @klass.allow_net_connect
+        old_ignore_localhost = @klass.ignore_localhost
+        @klass.allow_net_connect = false
+        @klass.ignore_localhost = true
+
+        req = Typhoeus::Request.new("http://localhost:3000")
+        hydra = @klass.new
+
+        lambda {
+          hydra.queue(req)
+        }.should_not raise_error
+      ensure
+        @klass.allow_net_connect = old_net_connect
+        @klass.ignore_localhost = old_ignore_localhost
+      end
+    end
+  end
+
+  describe "#allow_net_connect" do
+    it "should be settable" do
+      begin
+        # make sure to not mess up other specs.
+        old = @klass.allow_net_connect
+        @klass.allow_net_connect = true
+        @klass.allow_net_connect.should be_true
+      ensure
+        @klass.allow_net_connect = old
+      end
+    end
+
+    it "should default to true" do
+      @klass.allow_net_connect.should be_true
+    end
+
+    it "should raise an error if we queue a request while its false" do
+      begin
+        request = Typhoeus::Request.new("http://localhost:3000")
+        old_net_connect = @klass.allow_net_connect
+        old_ignore_localhost = @klass.ignore_localhost
+
+        @klass.allow_net_connect = false
+        @klass.ignore_localhost = false
+
+        hydra = Typhoeus::Hydra.new
+
+        lambda {
+          hydra.queue(request)
+        }.should raise_error(Typhoeus::Hydra::NetConnectNotAllowedError)
+      ensure
+        @klass.allow_net_connect = old_net_connect
+        @klass.ignore_localhost = old_ignore_localhost
+      end
+    end
+  end
+
+  describe "#allow_net_connect?" do
+    it "should return true by default" do
+      @klass.allow_net_connect?.should be_true
+    end
+  end
+end

data/spec/typhoeus/normalized_header_hash_spec.rb

@@ -0,0 +1,41 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+describe Typhoeus::NormalizedHeaderHash do
+  before(:all) do
+    @klass = Typhoeus::NormalizedHeaderHash
+  end
+
+  it "should normalize keys on assignment" do
+    hash = @klass.new
+    hash['Content-Type'] = 'text/html'
+    hash['content-type'].should == 'text/html'
+    hash[:content_type].should == 'text/html'
+    hash['Accepts'] = 'text/javascript'
+    hash['accepts'].should == 'text/javascript'
+  end
+
+  it "should normalize the keys on instantiation" do
+    hash = @klass.new('Content-Type' => 'text/html', :x_http_header => 'foo', 'X-HTTP-USER' => 'bar')
+    hash.keys.should =~ ['Content-Type', 'X-Http-Header', 'X-Http-User']
+  end
+
+  it "should merge keys correctly" do
+    hash = @klass.new
+    hash.merge!('Content-Type' => 'fdsa')
+    hash['content-type'].should == 'fdsa'
+  end
+
+  it "should allow any casing of keys" do
+    hash = @klass.new
+    hash['Content-Type'] = 'fdsa'
+    hash['content-type'].should == 'fdsa'
+    hash['cOnTent-TYPE'].should == 'fdsa'
+    hash['Content-Type'].should == 'fdsa'
+  end
+
+  it "should support has_key?" do
+    hash = @klass.new
+    hash['Content-Type'] = 'fdsa'
+    hash.has_key?('cOntent-Type').should be_true
+  end
+end

data/spec/typhoeus/remote_spec.rb

@@ -2,7 +2,7 @@ require File.dirname(__FILE__) + '/../spec_helper'
 
 describe Typhoeus do
   it "should be deprecated" do
-    fail "This entire interface is deprecated!"
+    pending "This entire interface is deprecated!"
   end
 
   # before(:each) do

data/spec/typhoeus/request_spec.rb

@@ -1,6 +1,50 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe Typhoeus::Request do
+  describe "#inspect" do
+    before(:each) do
+      @request = Typhoeus::Request.new('http://www.google.com/',
+                                       :body => "a=1&b=2",
+                                       :params => { :c => 'ok' },
+                                       :method => :get,
+                                       :headers => { 'Content-Type' => 'text/html' })
+    end
+
+    it "should dump out the URI" do
+      @request.inspect.should =~ /http:\/\/www\.google\.com/
+    end
+
+    it "should dump out the body" do
+      @request.inspect.should =~ /a=1&b=2/
+    end
+
+    it "should dump params" do
+      @request.inspect.should =~ /:c\s*=>\s*"ok"/
+    end
+
+    it "should dump the method" do
+      @request.inspect.should =~ /:get/
+    end
+    
+    it "should dump out headers" do
+      @request.inspect.should =~ /"Content-Type"\s*=>\s*"text\/html"/
+    end
+  end
+
+  describe "#localhost?" do
+    %w(localhost 127.0.0.1 0.0.0.0).each do |host|
+      it "should be true for the #{host} host" do
+        req = Typhoeus::Request.new("http://#{host}")
+        req.should be_localhost
+      end
+    end
+
+    it "should be false for other domains" do
+      req = Typhoeus::Request.new("http://google.com")
+      req.should_not be_localhost
+    end
+  end
+
   describe "#params_string" do
     it "should dump a sorted string" do
       request = Typhoeus::Request.new(
@@ -24,6 +68,14 @@ describe Typhoeus::Request do
                                       })
       request.params_string.should == "a=jlk&b=fdsa&c=789"
     end
+
+    it "should translate params with values that are arrays to the proper format" do
+      request = Typhoeus::Request.new('http://google.com',
+                                      :params => {
+                                        :a => ['789','2434']
+                                      })
+      request.params_string.should == "a[]=789&a[]=2434"
+    end
   end
 
   describe "quick request methods" do
@@ -160,9 +212,9 @@ describe Typhoeus::Request do
     request.call_handlers
     good.should be_true
   end
-  
+
   describe "authentication" do
-    
+
     it "should allow to set username and password" do
       auth = { :username => 'foo', :password => 'bar' }
       e = Typhoeus::Request.get(

data/spec/typhoeus/response_spec.rb

@@ -2,9 +2,35 @@ require File.dirname(__FILE__) + '/../spec_helper'
 
 describe Typhoeus::Response do
   describe "initialize" do
+    it "should store headers_hash" do
+      response = Typhoeus::Response.new(:headers_hash => {})
+      response.headers_hash.should == {}
+    end
+
+    it "allows header access using a different casing of the header key" do
+      response = Typhoeus::Response.new(:headers_hash => { 'content-type' => 'text/html' } )
+      response.headers_hash['Content-Type'].should == 'text/html'
+    end
+
     it "should store response_code" do
       Typhoeus::Response.new(:code => 200).code.should == 200
     end
+
+    it "should store status_message" do
+      Typhoeus::Response.new(:status_message => 'Not Found').status_message.should == 'Not Found'
+    end
+
+    it "should return nil for status_message if none is given and no header is given" do
+      Typhoeus::Response.new.status_message.should be_nil
+    end
+
+    it "should store http_version" do
+      Typhoeus::Response.new(:http_version => '1.1').http_version.should == '1.1'
+    end
+
+    it "should return nil for http version if none is given and no header is given" do
+      Typhoeus::Response.new.http_version.should be_nil
+    end
     
     it "should store response_headers" do
       Typhoeus::Response.new(:headers => "a header!").headers.should == "a header!"
@@ -27,34 +53,84 @@ describe Typhoeus::Response do
       response = Typhoeus::Response.new(:requested_http_method => :delete)
       response.requested_http_method.should == :delete
     end
-    
+
     it "should store an associated request object" do
       response = Typhoeus::Response.new(:request => "whatever")
       response.request.should == "whatever"
     end
+
+    it "should not default to be a mock response" do
+      response = Typhoeus::Response.new
+      response.should_not be_mock
+    end
   end
-  
+
+  describe "#mock?" do
+    it "should be true if it's a mock response" do
+      response = Typhoeus::Response.new(:mock => true)
+      response.should be_mock
+    end
+  end
+
   describe "headers" do
-    it "can parse the headers into a hash" do
-      response = Typhoeus::Response.new(:headers => "HTTP/1.1 200 OK\r\nContent-Type: text/html; charset=utf-8\r\nConnection: close\r\nStatus: 200\r\nX-Powered-By: Phusion Passenger (mod_rails/mod_rack) 2.2.9\r\nX-Cache: miss\r\nX-Runtime: 184\r\nETag: e001d08d9354ab7bc7c27a00163a3afa\r\nCache-Control: private, max-age=0, must-revalidate\r\nContent-Length: 4725\r\nSet-Cookie: _some_session=BAh7CDoGciIAOg9zZXNzaW9uX2lkIiU1OTQ2OTcwMjljMWM5ZTQwODU1NjQwYTViMmQxMTkxMjoGcyIKL2NhcnQ%3D--b4c4663932243090c961bb93d4ad5e4327064730; path=/; HttpOnly\r\nServer: nginx/0.6.37 + Phusion Passenger 2.2.4 (mod_rails/mod_rack)\r\nSet-Cookie: foo=bar; path=/;\r\nP3P: CP=\"NOI DSP COR NID ADMa OPTa OUR NOR\"\r\n\r\n")
-      response.headers_hash["Status"].should == "200"
-      response.headers_hash["Set-Cookie"].should == ["_some_session=BAh7CDoGciIAOg9zZXNzaW9uX2lkIiU1OTQ2OTcwMjljMWM5ZTQwODU1NjQwYTViMmQxMTkxMjoGcyIKL2NhcnQ%3D--b4c4663932243090c961bb93d4ad5e4327064730; path=/; HttpOnly", "foo=bar; path=/;"]
-      response.headers_hash["Content-Type"].should == "text/html; charset=utf-8"
+    it 'should return an empty hash from #headers_hash when no headers string is given' do
+      response = Typhoeus::Response.new.headers_hash.should == {}
     end
-    
+
+    describe "basic parsing" do
+      before(:all) do
+        @response = Typhoeus::Response.new(:headers => "HTTP/1.1 200 OK\r\nContent-Type: text/html; charset=utf-8\r\nConnection: close\r\nStatus: 200\r\nX-Powered-By: Phusion Passenger (mod_rails/mod_rack) 2.2.9\r\nX-Cache: miss\r\nX-Runtime: 184\r\nETag: e001d08d9354ab7bc7c27a00163a3afa\r\nCache-Control: private, max-age=0, must-revalidate\r\nContent-Length: 4725\r\nSet-Cookie: _some_session=BAh7CDoGciIAOg9zZXNzaW9uX2lkIiU1OTQ2OTcwMjljMWM5ZTQwODU1NjQwYTViMmQxMTkxMjoGcyIKL2NhcnQ%3D--b4c4663932243090c961bb93d4ad5e4327064730; path=/; HttpOnly\r\nServer: nginx/0.6.37 + Phusion Passenger 2.2.4 (mod_rails/mod_rack)\r\nSet-Cookie: foo=bar; path=/;\r\nP3P: CP=\"NOI DSP COR NID ADMa OPTa OUR NOR\"\r\n\r\n")
+      end
+
+      it "can be accessed with lowercase keys" do
+        @response.headers_hash['content-type'].should == 'text/html; charset=utf-8'
+      end
+
+      it "can parse the headers into a hash" do
+        @response.headers_hash["Status"].should == "200"
+        @response.headers_hash["Set-Cookie"].should == ["_some_session=BAh7CDoGciIAOg9zZXNzaW9uX2lkIiU1OTQ2OTcwMjljMWM5ZTQwODU1NjQwYTViMmQxMTkxMjoGcyIKL2NhcnQ%3D--b4c4663932243090c961bb93d4ad5e4327064730; path=/; HttpOnly", "foo=bar; path=/;"]
+        @response.headers_hash["Content-Type"].should == "text/html; charset=utf-8"
+      end
+
+      it 'parses the status message' do
+        @response.status_message.should == 'OK'
+      end
+
+      it 'parses the HTTP version' do
+        @response.http_version.should == '1.1'
+      end
+
+      it 'parses all header keys except HTTP version declaration' do
+        @response.headers_hash.keys.should =~ %w[
+          X-Powered-By
+          P3p
+          X-Cache
+          Etag
+          X-Runtime
+          Content-Type
+          Content-Length
+          Server
+          Set-Cookie
+          Cache-Control
+          Connection
+          Status
+        ]
+      end
+    end
+
     it "parses a header key that appears multiple times into an array" do
       response = Typhoeus::Response.new(:headers => "HTTP/1.1 302 Found\r\nContent-Type: text/html; charset=utf-8\r\nConnection: close\r\nStatus: 302\r\nX-Powered-By: Phusion Passenger (mod_rails/mod_rack) 2.2.9\r\nLocation: http://mckenzie-greenholt1512.myshopify.com/cart\r\nX-Runtime: 22\r\nCache-Control: no-cache\r\nContent-Length: 114\r\nSet-Cookie: cart=8fdd6a828d9c89a737a52668be0cebaf; path=/; expires=Fri, 12-Mar-2010 18:30:19 GMT\r\nSet-Cookie: _session=BAh7CToPc2Vzc2lvbl9pZCIlZTQzMDQzMDg1YjI3MTQ4MzAzMTZmMWZmMWJjMTU1NmI6CWNhcnQiJThmZGQ2YTgyOGQ5Yzg5YTczN2E1MjY2OGJlMGNlYmFmOgZyIgA6BnMiDi9jYXJ0L2FkZA%3D%3D--6b0a699625caed9597580d8e9b6ca5f5e5954125; path=/; HttpOnly\r\nServer: nginx/0.6.37 + Phusion Passenger 2.2.4 (mod_rails/mod_rack)\r\nP3P: CP=\"NOI DSP COR NID ADMa OPTa OUR NOR\"\r\n\r\n")
       response.headers_hash["Set-Cookie"].should include("cart=8fdd6a828d9c89a737a52668be0cebaf; path=/; expires=Fri, 12-Mar-2010 18:30:19 GMT")
       response.headers_hash["Set-Cookie"].should include("_session=BAh7CToPc2Vzc2lvbl9pZCIlZTQzMDQzMDg1YjI3MTQ4MzAzMTZmMWZmMWJjMTU1NmI6CWNhcnQiJThmZGQ2YTgyOGQ5Yzg5YTczN2E1MjY2OGJlMGNlYmFmOgZyIgA6BnMiDi9jYXJ0L2FkZA%3D%3D--6b0a699625caed9597580d8e9b6ca5f5e5954125; path=/; HttpOnly")
     end
   end
-  
+
   describe "status checking" do
     it "is successful if response code is 200-299" do
       Typhoeus::Response.new(:code => 220).success?.should be
       Typhoeus::Response.new(:code => 400).success?.should_not be
     end
-    
+
     it "is not modified if the status code is 304" do
       Typhoeus::Response.new(:code => 304).modified?.should_not be
       Typhoeus::Response.new(:code => 200).modified?.should be