typespec_from_serializers 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46bcf5deebdc474b0f22abee212194c394fc811492bf55c9a3eaae01ed3976a0
-  data.tar.gz: 8dc54c4ffb68a326c94c99f6ac778ebf9ee777e925e2bbe456c9256ed25abae6
+  metadata.gz: 1bc90948b5d93848663bab0d1162a1f26d49d832a05ef4c57eb5cb1e90f74ff3
+  data.tar.gz: '008ddb8319166e72e2e75a30d840ad387a082df6e4d0846698e87f9b15ac1c05'
 SHA512:
-  metadata.gz: 0bccf7a80481a2c8b20157c9889ef18a89390854692017c559d16feb52c464ba9cf95d9a280078b203d626b4f46c0f720d3b8b46b72d8d8543a550b76e1d7e67
-  data.tar.gz: 42c5a6028324542ecfaf6a79a5fea5fc635677688b960507cb8f4dc805ca7b7be164e3a5f39288dfbeea74f1e3af9b44f462f1d070eaed9cc947f4bee21c8ab0
+  metadata.gz: 950c7c34c0d3766854fd6eb4b3aa958b7ed8a20040ad8a43c5573d52741b156441b43e0fbded753536624d368ce353959f5f9e13d311eddea05ba75b8a4e85df
+  data.tar.gz: 6695700e9a0f73b03e97107d1844e2ef878dcf50217b45826418488827643923260f9b2465bd20fc4d03ef298ea2028f87132fa496abbb67f43ad635fda47562

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # TypeSpec From Serializers Changelog
 
+## [0.5.3] - 2025-12-23
+
+### Fixed
+- Body params now scoped per action by analyzing which `*_params` methods are called
+
 ## [0.5.2] - 2025-12-22
 
 ### Fixed

data/lib/typespec_from_serializers/generator.rb

@@ -980,56 +980,19 @@ module TypeSpecFromSerializers
 
     # Internal: Extracts serializer class from controller method source using Prism AST
     def extract_serializer_from_controller_method(controller_class, action)
-      return nil unless controller_class.method_defined?(action)
-
-      method = controller_class.instance_method(action)
-      source_location = method.source_location
-      return nil unless source_location
-
-      file_path, line_number = source_location
-      return nil unless File.exist?(file_path)
-
-      # Parse the file with Prism
-      result = Prism.parse_file(file_path)
-      return nil unless result.success?
-
-      # Find the specific method definition node
-      method_finder = MethodFinder.new(action.to_s, line_number)
-      method_finder.visit(result.value)
-      return nil unless method_finder.method_node
+      method_node = find_action_node(controller_class, action)
+      return unless method_node
 
       # Find serializer references only within this method
       visitor = SerializerVisitor.new
-      visitor.visit(method_finder.method_node)
+      visitor.visit(method_node)
 
       # Try to constantize any found serializers and return the first valid one
       visitor.serializer_names.filter_map(&:safe_constantize).first
     rescue
-      # File read or parsing error - return nil
       nil
     end
 
-    # Internal: Prism visitor to find a specific method definition by name and line
-    class MethodFinder < Prism::Visitor
-      attr_reader :method_node
-
-      def initialize(method_name, line_number)
-        super()
-        @method_name = method_name
-        @line_number = line_number
-        @method_node = nil
-      end
-
-      def visit_def_node(node)
-        # Match by method name and line number proximity
-        if node.name.to_s == @method_name &&
-            node.location.start_line <= @line_number &&
-            node.location.end_line >= @line_number
-          @method_node = node
-        end
-        super
-      end
-    end
 
     # Internal: Prism visitor to extract serializer class names from AST
     class SerializerVisitor < Prism::Visitor
@@ -1124,10 +1087,8 @@ module TypeSpecFromSerializers
     def extract_param_types_from_controller(controller_class, action)
       param_types = {}
 
-      # Extract from *_params methods with type DSL declarations
-      # Include private methods since *_params methods are typically private
-      param_methods = (controller_class.instance_methods(false) | controller_class.private_instance_methods(false))
-        .select { |m| m.to_s.end_with?(config.param_method_suffix) }
+      # Find which *_params methods are called by this action
+      param_methods = find_params_methods_called_by_action(controller_class, action)
 
       param_methods.each do |method_name|
         type_found = false
@@ -1172,6 +1133,63 @@ module TypeSpecFromSerializers
       {}
     end
 
+    # Internal: Finds *_params methods that are called by a specific action method
+    def find_params_methods_called_by_action(controller_class, action)
+      method_node = find_action_node(controller_class, action)
+      return [] unless method_node
+
+      suffix = config.param_method_suffix
+      find_method_calls(method_node)
+        .select { |name| name.end_with?(suffix) }
+        .map(&:to_sym)
+    rescue
+      []
+    end
+
+    # Internal: Finds the AST node for a controller action method.
+    def find_action_node(controller_class, action)
+      return unless controller_class.method_defined?(action)
+
+      method = controller_class.instance_method(action)
+      file_path, line_number = method.source_location
+      return unless file_path && File.exist?(file_path)
+
+      find_method_at_line(file_path, line_number)
+    end
+
+    # Internal: Parses a Ruby file and caches the result.
+    def parse_file_cached(file_path)
+      @parsed_files ||= {}
+      @parsed_files[file_path] ||= begin
+        result = Prism.parse_file(file_path)
+        result.success? ? result.value : nil
+      end
+    end
+
+    # Internal: Finds a DefNode at the exact line number.
+    def find_method_at_line(file_path, line_number)
+      ast = parse_file_cached(file_path)
+      return unless ast
+
+      queue = [ast]
+      while (node = queue.shift)
+        return node if node.is_a?(Prism::DefNode) && node.location.start_line == line_number
+        queue.concat(node.compact_child_nodes)
+      end
+      nil
+    end
+
+    # Internal: Finds all unqualified method call names in an AST node.
+    def find_method_calls(node)
+      calls = []
+      queue = [node]
+      while (current = queue.shift)
+        calls << current.name.to_s if current.is_a?(Prism::CallNode) && current.receiver.nil?
+        queue.concat(current.compact_child_nodes)
+      end
+      calls.uniq
+    end
+
     # Internal: Extracts key-value types from Sorbet hash type
     def extract_hash_types_from_sorbet(sorbet_type)
       param_types = {}

data/lib/typespec_from_serializers/version.rb

@@ -2,5 +2,5 @@
 
 module TypeSpecFromSerializers
   # Public: This library adheres to semantic versioning.
-  VERSION = "0.5.2"
+  VERSION = "0.5.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: typespec_from_serializers
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Danila Poyarkov
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-12-22 00:00:00.000000000 Z
+date: 2025-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties