typed_operation 0.3.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3c88c55bf10a3d9d6582adfbb253c94a1fd6cf287794089775c9a8dbf1dfd86
-  data.tar.gz: baee565ac599fb5351d1758fe720587e6793114c8ec830cbe3db6d5dc40b2d61
+  metadata.gz: 1d1be5d239791c002be2003d22a4d1a3bad636d10f5b3b923810627e5427f6d1
+  data.tar.gz: e539e29bb32268211d6831866ee5b455f11b96b1949b0ec788a8cd0ae90cb094
 SHA512:
-  metadata.gz: 32a92d0277fee468925bd0a3c5b4b377ebb8107b3202ea13f1c23925532df4665efffaac90e76c32060f629cb9a476e654abba406e80c28da7bcf590e504c445
-  data.tar.gz: 82d9ae76e6ba43564a3632d577ddf99ab92758c4b44cfad985a812b121c1c63efee7ceba0d92e1839c8fc6b5a0476a4914d4a33fdeca6a84bce9f0caca6c7789
+  metadata.gz: 0a0cccfd3499f7cd87e73ed646163f8617125e3c07dc9259972bdbc83d50634b32b129675e9d8bcf85aaef816b61f933d096aa2c6867bcde79c88b45d43cd491
+  data.tar.gz: 6cf1a3f0d2d7a70e57d361cdff698ddbb29505bf8177b54db9bfba83b54f64cf23983f984d990b75d2278ffbfca0c2548d2b57d8736d1acb6ac3410f58e136c6

data/README.md

@@ -4,7 +4,7 @@ An implementation of a Command pattern, which is callable, and can be partially
 
 Inputs to the operation are specified as typed attributes using the `param` method.
 
-Results of the operation are a type of `Dry::Monads::Result` object.
+Result format of the operation is up to you, but plays nicely with `Dry::Monads`. 
 
 ### Examples:
 
@@ -12,6 +12,8 @@ A base operation class:
 
 ```ruby
 class ApplicationOperation < ::TypedOperation::Base
+  include Dry::Monads[:result, :do]
+  
   param :initiator, ::RegisteredUser, allow_nil: true
 
   private
@@ -93,12 +95,19 @@ Or install it yourself as:
 $ gem install typed_operation
 ```
 
-## Add an `ApplicationOperation` to your project
+### Add an `ApplicationOperation` to your project
 
 ```ruby
 bin/rails g typed_operation:install
 ```
 
+Use the `--dry_monads` switch to `include Dry::Monads[:result]` into your `ApplicationOperation` (don't forget to also 
+add `gem "dry-monads"` to your Gemfile)
+
+```ruby
+bin/rails g typed_operation:install --dry_monads
+```
+
 ## Generate a new Operation
 
 ```ruby
@@ -113,6 +122,8 @@ bin/rails g typed_operation TestOperation --path=app/operations
 
 The default path is `app/operations`.
 
+The generator will also create a test file.
+
 ## Contributing
 Contribution directions go here.
 

data/lib/generators/templates/operation.rb

@@ -4,7 +4,8 @@
 module <%= namespace_name %>
   class <%= name %> < ::ApplicationOperation
     # Replace with implementation...
-    param :param1, String, convert: true
+    param :required_param, String
+    param :an_optional_param, Integer, convert: true, allow_nil: true
 
     def prepare
       # Prepare...
@@ -12,13 +13,15 @@ module <%= namespace_name %>
 
     def call
       # Perform...
+      "Hello World!"
     end
   end
 end
 <% else %>
 class <%= name %> < ::ApplicationOperation
   # Replace with implementation...
-  param :param1, String, convert: true
+  param :required_param, String
+  param :an_optional_param, Integer, convert: true, allow_nil: true
 
   def prepare
     # Prepare...
@@ -26,6 +29,7 @@ class <%= name %> < ::ApplicationOperation
 
   def call
     # Perform...
+    "Hello World!"
   end
 end
 <% end %>

data/lib/generators/templates/operation_test.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+<% if namespace_name.present? %>
+module <%= namespace_name %>
+  class <%= name %>Test < ActiveSupport::TestCase
+    def setup
+      @operation = <%= name %>.new(required_param: "test")
+    end
+
+    test "should raise ParameterError if required param is nil" do
+      assert_raises(ParameterError) do
+        <%= name %>.new(required_param: nil)
+      end
+    end
+
+    test "should convert optional_param if it is not a string" do
+      assert_equal <%= name %>.new(required_param: "foo", optional_param: 123).converts_param, "123"
+    end
+
+    test "call returns after operation" do
+      result = @operation.call
+      assert_equal result, "Hello World!"
+    end
+  end
+end
+<% else %>
+class <%= name %>Test < ActiveSupport::TestCase
+  def setup
+    @operation = <%= name %>.new(required_param: "test")
+  end
+
+  test "should raise ParameterError if required param is nil" do
+    assert_raises(ParameterError) do
+      <%= name %>.new(required_param: nil)
+    end
+  end
+
+  test "should convert optional_param if it is not a string" do
+    assert_equal <%= name %>.new(required_param: "foo", optional_param: 123).converts_param, "123"
+  end
+
+  test "call returns after operation" do
+    result = @operation.call
+    assert_equal result, "Hello World!"
+  end
+end
+<% end %>

data/lib/generators/typed_operation/install/USAGE

@@ -9,5 +9,13 @@ Command:
 --------
 rails generate typed_operation:install
 
+Options:
+--------
+--dry_monads: if specified the ApplicationOperation will include dry-monads Result and Do notation.
+
+Example:
+--------
+rails generate typed_operation:install
+
 This will create the following file:
 app/operations/application_operation.rb

data/lib/generators/typed_operation/install/install_generator.rb

@@ -5,10 +5,18 @@ require "rails/generators/base"
 module TypedOperation
   module Install
     class InstallGenerator < Rails::Generators::Base
+      class_option :dry_monads, type: :boolean, default: false
+
       source_root File.expand_path("templates", __dir__)
 
       def copy_application_operation_file
-        copy_file "application_operation.rb", "app/operations/application_operation.rb"
+        template "application_operation.rb", "app/operations/application_operation.rb"
+      end
+
+      private
+
+      def include_dry_monads?
+        options[:dry_monads]
       end
     end
   end

data/lib/generators/typed_operation/install/templates/application_operation.rb

@@ -1,5 +1,14 @@
 # frozen_string_literal: true
 
 class ApplicationOperation < ::TypedOperation::Base
-  # Common properties & methods for operations of this application...
+<% if include_dry_monads? -%>
+  include Dry::Monads[:result, :do]
+
+  def call!
+    call.value!
+  end
+
+<% end -%>
+  # Other common parameters & methods for Operations of this application...
+  # ...
 end

data/lib/generators/typed_operation_generator.rb

@@ -8,10 +8,14 @@ class TypedOperationGenerator < Rails::Generators::NamedBase
   class_option :path, type: :string, default: "app/operations"
 
   def generate_operation
-    template_path = File.join(self.class.source_root, "operation.rb")
-    dest_path = File.join(options[:path], "#{file_name}.rb")
-
-    template(template_path, dest_path)
+    template(
+      File.join(self.class.source_root, "operation.rb"),
+      File.join(options[:path], "#{file_name}.rb")
+    )
+    template(
+      File.join(self.class.source_root, "operation_test.rb"),
+      File.join("test/", options[:path].gsub(/\Aapp\//, ""), "#{file_name}_test.rb")
+    )
   end
 
   private

data/lib/typed_operation/base.rb

@@ -1,12 +1,10 @@
 # frozen_string_literal: true
 
-require "dry/monads"
 require "vident/typed"
 require "vident/typed/attributes"
 
 module TypedOperation
   class Base
-    include Dry::Monads[:result, :do]
     include Vident::Typed::Attributes
 
     class << self
@@ -35,7 +33,11 @@ module TypedOperation
     end
 
     def initialize(**attributes)
-      prepare_attributes(attributes)
+      begin
+        prepare_attributes(attributes)
+      rescue ::Dry::Struct::Error => e
+        raise ParameterError, e.message
+      end
       prepare if respond_to?(:prepare)
     end
 
@@ -43,10 +45,6 @@ module TypedOperation
       raise NotImplementedError, "You must implement #call"
     end
 
-    def call!
-      call.value!
-    end
-
     def to_proc
       method(:call).to_proc
     end

data/lib/typed_operation/version.rb

@@ -1,3 +1,3 @@
 module TypedOperation
-  VERSION = "0.3.0"
+  VERSION = "0.4.1"
 end

data/lib/typed_operation.rb

@@ -5,5 +5,5 @@ require "typed_operation/partially_applied"
 require "typed_operation/prepared"
 
 module TypedOperation
-  # Your code goes here...
+  class ParameterError < StandardError; end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: typed_operation
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Stephen Ierodiaconou
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-19 00:00:00.000000000 Z
+date: 2023-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -58,26 +58,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: dry-monads
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: '1'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: '1'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
 description: TypedOperation is a command pattern implementation where inputs can be
   defined with runtime type checks. Operations can be partially applied.
 email:
@@ -91,6 +71,7 @@ files:
 - Rakefile
 - lib/generators/USAGE
 - lib/generators/templates/operation.rb
+- lib/generators/templates/operation_test.rb
 - lib/generators/typed_operation/install/USAGE
 - lib/generators/typed_operation/install/install_generator.rb
 - lib/generators/typed_operation/install/templates/application_operation.rb