typed_eav 0.5.0 → 0.7.0

data/lib/typed_eav/versioning.rb

@@ -1,23 +1,15 @@
 # frozen_string_literal: true
 
 module TypedEAV
-  # Phase 04 versioning namespace. Houses the Subscriber that writes
-  # TypedEAV::ValueVersion rows in response to Value lifecycle events
-  # dispatched by EventDispatcher.
+  # Transactional versioning namespace. Houses the Subscriber that writes
+  # TypedEAV::ValueVersion rows from Value lifecycle callbacks.
   #
   # ## Architecture
   #
   # - TypedEAV::Versioning::Subscriber.call(value, change_type, context)
-  #   is conditionally registered with
-  #   EventDispatcher.register_internal_value_change at engine boot via
-  #   `TypedEAV::Versioning.register_if_enabled`, which is invoked from
-  #   the `config.after_initialize` block in lib/typed_eav/engine.rb.
-  #   When TypedEAV.config.versioning is false (default), the helper
-  #   returns early — no callable is added to the dispatcher chain.
-  #   When true, the subscriber registers and runs FIRST in the value-
-  #   change subscriber chain (slot 0 by `after_initialize` block
-  #   declaration order — Phase 07 will declare its matview block LATER
-  #   in the same engine to keep matview at slot ≥ 1).
+  #   is conditionally installed on Value's transactional callbacks at engine
+  #   boot via `TypedEAV::Versioning.register_if_enabled`. The version row
+  #   therefore shares the source transaction.
   #
   # - The subscriber is gated by TWO checks at call time (both must
   #   pass for a version row to be written):
@@ -30,10 +22,9 @@ module TypedEAV
   #   the callable — when false, the subscriber is never registered in
   #   the first place.
   #
-  # - Errors raised by Subscriber.call PROPAGATE per the EventDispatcher
-  #   internal-vs-user error policy (03-CONTEXT.md §User-callback error
-  #   policy). Versioning corruption must be loud — silent failure
-  #   leaves the audit log inconsistent with the live row.
+  # - Errors raised by Subscriber.call propagate. Versioning corruption must
+  #   be loud — silent failure leaves the audit log inconsistent with the live
+  #   row.
   #
   # ## Public API surface
   #
@@ -52,43 +43,70 @@ module TypedEAV
     # this namespace shell — it does NOT recursively autoload nested
     # constants. Without the explicit declaration below, the engine's
     # config.after_initialize block (which references
-    # `TypedEAV::Versioning::Subscriber.method(:call)`) raises
+    # `TypedEAV::Versioning::Subscriber`) raises
     # `NameError: uninitialized constant TypedEAV::Versioning::Subscriber`
     # at boot time, breaking every host that enables versioning.
     autoload :Subscriber, "typed_eav/versioning/subscriber"
 
-    # Conditionally register the Subscriber with EventDispatcher's internal
-    # value-change subscriber chain. Called by the engine's
-    # `config.after_initialize` block (lib/typed_eav/engine.rb).
+    CALLBACKS = {
+      create: %i[_write_version_create after].freeze,
+      update: %i[_write_version_update after].freeze,
+      destroy: %i[_write_version_destroy before].freeze,
+    }.freeze
+
+    # Conditionally install the Subscriber on Value's transactional callbacks.
+    # Called by the engine's `config.after_initialize` block.
     #
     # Extracted into a class method (not inlined inside the after_initialize
-    # block) for testability: specs can call this against a freshly-cleared
-    # `EventDispatcher.value_change_internals` to exercise both branches
-    # (versioning on/off) in-process, without booting the engine. The
-    # slot-0 regression spec (plan 04-03 P03) and the zero-overhead
-    # verification spec (this plan, subscriber_spec engine-boot block) both
-    # rely on this seam.
+    # block) for testability: specs can call this seam in-process without
+    # booting a second Rails application.
     #
-    # Idempotent — safe to call multiple times. Calling twice with
-    # versioning on results in exactly ONE entry in
-    # `EventDispatcher.value_change_internals`. The idempotency check uses
-    # `Array#include?` against `Subscriber.method(:call)`; `Method#==`
-    # compares receiver+name (semantic equality), so two fresh
-    # `Subscriber.method(:call)` instances compare equal even though they
-    # are different Method objects. The engine block runs this exactly
-    # once per boot in production; the idempotency guard protects future
-    # code paths that might re-invoke for any reason.
+    # Idempotent — safe to call multiple times. Pool validation happens before
+    # any callback is installed, so a multi-database misconfiguration fails
+    # closed without partial activation.
     #
     # When `TypedEAV.config.versioning` is false (default), this method is
-    # a no-op: zero callable in `value_change_internals`, zero per-write
-    # dispatch cost. That is the locked CONTEXT line 17 contract.
+    # a no-op: no callback is installed and the disabled path adds no
+    # per-write predicate or dispatcher work.
     def self.register_if_enabled
       return unless TypedEAV.config.versioning
 
-      method_ref = TypedEAV::Versioning::Subscriber.method(:call)
-      return if TypedEAV::EventDispatcher.value_change_internals.include?(method_ref)
+      value_pool = TypedEAV::Value.connection_pool
+      version_pool = TypedEAV::ValueVersion.connection_pool
+      unless value_pool.equal?(version_pool)
+        raise ArgumentError, "TypedEAV versioning requires Value and ValueVersion to share a connection pool"
+      end
+
+      callback_chains = callback_chains_for_installation
+
+      callback_chains.each do |event, (filter, kind, chain)|
+        next if chain.any? { |callback| callback.filter == filter && callback.kind == kind }
+
+        TypedEAV::Value.set_callback(event, kind, filter, prepend: true)
+      end
+    end
+
+    def self.callback_chains_for_installation
+      CALLBACKS.to_h do |event, (filter, kind)|
+        chain = TypedEAV::Value.send(:get_callbacks, event).to_a
+        wrong_kind = chain.find { |callback| callback.filter == filter && callback.kind != kind }
+        if wrong_kind
+          raise ArgumentError,
+                "TypedEAV versioning callback #{filter.inspect} on #{event} has kind " \
+                "#{wrong_kind.kind.inspect}; expected #{kind.inspect}"
+        end
+
+        [event, [filter, kind, chain]]
+      end
+    end
+    private_class_method :callback_chains_for_installation
 
-      TypedEAV::EventDispatcher.register_internal_value_change(method_ref)
+    def self.atomic_callbacks_installed?
+      CALLBACKS.all? do |event, (filter, kind)|
+        TypedEAV::Value.send(:get_callbacks, event).to_a.any? do |callback|
+          callback.filter == filter && callback.kind == kind
+        end
+      end
     end
   end
 end

data/lib/typed_eav.rb

@@ -18,6 +18,7 @@ module TypedEAV
   autoload :FilterQuery
   autoload :BulkRead
   autoload :BulkWrite
+  autoload :BulkUpsert
   autoload :Partition
   autoload :QueryBuilder
   autoload :SchemaPortability
@@ -27,6 +28,7 @@ module TypedEAV
   autoload :ValueVersion
   autoload :Versioned
   autoload :Versioning
+  autoload :FieldDeletion
 
   # Raised when a model declared `has_typed_eav scope_method: ...` but no
   # scope can be resolved at query time and `config.require_scope` is truthy.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: typed_eav
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.7.0
 platform: ruby
 authors:
 - dchuk
@@ -15,14 +15,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8.2'
 - !ruby/object:Gem::Dependency
   name: csv
   requirement: !ruby/object:Gem::Requirement
@@ -87,6 +93,8 @@ files:
 - db/migrate/20260505000000_create_typed_eav_value_versions.rb
 - db/migrate/20260506000001_add_version_group_id_to_typed_eav_value_versions.rb
 - db/migrate/20260507000000_add_label_to_typed_eav_fields.rb
+- db/migrate/20260712000000_enforce_parent_scope_invariant.rb
+- db/migrate/20260816000000_use_partial_covering_scalar_indexes.rb
 - lib/generators/typed_eav/install/install_generator.rb
 - lib/generators/typed_eav/scaffold/scaffold_generator.rb
 - lib/generators/typed_eav/scaffold/templates/config/initializers/typed_eav.rb
@@ -138,6 +146,7 @@ files:
 - lib/generators/typed_eav/scaffold/templates/views/typed_eav/values/inputs/_url.html.erb
 - lib/typed_eav.rb
 - lib/typed_eav/bulk_read.rb
+- lib/typed_eav/bulk_upsert.rb
 - lib/typed_eav/bulk_write.rb
 - lib/typed_eav/config.rb
 - lib/typed_eav/csv_mapper.rb
@@ -145,6 +154,7 @@ files:
 - lib/typed_eav/entity_query.rb
 - lib/typed_eav/event_dispatcher.rb
 - lib/typed_eav/field/typed_storage.rb
+- lib/typed_eav/field_deletion.rb
 - lib/typed_eav/filter_query.rb
 - lib/typed_eav/has_typed_eav.rb
 - lib/typed_eav/has_typed_eav/instance_methods.rb
@@ -152,6 +162,7 @@ files:
 - lib/typed_eav/query_builder.rb
 - lib/typed_eav/registry.rb
 - lib/typed_eav/schema_portability.rb
+- lib/typed_eav/schema_portability/import_index.rb
 - lib/typed_eav/scope_tuple.rb
 - lib/typed_eav/version.rb
 - lib/typed_eav/versioned.rb
@@ -174,14 +185,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.1'
+      version: '3.3'
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: '4.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.1
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Typed custom fields for ActiveRecord models
 test_files: []