typed_dag 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68e6894733312f8d62be51c1f249a767890402cc
-  data.tar.gz: b778e272530a806ec819024ce2a23597cfe1c0b6
+  metadata.gz: be1983f3f3663fca6096cedb4967bc29b8a72700
+  data.tar.gz: 3e3988050dac9d3e02bce00d94a335b7fd232a3f
 SHA512:
-  metadata.gz: 4c9827091a6768cc1e449f25f5cb167bae7fc8d80039adaf7b4552e79b8c63d3a9d20db5761222efcdb0b547a72d2d77a2c505afc9d9a26f184c78702fda230c
-  data.tar.gz: 73c1a4980d1c5e58ab6b09470f5bdac08241e6fe6bea9f9ffb9a2ac617b28d6130845b8bede5757f7413e08148f689b308a1ec8c047fae527b746f7973b6385e
+  metadata.gz: 15578eff98c3014a13bdf04420233b3eccbc7f5ffa3b7b9af54cce9546d23a474cf713299c50ac81862c3396887adad71e868246255a1840ce3d21196408297a
+  data.tar.gz: a33c762b8bd1940f9253920804cd7a5c0e2f916286e7ccb7e558df6df84aa0371ace212c13b7a001804c60958d0036ff4116bf48326bf0323928a9a6c193c0c0

data/README.md

@@ -187,14 +187,14 @@ A migration to create such a table could look like this:
 
     # give the index a custom name to avoid running into length limitation when having a couple of columns
     # in the index
-    add_index :edges, [:hierarchy, :reference], name: `index_on_type_columns`
+    add_index :edges, [:from_id, :to_id, :hierarchy, :reference], name: `index_on_type_columns`, unique: true
     add_index :edges, :count, where: 'count = 0'
   end
 ```
 
 The table can also have additional columns. They will not interfere with TypedDag.
 
-Which indices to use will depend on the data added but having an index over all the type columns is a good start. A partial index on count speeds up deleting edges while also being very lightweight to maintain.
+Which indices to use will depend on the data added but a unique index covering the foreign keys to the nodes as well as the columns counting the hops per type is required. A partial index on count speeds up deleting edges while also being very lightweight to maintain. Please note that [MySql does not support partial indices](https://dev.mysql.com/doc/refman/5.7/en/create-index.html).
 
 There are no requirements on the node's table.
 

data/lib/typed_dag/version.rb

@@ -1,3 +1,3 @@
 module TypedDag
-  VERSION = '2.0.1'.freeze
+  VERSION = '2.0.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: typed_dag
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - OpenProject GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-11 00:00:00.000000000 Z
+date: 2018-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -106,75 +106,6 @@ files:
 - lib/typed_dag/sql/select_closure.rb
 - lib/typed_dag/sql/truncate_closure.rb
 - lib/typed_dag/version.rb
-- spec/spec_helper.rb
-- spec/support/helpers.rb
-- spec/test_app/Rakefile
-- spec/test_app/app/assets/config/manifest.js
-- spec/test_app/app/assets/javascripts/application.js
-- spec/test_app/app/assets/javascripts/cable.js
-- spec/test_app/app/assets/stylesheets/application.css
-- spec/test_app/app/channels/application_cable/channel.rb
-- spec/test_app/app/channels/application_cable/connection.rb
-- spec/test_app/app/controllers/application_controller.rb
-- spec/test_app/app/helpers/application_helper.rb
-- spec/test_app/app/jobs/application_job.rb
-- spec/test_app/app/mailers/application_mailer.rb
-- spec/test_app/app/models/application_record.rb
-- spec/test_app/app/models/message.rb
-- spec/test_app/app/models/relation.rb
-- spec/test_app/app/views/layouts/application.html.erb
-- spec/test_app/app/views/layouts/mailer.html.erb
-- spec/test_app/app/views/layouts/mailer.text.erb
-- spec/test_app/bin/bundle
-- spec/test_app/bin/rails
-- spec/test_app/bin/rake
-- spec/test_app/bin/setup
-- spec/test_app/bin/update
-- spec/test_app/bin/yarn
-- spec/test_app/config.ru
-- spec/test_app/config/application.rb
-- spec/test_app/config/boot.rb
-- spec/test_app/config/cable.yml
-- spec/test_app/config/database.mysql.yml.travis
-- spec/test_app/config/database.postgresql.yml.travis
-- spec/test_app/config/database.yml
-- spec/test_app/config/environment.rb
-- spec/test_app/config/environments/development.rb
-- spec/test_app/config/environments/production.rb
-- spec/test_app/config/environments/test.rb
-- spec/test_app/config/initializers/application_controller_renderer.rb
-- spec/test_app/config/initializers/assets.rb
-- spec/test_app/config/initializers/backtrace_silencers.rb
-- spec/test_app/config/initializers/cookies_serializer.rb
-- spec/test_app/config/initializers/filter_parameter_logging.rb
-- spec/test_app/config/initializers/inflections.rb
-- spec/test_app/config/initializers/mime_types.rb
-- spec/test_app/config/initializers/typed_dag.rb
-- spec/test_app/config/initializers/wrap_parameters.rb
-- spec/test_app/config/locales/en.yml
-- spec/test_app/config/puma.rb
-- spec/test_app/config/routes.rb
-- spec/test_app/config/secrets.yml
-- spec/test_app/config/spring.rb
-- spec/test_app/db/development.sqlite3
-- spec/test_app/db/migrate/20170831093433_create_nodes_and_endges.rb
-- spec/test_app/db/schema.rb
-- spec/test_app/db/test.sqlite3
-- spec/test_app/log/development.log
-- spec/test_app/log/test.log
-- spec/test_app/package.json
-- spec/test_app/public/404.html
-- spec/test_app/public/422.html
-- spec/test_app/public/500.html
-- spec/test_app/public/apple-touch-icon-precomposed.png
-- spec/test_app/public/apple-touch-icon.png
-- spec/test_app/public/favicon.ico
-- spec/typed_dag/configuration.rb
-- spec/typed_dag/edge_spec.rb
-- spec/typed_dag/node_spec.rb
-- spec/typed_dag/sql/add_closure_spec.rb
-- spec/typed_dag/sql/truncate_closure_spec.rb
-- spec/typed_dag_spec.rb
 homepage: https://github.com/opf/typed_dag
 licenses:
 - MIT
@@ -199,73 +130,4 @@ rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Directed acyclic graphs for rails model with typed edges.
-test_files:
-- spec/spec_helper.rb
-- spec/support/helpers.rb
-- spec/test_app/app/assets/config/manifest.js
-- spec/test_app/app/assets/javascripts/application.js
-- spec/test_app/app/assets/javascripts/cable.js
-- spec/test_app/app/assets/stylesheets/application.css
-- spec/test_app/app/channels/application_cable/channel.rb
-- spec/test_app/app/channels/application_cable/connection.rb
-- spec/test_app/app/controllers/application_controller.rb
-- spec/test_app/app/helpers/application_helper.rb
-- spec/test_app/app/jobs/application_job.rb
-- spec/test_app/app/mailers/application_mailer.rb
-- spec/test_app/app/models/application_record.rb
-- spec/test_app/app/models/message.rb
-- spec/test_app/app/models/relation.rb
-- spec/test_app/app/views/layouts/application.html.erb
-- spec/test_app/app/views/layouts/mailer.html.erb
-- spec/test_app/app/views/layouts/mailer.text.erb
-- spec/test_app/bin/bundle
-- spec/test_app/bin/rails
-- spec/test_app/bin/rake
-- spec/test_app/bin/setup
-- spec/test_app/bin/update
-- spec/test_app/bin/yarn
-- spec/test_app/config/application.rb
-- spec/test_app/config/boot.rb
-- spec/test_app/config/cable.yml
-- spec/test_app/config/database.mysql.yml.travis
-- spec/test_app/config/database.postgresql.yml.travis
-- spec/test_app/config/database.yml
-- spec/test_app/config/environment.rb
-- spec/test_app/config/environments/development.rb
-- spec/test_app/config/environments/production.rb
-- spec/test_app/config/environments/test.rb
-- spec/test_app/config/initializers/application_controller_renderer.rb
-- spec/test_app/config/initializers/assets.rb
-- spec/test_app/config/initializers/backtrace_silencers.rb
-- spec/test_app/config/initializers/cookies_serializer.rb
-- spec/test_app/config/initializers/filter_parameter_logging.rb
-- spec/test_app/config/initializers/inflections.rb
-- spec/test_app/config/initializers/mime_types.rb
-- spec/test_app/config/initializers/typed_dag.rb
-- spec/test_app/config/initializers/wrap_parameters.rb
-- spec/test_app/config/locales/en.yml
-- spec/test_app/config/puma.rb
-- spec/test_app/config/routes.rb
-- spec/test_app/config/secrets.yml
-- spec/test_app/config/spring.rb
-- spec/test_app/config.ru
-- spec/test_app/db/development.sqlite3
-- spec/test_app/db/migrate/20170831093433_create_nodes_and_endges.rb
-- spec/test_app/db/schema.rb
-- spec/test_app/db/test.sqlite3
-- spec/test_app/log/development.log
-- spec/test_app/log/test.log
-- spec/test_app/package.json
-- spec/test_app/public/404.html
-- spec/test_app/public/422.html
-- spec/test_app/public/500.html
-- spec/test_app/public/apple-touch-icon-precomposed.png
-- spec/test_app/public/apple-touch-icon.png
-- spec/test_app/public/favicon.ico
-- spec/test_app/Rakefile
-- spec/typed_dag/configuration.rb
-- spec/typed_dag/edge_spec.rb
-- spec/typed_dag/node_spec.rb
-- spec/typed_dag/sql/add_closure_spec.rb
-- spec/typed_dag/sql/truncate_closure_spec.rb
-- spec/typed_dag_spec.rb
+test_files: []

data/spec/spec_helper.rb

@@ -1,89 +0,0 @@
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# The generated `.rspec` file contains `--require spec_helper` which will cause
-# this file to always be loaded, without a need to explicitly require it in any
-# files.
-#
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, consider making
-# a separate helper file that requires the additional dependencies and performs
-# the additional setup, and require it from the spec files that actually need
-# it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
-
-ENV['RAILS_ENV'] ||= 'test'
-
-require File.expand_path('../test_app/config/environment.rb', __FILE__)
-require 'rspec/rails'
-
-Rails.backtrace_cleaner.remove_silencers!
-
-# Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
-
-RSpec.configure do |config|
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
-  config.expect_with :rspec do |expectations|
-    # This option will default to `true` in RSpec 4. It makes the `description`
-    # and `failure_message` of custom matchers include text for helper methods
-    # defined using `chain`, e.g.:
-    #     be_bigger_than(2).and_smaller_than(4).description
-    #     # => "be bigger than 2 and smaller than 4"
-    # ...rather than:
-    #     # => "be bigger than 2"
-    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
-  end
-
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
-  config.mock_with :rspec do |mocks|
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended, and will default to
-    # `true` in RSpec 4.
-    mocks.verify_partial_doubles = true
-  end
-
-  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
-  # have no way to turn it off -- the option exists only for backwards
-  # compatibility in RSpec 3). It causes shared context metadata to be
-  # inherited by the metadata hash of host groups and examples, rather than
-  # triggering implicit auto-inclusion in groups with matching metadata.
-  config.shared_context_metadata_behavior = :apply_to_host_groups
-
-  config.use_transactional_fixtures = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-end

data/spec/support/helpers.rb

@@ -1,47 +0,0 @@
-module TypedDag
-  module Specs
-    module Helpers
-      def from_one_or_array(message)
-        if from_limit == 1
-          message
-        else
-          Array(message)
-        end
-      end
-
-      def message_with_from(text, parent)
-        if from_limit == 1
-          Message.create text: text, from => from_one_or_array(parent)
-        else
-          m = Message.create text: text
-          m.send("#{from}=", from_one_or_array(parent))
-          m
-        end
-      end
-
-      def create_message_with_invalidated_by(text, invalidated_by)
-        message = Message.create text: text
-        message.invalidated_by = Array(invalidated_by)
-        message
-      end
-
-      def to_attribute_array(relations)
-        relations.map do |r|
-          [r.from.text,
-           r.to.text,
-           r.hierarchy,
-           r.invalidate,
-           r.count]
-        end
-      end
-
-      def mysql_db?
-        ActiveRecord::Base.connection.adapter_name == 'Mysql2'
-      end
-
-      def harmonize_string(string)
-        string.squish.gsub('( ', '(').gsub(' )', ')')
-      end
-    end
-  end
-end

data/spec/test_app/Rakefile

@@ -1,6 +0,0 @@
-# Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
-
-require_relative 'config/application'
-
-Rails.application.load_tasks

data/spec/test_app/app/assets/config/manifest.js

@@ -1,4 +0,0 @@
-
-//= link_tree ../images
-//= link_directory ../javascripts .js
-//= link_directory ../stylesheets .css

data/spec/test_app/app/assets/javascripts/application.js

@@ -1,13 +0,0 @@
-// This is a manifest file that'll be compiled into application.js, which will include all the files
-// listed below.
-//
-// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts,
-// or any plugin's vendor/assets/javascripts directory can be referenced here using a relative path.
-//
-// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
-// compiled file. JavaScript code in this file should be added after the last require_* statement.
-//
-// Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details
-// about supported directives.
-//
-//= require_tree .

data/spec/test_app/app/assets/javascripts/cable.js

@@ -1,13 +0,0 @@
-// Action Cable provides the framework to deal with WebSockets in Rails.
-// You can generate new channels where WebSocket features live using the `rails generate channel` command.
-//
-//= require action_cable
-//= require_self
-//= require_tree ./channels
-
-(function() {
-  this.App || (this.App = {});
-
-  App.cable = ActionCable.createConsumer();
-
-}).call(this);

data/spec/test_app/app/assets/stylesheets/application.css

@@ -1,15 +0,0 @@
-/*
- * This is a manifest file that'll be compiled into application.css, which will include all the files
- * listed below.
- *
- * Any CSS and SCSS file within this directory, lib/assets/stylesheets, vendor/assets/stylesheets,
- * or any plugin's vendor/assets/stylesheets directory can be referenced here using a relative path.
- *
- * You're free to add application-wide styles to this file and they'll appear at the bottom of the
- * compiled file so the styles you add here take precedence over styles defined in any other CSS/SCSS
- * files in this directory. Styles in this file should be added after the last require_* statement.
- * It is generally better to create a new file per style scope.
- *
- *= require_tree .
- *= require_self
- */

data/spec/test_app/app/channels/application_cable/channel.rb

@@ -1,4 +0,0 @@
-module ApplicationCable
-  class Channel < ActionCable::Channel::Base
-  end
-end

data/spec/test_app/app/channels/application_cable/connection.rb

@@ -1,4 +0,0 @@
-module ApplicationCable
-  class Connection < ActionCable::Connection::Base
-  end
-end

data/spec/test_app/app/controllers/application_controller.rb

@@ -1,3 +0,0 @@
-class ApplicationController < ActionController::Base
-  protect_from_forgery with: :exception
-end

data/spec/test_app/app/helpers/application_helper.rb

@@ -1,2 +0,0 @@
-module ApplicationHelper
-end

data/spec/test_app/app/jobs/application_job.rb

@@ -1,2 +0,0 @@
-class ApplicationJob < ActiveJob::Base
-end

data/spec/test_app/app/mailers/application_mailer.rb

@@ -1,4 +0,0 @@
-class ApplicationMailer < ActionMailer::Base
-  default from: 'from@example.com'
-  layout 'mailer'
-end

data/spec/test_app/app/models/application_record.rb

@@ -1,3 +0,0 @@
-class ApplicationRecord < ActiveRecord::Base
-  self.abstract_class = true
-end

data/spec/test_app/app/models/message.rb

@@ -1,2 +0,0 @@
-class Message < ActiveRecord::Base
-end

data/spec/test_app/app/models/relation.rb

@@ -1,2 +0,0 @@
-class Relation < ActiveRecord::Base
-end

data/spec/test_app/app/views/layouts/application.html.erb

@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <head>
-    <title>TestApp</title>
-    <%= csrf_meta_tags %>
-
-    <%= stylesheet_link_tag    'application', media: 'all' %>
-    <%= javascript_include_tag 'application' %>
-  </head>
-
-  <body>
-    <%= yield %>
-  </body>
-</html>