typed_dag 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a7e31c0c6a123f535ad41b59c8aabaac96129a70
-  data.tar.gz: 78ee741a3bf16ea7014f2cf69a8a3f5903c9fab1
+  metadata.gz: 68e6894733312f8d62be51c1f249a767890402cc
+  data.tar.gz: b778e272530a806ec819024ce2a23597cfe1c0b6
 SHA512:
-  metadata.gz: 7941c61304bd469a8bff392405f09719f7246e6817e991cf835f7435d0570d8b832b37edaf87186ab359b57a20a0f5a5e949ffb65f87149b6745b4ab21be3b3c
-  data.tar.gz: 206c14332f5e58353063cf45ac0e8d279f632f017a14bbd1c96a0a2f4ab8e9cf3424f33cc1b2378c13eaf9363259caf2a8b26e920f37ec4a7eea412e24f2e383
+  metadata.gz: 4c9827091a6768cc1e449f25f5cb167bae7fc8d80039adaf7b4552e79b8c63d3a9d20db5761222efcdb0b547a72d2d77a2c505afc9d9a26f184c78702fda230c
+  data.tar.gz: 73c1a4980d1c5e58ab6b09470f5bdac08241e6fe6bea9f9ffb9a2ac617b28d6130845b8bede5757f7413e08148f689b308a1ec8c047fae527b746f7973b6385e

data/lib/typed_dag/edge/validations.rb

@@ -14,8 +14,19 @@ module TypedDag::Edge
       private
 
       def no_circular_dependency
-        if self.class.of_from_and_to(send(_dag_options.to_column),
-                                     send(_dag_options.from_column)).exists?
+        # Disregard self in case one wants to inverse the edge's direction.
+        # If the edge has not been persisted yet, AR will turn
+        #   where.not(id: id)
+        # into
+        #   WHERE id IS NOT NULL
+        # which is ok.
+        if self
+           .class
+           .of_from_and_to(send(_dag_options.to_column),
+                           send(_dag_options.from_column))
+           .where
+           .not(id: id)
+           .exists?
           errors.add :base, :'typed_dag.circular_dependency'
         end
       end

data/lib/typed_dag/version.rb

@@ -1,3 +1,3 @@
 module TypedDag
-  VERSION = '2.0.0'
+  VERSION = '2.0.1'.freeze
 end

data/spec/typed_dag/edge_spec.rb

@@ -134,6 +134,19 @@ RSpec.describe 'Edge' do
       end
     end
 
+    context 'with the relation switching directions' do
+      before do
+        relation.save
+        relation.from = to
+        relation.to = from
+      end
+
+      it 'is valid' do
+        expect(relation)
+          .to be_valid
+      end
+    end
+
     context 'with A - B - C and trying to connect C and A' do
       let(:a) { Message.create text: 'A' }
       let(:b) { Message.create text: 'B' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: typed_dag
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - OpenProject GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-08 00:00:00.000000000 Z
+date: 2018-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails