twog 0.3.5 → 0.3.6

data/lib/twog.rb

@@ -1,4 +1,6 @@
-#rubygems
+# frozen_string_literal: true
+
+# rubygems
 require 'rubygems'
 
 # 3rd party
@@ -14,7 +16,6 @@ require 'twog/blog_posts_handler'
 require 'twog/twitter_handler'
 require 'twog/post'
 
-
 module Twog
   module Twog
     include RssParser
@@ -24,26 +25,28 @@ module Twog
 
     def run(conf)
       posts = get_posts_to_tweet(conf)
-      return unless posts && posts.length > 0
+      return unless posts&.length&.positive?
+
       bitly = get_bitly_from(conf)
       tweet(posts, conf, bitly)
     end
 
     def get_posts_to_tweet(conf)
       posts = parse_feed(conf['rss_feed'])
-      posts = map(posts) 
+      posts = map(posts)
       posts = get_new_blog_posts(posts, conf['last_blog_post_tweeted'])
     end
 
     def get_bitly_from(conf)
       bitly_username = conf['bitly_username']
       bitly_api_key = conf['bitly_api_key']
-      return nil unless (bitly_username && bitly_api_key)
+      return nil unless bitly_username && bitly_api_key
+
       Bitly.new(bitly_username, bitly_api_key)
     end
-    
+
     def version
-      yml = YAML.load(File.read(File.join(File.dirname(__FILE__), *%w[.. VERSION.yml])))
+      yml = YAML.safe_load(File.read(File.join(File.dirname(__FILE__), *%w[.. VERSION.yml])))
       "#{yml[:major]}.#{yml[:minor]}.#{yml[:patch]}"
     end
   end

data/lib/twog/blog_posts_handler.rb

@@ -1,8 +1,11 @@
+# frozen_string_literal: true
+
 module Twog
   module BlogPostsHandler
     def get_new_blog_posts(posts, last_blog_post_tweeted)
-      return [] unless posts && posts.length > 0
+      return [] unless posts&.length&.positive?
       return posts unless last_blog_post_tweeted
+
       new_posts = posts.reject do |post|
         Time.parse(post.date.to_s) <= Time.parse(last_blog_post_tweeted.to_s)
       end

data/lib/twog/post.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Twog
   class Post
     def initialize(post)
@@ -11,13 +13,13 @@ module Twog
     def date
       @post.respond_to?('updated') ? @post.updated.content : @post.pubDate
     end
-    
+
     def title
       @post.title.respond_to?('content') ? @post.title.content : @post.title
     end
-    
-    def <=>(other_post)
-      Time.parse(self.date.to_s) <=> Time.parse(other_post.date.to_s)
+
+    def <=>(other)
+      Time.parse(date.to_s) <=> Time.parse(other.date.to_s)
     end
   end
 end

data/lib/twog/rss_entry_to_twog_post_mapper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Twog
   module RssEntryToTwogPostMapper
     def map(rss_entries)

data/lib/twog/rss_parser.rb

@@ -1,15 +1,16 @@
+# frozen_string_literal: true
+
 module Twog
   module RssParser
     def parse_feed(rss_feed_url)
-      raise Exception.new('RSS feed missing') unless rss_feed_url
+      raise StandardError, 'RSS feed missing' unless rss_feed_url
+
       rss = RSS::Parser.parse(get_content(rss_feed_url), false)
       rss.items
     end
 
     def get_content(rss_feed_url)
-      open(rss_feed_url) do |f|
-        f.read
-      end
+      open(rss_feed_url, &:read)
     end
   end
 end

data/lib/twog/twitter_handler.rb

@@ -1,11 +1,14 @@
+# frozen_string_literal: true
+
 module Twog
   module TwitterHandler
     def tweet(posts, conf, bitly)
-      return unless posts && posts.length > 0
-      raise Exception.new('OAuth Consumer Key missing') unless conf['consumer_key']
-      raise Exception.new('OAuth Consumer Secret missing') unless conf['consumer_secret']
-      raise Exception.new('OAuth Access Token missing') unless conf['access_token']
-      raise Exception.new('OAuth Access Secret missing') unless conf['access_secret']
+      return unless posts&.length&.positive?
+      raise StandardError, 'OAuth Consumer Key missing' unless conf['consumer_key']
+      raise StandardError, 'OAuth Consumer Secret missing' unless conf['consumer_secret']
+      raise StandardError, 'OAuth Access Token missing' unless conf['access_token']
+      raise StandardError, 'OAuth Access Secret missing' unless conf['access_secret']
+
       posts.sort.each do |post|
         link = bitly ? bitly.shorten(post.link).short_url : item.link
         use_twitter_oauth(post, link, conf)
@@ -15,25 +18,26 @@ module Twog
 
     def use_twitter_oauth(post, link, conf)
       client = TwitterOAuth::Client.new(
-        :consumer_key => conf['consumer_key'], 
-        :consumer_secret => conf['consumer_secret'], 
-        :token => conf['access_token'], 
-        :secret => conf['access_secret']
+        consumer_key: conf['consumer_key'],
+        consumer_secret: conf['consumer_secret'],
+        token: conf['access_token'],
+        secret: conf['access_secret']
       )
-      raise Exception.new('TwitterOAuth unauthorized') unless client.authorized?
+      raise StandardError, 'TwitterOAuth unauthorized' unless client.authorized?
+
       text = ensure_text_is_of_length(140, post.title, link)
       client.update(text)
     end
 
     def ensure_text_is_of_length(length, title, link)
-      blogged = "blogged:"
-      title = title[0,(length-((" "*2).length+blogged.length+link.length))]
+      blogged = 'blogged:'
+      title = title[0, (length - ((' ' * 2).length + blogged.length + link.length))]
       [blogged, title, link].join(' ')
     end
 
     def update_config_file_with_latest_tweet_date(last_blog_post_tweeted, conf)
       conf['last_blog_post_tweeted'] = last_blog_post_tweeted
-      File.open("#{ENV['HOME']}/.twog/conf.yaml","w") { |out| out.write(conf.to_yaml) }
+      File.open("#{ENV['HOME']}/.twog/conf.yaml", 'w') { |out| out.write(conf.to_yaml) }
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,6 @@
-$: << File.join(File.dirname(__FILE__), "/../lib")
+# frozen_string_literal: true
+
+$LOAD_PATH << File.join(File.dirname(__FILE__), '/../lib')
 
 require 'rubygems'
 require 'twog'
@@ -13,35 +15,34 @@ if ENV['COVERAGE']
 end
 
 def test_conf
-  @conf = {'rss_feed' => 'rss feed',
-    'bitly_username' => 'username',
-    'bitly_api_key' => 'api key',
-    'consumer_key' => 'consumerkey',
-    'consumer_secret' => 'consumersecret',
-    'access_token' => 'accesstoken',
-    'access_secret' => 'accesssecret',
-    'last_blog_post_tweeted' => '31 Mar 2010 07:52:17 -0600'}
+  @conf = { 'rss_feed' => 'rss feed',
+            'bitly_username' => 'username',
+            'bitly_api_key' => 'api key',
+            'consumer_key' => 'consumerkey',
+            'consumer_secret' => 'consumersecret',
+            'access_token' => 'accesstoken',
+            'access_secret' => 'accesssecret',
+            'last_blog_post_tweeted' => '31 Mar 2010 07:52:17 -0600' }
 end
 
 def rss_feed_entry
-  entry=<<-EOS
-  <item>
-<title>Gocode Vim Plugin and Go Modules</title>
-<description>
-<p><strong>Update</strong>: My friend <a href="https://twitter.com/_seemethere">Eli Uriegas</a> let me know that you don’t need <code class="highlighter-rouge">gocode</code> anymore since <code class="highlighter-rouge">vim-go</code> has autocompletion. I tested it out and he is correct. <a href="https://twitter.com/_seemethere/status/1081626050717728770">Here</a> is his tweet with a link to his dotfiles on how he sets up his <code class="highlighter-rouge">.vimrc</code> to use <code class="highlighter-rouge">vim-go</code></p> <p><em>Original Post:</em></p> <p>I recently purchased <a href="https://lets-go.alexedwards.net/">Let’s Go</a> from Alex Edwards. I wanted an end-to-end Golang website tutorial. It has been great. Lots learned.</p> <p>Unfortunately, he is using Go’s modules and the version of the gocode Vim plugin I was using did not support Go modules.</p> <h3 id="solution">Solution:</h3> <p>Use <a href="https://github.com/stamblerre/gocode">this fork</a> of the gocode Vim plugin and you’ll get support for Go modules.</p> <p>I use <a href="https://github.com/junegunn/vim-plug">Vim Plug</a> for my Vim plugins. Huge fan of Vundle but I like the post-actions feature of Plug. I just had to change one line of my vimrc and re-run updates.</p> <div class="language-diff highlighter-rouge"><div class="highlight"><pre class="highlight"><code><span class="gh">diff --git a/vimrc b/vimrc index 3e8edf1..8395705 100644 </span><span class="gd">--- a/vimrc </span><span class="gi">+++ b/vimrc </span><span class="gu">@@ -73,7 +73,7 @@ endif </span> let editor_name='nvim' Plug 'zchee/deoplete-go', { 'do': 'make'} endif <span class="gd">- Plug 'nsf/gocode', { 'rtp': 'vim', 'do': '~/.config/nvim/plugged/gocode/vim/symlink.sh' } </span><span class="gi">+ Plug 'stamblerre/gocode', { 'rtp': 'vim', 'do': '~/.vim/plugged/gocode/vim/symlink.sh' } </span> Plug 'godoctor/godoctor.vim', {'for': 'go'} " Gocode refactoring tool " } </code></pre></div></div> <p>That is the line I had to change then run <code class="highlighter-rouge">:PlugUpdate!</code> and the new plugin was installed.</p> <p>I figured all of this out due to <a href="https://github.com/zchee/deoplete-go/issues/134#issuecomment-435436305">this comment</a> by <a href="https://github.com/cippaciong">Tommaso Sardelli</a> on Github. Thank you Tommaso.</p>
-</description>
-<pubDate>Sat, 05 Jan 2019 11:09:26 -0600</pubDate>
-<link>
-https://blog.jasonmeridth.com/posts/gocode-vim-plugin-and-go-modules/
-</link>
-<guid isPermaLink="true">
-https://blog.jasonmeridth.com/posts/gocode-vim-plugin-and-go-modules/
-</guid>
-<category>go</category>
-<category>vim</category>
-</item>
-   EOS
-   return entry
+  <<~EOS
+      <item>
+    <title>Gocode Vim Plugin and Go Modules</title>
+    <description>
+    <p><strong>Update</strong>: My friend <a href="https://twitter.com/_seemethere">Eli Uriegas</a> let me know that you don’t need <code class="highlighter-rouge">gocode</code> anymore since <code class="highlighter-rouge">vim-go</code> has autocompletion. I tested it out and he is correct. <a href="https://twitter.com/_seemethere/status/1081626050717728770">Here</a> is his tweet with a link to his dotfiles on how he sets up his <code class="highlighter-rouge">.vimrc</code> to use <code class="highlighter-rouge">vim-go</code></p> <p><em>Original Post:</em></p> <p>I recently purchased <a href="https://lets-go.alexedwards.net/">Let’s Go</a> from Alex Edwards. I wanted an end-to-end Golang website tutorial. It has been great. Lots learned.</p> <p>Unfortunately, he is using Go’s modules and the version of the gocode Vim plugin I was using did not support Go modules.</p> <h3 id="solution">Solution:</h3> <p>Use <a href="https://github.com/stamblerre/gocode">this fork</a> of the gocode Vim plugin and you’ll get support for Go modules.</p> <p>I use <a href="https://github.com/junegunn/vim-plug">Vim Plug</a> for my Vim plugins. Huge fan of Vundle but I like the post-actions feature of Plug. I just had to change one line of my vimrc and re-run updates.</p> <div class="language-diff highlighter-rouge"><div class="highlight"><pre class="highlight"><code><span class="gh">diff --git a/vimrc b/vimrc index 3e8edf1..8395705 100644 </span><span class="gd">--- a/vimrc </span><span class="gi">+++ b/vimrc </span><span class="gu">@@ -73,7 +73,7 @@ endif </span> let editor_name='nvim' Plug 'zchee/deoplete-go', { 'do': 'make'} endif <span class="gd">- Plug 'nsf/gocode', { 'rtp': 'vim', 'do': '~/.config/nvim/plugged/gocode/vim/symlink.sh' } </span><span class="gi">+ Plug 'stamblerre/gocode', { 'rtp': 'vim', 'do': '~/.vim/plugged/gocode/vim/symlink.sh' } </span> Plug 'godoctor/godoctor.vim', {'for': 'go'} " Gocode refactoring tool " } </code></pre></div></div> <p>That is the line I had to change then run <code class="highlighter-rouge">:PlugUpdate!</code> and the new plugin was installed.</p> <p>I figured all of this out due to <a href="https://github.com/zchee/deoplete-go/issues/134#issuecomment-435436305">this comment</a> by <a href="https://github.com/cippaciong">Tommaso Sardelli</a> on Github. Thank you Tommaso.</p>
+    </description>
+    <pubDate>Sat, 05 Jan 2019 11:09:26 -0600</pubDate>
+    <link>
+    https://blog.jasonmeridth.com/posts/gocode-vim-plugin-and-go-modules/
+    </link>
+    <guid isPermaLink="true">
+    https://blog.jasonmeridth.com/posts/gocode-vim-plugin-and-go-modules/
+    </guid>
+    <category>go</category>
+    <category>vim</category>
+    </item>
+  EOS
 end
 
 def rss_entry
@@ -50,7 +51,7 @@ def rss_entry
 end
 
 def rss_feed_url_content
-  rss_header=<<-EOS
+  rss_header = <<-EOS
   <rss xmlns:atom="http://www.w3.org/2005/Atom" version="2.0">
   <channel>
     <title>Learn, Converse, Share</title>
@@ -61,6 +62,5 @@ def rss_feed_url_content
     <lastBuildDate>Fri, 01 Mar 2019 13:02:56 -0600</lastBuildDate>
     <generator>Jekyll v3.7.4</generator>
   EOS
-  return "#{rss_header}#{rss_feed_entry}</channel></rss>"
+  "#{rss_header}#{rss_feed_entry}</channel></rss>"
 end
-

data/spec/twog/blog_posts_handler_spec.rb

@@ -1,4 +1,6 @@
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe BlogPostsHandler do
   include BlogPostsHandler
@@ -9,27 +11,27 @@ describe BlogPostsHandler do
     @last_blog_post_tweeted = test_conf['last_blog_post_tweeted']
   end
 
-  it "should determine that there is one new blog post to tweet" do
+  it 'should determine that there is one new blog post to tweet' do
     posts = get_new_blog_posts(@posts, @last_blog_post_tweeted)
     expect(posts.length).to eq(1)
   end
 
-  it "should return zero if posts are nil" do
+  it 'should return zero if posts are nil' do
     posts = get_new_blog_posts(nil, @last_blog_post_tweeted)
     expect(posts.length).to eq(0)
   end
 
-  it "should return zero if no posts are passed" do
+  it 'should return zero if no posts are passed' do
     posts = get_new_blog_posts([], @last_blog_post_tweeted)
     expect(posts.length).to eq(0)
   end
 
-  it "should return the posts if there is no last_blog_post_tweeted in the conf file" do
+  it 'should return the posts if there is no last_blog_post_tweeted in the conf file' do
     posts = get_new_blog_posts(@posts, nil)
     expect(posts.length).to eq(1)
   end
 
-  it "should return zero posts if the date is older than the last blog post date tweeted" do
+  it 'should return zero posts if the date is older than the last blog post date tweeted' do
     post = Twog::Post.new(double('', pubDate: (Date.parse(@last_blog_post_tweeted.to_s) - 10).to_s, link: 'http://tinyurl.com'))
     @posts = [post]
     posts = get_new_blog_posts(@posts, @last_blog_post_tweeted)

data/spec/twog/post_spec.rb

@@ -1,33 +1,34 @@
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe Post do
-  context "when rss entry has updated and link.href" do
+  context 'when rss entry has updated and link.href' do
     before(:each) do
-      updated =double('update', content: '2010-04-02T01:00:00-06:00')
+      updated = double('update', content: '2010-04-02T01:00:00-06:00')
       link = double('link', href: 'http://tinyurl.com')
       title = double('title', content: 'test title')
       @post = double('post', updated: updated, link: link, title: title)
-
     end
 
-    it "should return a link" do
+    it 'should return a link' do
       twog_post = Twog::Post.new(@post)
-      expect(twog_post.date).to eq("2010-04-02T01:00:00-06:00")
+      expect(twog_post.date).to eq('2010-04-02T01:00:00-06:00')
     end
 
-    it "should return a date" do
+    it 'should return a date' do
       twog_post = Twog::Post.new(@post)
-      expect(twog_post.date).to eq("2010-04-02T01:00:00-06:00")
+      expect(twog_post.date).to eq('2010-04-02T01:00:00-06:00')
     end
 
-    it "should return a title" do
+    it 'should return a title' do
       twog_post = Twog::Post.new(@post)
-      expect(twog_post.title).to eq("test title")
+      expect(twog_post.title).to eq('test title')
     end
 
-    it "should sort multiple posts" do
+    it 'should sort multiple posts' do
       unsorted = (1..10).sort_by { rand }.collect do |i|
-        updated = double('update', content: (Time.now + (60*60*24*i)).to_s)
+        updated = double('update', content: (Time.now + (60 * 60 * 24 * i)).to_s)
         link = double('link', href: 'http://tinyurl.com')
         post = double('post', updated: updated, link: link)
         Twog::Post.new(post)
@@ -35,12 +36,12 @@ describe Post do
       sorted = unsorted.sort!
       expect(sorted.length).to eq(10)
 
-      sorted.inject {|i, j| expect(Time.parse(i.date.to_s)).to be < Time.parse(j.date.to_s); j }
+      sorted.inject { |i, j| expect(Time.parse(i.date.to_s)).to be < Time.parse(j.date.to_s); j }
     end
 
-    it "should leave meeting list alone if all the times are the same" do
-      unsorted = (1..10).collect do |i|
-        updated = double('update', content: (Time.now + (60*60*24*3)).to_s)
+    it 'should leave meeting list alone if all the times are the same' do
+      unsorted = (1..10).collect do |_i|
+        updated = double('update', content: (Time.now + (60 * 60 * 24 * 3)).to_s)
         link = double('link', href: 'http://tinyurl.com')
         post = double('post', updated: updated, link: link)
         Twog::Post.new(post)
@@ -51,27 +52,27 @@ describe Post do
     end
   end
 
-  context "when rss entry has pubDate and link" do
+  context 'when rss entry has pubDate and link' do
     before(:each) do
       @post = double('post', pubDate: '2010-04-02T01:00:00-06:00', link: 'http://tinyurl.com')
     end
 
-    it "should return a link" do
+    it 'should return a link' do
       twog_post = Twog::Post.new(@post)
 
-      expect(twog_post.link).to eq("http://tinyurl.com")
-      expect(twog_post.date).to eq("2010-04-02T01:00:00-06:00")
+      expect(twog_post.link).to eq('http://tinyurl.com')
+      expect(twog_post.date).to eq('2010-04-02T01:00:00-06:00')
     end
 
-    it "should sort multiple posts again" do
+    it 'should sort multiple posts again' do
       unsorted = (1..10).sort_by { rand }.collect do |i|
-        post = double('post', pubDate: (Time.now + (60*60*24*i)).to_s, link: 'http://tinyurl.com')
+        post = double('post', pubDate: (Time.now + (60 * 60 * 24 * i)).to_s, link: 'http://tinyurl.com')
         Twog::Post.new(post)
       end
       sorted = unsorted.sort!
       expect(sorted.length).to eq(10)
 
-      sorted.inject {|i, j| expect(Time.parse(i.date.to_s)).to be < Time.parse(j.date.to_s); j }
+      sorted.inject { |i, j| expect(Time.parse(i.date.to_s)).to be < Time.parse(j.date.to_s); j }
     end
   end
 end

data/spec/twog/rss_entry_to_twog_post_mapper_spec.rb

@@ -1,32 +1,34 @@
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe RssEntryToTwogPostMapper do
   include RssEntryToTwogPostMapper
 
-  it "should convert rss entries that have updated.content and link.href" do
+  it 'should convert rss entries that have updated.content and link.href' do
     updated = double('update', content: '2010-04-02T01:00:00-06:00')
     link = double('link', href: 'http://tinyurl.com')
     post = double('post', updated: updated, link: link)
 
-    posts = (0..20).collect { |x| post }
+    posts = (0..20).collect { |_x| post }
 
     twog_posts = map(posts)
     expect(twog_posts.length).to eq(21)
     twog_posts.each do |p|
-      expect(p.date).to eq("2010-04-02T01:00:00-06:00")
-      expect(p.link).to eq("http://tinyurl.com")
+      expect(p.date).to eq('2010-04-02T01:00:00-06:00')
+      expect(p.link).to eq('http://tinyurl.com')
     end
   end
 
-  it "should convert rss entries that have pubDate and link" do
+  it 'should convert rss entries that have pubDate and link' do
     post = double('post', pubDate: '2010-04-02T01:00:00-06:00', link: 'http://tinyurl.com')
-    posts = (0..20).collect { |x| post }
+    posts = (0..20).collect { |_x| post }
 
     twog_posts = map(posts)
     expect(twog_posts.length).to eq(21)
     twog_posts.each do |p|
-      expect(p.date).to eq("2010-04-02T01:00:00-06:00")
-      expect(p.link).to eq("http://tinyurl.com")
+      expect(p.date).to eq('2010-04-02T01:00:00-06:00')
+      expect(p.link).to eq('http://tinyurl.com')
     end
   end
 end

data/spec/twog/rss_parser_spec.rb

@@ -1,17 +1,19 @@
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe RssParser do
   include RssParser
 
-  it "should throw exception if rss_feed isn't provided" do
-    expect{ parse_feed(nil)}.to raise_error('RSS feed missing')
+  it 'should throw exception if rss_feed is not provided' do
+    expect { parse_feed(nil) }.to raise_error('RSS feed missing')
   end
 
-  it "should read the rss_feed_url and parse the items" do
+  it 'should read the rss_feed_url and parse the items' do
     allow(self).to receive(:get_content).and_return(rss_feed_url_content)
     items = parse_feed('http://tinyurl.com')
     expect(items.length).to eq(1)
-    expect(items[0].title.strip).to eq("Gocode Vim Plugin and Go Modules")
-    expect(items[0].link.strip).to eq("https://blog.jasonmeridth.com/posts/gocode-vim-plugin-and-go-modules/")
+    expect(items[0].title.strip).to eq('Gocode Vim Plugin and Go Modules')
+    expect(items[0].link.strip).to eq('https://blog.jasonmeridth.com/posts/gocode-vim-plugin-and-go-modules/')
   end
 end