twog 0.3.0 → 0.3.5

data/lib/twog.rb

@@ -9,32 +9,42 @@ require 'bitly'
 
 # internal requires
 require 'twog/rss_parser'
+require 'twog/rss_entry_to_twog_post_mapper'
 require 'twog/blog_posts_handler'
 require 'twog/twitter_handler'
+require 'twog/post'
 
 
-class Twog
-  extend RssParser
-  extend BlogPostsHandler
-  extend TwitterHandler
+module Twog
+  module Twog
+    include RssParser
+    include RssEntryToTwogPostMapper
+    include BlogPostsHandler
+    include TwitterHandler
 
-  def self.run(conf)
-    posts = parse(conf['rss_feed'])
-    posts = get_new_blog_posts(posts, conf['last_blog_post_tweeted'])
-    return unless posts && posts.length > 0
-    bitly = get_bitly_from(conf)
-    tweet(posts, conf, bitly)
-  end
+    def run(conf)
+      posts = get_posts_to_tweet(conf)
+      return unless posts && posts.length > 0
+      bitly = get_bitly_from(conf)
+      tweet(posts, conf, bitly)
+    end
 
-  def self.get_bitly_from(conf)
-    bitly_username = conf['bitly_username']
-    bitly_api_key = conf['bitly_api_key']
-    return nil unless (bitly_username && bitly_api_key)
-    Bitly.new(bitly_username, bitly_api_key)
-  end
-  
-  def self.version
-    yml = YAML.load(File.read(File.join(File.dirname(__FILE__), *%w[.. VERSION.yml])))
-    "#{yml[:major]}.#{yml[:minor]}.#{yml[:patch]}"
+    def get_posts_to_tweet(conf)
+      posts = parse_feed(conf['rss_feed'])
+      posts = map(posts) 
+      posts = get_new_blog_posts(posts, conf['last_blog_post_tweeted'])
+    end
+
+    def get_bitly_from(conf)
+      bitly_username = conf['bitly_username']
+      bitly_api_key = conf['bitly_api_key']
+      return nil unless (bitly_username && bitly_api_key)
+      Bitly.new(bitly_username, bitly_api_key)
+    end
+    
+    def version
+      yml = YAML.load(File.read(File.join(File.dirname(__FILE__), *%w[.. VERSION.yml])))
+      "#{yml[:major]}.#{yml[:minor]}.#{yml[:patch]}"
+    end
   end
 end

data/lib/twog/blog_posts_handler.rb

@@ -1,9 +1,11 @@
-
-
-module BlogPostsHandler
-  def get_new_blog_posts(posts, last_blog_post_tweeted)
-    return [] unless posts && posts.length > 0
-    return posts unless last_blog_post_tweeted
-    new_posts = posts.reject { |post| Time.parse(post.updated.content.to_s) <= Time.parse(last_blog_post_tweeted.to_s) }
+module Twog
+  module BlogPostsHandler
+    def get_new_blog_posts(posts, last_blog_post_tweeted)
+      return [] unless posts && posts.length > 0
+      return posts unless last_blog_post_tweeted
+      new_posts = posts.reject do |post|
+        Time.parse(post.date.to_s) <= Time.parse(last_blog_post_tweeted.to_s)
+      end
+    end
   end
 end

data/lib/twog/post.rb

@@ -0,0 +1,23 @@
+module Twog
+  class Post
+    def initialize(post)
+      @post = post
+    end
+
+    def link
+      @post.link.respond_to?('href') ? @post.link.href : @post.link
+    end
+
+    def date
+      @post.respond_to?('updated') ? @post.updated.content : @post.pubDate
+    end
+    
+    def title
+      @post.title.respond_to?('content') ? @post.title.content : @post.title
+    end
+    
+    def <=>(other_post)
+      Time.parse(self.date.to_s) <=> Time.parse(other_post.date.to_s)
+    end
+  end
+end

data/lib/twog/rss_entry_to_twog_post_mapper.rb

@@ -0,0 +1,7 @@
+module Twog
+  module RssEntryToTwogPostMapper
+    def map(rss_entries)
+      rss_entries.collect { |x| Post.new(x) }
+    end
+  end
+end

data/lib/twog/rss_parser.rb

@@ -1,13 +1,15 @@
-module RssParser
-  def parse(rss_feed_url)
-    raise Exception.new('RSS feed missing') unless rss_feed_url
-    rss = RSS::Parser.parse(get_content(rss_feed_url), false)
-    rss.items
-  end
+module Twog
+  module RssParser
+    def parse_feed(rss_feed_url)
+      raise Exception.new('RSS feed missing') unless rss_feed_url
+      rss = RSS::Parser.parse(get_content(rss_feed_url), false)
+      rss.items
+    end
 
-  def get_content(rss_feed_url)
-    open(rss_feed_url) do |f|
-      f.read
+    def get_content(rss_feed_url)
+      open(rss_feed_url) do |f|
+        f.read
+      end
     end
   end
 end

data/lib/twog/twitter_handler.rb

@@ -1,51 +1,39 @@
-class RSS::Atom::Feed::Entry
-  def <=>(other_entry)
-    this_time = Time.parse(updated.content.to_s)
-    other_time = Time.parse(other_entry.updated.content.to_s)
-    if this_time < other_time
-      -1
-    elsif this_time > other_time
-      1
-    else
-      0
+module Twog
+  module TwitterHandler
+    def tweet(posts, conf, bitly)
+      return unless posts && posts.length > 0
+      raise Exception.new('OAuth Consumer Key missing') unless conf['consumer_key']
+      raise Exception.new('OAuth Consumer Secret missing') unless conf['consumer_secret']
+      raise Exception.new('OAuth Access Token missing') unless conf['access_token']
+      raise Exception.new('OAuth Access Secret missing') unless conf['access_secret']
+      posts.sort.each do |post|
+        link = bitly ? bitly.shorten(post.link).short_url : item.link
+        use_twitter_oauth(post, link, conf)
+        update_config_file_with_latest_tweet_date(post.date.to_s, conf)
+      end
     end
-  end
-end
 
-module TwitterHandler
-  def tweet(posts, conf, bitly)
-    return unless posts && posts.length > 0
-    raise Exception.new('OAuth Consumer Key missing') unless conf['consumer_key']
-    raise Exception.new('OAuth Consumer Secret missing') unless conf['consumer_secret']
-    raise Exception.new('OAuth Access Token missing') unless conf['access_token']
-    raise Exception.new('OAuth Access Secret missing') unless conf['access_secret']
-    posts.sort.each do |item|
-      link = bitly ? bitly.shorten(item.link.href).short_url : item.link.href
-      use_twitter_oauth(item, link, conf)
-      update_config_file_with_latest_tweet_date(item.updated.content.to_s, conf)
+    def use_twitter_oauth(post, link, conf)
+      client = TwitterOAuth::Client.new(
+        :consumer_key => conf['consumer_key'], 
+        :consumer_secret => conf['consumer_secret'], 
+        :token => conf['access_token'], 
+        :secret => conf['access_secret']
+      )
+      raise Exception.new('TwitterOAuth unauthorized') unless client.authorized?
+      text = ensure_text_is_of_length(140, post.title, link)
+      client.update(text)
     end
-  end
-
-  def use_twitter_oauth(item, link, conf)
-    client = TwitterOAuth::Client.new(
-      :consumer_key => conf['consumer_key'], 
-      :consumer_secret => conf['consumer_secret'], 
-      :token => conf['access_token'], 
-      :secret => conf['access_secret']
-    )
-    raise Exception.new('TwitterOAuth unauthorized') unless client.authorized?
-    text = ensure_text_is_of_length(140, item.title.content, link)
-    client.update(text)
-  end
 
-  def ensure_text_is_of_length(length, title, link)
-    blogged = "blogged:"
-    title = title[0,(length-((" "*2).length+blogged.length+link.length))]
-    [blogged, title, link].join(' ')
-  end
+    def ensure_text_is_of_length(length, title, link)
+      blogged = "blogged:"
+      title = title[0,(length-((" "*2).length+blogged.length+link.length))]
+      [blogged, title, link].join(' ')
+    end
 
-  def update_config_file_with_latest_tweet_date(last_blog_post_tweeted, conf)
-    conf['last_blog_post_tweeted'] = last_blog_post_tweeted
-    File.open("#{ENV['HOME']}/.twog/conf.yaml","w") { |out| out.write(conf.to_yaml) }
+    def update_config_file_with_latest_tweet_date(last_blog_post_tweeted, conf)
+      conf['last_blog_post_tweeted'] = last_blog_post_tweeted
+      File.open("#{ENV['HOME']}/.twog/conf.yaml","w") { |out| out.write(conf.to_yaml) }
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,62 +1,66 @@
-require "lib/twog"
+$: << File.join(File.dirname(__FILE__), "/../lib")
+
+require 'rubygems'
+require 'twog'
 require 'rss'
+require 'simplecov'
+
+include Twog
+
+if ENV['COVERAGE']
+  require 'simplecov'
+  SimpleCov.start
+end
+
+def test_conf
+  @conf = {'rss_feed' => 'rss feed',
+    'bitly_username' => 'username',
+    'bitly_api_key' => 'api key',
+    'consumer_key' => 'consumerkey',
+    'consumer_secret' => 'consumersecret',
+    'access_token' => 'accesstoken',
+    'access_secret' => 'accesssecret',
+    'last_blog_post_tweeted' => '31 Mar 2010 07:52:17 -0600'}
+end
 
-module TwogSpecHelper
-  def test_conf
-    @conf = {'rss_feed' => 'rss feed',
-      'bitly_username' => 'username',
-      'bitly_api_key' => 'api key',
-      'consumer_key' => 'consumerkey',
-      'consumer_secret' => 'consumersecret',
-      'access_token' => 'accesstoken',
-      'access_secret' => 'accesssecret',
-      'last_blog_post_tweeted' => '31 Mar 2010 07:52:17 -0600'}
-  end
-
-  def rss_feed_entry
-    entry=<<-EOS
-     <entry>
-       <title>Pair Programming</title>
-       <link href="http://blog.jasonmeridth.com/2009/01/29/pair-programming.html"/>
-       <updated>2009-01-29T00:00:00-08:00</updated>
-       <id>http://blog.jasonmeridth.com/2009/01/29/pair-programming</id>
-       <content type="html">&lt;h1&gt;Pair Programming&lt;/h1&gt;
-    &lt;p class=&quot;meta&quot;&gt;29 Jan 2009 &amp;#8211; San Antonio&lt;/p&gt;
-    &lt;p&gt;I recently found this post, &lt;a href=&quot;http://blog.jayfields.com/2008/02/pair-programming-all-time.html&quot;&gt;Pair Programming all the time&lt;/a&gt;, by &lt;a href=&quot;http://blog.jayfields.com/&quot;&gt;Jay Fields&lt;/a&gt; and loved it.  I&amp;#8217;ve felt the same way about pair programming.&lt;/p&gt;
-    &lt;blockquote&gt;
-    &lt;p&gt;&amp;#8220;I define all the time (in terms of pairing) as when I&amp;#8217;m writing code that I&amp;#8217;m going to commit.&amp;#8221;&lt;/p&gt;
-    &lt;/blockquote&gt;
-    &lt;p&gt;That is perfect.  Common sense but stated explicitly.  I worked in an Agile shop for 2 1/2 years and the environment was setup to highlight pair programming.  Pictures and little explanation &lt;a href=&quot;http://www.lostechies.com/blogs/joe_ocampo/archive/2007/12/09/where-the-magic-happens-our-dev-lap.aspx&quot;&gt;here&lt;/a&gt; (Thanks Joe).  We even marked tasks in the stories as low (L) or high (H) to dictate whether a pair was necessary (this was decided during our modeling week by the two developers who tasked the story, but always up for discussion during the iteration).  It worked out pretty well.&lt;/p&gt;
-    &lt;p&gt;I understand and have heard all the reasons to not pair program.  Sometimes it works and sometimes it doesn&amp;#8217;t.  I&amp;#8217;ve personally experienced the benefits.  You learn to work with different personalities and that can only benefit you in your professional career.  And, the obvious reason, is immediate code review.  But, as my friend Scott C. Reynolds &lt;a href=&quot;http://www.lostechies.com/blogs/scottcreynolds/archive/2009/01/23/on-teaching-learning-and-being-honest-with-ourselves.aspx&quot;&gt;says&lt;/a&gt; (more or less):&lt;/p&gt;
-    &lt;blockquote&gt;
-    &lt;p&gt;&amp;#8220;Not everyone is cut from the same cloth&amp;#8221;&lt;/p&gt;
-    &lt;/blockquote&gt;
-    &lt;p&gt;That is true and that is life.  I hope this helps someone understand that not all pair programming enthusiasts are zealots.   I know it&amp;#8217;s a fine line though.&lt;/p&gt;</content>
-     </entry>
-     EOS
-     return entry
-  end
-
-  def rss_entry
-    rss = RSS::Parser.parse(rss_feed_url_content)
-    rss.items[0]
-  end
-
-  def rss_feed_url_content
-    post=<<-EOS
-    <?xml version="1.0" encoding="utf-8"?>
-    <feed xmlns="http://www.w3.org/2005/Atom">
-     
-     <title>Jason Meridth</title>
-     <link href="http://blog.jasonmeridth.com/atom.xml" rel="self"/>
-     <link href="http://blog.jasonmeridth.com/"/>
-     <updated>2010-04-04T13:15:31-07:00</updated>
-     <id>http://blog.jasonmeridth.com/</id>
-     <author>
-       <name>Jason Meridth</name>
-       <email>jmeridth@gmail.com</email>
-     </author>
-    EOS
-    return "#{post}#{rss_feed_entry}"
-  end
+def rss_feed_entry
+  entry=<<-EOS
+  <item>
+<title>Gocode Vim Plugin and Go Modules</title>
+<description>
+<p><strong>Update</strong>: My friend <a href="https://twitter.com/_seemethere">Eli Uriegas</a> let me know that you don’t need <code class="highlighter-rouge">gocode</code> anymore since <code class="highlighter-rouge">vim-go</code> has autocompletion. I tested it out and he is correct. <a href="https://twitter.com/_seemethere/status/1081626050717728770">Here</a> is his tweet with a link to his dotfiles on how he sets up his <code class="highlighter-rouge">.vimrc</code> to use <code class="highlighter-rouge">vim-go</code></p> <p><em>Original Post:</em></p> <p>I recently purchased <a href="https://lets-go.alexedwards.net/">Let’s Go</a> from Alex Edwards. I wanted an end-to-end Golang website tutorial. It has been great. Lots learned.</p> <p>Unfortunately, he is using Go’s modules and the version of the gocode Vim plugin I was using did not support Go modules.</p> <h3 id="solution">Solution:</h3> <p>Use <a href="https://github.com/stamblerre/gocode">this fork</a> of the gocode Vim plugin and you’ll get support for Go modules.</p> <p>I use <a href="https://github.com/junegunn/vim-plug">Vim Plug</a> for my Vim plugins. Huge fan of Vundle but I like the post-actions feature of Plug. I just had to change one line of my vimrc and re-run updates.</p> <div class="language-diff highlighter-rouge"><div class="highlight"><pre class="highlight"><code><span class="gh">diff --git a/vimrc b/vimrc index 3e8edf1..8395705 100644 </span><span class="gd">--- a/vimrc </span><span class="gi">+++ b/vimrc </span><span class="gu">@@ -73,7 +73,7 @@ endif </span> let editor_name='nvim' Plug 'zchee/deoplete-go', { 'do': 'make'} endif <span class="gd">- Plug 'nsf/gocode', { 'rtp': 'vim', 'do': '~/.config/nvim/plugged/gocode/vim/symlink.sh' } </span><span class="gi">+ Plug 'stamblerre/gocode', { 'rtp': 'vim', 'do': '~/.vim/plugged/gocode/vim/symlink.sh' } </span> Plug 'godoctor/godoctor.vim', {'for': 'go'} " Gocode refactoring tool " } </code></pre></div></div> <p>That is the line I had to change then run <code class="highlighter-rouge">:PlugUpdate!</code> and the new plugin was installed.</p> <p>I figured all of this out due to <a href="https://github.com/zchee/deoplete-go/issues/134#issuecomment-435436305">this comment</a> by <a href="https://github.com/cippaciong">Tommaso Sardelli</a> on Github. Thank you Tommaso.</p>
+</description>
+<pubDate>Sat, 05 Jan 2019 11:09:26 -0600</pubDate>
+<link>
+https://blog.jasonmeridth.com/posts/gocode-vim-plugin-and-go-modules/
+</link>
+<guid isPermaLink="true">
+https://blog.jasonmeridth.com/posts/gocode-vim-plugin-and-go-modules/
+</guid>
+<category>go</category>
+<category>vim</category>
+</item>
+   EOS
+   return entry
 end
+
+def rss_entry
+  rss = RSS::Parser.parse(rss_feed_url_content)
+  rss.items[0]
+end
+
+def rss_feed_url_content
+  rss_header=<<-EOS
+  <rss xmlns:atom="http://www.w3.org/2005/Atom" version="2.0">
+  <channel>
+    <title>Learn, Converse, Share</title>
+    <description>My Personal Blog</description>
+    <link>https://blog.jasonmeridth.com/</link>
+    <atom:link href="https://blog.jasonmeridth.com/feed.xml" rel="self" type="application/rss+xml"/>
+    <pubDate>Fri, 01 Mar 2019 13:02:56 -0600</pubDate>
+    <lastBuildDate>Fri, 01 Mar 2019 13:02:56 -0600</lastBuildDate>
+    <generator>Jekyll v3.7.4</generator>
+  EOS
+  return "#{rss_header}#{rss_feed_entry}</channel></rss>"
+end
+

data/spec/twog/blog_posts_handler_spec.rb

@@ -0,0 +1,38 @@
+require File.join(File.dirname(__FILE__), "/../spec_helper")
+
+describe BlogPostsHandler do
+  include BlogPostsHandler
+
+  before(:each) do
+    post = Twog::Post.new(double('', pubDate: Time.now, link: 'http://tinyurl.com'))
+    @posts = [post]
+    @last_blog_post_tweeted = test_conf['last_blog_post_tweeted']
+  end
+
+  it "should determine that there is one new blog post to tweet" do
+    posts = get_new_blog_posts(@posts, @last_blog_post_tweeted)
+    expect(posts.length).to eq(1)
+  end
+
+  it "should return zero if posts are nil" do
+    posts = get_new_blog_posts(nil, @last_blog_post_tweeted)
+    expect(posts.length).to eq(0)
+  end
+
+  it "should return zero if no posts are passed" do
+    posts = get_new_blog_posts([], @last_blog_post_tweeted)
+    expect(posts.length).to eq(0)
+  end
+
+  it "should return the posts if there is no last_blog_post_tweeted in the conf file" do
+    posts = get_new_blog_posts(@posts, nil)
+    expect(posts.length).to eq(1)
+  end
+
+  it "should return zero posts if the date is older than the last blog post date tweeted" do
+    post = Twog::Post.new(double('', pubDate: (Date.parse(@last_blog_post_tweeted.to_s) - 10).to_s, link: 'http://tinyurl.com'))
+    @posts = [post]
+    posts = get_new_blog_posts(@posts, @last_blog_post_tweeted)
+    expect(posts.length).to eq(0)
+  end
+end

data/spec/twog/post_spec.rb

@@ -0,0 +1,77 @@
+require File.join(File.dirname(__FILE__), "/../spec_helper")
+
+describe Post do
+  context "when rss entry has updated and link.href" do
+    before(:each) do
+      updated =double('update', content: '2010-04-02T01:00:00-06:00')
+      link = double('link', href: 'http://tinyurl.com')
+      title = double('title', content: 'test title')
+      @post = double('post', updated: updated, link: link, title: title)
+
+    end
+
+    it "should return a link" do
+      twog_post = Twog::Post.new(@post)
+      expect(twog_post.date).to eq("2010-04-02T01:00:00-06:00")
+    end
+
+    it "should return a date" do
+      twog_post = Twog::Post.new(@post)
+      expect(twog_post.date).to eq("2010-04-02T01:00:00-06:00")
+    end
+
+    it "should return a title" do
+      twog_post = Twog::Post.new(@post)
+      expect(twog_post.title).to eq("test title")
+    end
+
+    it "should sort multiple posts" do
+      unsorted = (1..10).sort_by { rand }.collect do |i|
+        updated = double('update', content: (Time.now + (60*60*24*i)).to_s)
+        link = double('link', href: 'http://tinyurl.com')
+        post = double('post', updated: updated, link: link)
+        Twog::Post.new(post)
+      end
+      sorted = unsorted.sort!
+      expect(sorted.length).to eq(10)
+
+      sorted.inject {|i, j| expect(Time.parse(i.date.to_s)).to be < Time.parse(j.date.to_s); j }
+    end
+
+    it "should leave meeting list alone if all the times are the same" do
+      unsorted = (1..10).collect do |i|
+        updated = double('update', content: (Time.now + (60*60*24*3)).to_s)
+        link = double('link', href: 'http://tinyurl.com')
+        post = double('post', updated: updated, link: link)
+        Twog::Post.new(post)
+      end
+      sorted = unsorted.sort!
+      expect(sorted.length).to eq(10)
+      expect(sorted).to eq(unsorted)
+    end
+  end
+
+  context "when rss entry has pubDate and link" do
+    before(:each) do
+      @post = double('post', pubDate: '2010-04-02T01:00:00-06:00', link: 'http://tinyurl.com')
+    end
+
+    it "should return a link" do
+      twog_post = Twog::Post.new(@post)
+
+      expect(twog_post.link).to eq("http://tinyurl.com")
+      expect(twog_post.date).to eq("2010-04-02T01:00:00-06:00")
+    end
+
+    it "should sort multiple posts again" do
+      unsorted = (1..10).sort_by { rand }.collect do |i|
+        post = double('post', pubDate: (Time.now + (60*60*24*i)).to_s, link: 'http://tinyurl.com')
+        Twog::Post.new(post)
+      end
+      sorted = unsorted.sort!
+      expect(sorted.length).to eq(10)
+
+      sorted.inject {|i, j| expect(Time.parse(i.date.to_s)).to be < Time.parse(j.date.to_s); j }
+    end
+  end
+end