two_factor_cookies 0.1.4 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8b15640efb0c0de5f91b24143dccd55afa656ae907fd339c0294d19e0839a19
-  data.tar.gz: 8ec02cd366c0460394ca526306f46d61bd5317e0969716f85fa3b4cfc82ae234
+  metadata.gz: ff154f3213027330160834208adbcc2133146e3e1eceecad33d671828fb9c2df
+  data.tar.gz: 738c73ec6492baf2f199c4f541344a6d13de93aeda526e7dc2cbffcff0f27be5
 SHA512:
-  metadata.gz: a7081336407be845c977d007288e31138401eff56a48054129cfd7a9dcacdb513ce10a9fd36e94d04fdd7ab54bce934edc7001e681567839ee337a644f6f2fb0
-  data.tar.gz: b30bd503bace7a1eaf0411957bf848cc87b202ddb468a51192958251128773f4a642dafda0a468300c550537697e461c2472de97cd546d1abf16b6cc26296185
+  metadata.gz: 49c9b2184c673215c1b77f41134f074d993c961fb6672fdcf9aa46faf8f39a78957f55cf8d807d366b655d72be03923ada8819db8476bd9de6ed5f1b75a7f814
+  data.tar.gz: 23a823447e95bd805f90bdfc14ea81d79b7ee24790619ab01cb493d610c2f7c4840ca14f2262697ca38e6ee2d16772f88c70d62530a77c3c44fc4ab380041911

data/README.md

@@ -29,10 +29,11 @@ TwoFactorCookies.configure do |config|
   config.otp_generation_secret_key =  MUST BE FILLED
 
   # Cookie expiry
+  # The values need to be an amount of seconds, for instance `30.minutes`. The gem adds this amount to the Time.zone.now and uses this to set the cookie's expiry
   # When a user will need to perform 2fa again
-  # config.two_factor_authentication_expiry = 30.days.from_now
+  # config.two_factor_authentication_expiry = 30.days
   # How much time a user has to type in the otp sent to his phone
-  # config.otp_expiry = 30.minutes.from_now
+  # config.otp_expiry = 30.minutes
 
   # Twilio API credentials
   config.twilio_account_sid = MUST BE FILLED

data/app/controllers/two_factor_cookies/toggle_two_factor_controller.rb

@@ -15,7 +15,8 @@ TwoFactorCookies.const_set('ToggleTwoFactorController',
 
       redirect_to eval(TwoFactorCookies.configuration.engine_name).public_send(
         TwoFactorCookies.configuration.confirm_phone_number_success_route,
-        current_user.to_param)
+        current_user.to_param
+      )
     end
 
     def toggle_two_factor

data/app/controllers/two_factor_cookies/two_factor_authentication_controller.rb

@@ -33,6 +33,8 @@ TwoFactorCookies.const_set('TwoFactorAuthenticationController',
       end
 
       def otp_verified?
+        return false unless cookies[:mfa].present?
+
         TwoFactorCookies::OneTimePasswordGenerator.verify_code(
           two_factor_authentication_params[:one_time_password],
           parsed_mfa_cookie[:seed]
@@ -59,7 +61,7 @@ TwoFactorCookies.const_set('TwoFactorAuthenticationController',
           value: JSON.generate(
             standard_values.merge(additional_authentication_values)
           ),
-          expires: TwoFactorCookies.configuration.two_factor_authentication_expiry
+          expires: Time.zone.now + TwoFactorCookies.configuration.two_factor_authentication_expiry
         }
       end
 
@@ -67,7 +69,7 @@ TwoFactorCookies.const_set('TwoFactorAuthenticationController',
         cookies.delete(:mfa)
         cookies.encrypted[:mfa] = {
           value: JSON.generate(seed: seed, user_name: current_user.public_send(TwoFactorCookies.configuration.username_field_name)),
-          expires: TwoFactorCookies.configuration.otp_expiry
+          expires: Time.zone.now + TwoFactorCookies.configuration.otp_expiry
         }
       end
 

data/lib/two_factor_cookies/configuration.rb

@@ -8,8 +8,8 @@ module TwoFactorCookies
 
     def initialize
       @otp_generation_secret_key = nil
-      @two_factor_authentication_expiry = 30.days.from_now
-      @otp_expiry = 30.minutes.from_now
+      @two_factor_authentication_expiry = 30.days
+      @otp_expiry = 30.minutes
 
       @twilio_account_sid = nil
       @twilio_phone_number = nil

data/lib/two_factor_cookies/version.rb

@@ -1,3 +1,3 @@
 module TwoFactorCookies
-  VERSION = '0.1.4'
+  VERSION = '0.1.7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: two_factor_cookies
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.7
 platform: ruby
 authors:
 - Nicolai Bach Woller
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-09-06 00:00:00.000000000 Z
+date: 2022-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.25.1
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.25.1
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: m
   requirement: !ruby/object:Gem::Requirement
@@ -143,7 +143,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -158,8 +158,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Simple two factor logon - with Twilio SMS for code delivery
 test_files: []