two_factor_cookies 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ccf0f45cecbc377af4bd82b5ac202731a8c09e160202199dd6133a613bbcc2c
-  data.tar.gz: 20d7518de754fbfe4fe5c58cd820d0d04544a55497485ce3ab22967d954cd7ba
+  metadata.gz: 10a72f05a70280e9ada50334d5e7b241b8938141b1dddd4a4a983e86e8e173ae
+  data.tar.gz: 759b972a8020bdc4af1c8e8b84c40f321b2d99279d42aa44cb61f7c0ded01185
 SHA512:
-  metadata.gz: 696b69c8e9b4b08dbc886b5c7cbcb0fb1b7a085dc92488eecd3d8bcb1b430df5873b6196cc18d5612c1b179fb63a1a1aabaad1fd0e5cfbf622fe66e073ee38ee
-  data.tar.gz: e29110160189fe56898b998b68f33bff6d68af084773c57ea7791f68633b71f2f96371ff3cac01e9efb1c89ddc15c8ed0d9453ad1c6d759c7ade83ef33b6af52
+  metadata.gz: 5d4d650b8a5ee61507f05dd2d76c0a9f808acf104a9bdfab79f6f1b8736758548242a192dd0cbf8eddc7f17afe092ab790744b7a166ebd7e78044ceecbd6a79b
+  data.tar.gz: e666f468fd3ef60f28281cb9d67476e1e3ab79bef4b4677147fc2aaec123108cba4a735cc3558cd4a545189f4fbcc13004d7aa0c538a99df283b810113f6f513

data/README.md

@@ -119,14 +119,10 @@ Toggling two factor on and off is handled by the `ToggleTwoFactorController` in
 `user` in the param is the name of the user model in the app, taken from the configuration. If enabled_two_factor is '1', two factor is toggled on. If enabled_two_factor is anything else, two factor will be toggled off
 
 #### Logging
-The gem can be configured to log, when 2fa is toggled on or off. To do this you must configure `logging_module` with a module that has `log` defined in whatever way makes sense in your project. The method will be passed a message consisting of a translation with a user id.
-```
-module Log
-  extend ActiveSupport::Concern
-
-  def log(message)
-    Rails.logger.info message
-  end
+The gem can be configured to log, when 2fa is toggled on or off. To do this you must configure `logging_method_name` with the name of a method, you implement, that logs in whatever way makes sense in your project. The method will be passed a message consisting of a translation with a user id.
+```ruby
+def log(message)
+  Rails.logger.info message
 end
 ```
 

data/app/controllers/two_factor_cookies/toggle_two_factor_controller.rb

@@ -1,7 +1,5 @@
 TwoFactorCookies.const_set('ToggleTwoFactorController',
   Class.new('TwoFactorCookies::TwoFactorAuthenticationController'.constantize) do
-    include TwoFactorCookies.configuration.logging_module.constantize if TwoFactorCookies.configuration.logging_module
-
     def update
       if TwoFactorCookies::OneTimePasswordGenerator.verify_code(
         confirm_phone_number_params[:one_time_password],
@@ -25,11 +23,11 @@ TwoFactorCookies.const_set('ToggleTwoFactorController',
         current_user.enable_two_factor!
         current_user.update(update_params) if TwoFactorCookies.configuration.update_params
         set_authenticated_cookie
-        log(I18n.t('two_factor_cookies.logger.toggle_2fa_on', id: current_user.id)) if TwoFactorCookies.configuration.logging_module
+        public_send(TwoFactorCookies.configuration.logging_method_name, I18n.t('two_factor_cookies.logger.toggle_2fa_on', id: current_user.id)) if TwoFactorCookies.configuration.logging_method_name
       else
         current_user.disable_two_factor!
         current_user.disaffirm_phone_number!
-        log(I18n.t('two_factor_cookies.logger.toggle_2fa_off', id: current_user.id)) if TwoFactorCookies.configuration.logging_module
+        public_send(TwoFactorCookies.configuration.logging_method_name, I18n.t('two_factor_cookies.logger.toggle_2fa_off', id: current_user.id)) if TwoFactorCookies.configuration.logging_method_name
       end
 
       redirect_to eval(TwoFactorCookies.configuration.engine_name).public_send(

data/lib/two_factor_cookies/configuration.rb

@@ -4,7 +4,7 @@ module TwoFactorCookies
       :toggle_two_factor_success_route, :two_factor_authentication_expiry, :otp_expiry, :twilio_account_sid,
       :twilio_phone_number, :twilio_auth_token, :phone_number_field_name, :user_model_name, :username_field_name,
       :two_factor_authentication_controller_parent, :skip_before_action, :layout_path, :additional_authentication_values,
-      :update_params, :engine_name, :logging_module
+      :update_params, :engine_name, :logging_method_name
 
     def initialize
       @otp_generation_secret_key = nil
@@ -24,7 +24,7 @@ module TwoFactorCookies
       @confirm_phone_number_success_route = nil
       @layout_path = nil
       @two_factor_authentication_controller_parent = '::ApplicationController'
-      @logging_module = nil
+      @logging_method_name = nil
 
       @additional_authentication_values = {}
 

data/lib/two_factor_cookies/version.rb

@@ -1,3 +1,3 @@
 module TwoFactorCookies
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: two_factor_cookies
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Nicolai Bach Woller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-19 00:00:00.000000000 Z
+date: 2019-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails