two_factor_authentication 1.1 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 86b64f6f26de2115a9fb9c35afd02072d4d668ab
-  data.tar.gz: b6448de97e61ce3d00910f3a6b5b165ad683e642
+  metadata.gz: 8037c367e1a0f7f7d253be0457b2046488b628fa
+  data.tar.gz: 024269293da1e0a407ac4e3537dc4e8749ca95a5
 SHA512:
-  metadata.gz: 17445687f19fe7f427b15c788423e1d7e26b90298e9e1c174a56168f3a7e6bb16172e4edb2fa6b3b7d27f17d54bc46119267524ce0fb6cf4a5946d0e8639eda9
-  data.tar.gz: 3538d6195e8529e753eaaf5bf85a85f9c65eac7af9cf51c227fea2bfe2b42a01eb91be4909196bfe749a8e78e23c8e87ba12791255327e592ae54fd415a94ce7
+  metadata.gz: 0c5a7deda98812e0a46ced0f99f2c0af64d4cd57531aad76660fecc7a1b351ba776263b24066a3d1f8caa93279f97fba1d415bcf41caf13bb1bc627a3a0c49ba
+  data.tar.gz: 2c80f6553ff57dbc3257f20c345cdf2217eefcf7d543f7547c0c31f8e57dbfc94ccf27759acbf81ba3937b05a808a8cc42acbb3ce7ee1ee7cb4869379f02bbaf

data/.travis.yml

@@ -3,6 +3,7 @@ language: ruby
 env:
   - "RAILS_VERSION=3.2.0"
   - "RAILS_VERSION=4.0.0"
+  - "RAILS_VERSION=4.1.1"
   - "RAILS_VERSION=master"
 
 rvm:

data/README.md

@@ -1,6 +1,7 @@
 # Two factor authentication for Devise
 
 [![Build Status](https://travis-ci.org/Houdini/two_factor_authentication.svg?branch=master)](https://travis-ci.org/Houdini/two_factor_authentication)
+[![Code Climate](https://codeclimate.com/github/Houdini/two_factor_authentication.png)](https://codeclimate.com/github/Houdini/two_factor_authentication)
 
 ## Features
 

data/app/controllers/devise/two_factor_authentication_controller.rb

@@ -9,7 +9,7 @@ class Devise::TwoFactorAuthenticationController < DeviseController
     render :show and return if params[:code].nil?
 
     if resource.authenticate_otp(params[:code])
-      warden.session(resource_name)[:need_two_factor_authentication] = false
+      warden.session(resource_name)['need_two_factor_authentication'] = false
       sign_in resource_name, resource, :bypass => true
       set_flash_message :notice, :success
       redirect_to stored_location_for(resource_name) || :root

data/lib/two_factor_authentication/controllers/helpers.rb

@@ -12,7 +12,7 @@ module TwoFactorAuthentication
       def handle_two_factor_authentication
         unless devise_controller?
           Devise.mappings.keys.flatten.any? do |scope|
-            if signed_in?(scope) and warden.session(scope)[:need_two_factor_authentication]
+            if signed_in?(scope) and warden.session(scope)['need_two_factor_authentication']
               handle_failed_second_factor(scope)
             end
           end
@@ -42,7 +42,7 @@ module Devise
   module Controllers
     module Helpers
       def is_fully_authenticated?
-        !session["warden.user.user.session"].try(:[], :need_two_factor_authentication)
+        !session["warden.user.user.session"].try(:[], 'need_two_factor_authentication')
       end
     end
   end

data/lib/two_factor_authentication/hooks/two_factor_authenticatable.rb

@@ -1,6 +1,6 @@
 Warden::Manager.after_authentication do |user, auth, options|
   if user.respond_to?(:need_two_factor_authentication?)
-    if auth.session(options[:scope])[:need_two_factor_authentication] = user.need_two_factor_authentication?(auth.request)
+    if auth.session(options[:scope])['need_two_factor_authentication'] = user.need_two_factor_authentication?(auth.request)
       user.send_two_factor_authentication_code
     end
   end

data/lib/two_factor_authentication/models/two_factor_authenticatable.rb

@@ -32,7 +32,7 @@ module Devise
         end
 
         def otp_code(time = Time.now)
-          ROTP::TOTP.new(self.otp_column).at(time)
+          ROTP::TOTP.new(self.otp_column).at(time, true)
         end
 
         def provisioning_uri(account = nil, options = {})

data/lib/two_factor_authentication/version.rb

@@ -1,3 +1,3 @@
 module TwoFactorAuthentication
-  VERSION = "1.1".freeze
+  VERSION = "1.1.1".freeze
 end

data/spec/lib/two_factor_authentication/models/two_factor_authenticatable_spec.rb

@@ -25,7 +25,15 @@ describe Devise::Models::TwoFactorAuthenticatable, '#otp_code' do
       let(:time) { 1392852756 }
 
       it "should return a known result" do
-        expect(subject).to eq(562202)
+        expect(subject).to eq('562202')
+      end
+    end
+
+    context "with a known time yielding a result with less than 6 digits" do
+      let(:time) { 1393065856 }
+
+      it "should return a known result padded with zeroes" do
+        expect(subject).to eq('007672')
       end
     end
   end

data/spec/rails_app/config/initializers/cookies_serializer.rb

@@ -0,0 +1,3 @@
+if Rails.version > '4.1.0'
+  Rails.application.config.action_dispatch.cookies_serializer = :json
+end

data/two_factor_authentication.gemspec

@@ -33,4 +33,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec-rails'
   s.add_development_dependency 'capybara'
+  s.add_development_dependency 'pry'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: two_factor_authentication
 version: !ruby/object:Gem::Version
-  version: '1.1'
+  version: 1.1.1
 platform: ruby
 authors:
 - Dmitrii Golub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-16 00:00:00.000000000 Z
+date: 2014-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -122,6 +122,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |2
       ### Features ###
       * control sms code pattern
@@ -184,6 +198,7 @@ files:
 - spec/rails_app/config/environments/production.rb
 - spec/rails_app/config/environments/test.rb
 - spec/rails_app/config/initializers/backtrace_silencers.rb
+- spec/rails_app/config/initializers/cookies_serializer.rb
 - spec/rails_app/config/initializers/devise.rb
 - spec/rails_app/config/initializers/inflections.rb
 - spec/rails_app/config/initializers/mime_types.rb
@@ -229,7 +244,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: two_factor_authentication
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Two factor authentication plugin for devise
@@ -261,6 +276,7 @@ test_files:
 - spec/rails_app/config/environments/production.rb
 - spec/rails_app/config/environments/test.rb
 - spec/rails_app/config/initializers/backtrace_silencers.rb
+- spec/rails_app/config/initializers/cookies_serializer.rb
 - spec/rails_app/config/initializers/devise.rb
 - spec/rails_app/config/initializers/inflections.rb
 - spec/rails_app/config/initializers/mime_types.rb