two-way-mapper 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b43b700b85546bce3d9c79425c5d82a20e4e63b24df74219296328c83c5f069
-  data.tar.gz: 5582e71aa4fc752c5fcc60709e65a7a58a72c119b529de1973845f768c804075
+  metadata.gz: 27c5a5f04384aebefba51e9ec085042cdf6d1ca40ff7d82aafba522b3b8eb457
+  data.tar.gz: 52d3d15700603d35a82e12f53c64765c71053644238bbe02cb44e9666934b6f6
 SHA512:
-  metadata.gz: 9f72fb8bfa5c89f4e810c955552d9fd4eed5d2a4d7bd67cc27f5bed42fe33d50c34447f2bf9f7ab16445385733cc3a5e5e0fa71a722ff621f2ab2e591c691945
-  data.tar.gz: ae220a4dea0fe3e3c836897822ac77d839a12d368bdd80f2f82aa2851fdebf25b057877aa55d6ab1632011f3de5ad7c4f0610e8407c66419103ba2bd2ccee271
+  metadata.gz: 7d1319a99792280e03ea43e6b8ecb294cb6da12d443e4b7f4a1211d4ef44515589de48307244330044baa666c4691f4816b7466ac56401ced959321afb263685
+  data.tar.gz: 4e99bb150c889eb4eafcb966ba7f3756cee4d64e63f2ec0b0040f19f2d830e75d1f433234018ca11a7506bb7b35a5962a74cf491b5a0166b3783bf60793f25b1

data/README.md

@@ -38,6 +38,20 @@ TwoWayMapper.register :customer do |mapping|
 end
 ```
 
+For simple rules use
+
+```ruby
+TwoWayMapper.register :customer do |mapping|
+  mapping.left :object # set left plugin to object
+  mapping.right :hash, stringify_keys: true # set right plugin to hash
+
+  mapping.rules(
+    'first_name' => 'FirstName',
+    'last_name' => 'LastName'
+  )
+end
+```
+
 Mapping can be defined explicitly without registration
 
 ```ruby
@@ -47,7 +61,7 @@ mapping.right :hash, stringify_keys: true
 # ...
 ```
 
-Once mapping is defined we can convert one object to another and vice versa
+Once the mapping is defined it can be used to convert one object to another and vice versa
 
 ```ruby
 Customer = Struct.new :first_name, :last_name, :gender

data/lib/two_way_mapper/mapping.rb

@@ -4,10 +4,10 @@ module TwoWayMapper
   class Mapping
     DIRECTIONS = [:left, :right].freeze
 
-    attr_reader :rules, :left_class, :left_options, :right_class, :right_options
+    attr_reader :rules_list, :left_class, :left_options, :right_class, :right_options
 
     def initialize
-      @rules = []
+      @rules_list = []
     end
 
     [DIRECTIONS, DIRECTIONS.reverse].each do |from, to|
@@ -18,7 +18,7 @@ module TwoWayMapper
         end
 
         def #{from}_selectors(mappable: false)
-          rules.flat_map do |rule|
+          rules_list.flat_map do |rule|
             if mappable && rule.from_#{from}_to_#{to}_only?
               []
             else
@@ -28,15 +28,15 @@ module TwoWayMapper
         end
 
         def from_#{from}_to_#{to}(left_obj, right_obj)
-          rules.each { |rule| rule.from_#{from}_to_#{to}(left_obj, right_obj) }
+          rules_list.each { |rule| rule.from_#{from}_to_#{to}(left_obj, right_obj) }
           #{to}_obj
         end
       CODE
     end
 
     def rule(left_selectors, right_selectors = {}, options = {})
-      raise 'You need to set left before calling rule' unless left_class
-      raise 'You need to set right before calling rule' unless right_class
+      raise 'left is not defined' unless left_class
+      raise 'right is not defined' unless right_class
 
       opt = options.dup
       left_opt = opt.delete(:left) || {}
@@ -52,14 +52,17 @@ module TwoWayMapper
         right_opt.merge!(opt.delete(right_selectors))
       end
 
-      left_nodes = Array(left_selectors).map do |left_selector|
-        left_class.new(left_selector, left_options.merge(left_opt))
-      end
-      right_nodes = Array(right_selectors).map do |right_selector|
-        right_class.new(right_selector, right_options.merge(right_opt))
-      end
+      @rules_list << Rule.new(
+        build_nodes(left_selectors, left_class, left_options.merge(left_opt)),
+        build_nodes(right_selectors, right_class, right_options.merge(right_opt)),
+        opt
+      )
+    end
 
-      @rules << Rule.new(left_nodes, right_nodes, opt)
+    def rules(hash)
+      hash.each do |left_selector, right_selector|
+        rule(left_selector, right_selector)
+      end
     end
 
     private
@@ -69,5 +72,11 @@ module TwoWayMapper
     rescue NameError
       raise NameError, 'Cannot find node'
     end
+
+    def build_nodes(selectors, klass, opt)
+      Array(selectors).map do |selector|
+        klass.new(selector, opt)
+      end
+    end
   end
 end

data/lib/two_way_mapper/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TwoWayMapper
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/spec/mapping_spec.rb

@@ -83,9 +83,9 @@ describe TwoWayMapper::Mapping do
     end
 
     it 'should add item to rules hash' do
-      expect { mapping.rule 'key1', 'Key1' }.to change { mapping.rules.count }.from(0).to(1)
+      expect { mapping.rule 'key1', 'Key1' }.to change { mapping.rules_list.count }.from(0).to(1)
 
-      rule = mapping.rules.first
+      rule = mapping.rules_list.first
       expect(rule).to be_instance_of TwoWayMapper::Rule
       expect(rule.left_nodes.map(&:selector)).to eql ['key1']
       expect(rule.right_nodes.map(&:selector)).to eql ['Key1']
@@ -94,7 +94,7 @@ describe TwoWayMapper::Mapping do
     it 'should support multiple selectors' do
       mapping.rule ['key1', 'key2'], ['Key1', 'Key2']
 
-      rule = mapping.rules.first
+      rule = mapping.rules_list.first
 
       expect(rule.left_nodes.size).to eql 2
       expect(rule.left_nodes[0].selector).to eql 'key1'
@@ -108,7 +108,7 @@ describe TwoWayMapper::Mapping do
       expect { mapping.rule 'key1' => { opt1: 'val' } }.to raise_error StandardError
 
       mapping.rule 'key1' => { opt1: 'val' }, 'Key2' => {}
-      rule = mapping.rules.first
+      rule = mapping.rules_list.first
 
       expect(rule.left_nodes.map(&:selector)).to eql ['key1']
       expect(rule.right_nodes.map(&:selector)).to eql ['Key2']
@@ -116,7 +116,7 @@ describe TwoWayMapper::Mapping do
 
     it 'should allow to pass left abd right options ' do
       mapping.rule 'key1', 'Key2', left: { opt1: 'val' }, right: { opt2: 'val' }
-      rule = mapping.rules.first
+      rule = mapping.rules_list.first
 
       expect(rule.left_nodes.first.options).to include opt1: 'val'
       expect(rule.right_nodes.first.options).to include opt2: 'val'
@@ -139,7 +139,7 @@ describe TwoWayMapper::Mapping do
     before :each do
       mapping.left :object
       mapping.right :hash
-      allow(mapping).to receive(:rules).and_return [rule1, rule2]
+      allow(mapping).to receive(:rules_list).and_return [rule1, rule2]
     end
 
     [described_class::DIRECTIONS, described_class::DIRECTIONS.reverse].each do |from, to|
@@ -155,4 +155,30 @@ describe TwoWayMapper::Mapping do
       end
     end
   end
+
+  describe '#rules' do
+    let(:hash) do
+      {
+        key1: :Key1,
+        key2: :Key2
+      }
+    end
+
+    before :each do
+      mapping.left :object
+      mapping.right :hash
+    end
+
+    it 'should allow to define multiple rules' do
+      expect { mapping.rules(hash) }.to change { mapping.rules_list.count }.from(0).to(2)
+
+      hash.each_with_index do |(left, right), index|
+        rule = mapping.rules_list[index]
+
+        expect(rule).to be_instance_of TwoWayMapper::Rule
+        expect(rule.left_nodes.map(&:selector)).to eql [left]
+        expect(rule.right_nodes.map(&:selector)).to eql [right]
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: two-way-mapper
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Tim Masliuchenko
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-03 00:00:00.000000000 Z
+date: 2020-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -123,7 +123,7 @@ homepage: https://github.com/timsly/two-way-mapper
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -139,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Two way data mapping
 test_files: