two-way-mapper 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bcbb9ddd6ab08af20ca40eec44b53bf3ac2109e9
-  data.tar.gz: 914738db9bb087708fc3603c1297738137d6226e
+SHA256:
+  metadata.gz: 57a42be67b0c722d8983ca53b2728722a7f6547609d7d8523963402e937f377e
+  data.tar.gz: c91f6f0b528679ef27f9a6d544ed3261c2c5a8815613e5c74757792fc9f75022
 SHA512:
-  metadata.gz: 9aad37686d32b6c02c163addb8d1a99bcdbbb39c5e5e770de7978825c354051872e114f4468c415b61d1574e83f7ef633bdb008c92d4bdd269bafa841cca000c
-  data.tar.gz: 24b29a8195033c489f9314620e5191c5be144c4d6b4bf15fb4280039ac686117569fabefa293d31081095beca0b7508324224006d1239328b7aa9ec8b77adc3e
+  metadata.gz: 6fa805f14750104f9e344d9d79de4a0a75c8ed8f14d447edad29d6ecedd26b05fa3fbbfdd71870c2832779edc76dfa1a2316a03f273717d5bc3e99f9c363e46a
+  data.tar.gz: e38c8c4a6028b516669afe6adfb4bd9cf02da30df15aa2d13c0d0df1f1f1b9788f8e48a498785b925e5850bb5db9efc9f2583d5f163a4f0bc4c94e648a6aa3ad

data/.travis.yml

@@ -5,10 +5,10 @@ notifications:
   email: false
 
 rvm:
- - 1.9.3
- - 2.0.0
- - 2.1.1
- - 2.1.2
+ - 2.3
+ - 2.4
+ - 2.5
+ - 2.6
  - ruby-head
  - jruby
 

data/README.md

@@ -38,6 +38,15 @@ TwoWayMapper.register :customer do |mapping|
 end
 ```
 
+Mapping can be defined explicitly without registration
+
+```ruby
+mapping = TwoWayMapper::Mapping.new
+mapping.left :object
+mapping.right :hash, stringify_keys: true
+# ...
+```
+
 Once mapping is defined we can convert one object to another and vice versa
 
 ```ruby
@@ -46,7 +55,7 @@ Customer = Struct.new :first_name, :last_name, :gender
 customer = Customer.new
 api_response = { 'FirstName' => 'Evee', 'LastName' => 'Fjord', 'sex' => 'female' }
 
-TwoWayMapper[:customer].from_right_to_left customer, api_response
+TwoWayMapper[:customer].from_right_to_left(customer, api_response)
 puts customer.first_name # => 'Evee'
 puts customer.last_name # => 'Fjord'
 puts customer.gender # => 'F'
@@ -58,17 +67,17 @@ another_customer.first_name = 'Step'
 another_customer.last_name = 'Bander'
 another_customer.gender = 'M'
 
-TwoWayMapper[:customer].from_left_to_right another_customer, request_data
+TwoWayMapper[:customer].from_left_to_right(another_customer, request_data)
 puts request_data # => { 'FirstName' => 'Step', 'LastName' => 'Bander', sex: 'male' }
 ```
 
-On rails, you can put all mappings into `app/mappings` folder
+In rails, mappings can be defined in `app/mappings` folder
 
 ### Available plugins
 
 * hash
 * object
-* active_record (same as object, but for keys like `user.email`, it will try to build `user` before updating `email` on write)
+* active_record (same as `object`, but for keys like `user.email`, it builds `user` before updating `email` on write)
 
 ## Contributing
 

data/lib/two-way-mapper.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'two_way_mapper'

data/lib/two_way_mapper/map.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   class Map
     delegate :[], to: :@maps
@@ -8,7 +10,9 @@ module TwoWayMapper
 
     def register(name)
       mapping = TwoWayMapper::Mapping.new
+
       yield mapping if block_given?
+
       @maps[name.to_sym] = mapping
     end
   end

data/lib/two_way_mapper/mapping.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   class Mapping
     attr_reader :rules, :left_class, :left_options, :right_class, :right_options
@@ -9,14 +11,14 @@ module TwoWayMapper
     [:left, :right].each do |method|
       class_eval <<-CODE, __FILE__, __LINE__ + 1
         def #{method}(plugin, options = {})
-          @#{method}_class = node_class plugin
+          @#{method}_class = node_class(plugin)
           @#{method}_options = options
         end
       CODE
     end
 
     def node_class(plugin)
-      TwoWayMapper::Node.const_get plugin.to_s.camelize
+      TwoWayMapper::Node.const_get(plugin.to_s.camelize)
     rescue NameError
       raise NameError, 'Cannot find node'
     end
@@ -31,15 +33,16 @@ module TwoWayMapper
 
       if left_selector.is_a?(Hash)
         raise ArgumentError if left_selector.count < 2
+
         opt = left_selector
         left_selector = opt.keys.first
-        left_opt.merge! opt.delete left_selector
+        left_opt.merge! opt.delete(left_selector)
         right_selector = opt.keys.first
-        right_opt.merge! opt.delete right_selector
+        right_opt.merge!(opt.delete(right_selector))
       end
 
-      left = left_class.new left_selector, left_options.merge(left_opt)
-      right = right_class.new right_selector, right_options.merge(right_opt)
+      left = left_class.new(left_selector, left_options.merge(left_opt))
+      right = right_class.new(right_selector, right_options.merge(right_opt))
 
       @rules << Rule.new(left, right, opt)
     end
@@ -47,7 +50,7 @@ module TwoWayMapper
     { left: :right, right: :left }.each do |from, to|
       class_eval <<-CODE, __FILE__, __LINE__ + 1
         def from_#{from}_to_#{to}(left_obj, right_obj)
-          rules.each { |r| r.from_#{from}_to_#{to} left_obj, right_obj }
+          rules.each { |r| r.from_#{from}_to_#{to}(left_obj, right_obj) }
           #{to}_obj
         end
       CODE

data/lib/two_way_mapper/node/active_record.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   module Node
     class ActiveRecord < Object
@@ -6,7 +8,7 @@ module TwoWayMapper
       end
 
       def create_node(obj, key)
-        obj.send "build_#{key}"
+        obj.send("build_#{key}")
       end
     end
   end

data/lib/two_way_mapper/node/{abstract.rb → base.rb}

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   module Node
-    class Abstract
+    class Base
       DIVIDER = '.'
 
       attr_accessor :selector, :options
@@ -14,47 +16,52 @@ module TwoWayMapper
           block = options[:stringify_keys] ? :to_s : :to_sym
           block = block.to_proc
         end
-        selector.split(DIVIDER).map &block
+        selector.split(DIVIDER).map(&block)
       end
 
       def read(source)
-        rewind_forward(source) { |obj, key| return nil }
+        rewind_forward(source) { |_obj, _key| return nil }
       end
 
-      def write(obj, value)
+      def write(_obj, _value)
+        raise NotImplementedError
       end
 
       def writable?(current_value, new_value)
         !options[:write_if] ||
-        !options[:write_if].respond_to?(:call) ||
-        options[:write_if].call(current_value, new_value)
+          !options[:write_if].respond_to?(:call) ||
+          options[:write_if].call(current_value, new_value)
       end
 
       private
 
       def rewind_forward(obj, margin = 0)
         to = -(1 + margin.to_i.abs)
+
         keys[0..to].each do |key|
           unless rewind_to?(obj, key)
             if block_given?
-              yield obj, key
+              yield(obj, key)
             else
-              create_node obj, key
+              create_node(obj, key)
             end
           end
-          obj = next_key obj, key
+          obj = next_key(obj, key)
         end
 
         obj
       end
 
-      def rewind_to?(obj, key)
+      def rewind_to?(_obj, _key)
+        raise NotImplementedError
       end
 
-      def create_node(obj, key)
+      def create_node(_obj, _key)
+        raise NotImplementedError
       end
 
-      def next_key(obj, key)
+      def next_key(_obj, _key)
+        raise NotImplementedError
       end
     end
   end

data/lib/two_way_mapper/node/hash.rb

@@ -1,10 +1,14 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   module Node
-    class Hash < Abstract
+    class Hash < Base
       def write(source, value)
         rewinded = rewind_forward source, 1
 
-        rewinded[keys.last] = value if writable? rewinded[keys.last], value
+        return unless writable?(rewinded[keys.last], value)
+
+        rewinded[keys.last] = value
       end
 
       private

data/lib/two_way_mapper/node/object.rb

@@ -1,23 +1,27 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   module Node
-    class Object < Abstract
+    class Object < Base
       def write(source, value)
-        rewinded = rewind_forward source, 1
+        rewinded = rewind_forward(source, 1)
+
+        return unless writable?(rewinded.send(keys.last), value)
 
-        rewinded.send "#{keys.last}=", value if writable? rewinded.send(keys.last), value
+        rewinded.send("#{keys.last}=", value)
       end
 
       private
 
       def rewind_to?(obj, key)
-        obj.respond_to? key
+        obj.respond_to?(key)
       end
 
       def create_node(obj, key)
       end
 
       def next_key(obj, key)
-        obj.send key
+        obj.send(key)
       end
     end
   end

data/lib/two_way_mapper/node.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   module Node
     extend ActiveSupport::Autoload
 
-    autoload :Abstract,     'two_way_mapper/node/abstract'
+    autoload :Base,         'two_way_mapper/node/base'
     autoload :Hash,         'two_way_mapper/node/hash'
     autoload :Object,       'two_way_mapper/node/object'
     autoload :ActiveRecord, 'two_way_mapper/node/active_record'

data/lib/two_way_mapper/railtie.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'rails'
 
 module TwoWayMapper
   class Railtie < Rails::Railtie
-    initializer "two_way_mapper.set_load_path" do |app|
+    initializer 'two_way_mapper.set_load_path' do |app|
       path = Rails.root.join('app', 'mappings', '*.rb').to_s
-      Dir[path].each{ |file| load file }
+      Dir[path].each { |file| load file }
     end
   end
 end

data/lib/two_way_mapper/rule.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   class Rule
     attr_reader :left, :right
@@ -11,12 +13,12 @@ module TwoWayMapper
     { left: :right, right: :left }.each do |from, to|
       class_eval <<-CODE, __FILE__, __LINE__ + 1
         def from_#{from}_to_#{to}(left_obj, right_obj)
-          value = #{from}.read #{from}_obj
-          value = map_value value, #{(from == :left).inspect}
-          if @options[:on_#{from}_to_#{to}].respond_to? :call
-            value = @options[:on_#{from}_to_#{to}].call value
+          value = #{from}.read(#{from}_obj)
+          value = map_value(value, #{(from == :left).inspect})
+          if @options[:on_#{from}_to_#{to}].respond_to?(:call)
+            value = @options[:on_#{from}_to_#{to}].call(value)
           end
-          #{to}.write #{to}_obj, value
+          #{to}.write(#{to}_obj, value)
 
           #{to}_obj
         end

data/lib/two_way_mapper/tools.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
   module Tools
     class << self
       def first_item_from_hash!(hash)
         raise ArgumentError unless hash.is_a?(Hash)
-        raise ArgumentError unless first = hash.first
+        raise ArgumentError unless (first = hash.first)
 
-        hash.delete first[0]
+        hash.delete(first[0])
         first
       end
     end

data/lib/two_way_mapper/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TwoWayMapper
-  VERSION = "0.0.1"
+  VERSION = '0.1.0'
 end

data/lib/two_way_mapper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/dependencies/autoload'
 require 'active_support/core_ext/module/delegation'
 require 'active_support/inflector'

data/spec/map_spec.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 describe TwoWayMapper::Map do
   describe '#register' do
-    let(:map) { TwoWayMapper::Map.new }
+    let(:map) { described_class.new }
 
     it 'should register new mapping' do
       map.register :import

data/spec/mapping_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 describe TwoWayMapper::Mapping do
+  let(:mapping) { described_class.new }
+
   [:left, :right].each do |method|
     describe "##{method}" do
-      let(:mapping) { TwoWayMapper::Mapping.new }
-
       it "should set #{method} with options" do
         mapping.send method, :object, opt1: ''
 
@@ -13,30 +15,30 @@ describe TwoWayMapper::Mapping do
   end
 
   describe '#rule' do
-    let(:mapping) { TwoWayMapper::Mapping.new }
     before :each do
       mapping.left :object
       mapping.right :hash
     end
 
     context 'left and right validation' do
-      let(:mapping_without_both) { TwoWayMapper::Mapping.new }
-      let(:mapping_without_left) { TwoWayMapper::Mapping.new }
-      let(:mapping_without_right) { TwoWayMapper::Mapping.new }
+      let(:mapping_without_both) { described_class.new }
+      let(:mapping_without_left) { described_class.new }
+      let(:mapping_without_right) { described_class.new }
+
       before :each do
         mapping_without_left.right :hash
         mapping_without_right.left :hash
       end
 
       it 'should raise error when no left or right nodes' do
-        expect{mapping_without_left.rule 'key', 'key'}.to raise_error
-        expect{mapping_without_right.rule 'key', 'key'}.to raise_error
-        expect{mapping_without_both.rule 'key', 'key'}.to raise_error
+        expect { mapping_without_left.rule 'key', 'key' }.to raise_error StandardError
+        expect { mapping_without_right.rule 'key', 'key' }.to raise_error StandardError
+        expect { mapping_without_both.rule 'key', 'key' }.to raise_error StandardError
       end
     end
 
     it 'should add item to rules hash' do
-      expect{mapping.rule 'key1', 'Key1'}.to change{mapping.rules.count}.from(0).to(1)
+      expect { mapping.rule 'key1', 'Key1' }.to change { mapping.rules.count }.from(0).to(1)
 
       rule = mapping.rules.first
       expect(rule).to be_instance_of TwoWayMapper::Rule
@@ -45,7 +47,7 @@ describe TwoWayMapper::Mapping do
     end
 
     it 'should allow to pass hash' do
-      expect{mapping.rule 'key1' => { opt1: 'val' }}.to raise_error
+      expect { mapping.rule 'key1' => { opt1: 'val' } }.to raise_error StandardError
 
       mapping.rule 'key1' => { opt1: 'val' }, 'Key2' => {}
       rule = mapping.rules.first
@@ -71,11 +73,11 @@ describe TwoWayMapper::Mapping do
   end
 
   context 'convertion methods' do
-    let(:mapping) { TwoWayMapper::Mapping.new }
     let(:rule1) { double from_left_to_right: nil, from_right_to_left: nil }
     let(:rule2) { double from_left_to_right: nil, from_right_to_left: nil }
-    let(:left_obj) { double() }
-    let(:right_obj) { double() }
+    let(:left_obj) { double }
+    let(:right_obj) { double }
+
     before :each do
       mapping.left :object
       mapping.right :hash

data/spec/node/active_record_spec.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+
 describe TwoWayMapper::Node::ActiveRecord do
-  let(:node) { TwoWayMapper::Node::ActiveRecord.new 'user.email' }
+  let(:node) { described_class.new 'user.email' }
 
   describe '#write' do
     it 'should try to build before write' do
       user = double(email: '')
-      obj = double()
+      obj = double
+
       allow(obj).to receive :build_user do
         allow(obj).to receive(:user).and_return user
       end
@@ -18,6 +21,7 @@ describe TwoWayMapper::Node::ActiveRecord do
     it 'should try to build even if respond_to but obj itself is nil' do
       user = double(email: '')
       obj = double(user: nil)
+
       allow(obj).to receive :build_user do
         allow(obj).to receive(:user).and_return user
       end

data/spec/node/{abstract_spec.rb → base_spec.rb}

@@ -1,19 +1,24 @@
-describe TwoWayMapper::Node::Abstract do
+# frozen_string_literal: true
+
+describe TwoWayMapper::Node::Base do
   describe '#keys' do
-    subject { TwoWayMapper::Node::Abstract.new 'key1.key11.key111' }
+    subject { described_class.new('key1.key11.key111') }
 
-    its(:keys) { should eql [:key1, :key11, :key111] }
+    its(:keys) { should eql %i[key1 key11 key111] }
   end
 
   describe 'writable?' do
     it 'should be truthy if write_if options not set' do
-      node = TwoWayMapper::Node::Abstract.new 'key1.key11.key111'
+      node = described_class.new('key1.key11.key111')
 
       expect(node).to be_writable 'current', 'new'
     end
 
     it 'should be truthy if write_if option set' do
-      node = TwoWayMapper::Node::Abstract.new 'key1.key11.key111', write_if: ->(c, n) { c == 'current' || n == 'new' }
+      node = described_class.new(
+        'key1.key11.key111',
+        write_if: ->(c, n) { c == 'current' || n == 'new' }
+      )
 
       expect(node).to be_writable 'current', 'new1'
       expect(node).to be_writable 'current1', 'new'

data/spec/node/hash_spec.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 describe TwoWayMapper::Node::Hash do
   context 'normal keys' do
-    let(:node) { TwoWayMapper::Node::Hash.new 'key1.key11.key111' }
+    let(:node) { described_class.new('key1.key11.key111') }
 
     describe '#read' do
       it 'should return nil when path is not avaiable' do
@@ -25,7 +27,9 @@ describe TwoWayMapper::Node::Hash do
   end
 
   context 'string keys' do
-    let(:node) { TwoWayMapper::Node::Hash.new 'key1.key11.key111', stringify_keys: true }
+    let(:node) do
+      described_class.new('key1.key11.key111', stringify_keys: true)
+    end
 
     describe '#read' do
       it 'should return nil when path is not avaiable' do
@@ -50,7 +54,7 @@ describe TwoWayMapper::Node::Hash do
   end
 
   context 'write_if option' do
-    let(:node) { TwoWayMapper::Node::Hash.new 'key1.key11', write_if: ->(c, n) { c.empty? || n == 'value1' } }
+    let(:node) { described_class.new 'key1.key11', write_if: ->(c, n) { c.empty? || n == 'value1' } }
     let(:writable_obj1) { { key1: { key11: '' } } }
     let(:writable_obj2) { { key1: { key11: 'smth' } } }
     let(:not_writable_obj) { { key1: { key11: 'smth' } } }

data/spec/node/object_spec.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 describe TwoWayMapper::Node::Object do
-  let(:node) { TwoWayMapper::Node::Object.new 'key1.key11.key111' }
+  let(:node) { described_class.new 'key1.key11.key111' }
 
   describe '#read' do
     it 'should return nil when path is not avaiable' do
@@ -25,7 +27,7 @@ describe TwoWayMapper::Node::Object do
   end
 
   context 'write_if option' do
-    let(:node) { TwoWayMapper::Node::Object.new 'key', write_if: ->(c, n) { c.empty? || n == 'value1'} }
+    let(:node) { described_class.new 'key', write_if: ->(c, n) { c.empty? || n == 'value1'} }
     let(:writable_obj1) { OpenStruct.new key: '' }
     let(:writable_obj2) { OpenStruct.new key: 'smth' }
     let(:not_writable_obj) { OpenStruct.new key: 'smth' }

data/spec/rule_spec.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 describe TwoWayMapper::Rule do
   context 'transformation methods' do
-    let(:left_node) { TwoWayMapper::Node::Object.new 'key1' }
-    let(:right_node) { TwoWayMapper::Node::Hash.new 'Kk.Key1' }
+    let(:left_node) { TwoWayMapper::Node::Object.new('key1') }
+    let(:right_node) { TwoWayMapper::Node::Hash.new('Kk.Key1') }
     let(:left_object) { OpenStruct.new }
     let(:map) { { 'value' => 'VALUE' } }
 
     context 'without options' do
-      let(:rule) { TwoWayMapper::Rule.new left_node, right_node }
+      let(:rule) { described_class.new left_node, right_node }
 
       describe '#from_left_to_right' do
         it 'should read from left node and write to right node' do
@@ -30,7 +32,7 @@ describe TwoWayMapper::Rule do
     end
 
     context 'with map option' do
-      let(:rule) { TwoWayMapper::Rule.new left_node, right_node, map: map, default: 'not found' }
+      let(:rule) { described_class.new left_node, right_node, map: map, default: 'not found' }
 
       describe '#from_left_to_right' do
         it 'should read from left node and write to right node' do
@@ -56,7 +58,7 @@ describe TwoWayMapper::Rule do
     context 'with default option' do
       describe '#from_left_to_right' do
         it 'should return default value if not found' do
-          rule = TwoWayMapper::Rule.new left_node, right_node, map: map, default: 'not found'
+          rule = described_class.new left_node, right_node, map: map, default: 'not found'
 
           left_object.key1 = 'value1'
           right_object = {}
@@ -66,7 +68,14 @@ describe TwoWayMapper::Rule do
         end
 
         it 'should return use default_left if present and value not found' do
-          rule = TwoWayMapper::Rule.new left_node, right_node, map: map, default: 'not found', default_left: 'not found on left', default_right: 'not found on right'
+          rule = described_class.new(
+            left_node,
+            right_node,
+            map: map,
+            default: 'not found',
+            default_left: 'not found on left',
+            default_right: 'not found on right'
+          )
 
           left_object.key1 = 'value1'
           right_object = {}
@@ -78,7 +87,7 @@ describe TwoWayMapper::Rule do
 
       describe '#from_right_to_left' do
         it 'should return default value if not found' do
-          rule = TwoWayMapper::Rule.new left_node, right_node, map: map, default: 'not found'
+          rule = described_class.new left_node, right_node, map: map, default: 'not found'
 
           left_object.key1 = nil
           right_object = { Kk: { Key1: 'VALUE1' } }
@@ -88,7 +97,14 @@ describe TwoWayMapper::Rule do
         end
 
         it 'should return use default_right if present and value not found' do
-          rule = TwoWayMapper::Rule.new left_node, right_node, map: map, default: 'not found', default_left: 'not found on left', default_right: 'not found on right'
+          rule = described_class.new(
+            left_node,
+            right_node,
+            map: map,
+            default: 'not found',
+            default_left: 'not found on left',
+            default_right: 'not found on right'
+          )
 
           left_object.key1 = nil
           right_object = { Kk: { Key1: 'VALUE1' } }
@@ -102,7 +118,11 @@ describe TwoWayMapper::Rule do
     describe 'with callback option' do
       describe 'on_left_to_right' do
         it 'should transform value if such options passed' do
-          rule = TwoWayMapper::Rule.new left_node, right_node, on_left_to_right: ->(v) { v.upcase }
+          rule = described_class.new(
+            left_node,
+            right_node,
+            on_left_to_right: ->(v) { v.upcase }
+          )
 
           left_object.key1 = 'value1'
           right_object = {}
@@ -114,7 +134,11 @@ describe TwoWayMapper::Rule do
 
       describe 'on_right_to_left' do
         it 'should transform value if such options passed' do
-          rule = TwoWayMapper::Rule.new left_node, right_node, on_right_to_left: ->(v) { v.downcase }
+          rule = described_class.new(
+            left_node,
+            right_node,
+            on_right_to_left: ->(v) { v.downcase }
+          )
 
           left_object.key1 = nil
           right_object = { Kk: { Key1: 'VALUE1' } }

data/spec/tools_spec.rb

@@ -1,19 +1,19 @@
-describe TwoWayMapper::Tools do
-  let(:tools) { TwoWayMapper::Tools }
+# frozen_string_literal: true
 
+describe TwoWayMapper::Tools do
   describe '.first_item_from_hash!' do
     it 'should raise error unless hash passed' do
-      expect{tools.first_item_from_hash!}.to raise_error
-      expect{tools.first_item_from_hash! ''}.to raise_error
-      expect{tools.first_item_from_hash! 1}.to raise_error
+      expect { described_class.first_item_from_hash! }.to raise_error ArgumentError
+      expect { described_class.first_item_from_hash! '' }.to raise_error ArgumentError
+      expect { described_class.first_item_from_hash! 1 }.to raise_error ArgumentError
     end
 
     it 'should raise error if emplt hash passed' do
-      expect{tools.first_item_from_hash! {}}.to raise_error
+      expect { described_class.first_item_from_hash! {} }.to raise_error ArgumentError
     end
 
     it 'should return first hash key and value' do
-      k, v = tools.first_item_from_hash! a: 1
+      k, v = described_class.first_item_from_hash! a: 1
 
       expect(k).to eql :a
       expect(v).to eql 1
@@ -21,7 +21,7 @@ describe TwoWayMapper::Tools do
 
     it 'should delete first item' do
       hash = { a: 1, b: 2 }
-      k, v = tools.first_item_from_hash! hash
+      _k, _v = described_class.first_item_from_hash!(hash)
 
       expect(hash).not_to include a: 1
     end

data/two-way-mapper.gemspec

@@ -1,27 +1,28 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'two_way_mapper/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "two-way-mapper"
+  spec.name          = 'two-way-mapper'
   spec.version       = TwoWayMapper::VERSION
-  spec.authors       = ["Tima Maslyuchenko"]
-  spec.email         = ["insside@gmail.com"]
-  spec.description   = %q{Two way data mapping}
-  spec.summary       = %q{Two way data mapping}
-  spec.homepage      = ""
-  spec.license       = "MIT"
+  spec.authors       = ['Tim Masliuchenko']
+  spec.email         = ['insside@gmail.com']
+  spec.description   = 'Two way data mapping'
+  spec.summary       = 'Two way data mapping'
+  spec.homepage      = 'https://github.com/timsly/two-way-mapper'
+  spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "activesupport"
+  spec.add_dependency 'activesupport'
 
-  spec.add_development_dependency "bundler",   "~> 1.3"
-  spec.add_development_dependency "rspec",     "~> 3.0"
-  spec.add_development_dependency "rspec-its"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rspec-its'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: two-way-mapper
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
-- Tima Maslyuchenko
+- Tim Masliuchenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-04 00:00:00.000000000 Z
+date: 2019-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -28,46 +28,46 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-its
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -101,8 +101,8 @@ files:
 - lib/two_way_mapper/map.rb
 - lib/two_way_mapper/mapping.rb
 - lib/two_way_mapper/node.rb
-- lib/two_way_mapper/node/abstract.rb
 - lib/two_way_mapper/node/active_record.rb
+- lib/two_way_mapper/node/base.rb
 - lib/two_way_mapper/node/hash.rb
 - lib/two_way_mapper/node/object.rb
 - lib/two_way_mapper/railtie.rb
@@ -111,15 +111,15 @@ files:
 - lib/two_way_mapper/version.rb
 - spec/map_spec.rb
 - spec/mapping_spec.rb
-- spec/node/abstract_spec.rb
 - spec/node/active_record_spec.rb
+- spec/node/base_spec.rb
 - spec/node/hash_spec.rb
 - spec/node/object_spec.rb
 - spec/rule_spec.rb
 - spec/spec_helper.rb
 - spec/tools_spec.rb
 - two-way-mapper.gemspec
-homepage: ''
+homepage: https://github.com/timsly/two-way-mapper
 licenses:
 - MIT
 metadata: {}
@@ -138,16 +138,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Two way data mapping
 test_files:
 - spec/map_spec.rb
 - spec/mapping_spec.rb
-- spec/node/abstract_spec.rb
 - spec/node/active_record_spec.rb
+- spec/node/base_spec.rb
 - spec/node/hash_spec.rb
 - spec/node/object_spec.rb
 - spec/rule_spec.rb