twitter_cldr 2.0.2 → 2.1.0

data/spec/shared/currencies_spec.rb

@@ -11,15 +11,6 @@ TEST_COUNTRIES = ["Australia", "Thailand", "Russia", "China", "Japan", "Peru", "
 TEST_CODES     = %w[AUD THB RUB CNY JPY PEN ZAR INR KRW GBP]
 
 describe Currencies do
-  describe "#countries" do
-    it "should list all supported countries" do
-      countries = Currencies.countries
-
-      countries.size.should == 112
-      countries.should include(*TEST_COUNTRIES)
-    end
-  end
-
   describe "#currency_codes" do
     it "should list all supported country codes" do
       codes = Currencies.currency_codes
@@ -29,29 +20,34 @@ describe Currencies do
     end
   end
 
-  describe "#for_country" do
-    it "should return all information for the given country" do
-      data = Currencies.for_country("Peru")
-
+  describe "#for_code" do
+    it "should return all information for PEN" do
+      data = Currencies.for_code("PEN")
       data.should be_a(Hash)
       data.should include(
-        :currency => :PEN,
-        :name => "Peruvian nuevo sol",
-        :symbol   => nil
+        :name        => "Peruvian nuevo sol",
+        :currency    => :PEN,
+        :symbol      => "S/.",
+        :cldr_symbol => "PEN"
       )
     end
-  end
-
-  describe "#for_code" do
-    it "should return all information for the given currency code" do
-      data = Currencies.for_code("PEN")
 
+    it "should return all information for CAD, a currency code with multiple possible symbols" do
+      data = Currencies.for_code("CAD")
       data.should be_a(Hash)
       data.should include(
-        :name => "Peruvian nuevo sol",
-        :currency => :PEN,
-        :symbol => nil
+        :name        => "Canadian dollar",
+        :currency    => :CAD,
+        :symbol      => "$",
+        :cldr_symbol => "CA$"
       )
     end
+
+    it "verifies that all code_points values are equivalent to their corresponding symbols" do
+      Currencies.currency_codes.select do |code|
+        data = Currencies.for_code(code)
+        data[:code_points].pack("U*").should == data[:symbol]
+      end
+    end
   end
 end

data/spec/shared/languages_spec.rb

@@ -10,31 +10,31 @@ include TwitterCldr::Shared
 describe Languages do
   describe "#translate_language" do
     it "should translate a language from one locale to another" do
-      Languages.translate_language("Russian", :en, :es).should == "ruso"
-      Languages.translate_language("ruso", :es, :en).should == "Russian"
-      Languages.translate_language("Spanish", :en, :es).should == "español"
-      Languages.translate_language("ruso", :es, :ru).should == "русский"
+      Languages.translate_language("Russian", :en, :es).should match_normalized("ruso")
+      Languages.translate_language("ruso", :es, :en).should match_normalized("Russian")
+      Languages.translate_language("Spanish", :en, :es).should match_normalized("español")
+      Languages.translate_language("ruso", :es, :ru).should match_normalized("русский")
     end
 
     it "should be capitalization agnostic" do
-      Languages.translate_language("russian", :en, :es).should == "ruso"
-      Languages.translate_language("RUSSIAN", :en, :es).should == "ruso"
+      Languages.translate_language("russian", :en, :es).should match_normalized("ruso")
+      Languages.translate_language("RUSSIAN", :en, :es).should match_normalized("ruso")
     end
 
-    it "defaults the destination language to English (or whatever FastGettext.locale is)" do
-      Languages.translate_language("Ruso", :es).should == "Russian"
-      Languages.translate_language("русский", :ru).should == "Russian"
+    it "defaults the destination language to English (or whatever the global locale is)" do
+      Languages.translate_language("Ruso", :es).should match_normalized("Russian")
+      Languages.translate_language("русский", :ru).should match_normalized("Russian")
     end
 
     it "defaults source and destination language to English if not given" do
-      Languages.translate_language("Russian").should == "Russian"
-      FastGettext.locale = :es
-      Languages.translate_language("Russian").should == "ruso"
+      Languages.translate_language("Russian").should match_normalized("Russian")
+      TwitterCldr.locale = :es
+      Languages.translate_language("Russian").should match_normalized("ruso")
     end
 
     it "successfully translates locale codes that are and are not in the CLDR using the locale map" do
-      Languages.translate_language("Russian", :en, :'zh-cn').should == "俄文"
-      Languages.translate_language("Russian", :en, :'zh').should == "俄文"
+      Languages.translate_language("Russian", :en, :'zh-cn').should match_normalized("俄文")
+      Languages.translate_language("Russian", :en, :'zh').should match_normalized("俄文")
     end
 
     it "should return nil if no translation was found" do
@@ -44,17 +44,17 @@ describe Languages do
 
   describe "#from_code_for_locale" do
     it "should return the language in the correct locale for the given locale code (i.e. es in English should be Spanish)" do
-      Languages.from_code_for_locale(:es, :en).should == "Spanish"
-      Languages.from_code_for_locale(:en, :es).should == "inglés"
+      Languages.from_code_for_locale(:es, :en).should match_normalized("Spanish")
+      Languages.from_code_for_locale(:en, :es).should match_normalized("inglés")
     end
   end
 
   describe "#from_code" do
     it "should return the language in the default locale for the given locale code" do
-      Languages.from_code(:es).should == "Spanish"
-      Languages.from_code(:ru).should == "Russian"
-      FastGettext.locale = :es
-      Languages.from_code(:es).should == "español"
+      Languages.from_code(:es).should match_normalized("Spanish")
+      Languages.from_code(:ru).should match_normalized("Russian")
+      TwitterCldr.locale = :es
+      Languages.from_code(:es).should match_normalized("español")
     end
   end
 
@@ -62,7 +62,7 @@ describe Languages do
     it "should return a hash of all languages for the given language code" do
       langs = Languages.all_for(:es)
       langs.should be_a(Hash)
-      langs[:ru].should == "ruso"
+      langs[:ru].should match_normalized("ruso")
     end
 
     it "should return an empty hash for an invalid language" do
@@ -75,14 +75,14 @@ describe Languages do
     it "should use the default language to get the language hash" do
       langs = Languages.all
       langs.should be_a(Hash)
-      langs[:ru].should == "Russian"
-      langs[:de].should == "German"
+      langs[:ru].should match_normalized("Russian")
+      langs[:de].should match_normalized("German")
 
-      FastGettext.locale = :es
+      TwitterCldr.locale = :es
       langs = Languages.all
       langs.should be_a(Hash)
-      langs[:ru].should == "ruso"
-      langs[:de].should == "alemán"
+      langs[:ru].should match_normalized("ruso")
+      langs[:de].should match_normalized("alemán")
     end
   end
 
@@ -106,4 +106,4 @@ describe Languages do
     end
   end
 
-end
+end

data/spec/shared/numbers_spec.rb

@@ -12,7 +12,7 @@ describe Numbers do
     let(:symbols) { { :nan => 'NaN', :minus_sign => '-' } }
 
     it 'returns numerical symbols for default locale' do
-      stub(TwitterCldr).get_locale { :jp }
+      stub(TwitterCldr).locale { :jp }
       stub(TwitterCldr).get_locale_resource(:jp, :numbers) { { :jp => { :numbers => { :symbols => symbols } } } }
       TwitterCldr::Shared::Numbers.symbols.should == symbols
     end

data/spec/shared/territories_spec.rb

@@ -0,0 +1,120 @@
+# encoding: UTF-8
+
+# Copyright 2012 Twitter, Inc
+# http://www.apache.org/licenses/LICENSE-2.0
+
+require 'spec_helper'
+
+include TwitterCldr::Shared
+
+describe Territories do
+  describe "#translate_territory" do
+    it "should translate country names from one locale to another" do
+      Territories.translate_territory("Russia", :en, :es).should match_normalized("Rusia")
+      Territories.translate_territory("Rusia", :es, :en).should match_normalized("Russia")
+      Territories.translate_territory("Spain", :en, :es).should match_normalized("España")
+      Territories.translate_territory("España", :es, :ru).should match_normalized("Испания")
+    end
+
+    it "should use alternate/short names" do
+      Territories.translate_territory("Congo [DRC]", :en, :es).should match_normalized("Congo [República Democrática del Congo]")
+      Territories.translate_territory("Congo [Republic]", :en, :es).should match_normalized("Congo [República]")
+      Territories.translate_territory("East Timor", :en, :es).should match_normalized("Timor Oriental")
+      Territories.translate_territory("Falkland Islands [Islas Malvinas]", :en, :es).should match_normalized("Islas Malvinas [Islas Falkland]")
+      Territories.translate_territory("Hong Kong", :en, :es).should match_normalized("Hong Kong")
+      Territories.translate_territory("Ivory Coast", :en, :es).should match_normalized("Costa de Marfil")
+      Territories.translate_territory("Macau", :en, :es).should match_normalized("Macao")
+      Territories.translate_territory("Macedonia [FYROM]", :en, :es).should match_normalized("Macedonia [ERYM]")
+    end
+
+    it "should be capitalization agnostic" do
+      Territories.translate_territory("russia", :en, :es).should match_normalized("Rusia")
+      Territories.translate_territory("RUSSIA", :en, :es).should match_normalized("Rusia")
+    end
+
+    it "defaults the destination language to English (or whatever the global locale is)" do
+      Territories.translate_territory("Rusia", :es).should match_normalized("Russia")
+      Territories.translate_territory("Россия", :ru).should match_normalized("Russia")
+    end
+
+    it "defaults source and destination language to English if not given" do
+      Territories.translate_territory("Russia").should match_normalized("Russia")
+      TwitterCldr.locale = :es
+      Territories.translate_territory("Russia").should match_normalized("Rusia")
+    end
+
+    it "successfully translates locale codes that are and are not in the CLDR using the locale map" do
+      Territories.translate_territory("Russia", :en, :'zh-cn').should match_normalized("俄罗斯")
+      Territories.translate_territory("Russia", :en, :'zh').should match_normalized("俄罗斯")
+    end
+
+    it "should return nil if no translation was found" do
+      Territories.translate_territory("Russia", :en, :blarg).should == nil
+    end
+  end
+
+  describe "#from_territory_code_for_locale" do
+    it "should return the territory in the correct locale for the given locale code (i.e. RU in English should be Russia)" do
+      Territories.from_territory_code_for_locale(:ES, :en).should match_normalized("Spain")
+      Territories.from_territory_code_for_locale(:GB, :es).should match_normalized("Reino Unido")
+    end
+
+    it "should work with lower-case country codes as well" do
+      Territories.from_territory_code_for_locale(:es, :en).should match_normalized("Spain")
+      Territories.from_territory_code_for_locale(:gb, :es).should match_normalized("Reino Unido")
+    end
+
+    it "should work with Traditional Chinese" do
+      Territories.from_territory_code_for_locale(:US, :"zh-Hant").should match_normalized("美國")
+    end
+  end
+
+  describe "#from_territory_code" do
+    it "should return the language in the default locale for the given locale code" do
+      Territories.from_territory_code(:ES).should match_normalized("Spain")
+      Territories.from_territory_code(:RU).should match_normalized("Russia")
+      TwitterCldr.locale = :es
+      Territories.from_territory_code(:ES).should match_normalized("España")
+    end
+  end
+
+  describe "#all_for" do
+    it "should return a hash of all languages for the given language code" do
+      territories = Territories.all_for(:es)
+      territories.should be_a(Hash)
+      territories[:ru].should match_normalized("Rusia")
+    end
+
+    it "should return an empty hash for an invalid language" do
+      territories = Territories.all_for(:blarg)
+      territories.should == {}
+    end
+  end
+
+  describe "#all" do
+    it "should use the default language to get the language hash" do
+      territories = Territories.all
+      territories.should be_a(Hash)
+      territories[:ru].should match_normalized("Russia")
+      territories[:de].should match_normalized("Germany")
+
+      TwitterCldr.locale = :es
+      territories = Territories.all
+      territories.should be_a(Hash)
+      territories[:ru].should match_normalized("Rusia")
+      territories[:de].should match_normalized("Alemania")
+    end
+  end
+
+  describe "the lack of knowledge about three-digit UN area codes" do
+    it "should not be able to translate three-digit UN area codes" do
+      Territories.translate_territory("Southern Africa", :en, :es).should == nil
+    end
+
+    it "should not be able to name three-digit UN area codes" do
+      Territories.from_territory_code_for_locale(:"18", :es).should == nil
+    end
+  end
+
+end
+

data/spec/spec_helper.rb

@@ -21,8 +21,22 @@ class FastGettext
       @@locale
     end
 
-    def locale=(value)
-      @@locale = value
+    def locale=(new_locale)
+      @@locale = new_locale
+    end
+  end
+end
+
+class I18n
+  class << self
+    @@locale = :en
+
+    def locale
+      @@locale
+    end
+
+    def locale=(new_locale)
+      @@locale = new_locale
     end
   end
 end
@@ -35,7 +49,10 @@ RSpec.configure do |config|
   config.filter_run_excluding(:slow => true) unless ENV['FULL_SPEC']
 
   config.before(:each) do
+    TwitterCldr.reset_locale_fallbacks
+    TwitterCldr.locale = :en
     FastGettext.locale = :en
+    I18n.locale = :en
   end
 end
 

data/spec/twitter_cldr_spec.rb

@@ -62,17 +62,242 @@ describe TwitterCldr do
     end
   end
 
-  describe "#get_locale" do
-    context "with FastGettext locale" do
-      it "should return the FastGettext locale" do
-        mock(FastGettext).locale { "es" }
-        TwitterCldr.get_locale.should == :es
+  describe "#locale" do
+    context "with explicit locale" do
+      it "should return the same locale the user sets (if it's supported)" do
+        TwitterCldr.locale = :es
+        TwitterCldr.locale.should == :es
       end
 
-      it "should return the default locale if the FastGettext locale is unsupported" do
-        mock(FastGettext).locale { "bogus" }
-        TwitterCldr.get_locale.should == TwitterCldr::DEFAULT_LOCALE
+      it "should convert strings to symbols" do
+        TwitterCldr.locale = "es"
+        TwitterCldr.locale.should == :es
       end
+
+      it "should fall back if the user sets an unsupported locale" do
+        FastGettext.locale = :ko
+        TwitterCldr.locale = "blarg"
+        TwitterCldr.locale.should == :ko
+
+        FastGettext.locale = nil
+        I18n.locale = :hu
+        TwitterCldr.locale.should == :hu
+      end
+    end
+
+    context "with implicit locale (fallbacks)" do
+      before(:each) do
+        TwitterCldr.locale = nil
+      end
+
+      it "should return FastGettext locale before I18n locale and fall back gracefully" do
+        FastGettext.locale = :pt
+        I18n.locale = :ar
+        TwitterCldr.locale.should == :pt
+
+        FastGettext.locale = nil
+        TwitterCldr.locale.should == :ar
+
+        I18n.locale = nil
+        TwitterCldr.locale.should == :en
+      end
+
+      context "with only FastGettext locale" do
+        before(:each) do
+          I18n.locale = nil  # disable I18n fallback
+        end
+
+        it "should return the FastGettext locale if it's supported" do
+          FastGettext.locale = "vi"
+          TwitterCldr.locale.should == :vi
+        end
+
+        it "should return the default locale if the FastGettext locale is unsupported" do
+          FastGettext.locale = "bogus"
+          TwitterCldr.locale.should == TwitterCldr::DEFAULT_LOCALE
+        end
+      end
+
+      context "with only I18n locale" do
+        before(:each) do
+          FastGettext.locale = nil  # disable FastGettext fallback
+        end
+
+        it "should return the I18n locale if it's supported" do
+          I18n.locale = "ru"
+          TwitterCldr.locale.should == :ru
+        end
+
+        it "should return the default locale if the I18n locale is unsupported" do
+          I18n.locale = "bogus"
+          TwitterCldr.locale.should == TwitterCldr::DEFAULT_LOCALE
+        end
+      end
+
+      context "with a custom fallback" do
+        before(:each) do
+          @allow = false
+          TwitterCldr.register_locale_fallback(lambda { @allow ? :uk : nil })
+        end
+
+        it "should fall back to the custom locale" do
+          TwitterCldr.locale.should == :en
+          @allow = true
+          TwitterCldr.locale.should == :uk
+        end
+
+        it "should fall back to the next fallback option if the custom one returns nil" do
+          FastGettext.locale = :lv
+          TwitterCldr.locale.should == :lv
+          @allow = true
+          TwitterCldr.locale.should == :uk
+        end
+
+        it "should not return the fallback locale if it's unsupported" do
+          TwitterCldr.reset_locale_fallbacks
+          TwitterCldr.register_locale_fallback(lambda { :zzz })
+          TwitterCldr.locale.should == :en
+        end
+      end
+
+      it "should fall back if the user sets an unsupported locale" do
+        FastGettext.locale = :ko
+        TwitterCldr.locale = "blarg"
+        TwitterCldr.locale.should == :ko
+
+        FastGettext.locale = nil
+        I18n.locale = :hu
+        TwitterCldr.locale.should == :hu
+      end
+    end
+
+    context "with implicit locale (fallbacks)" do
+      before(:each) do
+        TwitterCldr.locale = nil
+      end
+
+      it "should return FastGettext locale before I18n locale and fall back gracefully" do
+        FastGettext.locale = :pt
+        I18n.locale = :ar
+        TwitterCldr.locale.should == :pt
+
+        FastGettext.locale = nil
+        TwitterCldr.locale.should == :ar
+
+        I18n.locale = nil
+        TwitterCldr.locale.should == :en
+      end
+
+      context "with only FastGettext locale" do
+        before(:each) do
+          I18n.locale = nil  # disable I18n fallback
+        end
+
+        it "should return the FastGettext locale if it's supported" do
+          FastGettext.locale = "vi"
+          TwitterCldr.locale.should == :vi
+        end
+
+        it "should return the default locale if the FastGettext locale is unsupported" do
+          FastGettext.locale = "bogus"
+          TwitterCldr.locale.should == TwitterCldr::DEFAULT_LOCALE
+        end
+      end
+
+      context "with only I18n locale" do
+        before(:each) do
+          FastGettext.locale = nil  # disable FastGettext fallback
+        end
+
+        it "should return the I18n locale if it's supported" do
+          I18n.locale = "ru"
+          TwitterCldr.locale.should == :ru
+        end
+
+        it "should return the default locale if the I18n locale is unsupported" do
+          I18n.locale = "bogus"
+          TwitterCldr.locale.should == TwitterCldr::DEFAULT_LOCALE
+        end
+      end
+
+      context "with a custom fallback" do
+        before(:each) do
+          @allow = false
+          TwitterCldr.register_locale_fallback(lambda { @allow ? :uk : nil })
+        end
+
+        it "should fall back to the custom locale" do
+          TwitterCldr.locale.should == :en
+          @allow = true
+          TwitterCldr.locale.should == :uk
+        end
+
+        it "should fall back to the next fallback option if the custom one returns nil" do
+          FastGettext.locale = :lv
+          TwitterCldr.locale.should == :lv
+          @allow = true
+          TwitterCldr.locale.should == :uk
+        end
+
+        it "should not return the fallback locale if it's unsupported" do
+          TwitterCldr.reset_locale_fallbacks
+          TwitterCldr.register_locale_fallback(lambda { :zzz })
+          TwitterCldr.locale.should == :en
+        end
+      end
+    end
+  end
+
+  describe "#with_locale" do
+    it "should only change the locale in the context of the block" do
+      TwitterCldr::Shared::Languages.from_code(:es).should == "Spanish"
+      TwitterCldr.with_locale(:es) { TwitterCldr::Shared::Languages.from_code(:es) }.should match_normalized("español")
+      TwitterCldr::Shared::Languages.from_code(:es).should == "Spanish"
+    end
+
+    it "switches the locale back to the original if the block raises an error" do
+      TwitterCldr.locale.should == :en
+      locale_inside_block = nil
+
+      lambda do
+        TwitterCldr.with_locale(:es) do
+          locale_inside_block = TwitterCldr.locale
+          raise "Error!"
+        end
+      end.should raise_error
+
+      locale_inside_block.should == :es
+      TwitterCldr.locale.should == :en
+    end
+  end
+
+  describe "#with_locale" do
+    it "should only change the locale in the context of the block" do
+      TwitterCldr::Shared::Languages.from_code(:es).should == "Spanish"
+      TwitterCldr.with_locale(:es) { TwitterCldr::Shared::Languages.from_code(:es) }.should match_normalized("español")
+      TwitterCldr::Shared::Languages.from_code(:es).should == "Spanish"
+    end
+
+    it "doesn't mess up if the given locale isn't supported" do
+      TwitterCldr.locale = :pt
+      TwitterCldr.locale.should == :pt
+      lambda { TwitterCldr.with_locale(:xx) {} }.should raise_error
+      TwitterCldr.locale.should == :pt
+    end
+
+    it "switches the locale back to the original if the block raises an error" do
+      TwitterCldr.locale.should == :en
+      locale_inside_block = nil
+
+      lambda do
+        TwitterCldr.with_locale(:es) do
+          locale_inside_block = TwitterCldr.locale
+          raise "Error!"
+        end
+      end.should raise_error
+
+      locale_inside_block.should == :es
+      TwitterCldr.locale.should == :en
     end
   end
 
@@ -104,4 +329,4 @@ describe TwitterCldr do
       TwitterCldr.get_locale_resource(:de, :numbers).should == 'result'
     end
   end
-end
+end

data/spec/utils/territories_spec.rb

@@ -0,0 +1,16 @@
+# encoding: UTF-8
+
+# Copyright 2012 Twitter, Inc
+# http://www.apache.org/licenses/LICENSE-2.0
+
+require 'spec_helper'
+
+describe TwitterCldr::Utils::Territories do
+  describe "#deep_normalize_territory_code_keys" do
+    TwitterCldr::Utils::Territories.deep_normalize_territory_code_keys(
+      { "is" => [ { "US" => "United States",
+                    5 => "Suður-Ameríka" },
+                  { "009" => "Eyjaálfa" } ] }
+    ).should == { :is => [ { :us => "United States" }, { } ] }
+  end
+end

data/spec/utils_spec.rb

@@ -97,4 +97,4 @@ describe TwitterCldr::Utils do
       TwitterCldr::Utils.traverse_hash(42, [:foo, :bar]).should be_nil
     end
   end
-end
+end