twitter4r 0.3.0 → 0.3.1

data/spec/twitter/client/search_spec.rb

@@ -0,0 +1,68 @@
+require File.join(File.dirname(__FILE__), '..', '..', 'spec_helper')
+
+describe Twitter::Client, "#search" do
+  before(:each) do
+    @twitter = client_context
+    @uris = Twitter::Client.class_eval("@@SEARCH_URIS")
+    @request = mas_net_http_get(:basic_auth => nil)
+    @response = mas_net_http_response(:success, "{\"results\": [], \"refresh_url\":\"?since_id=1768746401&q=blabla\"}")
+    @connection = mas_net_http(@response)
+    Net::HTTP.stub!(:new).and_return(@connection)
+    @statuses = []
+    Twitter::Status.stub!(:unmarshal).and_return(@statuses)
+    @page = 2
+    @keywords = "twitter4r"
+    @to = "SusanPotter"
+    @from = "twitter4r"
+  end
+  
+  it "should create expected HTTP GET request using :to" do
+    @twitter.should_receive(:create_http_get_request).with(@uris[:basic], {:to => @to}).and_return(@request)
+    @twitter.search(:to => @to)
+  end
+  
+  it "should bless the Array returned from Twitter for :to case" do
+    @twitter.should_receive(:bless_models).with(@statuses).and_return(@statuses)
+    @twitter.search(:to => @to)
+  end
+  
+  it "should create expected HTTP GET request using :from" do
+    @twitter.should_receive(:create_http_get_request).with(@uris[:basic], {:from => @from}).and_return(@request)
+    @twitter.search(:from => @from)
+  end
+  
+  it "should bless the Array returned from Twitter for :to case" do
+    @twitter.should_receive(:bless_models).with(@statuses).and_return(@statuses)
+    @twitter.search(:from => @from)
+  end
+  
+  it "should create expected HTTP GET request using :keywords" do
+    @twitter.should_receive(:create_http_get_request).with(@uris[:basic], {:keywords => @keywords}).and_return(@request)
+    @twitter.search(:keywords => @keywords)
+  end
+  
+  it "should bless the Array returned from Twitter for :keywords case" do
+    @twitter.should_receive(:bless_models).with(@statuses).and_return(@statuses)
+    @twitter.search(:keywords => @keywords)
+  end
+  
+  it "should accept paging option" do
+    lambda {
+      @twitter.search(:keywords => @keywords, :page => @page)
+    }.should_not raise_error(Exception)
+  end
+
+  it "should generate expected GET HTTP request for paging case" do
+    @twitter.should_receive(:create_http_get_request).with(@uris[:basic], {:page => @page}).and_return(@request)
+    @twitter.search(:page => @page)
+  end
+
+  it "should bless models for paging case" do
+    @twitter.should_receive(:bless_models).with(@statuses).and_return(@statuses)
+    @twitter.search(:page => @page)
+  end
+  
+  after(:each) do
+    nilize(@twitter, @uris, @request, @response, @connection, @statuses)
+  end
+end

data/spec/twitter/client/status_spec.rb

@@ -11,6 +11,7 @@ describe Twitter::Client, "#status" do
     @connection = mas_net_http(@response)
     @float = 43.3434
     @status = Twitter::Status.new(:id => 2349343)
+    @reply_to_status_id = 3495293
     @source = Twitter::Client.class_eval("@@defaults[:source]")
   end
 
@@ -55,6 +56,32 @@ describe Twitter::Client, "#status" do
     @twitter.status(:post, @message)
   end
   
+  it "should return nil if no :status key-value given in the value argument for :reply case" do
+    status = @twitter.status(:reply, {})
+    status.should be_nil
+  end
+  
+  it "should return nil if nil is passed as value argument for :reply case" do
+    status = @twitter.status(:reply, nil)
+    status.should be_nil
+  end
+  
+  it "should not call @twitter#http_connect when passing a value Hash argument that has no :status key-value in :reply case" do
+    @twitter.should_not_receive(:http_connect)
+    @twitter.status(:reply, {})
+  end
+  
+  it "should not call @twitter#http_connect when passing nil for value argument in :reply case" do
+    @twitter.should_not_receive(:http_connect)
+    @twitter.status(:reply, nil)
+  end
+  
+  it "should create expected HTTP POST request for :reply case" do
+    @twitter.should_receive(:create_http_post_request).with(@uris[:reply]).and_return(@request)
+    @connection.should_receive(:request).with(@request, {:status => @message, :source => @source, :in_reply_to_status_id => @reply_to_status_id}.to_http_str).and_return(@response)
+    @twitter.status(:reply, :status => @message, :in_reply_to_status_id => @reply_to_status_id)
+  end
+  
   it "should return nil if nil is passed as value argument for :delete case" do
     status = @twitter.status(:delete, nil)
     status.should be_nil

data/spec/twitter/client/user_spec.rb

@@ -1,22 +1,5 @@
 require File.join(File.dirname(__FILE__), '..', '..', 'spec_helper')
 
-describe Twitter::Client, "#user(id, :followers)" do
-  before(:each) do
-    @twitter = client_context    
-    @id = 395783
-  end
-  
-  it "should raise ArgumentError" do
-    lambda {
-      @twitter.user(@id, :followers)
-    }.should raise_error(ArgumentError)
-  end
-  
-  after(:each) do
-    nilize(@twitter, @id)
-  end
-end
-
 describe Twitter::Client, "#user(id, :info)" do
   before(:each) do
     @twitter = client_context

data/spec/twitter/ext/stdlib_spec.rb

@@ -3,9 +3,9 @@ require File.join(File.dirname(__FILE__), '..', '..', 'spec_helper')
 describe Hash, "#to_http_str" do
   before(:each) do
     @http_params = {:id => 'otherlogin', :since_id => 3953743, :full_name => 'Lucy Cross'}
-    @id_regexp = Regexp.new("id=#{URI.encode(@http_params[:id].to_s)}")
-    @since_id_regexp = Regexp.new("since_id=#{URI.encode(@http_params[:since_id].to_s)}")
-    @full_name_regexp = Regexp.new("full_name=#{URI.encode(@http_params[:full_name].to_s)}")
+    @id_regexp = Regexp.new("id=#{CGI.escape(@http_params[:id].to_s)}")
+    @since_id_regexp = Regexp.new("since_id=#{CGI.escape(@http_params[:since_id].to_s)}")
+    @full_name_regexp = Regexp.new("full_name=Lucy\\+Cross")
   end
   
   it "should generate expected URL encoded string" do
@@ -40,3 +40,20 @@ describe Time, "#to_s" do
     nilize(@time, @expected_string)
   end
 end
+
+# TODO: figure out how to stub the gem method to do what we want rather than this monstrousity.  It is dependent on the system installation, which is always a bad thing.  For now it will do so we can ship with 100% C0 coverage.
+describe Kernel, "#gem_present?" do
+  before(:each) do
+    @present_gem = "rake"
+    @uninstalled_gem = "uninstalled-gem-crap"
+  end
+  
+  it "should return true when a gem isn't present on system" do
+    gem_present?(@present_gem).should eql(true)
+  end
+  
+  it "should return false when a gem isn't present on system" do
+    gem_present?(@uninstalled_gem).should eql(false)
+  end
+end
+

data/spec/twitter/model_spec.rb

@@ -194,30 +194,6 @@ describe Twitter::User, "#is_me?" do
   end
 end
 
-describe Twitter::User, "#bless(client)" do
-  before(:each) do
-    @twitter = Twitter::Client.from_config('config/twitter.yml')
-    @user_not_me = Twitter::User.new(:screen_name => 'notmylogin')
-    @user_me = Twitter::User.new(:screen_name => @twitter.instance_eval("@login"))
-  end
-  
-  it "should add a followers method" do
-    @user_me.should_not respond_to?(:followers)
-    @user_me.bless(@twitter)
-    @user_me.should respond_to?(:followers)
-  end
-  
-  it "should not add a followers method" do
-    @user_not_me.should_not respond_to?(:followers)
-    @user_not_me.bless(@twitter)
-    @user_not_me.should_not respond_to?(:followers)
-  end
-  
-  after(:each) do
-    nilize(@twitter, @user_not_me, @user_me)
-  end
-end
-
 describe Twitter::User, "#friends" do
   before(:each) do
     @twitter = Twitter::Client.from_config('config/twitter.yml')
@@ -245,7 +221,7 @@ describe Twitter::User, "#followers" do
   end
   
   it "should delegate to @client.my(:followers)" do
-    @twitter.should_receive(:my).with(:followers)
+    @twitter.should_receive(:my).with(:followers, {})
     @user.followers
   end
   
@@ -457,9 +433,53 @@ describe Twitter::User, "#defriend" do
   end
 end
 
+describe Twitter::Status, "#reply?" do
+  before(:each) do
+    @status = Twitter::Status.new(
+      :id => 123456789,
+      :text => "Wazzup?", 
+      :user => mock(Twitter::User)
+    )
+    @reply = Twitter::Status.new(
+      :text => "No much bro.  You?",
+      :user => mock(Twitter::User),
+      :in_reply_to_status_id => @status.id
+    )
+  end
+
+  it "should return false for the original status" do
+    @status.reply?.should be(false)
+  end
+
+  it "should return true for the reply to the original status" do
+    @reply.reply?.should be(true)
+  end
+end
+
+describe Twitter::Status, "#reply(status_text)" do
+  before(:each) do
+    @twitter = client_context
+    @status = Twitter::Status.new(
+        :id => 1234,
+        :text => "The status text",
+        :client => @twitter)
+    @reply_text = "Reply text goes here"
+    @reply_status = Twitter::Status.new()
+  end
+
+  it "should invoke #status(:reply, :status => ..., :in_reply_to_status_id => ...) on client context" do
+    @twitter.should_receive(:status).with(:reply, :status => @reply_text, :in_reply_to_status_id => @status.id).and_return(@reply_status)
+    @status.reply(@reply_text)
+  end
+
+  after(:each) do
+    nilize(@twitter, @status)
+  end 
+end
+
 describe Twitter::Status, "#to_s" do
   before(:each) do
-	  @text = 'Aloha'
+    @text = 'Aloha'
     @status = Twitter::Status.new(:text => @text)
   end
   

metadata

@@ -1,93 +1,118 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.4
-specification_version: 1
 name: twitter4r
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
-date: 2007-11-05 00:00:00 -06:00
-summary: A clean Twitter client API in pure Ruby. Will include Twitter add-ons also in Ruby.
-require_paths: 
-- lib
-email: twitter4r-users@googlegroups.com
-homepage: http://twitter4r.rubyforge.org
-rubyforge_project: twitter4r
-description: 
-autorequire: twitter
-default_executable: 
-bindir: bin
-has_rdoc: true
-required_ruby_version: !ruby/object:Gem::Version::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: 1.8.2
-  version: 
+  version: 0.3.1
 platform: ruby
-signing_key: 
-cert_chain: 
-post_install_message: 
 authors: 
 - Susan Potter
+autorequire: twitter
+bindir: bin
+cert_chain: []
+
+date: 2009-05-11 00:00:00 -05:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: json
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.1.1
+    version: 
+description: 
+email: twitter4r-users@googlegroups.com
+executables: []
+
+extensions: []
+
+extra_rdoc_files: 
+- README
+- CHANGES
+- TODO
+- MIT-LICENSE
 files: 
-- lib/twitter/extras.rb
+- lib/twitter.rb
 - lib/twitter/config.rb
-- lib/twitter/core.rb
+- lib/twitter/model.rb
+- lib/twitter/ext/stdlib.rb
+- lib/twitter/ext.rb
+- lib/twitter/meta.rb
+- lib/twitter/client.rb
+- lib/twitter/console.rb
+- lib/twitter/client/graph.rb
+- lib/twitter/client/blocks.rb
+- lib/twitter/client/profile.rb
+- lib/twitter/client/status.rb
 - lib/twitter/client/timeline.rb
-- lib/twitter/client/messaging.rb
-- lib/twitter/client/base.rb
 - lib/twitter/client/favorites.rb
-- lib/twitter/client/status.rb
+- lib/twitter/client/account.rb
+- lib/twitter/client/base.rb
+- lib/twitter/client/messaging.rb
 - lib/twitter/client/friendship.rb
-- lib/twitter/client/auth.rb
+- lib/twitter/client/search.rb
 - lib/twitter/client/user.rb
-- lib/twitter/rails.rb
-- lib/twitter/client.rb
-- lib/twitter/console.rb
+- lib/twitter/client/auth.rb
 - lib/twitter/version.rb
-- lib/twitter/model.rb
-- lib/twitter/meta.rb
-- lib/twitter/ext.rb
-- lib/twitter/ext/stdlib.rb
-- lib/twitter.rb
-- spec/twitter/config_spec.rb
-- spec/twitter/core_spec.rb
+- lib/twitter/extras.rb
+- lib/twitter/core.rb
+- spec/twitter/client_spec.rb
+- spec/twitter/ext/stdlib_spec.rb
+- spec/twitter/console_spec.rb
+- spec/twitter/version_spec.rb
 - spec/twitter/model_spec.rb
+- spec/twitter/config_spec.rb
+- spec/twitter/client/messaging_spec.rb
+- spec/twitter/client/friendship_spec.rb
+- spec/twitter/client/graph_spec.rb
+- spec/twitter/client/base_spec.rb
+- spec/twitter/client/favorites_spec.rb
+- spec/twitter/client/account_spec.rb
 - spec/twitter/client/status_spec.rb
+- spec/twitter/client/search_spec.rb
+- spec/twitter/client/blocks_spec.rb
 - spec/twitter/client/timeline_spec.rb
 - spec/twitter/client/auth_spec.rb
 - spec/twitter/client/user_spec.rb
-- spec/twitter/client/messaging_spec.rb
-- spec/twitter/client/base_spec.rb
-- spec/twitter/client/favorites_spec.rb
-- spec/twitter/client/friendship_spec.rb
-- spec/twitter/version_spec.rb
-- spec/twitter/rails_spec.rb
-- spec/twitter/client_spec.rb
-- spec/twitter/meta_spec.rb
-- spec/twitter/console_spec.rb
+- spec/twitter/client/profile_spec.rb
 - spec/twitter/extras_spec.rb
-- spec/twitter/ext/stdlib_spec.rb
-test_files: []
+- spec/twitter/meta_spec.rb
+- spec/twitter/core_spec.rb
+- README
+- CHANGES
+- TODO
+- MIT-LICENSE
+has_rdoc: true
+homepage: http://twitter4r.rubyforge.org
+licenses: []
 
+post_install_message: 
 rdoc_options: []
 
-extra_rdoc_files: []
-
-executables: []
-
-extensions: []
-
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: 1.8.2
+  version: 
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
 requirements: 
 - Ruby 1.8.4+
 - json gem, version 0.4.3 or higher
 - jcode (for unicode support)
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: json
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Version::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: 0.4.3
-    version: 
+rubyforge_project: twitter4r
+rubygems_version: 1.3.2
+signing_key: 
+specification_version: 3
+summary: A clean Twitter client API in pure Ruby. Will include Twitter add-ons also in Ruby.
+test_files: []
+

data/lib/twitter/rails.rb

@@ -1,89 +0,0 @@
-# File that contains extensions to the Twitter4R library directly related to providing
-# seamless Rails integration.
-
-require 'active_support'
-#require 'active_support/core_ext'
-require 'active_record/xml_serialization'
-
-# Extend +String+ with +#xmlize+ method for convenience.
-class String
-  def xmlize
-    # Forget module/namespace for now as this is totally broken in Rails 1.2.x 
-    # (search for namespaced models on the Rails Trac site)
-    cls = self.split('::').pop
-    cls.dasherize.downcase
-  end
-end
-
-# Parent mixin module that defines +InstanceMethods+ for Twitter4R model classes.
-# 
-# Defines/overrides the following methods for:
-# * Twitter::RailsPatch::InstanceMethods#to_param
-# * Twitter::RailsPatch::InstanceMethods#to_xml
-# * Twitter::RailsPatch::InstanceMethods#to_json
-module Twitter::RailsPatch
-  class << self
-    def included(base)
-      base.send(:include, InstanceMethods)
-      base.extend ClassMethods
-    end
-
-    module ClassMethods
-      # Dummy method to satisfy ActiveRecord's XmlSerializer.
-      def inheritance_column
-        nil
-      end
-      
-      # Returns Hash of name-column pairs
-      def columns_hash
-        {}
-      end      
-    end
-    
-    module InstanceMethods
-      # Returns an Array of attribute names of the model
-      def attribute_names
-        self.class.class_eval("@@ATTRIBUTES").collect {|att| att.to_s }
-      end
-      
-      # Override default +#to_param+ implementation.
-      def to_param
-        self.id.to_s
-      end
-
-      # Returns XML representation of model.      
-      def to_xml(options = {})
-        ActiveRecord::XmlSerializer.new(self, options.merge(:root => self.class.name.xmlize)).to_s
-      end
-      
-      # Returns JSON representation of model.
-      # 
-      # The current implementation basically ignoring +options+, so reopen and override 
-      # this implementation or live with it for the moment:)
-      def to_json(options = {})
-        JSON.unparse(self.to_hash)
-      end
-    end
-  end
-end
-
-class Twitter::User
-  include Twitter::RailsPatch
-end
-
-class Twitter::Status
-  include Twitter::RailsPatch
-end
-
-class Twitter::Message
-  include Twitter::RailsPatch
-end
-
-class Twitter::RESTError
-  include Twitter::RailsPatch
-  alias :id :code
-  def to_hash
-    { :code => @code, :message => @message, :uri => @uri }
-  end
-end
-

data/spec/twitter/rails_spec.rb

@@ -1,110 +0,0 @@
-require File.join(File.dirname(__FILE__), '..', 'spec_helper')
-
-describe String, "representing a class name" do
-
-  before(:each) do
-    @class_name = Twitter::User.class.name
-    @xmlized_name = @class_name.downcase # simple case for the moment...since Rails' support for namespaced models sucks!
-  end
-
-  it "should be downcased (minus module namespaces) when xmlized" do
-    @class_name.xmlize.should eql(@xmlized_name)
-  end
-
-  after(:each) do
-    nilize(@class_name, @xmlized_name)
-  end  
-end
-
-describe "Rails model extensions for model classes", :shared => true do
-
-  before(:each) do
-    @id = 3242334
-    @id_s = @id.to_s
-    @model = model(@id)
-    @model_hash = @model.to_hash
-    @json = JSON.unparse(@model_hash)
-    @serializer = ActiveRecord::XmlSerializer.new(@model, {:root => @model.class.name.downcase})
-    @xml = @serializer.to_s
-  end
-
-  it "should invoke #to_param as expected" do
-    @model.should_receive(:id).and_return(@id)
-    @model.to_param
-  end
-  
-  it "should return string representation for id for #to_param" do
-    @model.to_param.class.should eql(String)
-  end
-  
-  it "should return output from JSON.unparse for #to_json" do
-    @model.should_receive(:to_hash).and_return(@model_hash)
-    JSON.should_receive(:unparse).and_return(@json)
-    @model.to_json
-  end
-  
-  it "should return XmlSerializer string output for #to_xml" do
-    ActiveRecord::XmlSerializer.should_receive(:new).and_return(@serializer)
-    @serializer.should_receive(:to_s).and_return(@xml)
-    @model.to_xml
-  end
-  
-  after(:each) do
-    nilize(@id, @model)
-  end
-end
-
-describe Twitter::User, "Rails extensions" do
-
-  def model(id)
-    Twitter::User.new(:id => id)
-  end
-
-  it_should_behave_like "Rails model extensions for model classes"
-end
-
-describe Twitter::Status, "Rails extensions" do
-
-  def model(id)
-    Twitter::Status.new(:id => id)
-  end
-
-  it_should_behave_like "Rails model extensions for model classes"
-end
-
-describe Twitter::Message, "Rails extensions" do
-
-  def model(id)
-    Twitter::Message.new(:id => id)
-  end
-
-  it_should_behave_like "Rails model extensions for model classes"
-end
-
-describe Twitter::RESTError, "Rails extensions" do
-  
-  before(:each) do
-    @attributes = { :code => 200, :message => 'Success', :uri => 'http://twitter.com/statuses' }
-    @model = Twitter::RESTError.new(@attributes)
-    @json = "JSON" # doesn't really matter what the value is
-  end
-  
-  it "should return a Hash of attribute name-value pairs for #to_hash" do
-    @model.to_hash.should === @attributes
-  end
-
-  it "should invoke XmlSerializer for #to_xml" do
-    
-    @model.to_xml
-  end
-
-  it "should return expected JSON for #to_json" do
-    @model.to_hash
-    JSON.should_receive(:unparse).and_return(@json)
-    @model.to_json
-  end
-
-  after(:each) do
-    nilize(@attributes, @model)
-  end  
-end