twitter 6.2.0 → 8.0.0.rc.1

data/lib/twitter/rest/api.rb

@@ -1,32 +1,38 @@
-require 'twitter/rest/direct_messages'
-require 'twitter/rest/favorites'
-require 'twitter/rest/friends_and_followers'
-require 'twitter/rest/help'
-require 'twitter/rest/lists'
-require 'twitter/rest/oauth'
-require 'twitter/rest/places_and_geo'
-require 'twitter/rest/saved_searches'
-require 'twitter/rest/search'
-require 'twitter/rest/spam_reporting'
-require 'twitter/rest/suggested_users'
-require 'twitter/rest/timelines'
-require 'twitter/rest/trends'
-require 'twitter/rest/tweets'
-require 'twitter/rest/undocumented'
-require 'twitter/rest/users'
+require "twitter/rest/account_activity"
+require "twitter/rest/direct_messages"
+require "twitter/rest/direct_messages/welcome_messages"
+require "twitter/rest/favorites"
+require "twitter/rest/friends_and_followers"
+require "twitter/rest/help"
+require "twitter/rest/lists"
+require "twitter/rest/oauth"
+require "twitter/rest/places_and_geo"
+require "twitter/rest/saved_searches"
+require "twitter/rest/search"
+require "twitter/rest/premium_search"
+require "twitter/rest/spam_reporting"
+require "twitter/rest/suggested_users"
+require "twitter/rest/timelines"
+require "twitter/rest/trends"
+require "twitter/rest/tweets"
+require "twitter/rest/undocumented"
+require "twitter/rest/users"
 
 module Twitter
   module REST
     # @note All methods have been separated into modules and follow the same grouping used in {http://dev.twitter.com/doc the Twitter API Documentation}.
     # @see https://dev.twitter.com/overview/general/things-every-developer-should-know
     module API
+      include Twitter::REST::AccountActivity
       include Twitter::REST::DirectMessages
+      include Twitter::REST::DirectMessages::WelcomeMessages
       include Twitter::REST::Favorites
       include Twitter::REST::FriendsAndFollowers
       include Twitter::REST::Help
       include Twitter::REST::Lists
       include Twitter::REST::OAuth
       include Twitter::REST::PlacesAndGeo
+      include Twitter::REST::PremiumSearch
       include Twitter::REST::SavedSearches
       include Twitter::REST::Search
       include Twitter::REST::SpamReporting

data/lib/twitter/rest/client.rb

@@ -1,7 +1,7 @@
-require 'twitter/client'
-require 'twitter/rest/api'
-require 'twitter/rest/request'
-require 'twitter/rest/utils'
+require "twitter/client"
+require "twitter/rest/api"
+require "twitter/rest/request"
+require "twitter/rest/utils"
 
 module Twitter
   module REST

data/lib/twitter/rest/direct_messages/welcome_messages.rb

@@ -0,0 +1,90 @@
+require "twitter/arguments"
+require "twitter/rest/upload_utils"
+require "twitter/rest/utils"
+require "twitter/utils"
+
+module Twitter
+  module REST
+    module DirectMessages
+      module WelcomeMessages
+        include Twitter::REST::UploadUtils
+        include Twitter::REST::Utils
+        include Twitter::Utils
+
+        # Welcome Message
+
+        def create_welcome_message(text, name = nil, options = {})
+          json_options = {
+            welcome_message: {
+              message_data: {
+                text: text,
+              },
+            },
+          }
+          json_options[:welcome_message][:name] = name if name
+          welcome_message_wrapper = perform_request_with_object(:json_post, "/1.1/direct_messages/welcome_messages/new.json", json_options.merge!(options), Twitter::DirectMessages::WelcomeMessageWrapper)
+          welcome_message_wrapper.welcome_message
+        end
+
+        def destroy_welcome_message(*ids)
+          perform_requests(:delete, "/1.1/direct_messages/welcome_messages/destroy.json", ids)
+        end
+
+        def update_welcome_message(welcome_message_id, text, options = {})
+          params = {
+            id: welcome_message_id,
+          }
+          json_options = {
+            message_data: {
+              text: text,
+            },
+          }
+          welcome_message_wrapper = perform_request_with_object(:json_put, "/1.1/direct_messages/welcome_messages/update.json", json_options.merge!(options), Twitter::DirectMessages::WelcomeMessageWrapper, params)
+          welcome_message_wrapper.welcome_message
+        end
+
+        def welcome_message(id, options = {})
+          options = options.dup
+          options[:id] = id
+          welcome_message_wrapper = perform_get_with_object("/1.1/direct_messages/welcome_messages/show.json", options, Twitter::DirectMessages::WelcomeMessageWrapper)
+          welcome_message_wrapper.welcome_message
+        end
+
+        def welcome_message_list(options = {})
+          limit = options.fetch(:count, 20)
+          welcome_message_wrappers = perform_get_with_cursor("/1.1/direct_messages/welcome_messages/list.json", options.merge!(no_default_cursor: true, count: 50, limit: limit), :welcome_messages, Twitter::DirectMessages::WelcomeMessageWrapper)
+          welcome_message_wrappers.collect(&:welcome_message)
+        end
+
+        # Welcome Message Rule
+
+        def create_welcome_message_rule(welcome_message_id, options = {})
+          json_options = {
+            welcome_message_rule: {
+              welcome_message_id: welcome_message_id,
+            },
+          }
+          rule_wrapper = perform_request_with_object(:json_post, "/1.1/direct_messages/welcome_messages/rules/new.json", json_options.merge!(options), Twitter::DirectMessages::WelcomeMessageRuleWrapper)
+          rule_wrapper.welcome_message_rule
+        end
+
+        def destroy_welcome_message_rule(*ids)
+          perform_requests(:delete, "/1.1/direct_messages/welcome_messages/rules/destroy.json", ids)
+        end
+
+        def welcome_message_rule(id, options = {})
+          options = options.dup
+          options[:id] = id
+          rule_wrapper = perform_get_with_object("/1.1/direct_messages/welcome_messages/rules/show.json", options, Twitter::DirectMessages::WelcomeMessageRuleWrapper)
+          rule_wrapper.welcome_message_rule
+        end
+
+        def welcome_message_rule_list(options = {})
+          limit = options.fetch(:count, 20)
+          rule_wrappers = perform_get_with_cursor("/1.1/direct_messages/welcome_messages/rules/list.json", options.merge!(no_default_cursor: true, count: 50, limit: limit), :welcome_message_rules, Twitter::DirectMessages::WelcomeMessageRuleWrapper)
+          rule_wrappers.collect(&:welcome_message_rule)
+        end
+      end
+    end
+  end
+end

data/lib/twitter/rest/direct_messages.rb

@@ -1,65 +1,111 @@
-require 'twitter/arguments'
-require 'twitter/direct_message'
-require 'twitter/rest/utils'
-require 'twitter/user'
-require 'twitter/utils'
+require "twitter/arguments"
+require "twitter/direct_message"
+require "twitter/direct_message_event"
+require "twitter/rest/upload_utils"
+require "twitter/rest/utils"
+require "twitter/user"
+require "twitter/utils"
 
 module Twitter
   module REST
     module DirectMessages
+      include Twitter::REST::UploadUtils
       include Twitter::REST::Utils
       include Twitter::Utils
 
-      # Returns the 20 most recent direct messages sent to the authenticating user
-      #
-      # @see https://dev.twitter.com/rest/reference/get/direct_messages
+      # Returns all Direct Message events for the authenticated user (both sent and received) within the last 30 days. Sorted in reverse-chronological order.
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/list-events
+      # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
+      # @rate_limited Yes
+      # @authentication Requires user context
+      # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
+      # @return [Array<Twitter::DirectMessageEvent>] Direct message events sent by and received by the authenticating user.
+      # @param options [Hash] A customizable set of options.
+      # @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 50. Default is 20
+      # @option options [String] :cursor Specifies the cursor position of results to retrieve.
+      def direct_messages_events(options = {})
+        limit = options.fetch(:count, 20)
+        perform_get_with_cursor("/1.1/direct_messages/events/list.json", options.merge!(no_default_cursor: true, count: 50, limit: limit), :events, Twitter::DirectMessageEvent)
+      end
+
+      # Returns all Direct Messages for the authenticated user (both sent and received) within the last 30 days. Sorted in reverse-chronological order.
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/list-events
+      # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
+      # @rate_limited Yes
+      # @authentication Requires user context
+      # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
+      # @return [Array<Twitter::DirectMessage>] Direct messages sent by and received by the authenticating user.
+      # @param options [Hash] A customizable set of options.
+      # @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 50. Default is 20
+      # @option options [String] :cursor Specifies the cursor position of results to retrieve.
+      def direct_messages_list(options = {})
+        direct_messages_events(options).collect(&:direct_message)
+      end
+
+      # Returns Direct Messages received by the authenticated user within the last 30 days. Sorted in reverse-chronological order.
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/list-events
       # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
       # @rate_limited Yes
       # @authentication Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
-      # @return [Array<Twitter::DirectMessage>] Direct messages sent to the authenticating user.
+      # @return [Array<Twitter::DirectMessage>] Direct messages received by the authenticating user.
       # @param options [Hash] A customizable set of options.
-      # @option options [Integer] :since_id Returns results with an ID greater than (that is, more recent than) the specified ID.
-      # @option options [Integer] :max_id Returns results with an ID less than (that is, older than) or equal to the specified ID.
-      # @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 200.
-      # @option options [Integer] :page Specifies the page of results to retrieve.
+      # @option options [Integer] :count Specifies the number of records (sent and received dms) to retrieve. Must be less than or equal to 50. Default is 50
+      # this count does not directly correspond to the output, as we pull sent and received messages from twitter and only present received to the user
+      # @option options [String] :cursor Specifies the cursor position of results to retrieve.
       def direct_messages_received(options = {})
-        perform_get_with_objects('/1.1/direct_messages.json', options, Twitter::DirectMessage)
+        limit = options.fetch(:count, 20)
+        direct_messages_list(options).select { |dm| dm.recipient_id == user_id }.first(limit)
       end
 
-      # Returns the 20 most recent direct messages sent by the authenticating user
-      #
-      # @see https://dev.twitter.com/rest/reference/get/direct_messages/sent
+      # Returns Direct Messages sent by the authenticated user within the last 30 days. Sorted in reverse-chronological order.
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/list-events
       # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
       # @rate_limited Yes
       # @authentication Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
       # @return [Array<Twitter::DirectMessage>] Direct messages sent by the authenticating user.
       # @param options [Hash] A customizable set of options.
-      # @option options [Integer] :since_id Returns results with an ID greater than (that is, more recent than) the specified ID.
-      # @option options [Integer] :max_id Returns results with an ID less than (that is, older than) or equal to the specified ID.
-      # @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 200.
-      # @option options [Integer] :page Specifies the page of results to retrieve.
+      # @option options [Integer] :count Specifies the number of records (sent and received dms) to retrieve. Must be less than or equal to 50. Default is 50
+      # this count does not directly correspond to the output, as we pull sent and received messages from twitter and only present received to the user
+      # @option options [String] :cursor Specifies the cursor position of results to retrieve.
       def direct_messages_sent(options = {})
-        perform_get_with_objects('/1.1/direct_messages/sent.json', options, Twitter::DirectMessage)
+        limit = options.fetch(:count, 20)
+        direct_messages_list(options).select { |dm| dm.sender_id == user_id }.first(limit)
       end
 
       # Returns a direct message
       #
-      # @see https://dev.twitter.com/rest/reference/get/direct_messages/show
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/get-event
       # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
       # @rate_limited Yes
       # @authentication Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
-      # @return [Twitter::DirectMessage] The requested messages.
+      # @return [Twitter::DirectMessage] The requested message.
       # @param id [Integer] A direct message ID.
       # @param options [Hash] A customizable set of options.
+
       def direct_message(id, options = {})
+        direct_message_event(id, options).direct_message
+      end
+
+      # Returns a direct message event
+      #
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/get-event
+      # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
+      # @rate_limited Yes
+      # @authentication Requires user context
+      # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
+      # @return [Twitter::DirectMessageEvent] The requested message.
+      # @param id [Integer] A direct message ID.
+      # @param options [Hash] A customizable set of options.
+      def direct_message_event(id, options = {})
         options = options.dup
         options[:id] = id
-        perform_get_with_object('/1.1/direct_messages/show.json', options, Twitter::DirectMessage)
+        perform_get_with_object("/1.1/direct_messages/events/show.json", options, Twitter::DirectMessageEvent)
       end
 
+      # Returns direct messages specified in arguments, or, if no arguments are given, returns direct messages received by authenticating user
       # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
       # @rate_limited Yes
       # @authentication Requires user context
@@ -67,13 +113,12 @@ module Twitter
       # @return [Array<Twitter::DirectMessage>] The requested messages.
       # @overload direct_messages(options = {})
       #   Returns the 20 most recent direct messages sent to the authenticating user
-      #
-      #   @see https://dev.twitter.com/rest/reference/get/direct_messages
+
+      #   @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/list-events
       #   @param options [Hash] A customizable set of options.
-      #   @option options [Integer] :since_id Returns results with an ID greater than (that is, more recent than) the specified ID.
-      #   @option options [Integer] :max_id Returns results with an ID less than (that is, older than) or equal to the specified ID.
-      #   @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 200.
-      #   @option options [Integer] :page Specifies the page of results to retrieve.
+      #   @option options [Integer] :count Specifies the number of records (sent and received dms) to retrieve. Must be less than or equal to 50. Default is 50
+      #   this count does not directly correspond to the output, as we pull sent and received messages from twitter and only present received to the user
+      #   @option options [String] :cursor Specifies the cursor position of results to retrieve.
       # @overload direct_messages(*ids)
       #   Returns direct messages
       #
@@ -98,40 +143,84 @@ module Twitter
 
       # Destroys direct messages
       #
-      # @see https://dev.twitter.com/rest/reference/post/direct_messages/destroy
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/delete-message-event
       # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
-      # @rate_limited No
+      # @rate_limited Yes
       # @authentication Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
-      # @return [Array<Twitter::DirectMessage>] Deleted direct message.
+      # @return [nil] Response body from Twitter is nil if successful
       # @overload destroy_direct_message(*ids)
       #   @param ids [Enumerable<Integer>] A collection of direct message IDs.
-      # @overload destroy_direct_message(*ids, options)
-      #   @param ids [Enumerable<Integer>] A collection of direct message IDs.
-      #   @param options [Hash] A customizable set of options.
-      def destroy_direct_message(*args)
-        parallel_objects_from_response(Twitter::DirectMessage, :post, '/1.1/direct_messages/destroy.json', args)
+      def destroy_direct_message(*ids)
+        pmap(ids) do |id|
+          perform_requests(:delete, "/1.1/direct_messages/events/destroy.json", id: id)
+        end
+        nil
       end
 
       # Sends a new direct message to the specified user from the authenticating user
       #
-      # @see https://dev.twitter.com/rest/reference/post/direct_messages/new
-      # @rate_limited No
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/new-event
+      # @rate_limited Yes
       # @authentication Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
       # @return [Twitter::DirectMessage] The sent message.
-      # @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
+      # @param user [Integer, String, Twitter::User] A Twitter user ID
       # @param text [String] The text of your direct message, up to 10,000 characters.
       # @param options [Hash] A customizable set of options.
-      def create_direct_message(user, text, options = {})
-        options = options.dup
-        merge_user!(options, user)
-        options[:text] = text
-        perform_post_with_object('/1.1/direct_messages/new.json', options, Twitter::DirectMessage)
+      def create_direct_message(user_id, text, options = {})
+        event = perform_request_with_object(:json_post, "/1.1/direct_messages/events/new.json", format_json_options(user_id, text, options), Twitter::DirectMessageEvent)
+        event.direct_message
       end
       alias d create_direct_message
       alias m create_direct_message
       alias dm create_direct_message
+
+      # Create a new direct message event to the specified user from the authenticating user
+      #
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/new-event
+      # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
+      # @rate_limited Yes
+      # @authentication Requires user context
+      # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
+      # @return [Twitter::DirectMessageEvent] The created direct message event.
+      # @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
+      # @param text [String] The text of your direct message, up to 10,000 characters.
+      # @param options [Hash] A customizable set of options.
+      def create_direct_message_event(*args)
+        arguments = Twitter::Arguments.new(args)
+        options = arguments.options.dup
+        options[:event] = {type: "message_create", message_create: {target: {recipient_id: extract_id(arguments[0])}, message_data: {text: arguments[1]}}} if arguments.length >= 2
+        response = Twitter::REST::Request.new(self, :json_post, "/1.1/direct_messages/events/new.json", options).perform
+        Twitter::DirectMessageEvent.new(response[:event])
+      end
+
+      # Create a new direct message event to the specified user from the authenticating user with media
+      #
+      # @see https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/new-event
+      # @see https://developer.twitter.com/en/docs/direct-messages/message-attachments/guides/attaching-media
+      # @note This method requires an access token with RWD (read, write & direct message) permissions. Consult The Application Permission Model for more information.
+      # @rate_limited Yes
+      # @authentication Requires user context
+      # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
+      # @return [Twitter::DirectMessageEvent] The created direct message event.
+      # @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
+      # @param text [String] The text of your direct message, up to 10,000 characters.
+      # @param media [File] A media file (PNG, JPEG, GIF or MP4).
+      # @param options [Hash] A customizable set of options.
+      def create_direct_message_event_with_media(user, text, media, options = {})
+        media_id = upload(media, media_category_prefix: "dm")[:media_id]
+        options = options.dup
+        options[:event] = {type: "message_create", message_create: {target: {recipient_id: extract_id(user)}, message_data: {text: text, attachment: {type: "media", media: {id: media_id}}}}}
+        response = Twitter::REST::Request.new(self, :json_post, "/1.1/direct_messages/events/new.json", options).perform
+        Twitter::DirectMessageEvent.new(response[:event])
+      end
+
+    private
+
+      def format_json_options(user_id, text, options)
+        {event: {type: "message_create", message_create: {target: {recipient_id: user_id}, message_data: {text: text}.merge(options)}}}
+      end
     end
   end
 end

data/lib/twitter/rest/favorites.rb

@@ -1,9 +1,9 @@
-require 'twitter/arguments'
-require 'twitter/error'
-require 'twitter/rest/utils'
-require 'twitter/tweet'
-require 'twitter/user'
-require 'twitter/utils'
+require "twitter/arguments"
+require "twitter/error"
+require "twitter/rest/utils"
+require "twitter/tweet"
+require "twitter/user"
+require "twitter/utils"
 
 module Twitter
   module REST
@@ -20,19 +20,19 @@ module Twitter
       #   Returns the 20 most recent favorite Tweets for the authenticating user
       #
       #   @param options [Hash] A customizable set of options.
-      #   @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 100.
+      #   @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 200.
       #   @option options [Integer] :since_id Returns results with an ID greater than (that is, more recent than) the specified ID.
       # @overload favorites(user, options = {})
       #   Returns the 20 most recent favorite Tweets for the specified user
       #
       #   @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
       #   @param options [Hash] A customizable set of options.
-      #   @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 100.
+      #   @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 200.
       #   @option options [Integer] :since_id Returns results with an ID greater than (that is, more recent than) the specified ID.
       def favorites(*args)
         arguments = Twitter::Arguments.new(args)
         merge_user!(arguments.options, arguments.pop) if arguments.last
-        perform_get_with_objects('/1.1/favorites/list.json', arguments.options, Twitter::Tweet)
+        perform_get_with_objects("/1.1/favorites/list.json", arguments.options, Twitter::Tweet)
       end
 
       # Un-favorites the specified Tweets as the authenticating user
@@ -50,11 +50,9 @@ module Twitter
       def unfavorite(*args)
         arguments = Twitter::Arguments.new(args)
         pmap(arguments) do |tweet|
-          begin
-            perform_post_with_object('/1.1/favorites/destroy.json', arguments.options.merge(id: extract_id(tweet)), Twitter::Tweet)
-          rescue Twitter::Error::NotFound
-            next
-          end
+          perform_post_with_object("/1.1/favorites/destroy.json", arguments.options.merge(id: extract_id(tweet)), Twitter::Tweet)
+        rescue Twitter::Error::NotFound
+          next
         end.compact
       end
       alias destroy_favorite unfavorite
@@ -73,7 +71,7 @@ module Twitter
       #   @param tweets [Enumerable<Integer, String, URI, Twitter::Tweet>] A collection of Tweet IDs, URIs, or objects.
       #   @param options [Hash] A customizable set of options.
       def unfavorite!(*args)
-        parallel_objects_from_response(Twitter::Tweet, :post, '/1.1/favorites/destroy.json', args)
+        parallel_objects_from_response(Twitter::Tweet, :post, "/1.1/favorites/destroy.json", args)
       end
 
       # Favorites the specified Tweets as the authenticating user
@@ -91,11 +89,9 @@ module Twitter
       def favorite(*args)
         arguments = Twitter::Arguments.new(args)
         pmap(arguments) do |tweet|
-          begin
-            perform_post_with_object('/1.1/favorites/create.json', arguments.options.merge(id: extract_id(tweet)), Twitter::Tweet)
-          rescue Twitter::Error::AlreadyFavorited, Twitter::Error::NotFound
-            next
-          end
+          perform_post_with_object("/1.1/favorites/create.json", arguments.options.merge(id: extract_id(tweet)), Twitter::Tweet)
+        rescue Twitter::Error::AlreadyFavorited, Twitter::Error::NotFound
+          next
         end.compact
       end
       alias fav favorite
@@ -118,7 +114,7 @@ module Twitter
       def favorite!(*args)
         arguments = Twitter::Arguments.new(args)
         pmap(arguments) do |tweet|
-          perform_post_with_object('/1.1/favorites/create.json', arguments.options.merge(id: extract_id(tweet)), Twitter::Tweet)
+          perform_post_with_object("/1.1/favorites/create.json", arguments.options.merge(id: extract_id(tweet)), Twitter::Tweet)
         end
       end
       alias create_favorite! favorite!

data/lib/twitter/rest/form_encoder.rb

@@ -0,0 +1,27 @@
+module Twitter
+  module REST
+    class FormEncoder
+      UNESCAPED_CHARS = /[^a-z0-9\-._~]/i
+
+      def self.encode(data)
+        data.collect do |k, v|
+          if v.nil?
+            ::URI::DEFAULT_PARSER.escape(k.to_s, UNESCAPED_CHARS)
+          elsif v.respond_to?(:to_ary)
+            v.to_ary.collect do |w|
+              str = ::URI::DEFAULT_PARSER.escape(k.to_s, UNESCAPED_CHARS)
+              unless w.nil?
+                str << "="
+                str << ::URI::DEFAULT_PARSER.escape(w.to_s, UNESCAPED_CHARS)
+              end
+            end.join("&")
+          else
+            str = ::URI::DEFAULT_PARSER.escape(k.to_s, UNESCAPED_CHARS)
+            str << "="
+            str << ::URI::DEFAULT_PARSER.escape(v.to_s, UNESCAPED_CHARS)
+          end
+        end.join("&")
+      end
+    end
+  end
+end