twitter 5.4.0 → 5.4.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+5.4.1
+-----
+* [Default to maximum number of tweets per request](https://github.com/sferik/twitter/commit/1e41b5d4dde8678f5968b57dafe9da63b092646c)
+
 5.4.0
 -----
 * [Fix enumerable search interface](https://github.com/sferik/twitter/commit/e14cc3391ebe8229184e9e83806c870df3baa24c)

data/lib/twitter/rest/api/search.rb

@@ -6,6 +6,7 @@ module Twitter
     module API
       module Search
         include Twitter::REST::API::Utils
+        MAX_TWEETS_PER_REQUEST = 100
 
         # Returns tweets that match a specified query.
         #
@@ -28,6 +29,7 @@ module Twitter
         # @option options [Boolean, String, Integer] :include_entities The tweet entities node will be disincluded when set to false.
         # @return [Twitter::SearchResults] Return tweets that match a specified query with search metadata
         def search(q, options = {})
+          options[:count] ||= MAX_TWEETS_PER_REQUEST
           search_results_from_response(:get, '/1.1/search/tweets.json', options.merge(:q => q))
         end
 

data/lib/twitter/version.rb

@@ -2,7 +2,7 @@ module Twitter
   class Version
     MAJOR = 5
     MINOR = 4
-    PATCH = 0
+    PATCH = 1
     PRE = nil
 
     class << self

data/spec/twitter/rest/api/search_spec.rb

@@ -7,27 +7,34 @@ describe Twitter::REST::API::Search do
   end
 
   describe '#search' do
-    before do
-      stub_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames'}).to_return(:body => fixture('search.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
-    end
-    it 'requests the correct resource' do
-      @client.search('#freebandnames')
-      expect(a_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames'})).to have_been_made
-    end
-    it 'returns recent Tweets related to a query with images and videos embedded' do
-      search = @client.search('#freebandnames')
-      expect(search).to be_a Twitter::SearchResults
-      expect(search.first).to be_a Twitter::Tweet
-      expect(search.first.text).to eq('@Just_Reboot #FreeBandNames mono surround')
-    end
-    context 'when search API responds a malformed result' do
+    context 'without count specified' do
       before do
-        stub_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames'}).to_return(:body => fixture('search_malformed.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+        stub_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames', :count => '100'}).to_return(:body => fixture('search.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
       end
-      it 'returns an empty array' do
+      it 'requests the correct resource' do
+        @client.search('#freebandnames')
+        expect(a_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames', :count => '100'})).to have_been_made
+      end
+      it 'returns recent Tweets related to a query with images and videos embedded' do
         search = @client.search('#freebandnames')
-        expect(search.to_a).to be_an Array
-        expect(search.to_a).to be_empty
+        expect(search).to be_a Twitter::SearchResults
+        expect(search.first).to be_a Twitter::Tweet
+        expect(search.first.text).to eq('@Just_Reboot #FreeBandNames mono surround')
+      end
+    end
+    context 'with count specified' do
+      before do
+        stub_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames', :count => '3'}).to_return(:body => fixture('search.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+      end
+      it 'requests the correct resource' do
+        @client.search('#freebandnames', :count => 3)
+        expect(a_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames', :count => '3'})).to have_been_made
+      end
+      it 'returns recent Tweets related to a query with images and videos embedded' do
+        search = @client.search('#freebandnames', :count => 3)
+        expect(search).to be_a Twitter::SearchResults
+        expect(search.first).to be_a Twitter::Tweet
+        expect(search.first.text).to eq('@Just_Reboot #FreeBandNames mono surround')
       end
     end
   end

data/spec/twitter/search_results_spec.rb

@@ -5,12 +5,12 @@ describe Twitter::SearchResults do
   describe '#each' do
     before do
       @client = Twitter::REST::Client.new(:consumer_key => 'CK', :consumer_secret => 'CS', :access_token => 'AT', :access_token_secret => 'AS')
-      stub_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames'}).to_return(:body => fixture('search.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+      stub_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames', :count => '100'}).to_return(:body => fixture('search.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
       stub_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames', :count => '3', :include_entities => '1', :max_id => '414071361066532863'}).to_return(:body => fixture('search2.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
     end
     it 'requests the correct resources' do
       @client.search('#freebandnames').each {}
-      expect(a_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames'})).to have_been_made
+      expect(a_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames', :count => '100'})).to have_been_made
       expect(a_get('/1.1/search/tweets.json').with(:query => {:q => '#freebandnames', :count => '3', :include_entities => '1', :max_id => '414071361066532863'})).to have_been_made
     end
     it 'iterates' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: twitter
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 5.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -453,7 +453,6 @@ files:
 - spec/twitter/trend_spec.rb
 - spec/twitter/tweet_spec.rb
 - spec/twitter/user_spec.rb
-- spec/twitter_spec.rb
 homepage: http://sferik.github.com/twitter/
 licenses:
 - MIT
@@ -469,7 +468,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2007374580956818801
+      hash: -2856060050130677509
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -605,5 +604,4 @@ test_files:
 - spec/twitter/trend_spec.rb
 - spec/twitter/tweet_spec.rb
 - spec/twitter/user_spec.rb
-- spec/twitter_spec.rb
 has_rdoc: 

metadata.gz.sig

@@ -1,3 +1,2 @@
-DɻȫJ�y�W������1���*
-ex��E[R���nZ�³9# s\��9wK~�=.Y
-��&/�y�D�i$!�7�Ŀ�������H�ɄfF�,�Ӎ ��J�+�6b8���ܔ��'�ע��(�p�l��Ds�B�oM�gN� z
+6����rNV
+�FK��	r�VԮ_�J�҉O�_k�	��
ae��҇�h�U������y����FX�gҒ������<V��%�m����$B<F#9#м�۸ڂ�K)i��/޼