twitter 5.1.1 → 5.2.0

data/spec/twitter/media_factory_spec.rb

@@ -2,13 +2,13 @@ require 'helper'
 
 describe Twitter::MediaFactory do
 
-  describe ".new" do
-    it "generates a Photo" do
-      media = Twitter::MediaFactory.new(:id => 1, :type => "photo")
+  describe '.new' do
+    it 'generates a Photo' do
+      media = Twitter::MediaFactory.new(:id => 1, :type => 'photo')
       expect(media).to be_a Twitter::Media::Photo
     end
-    it "raises an IndexError when type is not specified" do
-      expect{Twitter::MediaFactory.new}.to raise_error IndexError
+    it 'raises an IndexError when type is not specified' do
+      expect { Twitter::MediaFactory.new }.to raise_error IndexError
     end
   end
 

data/spec/twitter/null_object_spec.rb

@@ -6,20 +6,20 @@ describe Twitter::NullObject do
     @null_object = Twitter::NullObject.new
   end
 
-  describe "#nil?" do
-    it "returns true" do
+  describe '#nil?' do
+    it 'returns true' do
       expect(@null_object.nil?).to be true
     end
   end
 
-  describe "calling any method" do
-    it "returns self" do
+  describe 'calling any method' do
+    it 'returns self' do
       expect(@null_object.any).to equal @null_object
     end
   end
 
-  describe "#respond_to?" do
-    it "returns true" do
+  describe '#respond_to?' do
+    it 'returns true' do
       expect(@null_object.respond_to?(:any)).to be true
     end
   end

data/spec/twitter/oembed_spec.rb

@@ -2,166 +2,166 @@ require 'helper'
 
 describe Twitter::OEmbed do
 
-  describe "#author_uri" do
-    it "returns a URI when the author_url is set" do
-      oembed = Twitter::OEmbed.new(:author_url => "https://twitter.com/sferik")
+  describe '#author_uri' do
+    it 'returns a URI when the author_url is set' do
+      oembed = Twitter::OEmbed.new(:author_url => 'https://twitter.com/sferik')
       expect(oembed.author_uri).to be_a Addressable::URI
-      expect(oembed.author_uri.to_s).to eq("https://twitter.com/sferik")
+      expect(oembed.author_uri.to_s).to eq('https://twitter.com/sferik')
     end
-    it "returns nil when the author_uri is not set" do
+    it 'returns nil when the author_uri is not set' do
       oembed = Twitter::OEmbed.new
       expect(oembed.author_uri).to be_nil
     end
   end
 
-  describe "#author_uri?" do
-    it "returns true when the author_url is set" do
-      oembed = Twitter::OEmbed.new(:author_url => "https://twitter.com/sferik")
+  describe '#author_uri?' do
+    it 'returns true when the author_url is set' do
+      oembed = Twitter::OEmbed.new(:author_url => 'https://twitter.com/sferik')
       expect(oembed.author_uri?).to be true
     end
-    it "returns false when the author_uri is not set" do
+    it 'returns false when the author_uri is not set' do
       oembed = Twitter::OEmbed.new
       expect(oembed.author_uri?).to be false
     end
   end
 
-  describe "#author_name" do
-    it "returns the author's name" do
-      oembed = Twitter::OEmbed.new(:author_name => "Erik Michaels-Ober")
-      expect(oembed.author_name).to eq("Erik Michaels-Ober")
+  describe '#author_name' do
+    it 'returns the author name' do
+      oembed = Twitter::OEmbed.new(:author_name => 'Erik Michaels-Ober')
+      expect(oembed.author_name).to eq('Erik Michaels-Ober')
     end
-    it "returns nil when not set" do
+    it 'returns nil when not set' do
       author_name = Twitter::OEmbed.new.author_name
       expect(author_name).to be_nil
     end
   end
 
-  describe "#cache_age" do
-    it "returns the cache_age" do
-      oembed = Twitter::OEmbed.new(:cache_age => "31536000000")
-      expect(oembed.cache_age).to eq("31536000000")
+  describe '#cache_age' do
+    it 'returns the cache_age' do
+      oembed = Twitter::OEmbed.new(:cache_age => '31536000000')
+      expect(oembed.cache_age).to eq('31536000000')
     end
-    it "returns nil when not set" do
+    it 'returns nil when not set' do
       cache_age = Twitter::OEmbed.new.cache_age
       expect(cache_age).to be_nil
     end
   end
 
-  describe "#height" do
-    it "returns the height" do
+  describe '#height' do
+    it 'returns the height' do
       oembed = Twitter::OEmbed.new(:height => 200)
       expect(oembed.height).to eq(200)
     end
-    it "returns it as an Integer" do
+    it 'returns it as an Integer' do
       oembed = Twitter::OEmbed.new(:height => 200)
       expect(oembed.height).to be_an Integer
     end
-    it "returns nil when not set" do
+    it 'returns nil when not set' do
       height = Twitter::OEmbed.new.height
       expect(height).to be_nil
     end
   end
 
-  describe "#html" do
-    it "returns the html" do
-      oembed = Twitter::OEmbed.new(:html => "<blockquote>all my <b>witty tweet</b> stuff here</blockquote>")
-      expect(oembed.html).to eq("<blockquote>all my <b>witty tweet</b> stuff here</blockquote>")
+  describe '#html' do
+    it 'returns the html' do
+      oembed = Twitter::OEmbed.new(:html => '<blockquote>all my <b>witty tweet</b> stuff here</blockquote>')
+      expect(oembed.html).to eq('<blockquote>all my <b>witty tweet</b> stuff here</blockquote>')
     end
-    it "returns nil when not set" do
+    it 'returns nil when not set' do
       html = Twitter::OEmbed.new.html
       expect(html).to be_nil
     end
   end
 
-  describe "#provider_name" do
-    it "returns the provider_name" do
-      oembed = Twitter::OEmbed.new(:provider_name => "Twitter")
-      expect(oembed.provider_name).to eq("Twitter")
+  describe '#provider_name' do
+    it 'returns the provider_name' do
+      oembed = Twitter::OEmbed.new(:provider_name => 'Twitter')
+      expect(oembed.provider_name).to eq('Twitter')
     end
-    it "returns nil when not set" do
+    it 'returns nil when not set' do
       provider_name = Twitter::OEmbed.new.provider_name
       expect(provider_name).to be_nil
     end
   end
 
-  describe "#provider_uri" do
-    it "returns a URI when the provider_url is set" do
-      oembed = Twitter::OEmbed.new(:provider_url => "http://twitter.com")
+  describe '#provider_uri' do
+    it 'returns a URI when the provider_url is set' do
+      oembed = Twitter::OEmbed.new(:provider_url => 'http://twitter.com')
       expect(oembed.provider_uri).to be_a Addressable::URI
-      expect(oembed.provider_uri.to_s).to eq("http://twitter.com")
+      expect(oembed.provider_uri.to_s).to eq('http://twitter.com')
     end
-    it "returns nil when the provider_uri is not set" do
+    it 'returns nil when the provider_uri is not set' do
       oembed = Twitter::OEmbed.new
       expect(oembed.provider_uri).to be_nil
     end
   end
 
-  describe "#provider_uri?" do
-    it "returns true when the provider_url is set" do
-      oembed = Twitter::OEmbed.new(:provider_url => "https://twitter.com/sferik")
+  describe '#provider_uri?' do
+    it 'returns true when the provider_url is set' do
+      oembed = Twitter::OEmbed.new(:provider_url => 'https://twitter.com/sferik')
       expect(oembed.provider_uri?).to be true
     end
-    it "returns false when the provider_uri is not set" do
+    it 'returns false when the provider_uri is not set' do
       oembed = Twitter::OEmbed.new
       expect(oembed.provider_uri?).to be false
     end
   end
 
-  describe "#type" do
-    it "returns the type" do
-      oembed = Twitter::OEmbed.new(:type => "rich")
-      expect(oembed.type).to eq("rich")
+  describe '#type' do
+    it 'returns the type' do
+      oembed = Twitter::OEmbed.new(:type => 'rich')
+      expect(oembed.type).to eq('rich')
     end
-    it "returns nil when not set" do
+    it 'returns nil when not set' do
       type = Twitter::OEmbed.new.type
       expect(type).to be_nil
     end
   end
 
-  describe "#width" do
-    it "returns the width" do
+  describe '#width' do
+    it 'returns the width' do
       oembed = Twitter::OEmbed.new(:width => 550)
       expect(oembed.width).to eq(550)
     end
-    it "returns it as an Integer" do
+    it 'returns it as an Integer' do
       oembed = Twitter::OEmbed.new(:width => 550)
       expect(oembed.width).to be_an Integer
     end
-    it "returns nil when not set" do
+    it 'returns nil when not set' do
       width = Twitter::OEmbed.new.width
       expect(width).to be_nil
     end
   end
 
-  describe "#uri" do
-    it "returns a URI when the url is set" do
-      oembed = Twitter::OEmbed.new(:url => "https://twitter.com/twitterapi/status/133640144317198338")
+  describe '#uri' do
+    it 'returns a URI when the url is set' do
+      oembed = Twitter::OEmbed.new(:url => 'https://twitter.com/twitterapi/status/133640144317198338')
       expect(oembed.uri).to be_a Addressable::URI
-      expect(oembed.uri.to_s).to eq("https://twitter.com/twitterapi/status/133640144317198338")
+      expect(oembed.uri.to_s).to eq('https://twitter.com/twitterapi/status/133640144317198338')
     end
-    it "returns nil when the url is not set" do
+    it 'returns nil when the url is not set' do
       oembed = Twitter::OEmbed.new
       expect(oembed.uri).to be_nil
     end
   end
 
-  describe "#uri?" do
-    it "returns true when the url is set" do
-      oembed = Twitter::OEmbed.new(:url => "https://twitter.com/twitterapi/status/133640144317198338")
+  describe '#uri?' do
+    it 'returns true when the url is set' do
+      oembed = Twitter::OEmbed.new(:url => 'https://twitter.com/twitterapi/status/133640144317198338')
       expect(oembed.uri?).to be true
     end
-    it "returns false when the url is not set" do
+    it 'returns false when the url is not set' do
       oembed = Twitter::OEmbed.new
       expect(oembed.uri?).to be false
     end
   end
 
-  describe "#version" do
-    it "returns the version" do
-      oembed = Twitter::OEmbed.new(:version => "1.0")
-      expect(oembed.version).to eq("1.0")
+  describe '#version' do
+    it 'returns the version' do
+      oembed = Twitter::OEmbed.new(:version => '1.0')
+      expect(oembed.version).to eq('1.0')
     end
-    it "returns nil when not set" do
+    it 'returns nil when not set' do
       version = Twitter::OEmbed.new.version
       expect(version).to be_nil
     end

data/spec/twitter/place_spec.rb

@@ -2,128 +2,157 @@ require 'helper'
 
 describe Twitter::Place do
 
-  describe "#==" do
-    it "returns true when objects WOE IDs are the same" do
-      place = Twitter::Place.new(:woeid => 1, :name => "foo")
-      other = Twitter::Place.new(:woeid => 1, :name => "bar")
+  describe '#eql?' do
+    it 'returns true when objects WOE IDs are the same' do
+      place = Twitter::Place.new(:woeid => 1, :name => 'foo')
+      other = Twitter::Place.new(:woeid => 1, :name => 'bar')
+      expect(place).to eql(other)
+    end
+    it 'returns false when objects WOE IDs are different' do
+      place = Twitter::Place.new(:woeid => 1)
+      other = Twitter::Place.new(:woeid => 2)
+      expect(place).not_to eql(other)
+    end
+    it 'returns false when classes are different' do
+      place = Twitter::Place.new(:woeid => 1)
+      other = Twitter::Base.new(:woeid => 1)
+      expect(place).not_to eql(other)
+    end
+  end
+
+  describe '#bounding_box' do
+    it 'returns a Twitter::Geo when bounding_box is set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :bounding_box => {:type => 'Polygon', :coordinates => [[[-122.40348192, 37.77752898], [-122.387436, 37.77752898], [-122.387436, 37.79448597], [-122.40348192, 37.79448597]]]})
+      expect(place.bounding_box).to be_a Twitter::Geo::Polygon
+    end
+    it 'returns nil when not bounding_box is not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
+      expect(place.bounding_box).to be_nil
+    end
+  end
+
+  describe '#==' do
+    it 'returns true when objects WOE IDs are the same' do
+      place = Twitter::Place.new(:woeid => 1, :name => 'foo')
+      other = Twitter::Place.new(:woeid => 1, :name => 'bar')
       expect(place == other).to be true
     end
-    it "returns false when objects WOE IDs are different" do
+    it 'returns false when objects WOE IDs are different' do
       place = Twitter::Place.new(:woeid => 1)
       other = Twitter::Place.new(:woeid => 2)
       expect(place == other).to be false
     end
-    it "returns false when classes are different" do
+    it 'returns false when classes are different' do
       place = Twitter::Place.new(:woeid => 1)
       other = Twitter::Base.new(:woeid => 1)
       expect(place == other).to be false
     end
   end
 
-  describe "#bounding_box" do
-    it "returns a Twitter::Geo when bounding_box is set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :bounding_box => {:type => "Polygon", :coordinates => [[[-122.40348192, 37.77752898], [-122.387436, 37.77752898], [-122.387436, 37.79448597], [-122.40348192, 37.79448597]]]})
+  describe '#bounding_box' do
+    it 'returns a Twitter::Geo when bounding_box is set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :bounding_box => {:type => 'Polygon', :coordinates => [[[-122.40348192, 37.77752898], [-122.387436, 37.77752898], [-122.387436, 37.79448597], [-122.40348192, 37.79448597]]]})
       expect(place.bounding_box).to be_a Twitter::Geo::Polygon
     end
-    it "returns nil when not bounding_box is not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns nil when not bounding_box is not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.bounding_box).to be_nil
     end
   end
 
-  describe "#bounding_box?" do
-    it "returns true when bounding_box is set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :bounding_box => {:type => "Polygon", :coordinates => [[[-122.40348192, 37.77752898], [-122.387436, 37.77752898], [-122.387436, 37.79448597], [-122.40348192, 37.79448597]]]})
+  describe '#bounding_box?' do
+    it 'returns true when bounding_box is set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :bounding_box => {:type => 'Polygon', :coordinates => [[[-122.40348192, 37.77752898], [-122.387436, 37.77752898], [-122.387436, 37.79448597], [-122.40348192, 37.79448597]]]})
       expect(place.bounding_box?).to be true
     end
-    it "returns false when bounding_box is not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns false when bounding_box is not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.bounding_box?).to be false
     end
   end
 
-  describe "#contained_within" do
-    it "returns a Twitter::Place when contained_within is set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :contained_within => {:woeid => "247f43d441defc04"})
+  describe '#contained_within' do
+    it 'returns a Twitter::Place when contained_within is set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :contained_within => {:woeid => '247f43d441defc04'})
       expect(place.contained_within).to be_a Twitter::Place
     end
-    it "returns nil when not contained_within is not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns nil when not contained_within is not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.contained_within).to be_nil
     end
   end
 
-  describe "#contained_within?" do
-    it "returns true when contained_within is set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :contained_within => {:woeid => "247f43d441defc04"})
+  describe '#contained_within?' do
+    it 'returns true when contained_within is set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :contained_within => {:woeid => '247f43d441defc04'})
       expect(place.contained?).to be true
     end
-    it "returns false when contained_within is not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns false when contained_within is not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.contained?).to be false
     end
   end
 
-  describe "#country_code" do
-    it "returns a country code when set with country_code" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :country_code => "US")
-      expect(place.country_code).to eq("US")
+  describe '#country_code' do
+    it 'returns a country code when set with country_code' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :country_code => 'US')
+      expect(place.country_code).to eq('US')
     end
-    it "returns a country code when set with countryCode" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :countryCode => "US")
-      expect(place.country_code).to eq("US")
+    it 'returns a country code when set with countryCode' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :countryCode => 'US') # rubocop:disable SymbolName
+      expect(place.country_code).to eq('US')
     end
-    it "returns nil when not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns nil when not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.country_code).to be_nil
     end
   end
 
-  describe "#parent_id" do
-    it "returns a parent ID when set with parentid" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :parentid => 1)
+  describe '#parent_id' do
+    it 'returns a parent ID when set with parentid' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :parentid => 1)
       expect(place.parent_id).to eq(1)
     end
-    it "returns nil when not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns nil when not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.parent_id).to be_nil
     end
   end
 
-  describe "#place_type" do
-    it "returns a place type when set with place_type" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :place_type => "city")
-      expect(place.place_type).to eq("city")
+  describe '#place_type' do
+    it 'returns a place type when set with place_type' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :place_type => 'city')
+      expect(place.place_type).to eq('city')
     end
-    it "returns a place type when set with placeType[name]" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :placeType => {:name => "Town"})
-      expect(place.place_type).to eq("Town")
+    it 'returns a place type when set with placeType[name]' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :placeType => {:name => 'Town'}) # rubocop:disable SymbolName
+      expect(place.place_type).to eq('Town')
     end
-    it "returns nil when not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns nil when not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.place_type).to be_nil
     end
   end
 
-  describe "#uri" do
-    it "returns a URI when the url is set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :url => "https://api.twitter.com/1.1/geo/id/247f43d441defc03.json")
+  describe '#uri' do
+    it 'returns a URI when the url is set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :url => 'https://api.twitter.com/1.1/geo/id/247f43d441defc03.json')
       expect(place.uri).to be_a Addressable::URI
-      expect(place.uri.to_s).to eq("https://api.twitter.com/1.1/geo/id/247f43d441defc03.json")
+      expect(place.uri.to_s).to eq('https://api.twitter.com/1.1/geo/id/247f43d441defc03.json')
     end
-    it "returns nil when the url is not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns nil when the url is not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.uri).to be_nil
     end
   end
 
-  describe "#uri?" do
-    it "returns true when the url is set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03", :url => "https://api.twitter.com/1.1/geo/id/247f43d441defc03.json")
+  describe '#uri?' do
+    it 'returns true when the url is set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03', :url => 'https://api.twitter.com/1.1/geo/id/247f43d441defc03.json')
       expect(place.uri?).to be true
     end
-    it "returns false when the url is not set" do
-      place = Twitter::Place.new(:woeid => "247f43d441defc03")
+    it 'returns false when the url is not set' do
+      place = Twitter::Place.new(:woeid => '247f43d441defc03')
       expect(place.uri?).to be false
     end
   end