twitter 5.0.0 → 5.4.1

data/lib/twitter/rest/api/favorites.rb

@@ -4,6 +4,7 @@ require 'twitter/error/forbidden'
 require 'twitter/rest/api/utils'
 require 'twitter/tweet'
 require 'twitter/user'
+require 'twitter/utils'
 
 module Twitter
   module REST
@@ -16,13 +17,13 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [Array<Twitter::Tweet>] favorite Tweets.
-        # @overload favorites(options={})
+        # @overload favorites(options = {})
         #   Returns the 20 most recent favorite Tweets for the authenticating user
         #
         #   @param options [Hash] A customizable set of options.
         #   @option options [Integer] :count Specifies the number of records to retrieve. Must be less than or equal to 100.
         #   @option options [Integer] :since_id Returns results with an ID greater than (that is, more recent than) the specified ID.
-        # @overload favorites(user, options={})
+        # @overload favorites(user, options = {})
         #   Returns the 20 most recent favorite Tweets for the specified user
         #
         #   @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
@@ -32,7 +33,7 @@ module Twitter
         def favorites(*args)
           arguments = Twitter::Arguments.new(args)
           merge_user!(arguments.options, arguments.pop) if arguments.last
-          objects_from_response(Twitter::Tweet, :get, "/1.1/favorites/list.json", arguments.options)
+          objects_from_response(Twitter::Tweet, :get, '/1.1/favorites/list.json', arguments.options)
         end
 
         # Un-favorites the specified Tweets as the authenticating user
@@ -48,9 +49,9 @@ module Twitter
         #   @param tweets [Enumerable<Integer, String, URI, Twitter::Tweet>] A collection of Tweet IDs, URIs, or objects.
         #   @param options [Hash] A customizable set of options.
         def unfavorite(*args)
-          threaded_objects_from_response(Twitter::Tweet, :post, "/1.1/favorites/destroy.json", args)
+          threaded_objects_from_response(Twitter::Tweet, :post, '/1.1/favorites/destroy.json', args)
         end
-        alias destroy_favorite unfavorite
+        alias_method :destroy_favorite, :unfavorite
         deprecate_alias :favorite_destroy, :unfavorite
 
         # Favorites the specified Tweets as the authenticating user
@@ -67,17 +68,17 @@ module Twitter
         #   @param options [Hash] A customizable set of options.
         def favorite(*args)
           arguments = Twitter::Arguments.new(args)
-          arguments.flatten.threaded_map do |tweet|
+          Twitter::Utils.parallel_map(arguments) do |tweet|
             id = extract_id(tweet)
             begin
-              object_from_response(Twitter::Tweet, :post, "/1.1/favorites/create.json", arguments.options.merge(:id => id))
+              object_from_response(Twitter::Tweet, :post, '/1.1/favorites/create.json', arguments.options.merge(:id => id))
             rescue Twitter::Error::Forbidden => error
               raise unless error.message == Twitter::Error::AlreadyFavorited::MESSAGE
             end
           end.compact
         end
-        alias fav favorite
-        alias fave favorite
+        alias_method :fav, :favorite
+        alias_method :fave, :favorite
         deprecate_alias :favorite_create, :favorite
 
         # Favorites the specified Tweets as the authenticating user and raises an error if one has already been favorited
@@ -95,20 +96,19 @@ module Twitter
         #   @param options [Hash] A customizable set of options.
         def favorite!(*args)
           arguments = Twitter::Arguments.new(args)
-          arguments.flatten.threaded_map do |tweet|
+          Twitter::Utils.parallel_map(arguments) do |tweet|
             id = extract_id(tweet)
             begin
-              object_from_response(Twitter::Tweet, :post, "/1.1/favorites/create.json", arguments.options.merge(:id => id))
+              object_from_response(Twitter::Tweet, :post, '/1.1/favorites/create.json', arguments.options.merge(:id => id))
             rescue Twitter::Error::Forbidden => error
               handle_forbidden_error(Twitter::Error::AlreadyFavorited, error)
             end
           end
         end
-        alias create_favorite! favorite!
-        alias fav! favorite!
-        alias fave! favorite!
+        alias_method :create_favorite!, :favorite!
+        alias_method :fav!, :favorite!
+        alias_method :fave!, :favorite!
         deprecate_alias :favorite_create!, :favorite!
-
       end
     end
   end

data/lib/twitter/rest/api/friends_and_followers.rb

@@ -4,6 +4,7 @@ require 'twitter/error/forbidden'
 require 'twitter/relationship'
 require 'twitter/rest/api/utils'
 require 'twitter/user'
+require 'twitter/utils'
 
 module Twitter
   module REST
@@ -16,19 +17,19 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [Twitter::Cursor]
-        # @overload friend_ids(options={})
+        # @overload friend_ids(options = {})
         #   Returns an array of numeric IDs for every user the authenticated user is following
         #
         #   @param options [Hash] A customizable set of options.
         #   @option options [Integer] :cursor (-1) Breaks the results into pages. This is recommended for users who are following many users. Provide a value of -1 to begin paging. Provide values as returned in the response body's next_cursor and previous_cursor attributes to page back and forth in the list.
-        # @overload friend_ids(user, options={})
+        # @overload friend_ids(user, options = {})
         #   Returns an array of numeric IDs for every user the specified user is following
         #
         #   @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
         #   @param options [Hash] A customizable set of options.
         #   @option options [Integer] :cursor (-1) Breaks the results into pages. Provide values as returned in the response objects's next_cursor and previous_cursor attributes to page back and forth in the list.
         def friend_ids(*args)
-          cursor_from_response_with_user(:ids, nil, :get, "/1.1/friends/ids.json", args)
+          cursor_from_response_with_user(:ids, nil, :get, '/1.1/friends/ids.json', args)
         end
 
         # @see https://dev.twitter.com/docs/api/1.1/get/followers/ids
@@ -36,19 +37,19 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [Twitter::Cursor]
-        # @overload follower_ids(options={})
+        # @overload follower_ids(options = {})
         #   Returns an array of numeric IDs for every user following the authenticated user
         #
         #   @param options [Hash] A customizable set of options.
         #   @option options [Integer] :cursor (-1) Breaks the results into pages. Provide values as returned in the response objects's next_cursor and previous_cursor attributes to page back and forth in the list.
-        # @overload follower_ids(user, options={})
+        # @overload follower_ids(user, options = {})
         #   Returns an array of numeric IDs for every user following the specified user
         #
         #   @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
         #   @param options [Hash] A customizable set of options.
         #   @option options [Integer] :cursor (-1) Breaks the results into pages. This is recommended for users who are following many users. Provide a value of -1 to begin paging. Provide values as returned in the response body's next_cursor and previous_cursor attributes to page back and forth in the list.
         def follower_ids(*args)
-          cursor_from_response_with_user(:ids, nil, :get, "/1.1/followers/ids.json", args)
+          cursor_from_response_with_user(:ids, nil, :get, '/1.1/followers/ids.json', args)
         end
 
         # Returns the relationship of the authenticating user to the comma separated list of up to 100 screen_names or user_ids provided. Values for connections can be: following, following_requested, followed_by, none.
@@ -66,7 +67,7 @@ module Twitter
         def friendships(*args)
           arguments = Twitter::Arguments.new(args)
           merge_users!(arguments.options, arguments)
-          objects_from_response(Twitter::User, :get, "/1.1/friendships/lookup.json", arguments.options)
+          objects_from_response(Twitter::User, :get, '/1.1/friendships/lookup.json', arguments.options)
         end
 
         # Returns an array of numeric IDs for every user who has a pending request to follow the authenticating user
@@ -78,8 +79,8 @@ module Twitter
         # @return [Twitter::Cursor]
         # @param options [Hash] A customizable set of options.
         # @option options [Integer] :cursor (-1) Breaks the results into pages. Provide values as returned in the response objects's next_cursor and previous_cursor attributes to page back and forth in the list.
-        def friendships_incoming(options={})
-          cursor_from_response(:ids, nil, :get, "/1.1/friendships/incoming.json", options)
+        def friendships_incoming(options = {})
+          cursor_from_response(:ids, nil, :get, '/1.1/friendships/incoming.json', options)
         end
 
         # Returns an array of numeric IDs for every protected user for whom the authenticating user has a pending follow request
@@ -91,8 +92,8 @@ module Twitter
         # @return [Twitter::Cursor]
         # @param options [Hash] A customizable set of options.
         # @option options [Integer] :cursor (-1) Breaks the results into pages. Provide values as returned in the response objects's next_cursor and previous_cursor attributes to page back and forth in the list.
-        def friendships_outgoing(options={})
-          cursor_from_response(:ids, nil, :get, "/1.1/friendships/outgoing.json", options)
+        def friendships_outgoing(options = {})
+          cursor_from_response(:ids, nil, :get, '/1.1/friendships/outgoing.json', options)
         end
 
         # Allows the authenticating user to follow the specified users, unless they are already followed
@@ -118,7 +119,7 @@ module Twitter
           end
           follow!(new_friends.value - existing_friends.value, arguments.options)
         end
-        alias create_friendship follow
+        alias_method :create_friendship, :follow
         deprecate_alias :friendship_create, :follow
 
         # Allows the authenticating user to follow the specified users
@@ -136,16 +137,11 @@ module Twitter
         #   @option options [Boolean] :follow (false) Enable notifications for the target user.
         def follow!(*args)
           arguments = Twitter::Arguments.new(args)
-          arguments.flatten.threaded_map do |user|
-            begin
-              object_from_response(Twitter::User, :post, "/1.1/friendships/create.json", merge_user(arguments.options, user))
-            rescue Twitter::Error::Forbidden
-              # This error will be raised if the user doesn't have permission to
-              # follow list_member, for whatever reason.
-            end
+          Twitter::Utils.parallel_map(arguments) do |user|
+            object_from_response(Twitter::User, :post, '/1.1/friendships/create.json', merge_user(arguments.options, user))
           end.compact
         end
-        alias create_friendship! follow!
+        alias_method :create_friendship!, :follow!
         deprecate_alias :friendship_create!, :follow!
 
         # Allows the authenticating user to unfollow the specified users
@@ -161,9 +157,9 @@ module Twitter
         #   @param users [Enumerable<Integer, String, Twitter::User>] A collection of Twitter user IDs, screen names, or objects.
         #   @param options [Hash] A customizable set of options.
         def unfollow(*args)
-          threaded_user_objects_from_response(:post, "/1.1/friendships/destroy.json", args)
+          threaded_user_objects_from_response(:post, '/1.1/friendships/destroy.json', args)
         end
-        alias destroy_friendship unfollow
+        alias_method :destroy_friendship, :unfollow
         deprecate_alias :friendship_destroy, :unfollow
 
         # Allows one to enable or disable retweets and device notifications from the specified user.
@@ -177,9 +173,9 @@ module Twitter
         # @param options [Hash] A customizable set of options.
         # @option options [Boolean] :device Enable/disable device notifications from the target user.
         # @option options [Boolean] :retweets Enable/disable retweets from the target user.
-        def friendship_update(user, options={})
+        def friendship_update(user, options = {})
           merge_user!(options, user)
-          object_from_response(Twitter::Relationship, :post, "/1.1/friendships/update.json", options)
+          object_from_response(Twitter::Relationship, :post, '/1.1/friendships/update.json', options)
         end
 
         # Returns detailed information about the relationship between two users
@@ -192,15 +188,15 @@ module Twitter
         # @param source [Integer, String, Twitter::User] The Twitter user ID, screen name, or object of the source user.
         # @param target [Integer, String, Twitter::User] The Twitter user ID, screen name, or object of the target user.
         # @param options [Hash] A customizable set of options.
-        def friendship(source, target, options={})
-          merge_user!(options, source, "source")
+        def friendship(source, target, options = {})
+          merge_user!(options, source, 'source')
           options[:source_id] = options.delete(:source_user_id) unless options[:source_user_id].nil?
-          merge_user!(options, target, "target")
+          merge_user!(options, target, 'target')
           options[:target_id] = options.delete(:target_user_id) unless options[:target_user_id].nil?
-          object_from_response(Twitter::Relationship, :get, "/1.1/friendships/show.json", options)
+          object_from_response(Twitter::Relationship, :get, '/1.1/friendships/show.json', options)
         end
-        alias friendship_show friendship
-        alias relationship friendship
+        alias_method :friendship_show, :friendship
+        alias_method :relationship, :friendship
 
         # Test for the existence of friendship between two users
         #
@@ -212,7 +208,7 @@ module Twitter
         # @param source [Integer, String, Twitter::User] The Twitter user ID, screen name, or object of the source user.
         # @param target [Integer, String, Twitter::User] The Twitter user ID, screen name, or object of the target user.
         # @param options [Hash] A customizable set of options.
-        def friendship?(source, target, options={})
+        def friendship?(source, target, options = {})
           friendship(source, target, options).source.following?
         end
 
@@ -223,14 +219,14 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [Twitter::Cursor]
-        # @overload followers(options={})
+        # @overload followers(options = {})
         #   Returns a cursored collection of user objects for users following the authenticated user.
         #
         #   @param options [Hash] A customizable set of options.
         #   @option options [Integer] :cursor (-1) Breaks the results into pages. This is recommended for users who are following many users. Provide a value of -1 to begin paging. Provide values as returned in the response body's next_cursor and previous_cursor attributes to page back and forth in the list.
         #   @option options [Boolean, String, Integer] :skip_status Do not include contributee's Tweets when set to true, 't' or 1.
         #   @option options [Boolean, String, Integer] :include_user_entities The user entities node will be disincluded when set to false.
-        # @overload followers(user, options={})
+        # @overload followers(user, options = {})
         #   Returns a cursored collection of user objects for users following the specified user.
         #
         #   @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
@@ -239,7 +235,7 @@ module Twitter
         #   @option options [Boolean, String, Integer] :skip_status Do not include contributee's Tweets when set to true, 't' or 1.
         #   @option options [Boolean, String, Integer] :include_user_entities The user entities node will be disincluded when set to false.
         def followers(*args)
-          cursor_from_response_with_user(:users, Twitter::User, :get, "/1.1/followers/list.json", args)
+          cursor_from_response_with_user(:users, Twitter::User, :get, '/1.1/followers/list.json', args)
         end
 
         # Returns a cursored collection of user objects for every user the specified user is following (otherwise known as their "friends").
@@ -249,14 +245,14 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [Twitter::Cursor]
-        # @overload friends(options={})
+        # @overload friends(options = {})
         #   Returns a cursored collection of user objects for every user the authenticated user is following (otherwise known as their "friends").
         #
         #   @param options [Hash] A customizable set of options.
         #   @option options [Integer] :cursor (-1) Breaks the results into pages. This is recommended for users who are following many users. Provide a value of -1 to begin paging. Provide values as returned in the response body's next_cursor and previous_cursor attributes to page back and forth in the list.
         #   @option options [Boolean, String, Integer] :skip_status Do not include contributee's Tweets when set to true, 't' or 1.
         #   @option options [Boolean, String, Integer] :include_user_entities The user entities node will be disincluded when set to false.
-        # @overload friends(user, options={})
+        # @overload friends(user, options = {})
         #   Returns a cursored collection of user objects for every user the specified user is following (otherwise known as their "friends").
         #
         #   @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, URI, or object.
@@ -265,9 +261,9 @@ module Twitter
         #   @option options [Boolean, String, Integer] :skip_status Do not include contributee's Tweets when set to true, 't' or 1.
         #   @option options [Boolean, String, Integer] :include_user_entities The user entities node will be disincluded when set to false.
         def friends(*args)
-          cursor_from_response_with_user(:users, Twitter::User, :get, "/1.1/friends/list.json", args)
+          cursor_from_response_with_user(:users, Twitter::User, :get, '/1.1/friends/list.json', args)
         end
-        alias following friends
+        alias_method :following, :friends
 
         # Returns a collection of user IDs that the currently authenticated user does not want to receive retweets from.
         # @see https://dev.twitter.com/docs/api/1.1/get/friendships/no_retweets/ids
@@ -276,11 +272,10 @@ module Twitter
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [Array<Integer>]
         # @param options [Hash] A customizable set of options.
-        def no_retweet_ids(options={})
-          get("/1.1/friendships/no_retweets/ids.json", options)[:body].map(&:to_i)
+        def no_retweet_ids(options = {})
+          get('/1.1/friendships/no_retweets/ids.json', options)[:body].map(&:to_i)
         end
-        alias no_retweets_ids no_retweet_ids
-
+        alias_method :no_retweets_ids, :no_retweet_ids
       end
     end
   end

data/lib/twitter/rest/api/help.rb

@@ -15,8 +15,8 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [Twitter::Configuration] Twitter's configuration.
-        def configuration(options={})
-          object_from_response(Twitter::Configuration, :get, "/1.1/help/configuration.json", options)
+        def configuration(options = {})
+          object_from_response(Twitter::Configuration, :get, '/1.1/help/configuration.json', options)
         end
 
         # Returns the list of languages supported by Twitter
@@ -26,8 +26,8 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [Array<Twitter::Language>]
-        def languages(options={})
-          objects_from_response(Twitter::Language, :get, "/1.1/help/languages.json", options)
+        def languages(options = {})
+          objects_from_response(Twitter::Language, :get, '/1.1/help/languages.json', options)
         end
 
         # Returns {https://twitter.com/privacy Twitter's Privacy Policy}
@@ -37,8 +37,8 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [String]
-        def privacy(options={})
-          get("/1.1/help/privacy.json", options)[:body][:privacy]
+        def privacy(options = {})
+          get('/1.1/help/privacy.json', options)[:body][:privacy]
         end
 
         # Returns {https://twitter.com/tos Twitter's Terms of Service}
@@ -48,10 +48,9 @@ module Twitter
         # @authentication Requires user context
         # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
         # @return [String]
-        def tos(options={})
-          get("/1.1/help/tos.json", options)[:body][:tos]
+        def tos(options = {})
+          get('/1.1/help/tos.json', options)[:body][:tos]
         end
-
       end
     end
   end