twitter 5.0.0.rc.1 → 5.0.0

data/spec/twitter/suggestion_spec.rb

@@ -3,35 +3,25 @@ require 'helper'
 describe Twitter::Suggestion do
 
   describe "#==" do
-    it "returns false for empty objects" do
+    it "returns true for empty objects" do
       suggestion = Twitter::Suggestion.new
       other = Twitter::Suggestion.new
-      expect(suggestion == other).to be_false
+      expect(suggestion == other).to be true
     end
     it "returns true when objects slugs are the same" do
       suggestion = Twitter::Suggestion.new(:slug => 1, :name => "foo")
       other = Twitter::Suggestion.new(:slug => 1, :name => "bar")
-      expect(suggestion == other).to be_true
+      expect(suggestion == other).to be true
     end
     it "returns false when objects slugs are different" do
       suggestion = Twitter::Suggestion.new(:slug => 1)
       other = Twitter::Suggestion.new(:slug => 2)
-      expect(suggestion == other).to be_false
+      expect(suggestion == other).to be false
     end
     it "returns false when classes are different" do
       suggestion = Twitter::Suggestion.new(:slug => 1)
       other = Twitter::Base.new(:slug => 1)
-      expect(suggestion == other).to be_false
-    end
-    it "returns true when objects non-slug attributes are the same" do
-      suggestion = Twitter::Suggestion.new(:name => "foo")
-      other = Twitter::Suggestion.new(:name => "foo")
-      expect(suggestion == other).to be_true
-    end
-    it "returns false when objects non-slug attributes are different" do
-      suggestion = Twitter::Suggestion.new(:name => "foo")
-      other = Twitter::Suggestion.new(:name => "bar")
-      expect(suggestion == other).to be_false
+      expect(suggestion == other).to be false
     end
   end
 

data/spec/twitter/target_user_spec.rb

@@ -6,17 +6,17 @@ describe Twitter::TargetUser do
     it "returns true when objects IDs are the same" do
       saved_search = Twitter::TargetUser.new(:id => 1, :name => "foo")
       other = Twitter::TargetUser.new(:id => 1, :name => "bar")
-      expect(saved_search == other).to be_true
+      expect(saved_search == other).to be true
     end
     it "returns false when objects IDs are different" do
       saved_search = Twitter::TargetUser.new(:id => 1)
       other = Twitter::TargetUser.new(:id => 2)
-      expect(saved_search == other).to be_false
+      expect(saved_search == other).to be false
     end
     it "returns false when classes are different" do
       saved_search = Twitter::TargetUser.new(:id => 1)
       other = Twitter::Identity.new(:id => 1)
-      expect(saved_search == other).to be_false
+      expect(saved_search == other).to be false
     end
   end
 

data/spec/twitter/token_spec.rb

@@ -5,11 +5,11 @@ describe Twitter::Token do
   describe "#bearer?" do
     it "returns true when token is a bearer token" do
       token = Twitter::Token.new(:token_type => "bearer")
-      expect(token.bearer?).to be_true
+      expect(token.bearer?).to be true
     end
     it "returns false when token type is nil" do
       token = Twitter::Token.new
-      expect(token.bearer?).to be_false
+      expect(token.bearer?).to be false
     end
   end
 

data/spec/twitter/trend_results_spec.rb

@@ -16,11 +16,11 @@ describe Twitter::TrendResults do
   describe "#as_of?" do
     it "returns true when as_of is set" do
       trend_results = Twitter::TrendResults.new(:id => 1, :as_of => "2012-08-24T23:24:14Z")
-      expect(trend_results.as_of?).to be_true
+      expect(trend_results.as_of?).to be true
     end
     it "returns false when as_of is not set" do
       trend_results = Twitter::TrendResults.new(:id => 1)
-      expect(trend_results.as_of?).to be_false
+      expect(trend_results.as_of?).to be false
     end
   end
 
@@ -38,11 +38,11 @@ describe Twitter::TrendResults do
   describe "#created?" do
     it "returns true when created_at is set" do
       trend_results = Twitter::TrendResults.new(:id => 1, :created_at => "2012-08-24T23:24:14Z")
-      expect(trend_results.created?).to be_true
+      expect(trend_results.created?).to be true
     end
     it "returns false when created_at is not set" do
       trend_results = Twitter::TrendResults.new(:id => 1)
-      expect(trend_results.created?).to be_false
+      expect(trend_results.created?).to be false
     end
   end
 
@@ -78,11 +78,11 @@ describe Twitter::TrendResults do
   describe "#location?" do
     it "returns true when location is set" do
       trend_results = Twitter::TrendResults.new(:id => 1, :locations => [{:name => "Worldwide", :woeid => 1}])
-      expect(trend_results.location?).to be_true
+      expect(trend_results.location?).to be true
     end
     it "returns false when location is not set" do
       trend_results = Twitter::TrendResults.new(:id => 1)
-      expect(trend_results.location?).to be_false
+      expect(trend_results.location?).to be false
     end
   end
 

data/spec/twitter/trend_spec.rb

@@ -3,35 +3,25 @@ require 'helper'
 describe Twitter::Trend do
 
   describe "#==" do
-    it "returns false for empty objects" do
+    it "returns true for empty objects" do
       trend = Twitter::Trend.new
       other = Twitter::Trend.new
-      expect(trend == other).to be_false
+      expect(trend == other).to be true
     end
     it "returns true when objects names are the same" do
       trend = Twitter::Trend.new(:name => "#sevenwordsaftersex", :query => "foo")
       other = Twitter::Trend.new(:name => "#sevenwordsaftersex", :query => "bar")
-      expect(trend == other).to be_true
+      expect(trend == other).to be true
     end
     it "returns false when objects names are different" do
       trend = Twitter::Trend.new(:name => "#sevenwordsaftersex")
       other = Twitter::Trend.new(:name => "#sixwordsaftersex")
-      expect(trend == other).to be_false
+      expect(trend == other).to be false
     end
     it "returns false when classes are different" do
       trend = Twitter::Trend.new(:name => "#sevenwordsaftersex")
       other = Twitter::Base.new(:name => "#sevenwordsaftersex")
-      expect(trend == other).to be_false
-    end
-    it "returns true when objects non-name attributes are the same" do
-      trend = Twitter::Trend.new(:query => "foo")
-      other = Twitter::Trend.new(:query => "foo")
-      expect(trend == other).to be_true
-    end
-    it "returns false when objects non-name attributes are different" do
-      trend = Twitter::Trend.new(:query => "foo")
-      other = Twitter::Trend.new(:query => "bar")
-      expect(trend == other).to be_false
+      expect(trend == other).to be false
     end
   end
 
@@ -50,11 +40,11 @@ describe Twitter::Trend do
   describe "#uri?" do
     it "returns true when the url is set" do
       trend = Twitter::Trend.new(:url => "https://api.twitter.com/1.1/geo/id/247f43d441defc03.json")
-      expect(trend.uri?).to be_true
+      expect(trend.uri?).to be true
     end
     it "returns false when the url is not set" do
       trend = Twitter::Trend.new
-      expect(trend.uri?).to be_false
+      expect(trend.uri?).to be false
     end
   end
 

data/spec/twitter/tweet_spec.rb

@@ -1,3 +1,4 @@
+# coding: utf-8
 require 'helper'
 
 describe Twitter::Tweet do
@@ -15,17 +16,17 @@ describe Twitter::Tweet do
     it "returns true when objects IDs are the same" do
       tweet = Twitter::Tweet.new(:id => 1, :text => "foo")
       other = Twitter::Tweet.new(:id => 1, :text => "bar")
-      expect(tweet == other).to be_true
+      expect(tweet == other).to be true
     end
     it "returns false when objects IDs are different" do
       tweet = Twitter::Tweet.new(:id => 1)
       other = Twitter::Tweet.new(:id => 2)
-      expect(tweet == other).to be_false
+      expect(tweet == other).to be false
     end
     it "returns false when classes are different" do
       tweet = Twitter::Tweet.new(:id => 1)
       other = Twitter::Identity.new(:id => 1)
-      expect(tweet == other).to be_false
+      expect(tweet == other).to be false
     end
   end
 
@@ -43,18 +44,23 @@ describe Twitter::Tweet do
   describe "#created?" do
     it "returns true when created_at is set" do
       tweet = Twitter::Tweet.new(:id => 28669546014, :created_at => "Mon Jul 16 12:59:01 +0000 2007")
-      expect(tweet.created?).to be_true
+      expect(tweet.created?).to be true
     end
     it "returns false when created_at is not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.created?).to be_false
+      expect(tweet.created?).to be false
     end
   end
 
   describe "#entities?" do
     it "returns false if there are no entities set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.entities?).to be_false
+      expect(tweet.entities?).to be false
+    end
+
+    it "returns false if there are blank lists of entities set" do
+      tweet = Twitter::Tweet.new(:id => 28669546014, :entities => {:urls => []})
+      expect(tweet.entities?).to be false
     end
 
     it "returns true if there are entities set" do
@@ -62,12 +68,12 @@ describe Twitter::Tweet do
         {
           :url => "http://example.com/t.co",
           :expanded_url => "http://example.com/expanded",
-          :display_url => "example.com/expanded",
+          :display_url => "example.com/expanded…",
           :indices => [10, 33],
         }
       ]
       tweet = Twitter::Tweet.new(:id => 28669546014, :entities => {:urls => urls_array})
-      expect(tweet.entities?).to be_true
+      expect(tweet.entities?).to be true
     end
   end
 
@@ -119,11 +125,11 @@ describe Twitter::Tweet do
   describe "#geo?" do
     it "returns true when geo is set" do
       tweet = Twitter::Tweet.new(:id => 28669546014, :geo => {:id => 1, :type => "Point"})
-      expect(tweet.geo?).to be_true
+      expect(tweet.geo?).to be true
     end
     it "returns false when geo is not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.geo?).to be_false
+      expect(tweet.geo?).to be false
     end
   end
 
@@ -181,11 +187,11 @@ describe Twitter::Tweet do
   describe "#metadata?" do
     it "returns true when metadata is set" do
       tweet = Twitter::Tweet.new(:id => 28669546014, :metadata => {})
-      expect(tweet.metadata?).to be_true
+      expect(tweet.metadata?).to be true
     end
     it "returns false when metadata is not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.metadata?).to be_false
+      expect(tweet.metadata?).to be false
     end
   end
 
@@ -203,33 +209,33 @@ describe Twitter::Tweet do
   describe "#place?" do
     it "returns true when place is set" do
       tweet = Twitter::Tweet.new(:id => 28669546014, :place => {:id => "247f43d441defc03"})
-      expect(tweet.place?).to be_true
+      expect(tweet.place?).to be true
     end
     it "returns false when place is not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.place?).to be_false
+      expect(tweet.place?).to be false
     end
   end
 
   describe "#reply?" do
     it "returns true when there is an in-reply-to status" do
       tweet = Twitter::Tweet.new(:id => 28669546014, :in_reply_to_status_id => 114749583439036416)
-      expect(tweet.reply?).to be_true
+      expect(tweet.reply?).to be true
     end
     it "returns false when in_reply_to_status_id is not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.reply?).to be_false
+      expect(tweet.reply?).to be false
     end
   end
 
   describe "#retweet?" do
     it "returns true when there is a retweeted status" do
       tweet = Twitter::Tweet.new(:id => 28669546014, :retweeted_status => {:id => 25938088801, :text => "BOOSH"})
-      expect(tweet.retweet?).to be_true
+      expect(tweet.retweet?).to be true
     end
     it "returns false when retweeted_status is not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.retweet?).to be_false
+      expect(tweet.retweet?).to be false
     end
   end
 
@@ -248,11 +254,11 @@ describe Twitter::Tweet do
   describe "#retweeted_status?" do
     it "returns true when retweeted_status is set" do
       tweet = Twitter::Tweet.new(:id => 28669546014, :retweeted_status => {:id => 25938088801, :text => "BOOSH"})
-      expect(tweet.retweeted_status?).to be_true
+      expect(tweet.retweeted_status?).to be true
     end
     it "returns false when retweeted_status is not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.retweeted_status?).to be_false
+      expect(tweet.retweeted_status?).to be false
     end
   end
 
@@ -285,7 +291,7 @@ describe Twitter::Tweet do
         {
           :url => "http://example.com/t.co",
           :expanded_url => "http://example.com/expanded",
-          :display_url => "example.com/expanded",
+          :display_url => "example.com/expanded…",
           :indices => [10, 33],
         }
       ]
@@ -293,8 +299,8 @@ describe Twitter::Tweet do
       expect(tweet.uris).to be_an Array
       expect(tweet.uris.first).to be_a Twitter::Entity::URI
       expect(tweet.uris.first.indices).to eq([10, 33])
-      expect(tweet.uris.first.display_uri).to be_a URI
-      expect(tweet.uris.first.display_uri.to_s).to eq("example.com/expanded")
+      expect(tweet.uris.first.display_uri).to be_a String
+      expect(tweet.uris.first.display_uri).to eq("example.com/expanded…")
     end
     it "is empty when not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
@@ -333,11 +339,11 @@ describe Twitter::Tweet do
   describe "#user?" do
     it "returns true when status is set" do
       tweet = Twitter::Tweet.new(:id => 28669546014, :user => {:id => 7505382})
-      expect(tweet.user?).to be_true
+      expect(tweet.user?).to be true
     end
     it "returns false when status is not set" do
       tweet = Twitter::Tweet.new(:id => 28669546014)
-      expect(tweet.user?).to be_false
+      expect(tweet.user?).to be false
     end
   end
 

data/spec/twitter/user_spec.rb

@@ -1,4 +1,4 @@
-# -*- coding: UTF-8 -*-
+# coding: utf-8
 require 'helper'
 
 describe Twitter::User do
@@ -7,17 +7,17 @@ describe Twitter::User do
     it "returns true when objects IDs are the same" do
       user = Twitter::User.new(:id => 1, :screen_name => "foo")
       other = Twitter::User.new(:id => 1, :screen_name => "bar")
-      expect(user == other).to be_true
+      expect(user == other).to be true
     end
     it "returns false when objects IDs are different" do
       user = Twitter::User.new(:id => 1)
       other = Twitter::User.new(:id => 2)
-      expect(user == other).to be_false
+      expect(user == other).to be false
     end
     it "returns false when classes are different" do
       user = Twitter::User.new(:id => 1)
       other = Twitter::Identity.new(:id => 1)
-      expect(user == other).to be_false
+      expect(user == other).to be false
     end
   end
 
@@ -35,11 +35,11 @@ describe Twitter::User do
   describe "#created?" do
     it "returns true when created_at is set" do
       user = Twitter::User.new(:id => 7505382, :created_at => "Mon Jul 16 12:59:01 +0000 2007")
-      expect(user.created?).to be_true
+      expect(user.created?).to be true
     end
     it "returns false when created_at is not set" do
       user = Twitter::User.new(:id => 7505382)
-      expect(user.created?).to be_false
+      expect(user.created?).to be false
     end
   end
 
@@ -49,7 +49,7 @@ describe Twitter::User do
         {
           :url => "http://example.com/t.co",
           :expanded_url => "http://example.com/expanded",
-          :display_url => "example.com/expanded",
+          :display_url => "example.com/expanded…",
           :indices => [10, 33],
         }
       ]
@@ -57,7 +57,7 @@ describe Twitter::User do
       expect(user.description_uris).to be_an Array
       expect(user.description_uris.first).to be_a Twitter::Entity::URI
       expect(user.description_uris.first.indices).to eq([10, 33])
-      expect(user.description_uris.first.display_uri.to_s).to eq("example.com/expanded")
+      expect(user.description_uris.first.display_uri).to eq("example.com/expanded…")
     end
     it "is empty when not set" do
       user = Twitter::User.new(:id => 7505382, :entities => {:description => {:urls => []}})
@@ -166,11 +166,11 @@ describe Twitter::User do
   describe "#profile_banner_uri?" do
     it "returns true when profile_banner_url is set" do
       user = Twitter::User.new(:id => 7505382, :profile_banner_url => "https://si0.twimg.com/profile_banners/7505382/1348266581")
-      expect(user.profile_banner_uri?).to be_true
+      expect(user.profile_banner_uri?).to be true
     end
     it "returns false when status is not set" do
       user = Twitter::User.new(:id => 7505382)
-      expect(user.profile_banner_uri?).to be_false
+      expect(user.profile_banner_uri?).to be false
     end
   end
 
@@ -267,11 +267,11 @@ describe Twitter::User do
   describe "#profile_image_uri?" do
     it "returns true when profile_banner_url is set" do
       user = Twitter::User.new(:id => 7505382, :profile_image_url_https => "https://si0.twimg.com/profile_banners/7505382/1348266581")
-      expect(user.profile_image_uri?).to be_true
+      expect(user.profile_image_uri?).to be true
     end
     it "returns false when status is not set" do
       user = Twitter::User.new(:id => 7505382)
-      expect(user.profile_image_uri?).to be_false
+      expect(user.profile_image_uri?).to be false
     end
   end
 
@@ -294,11 +294,11 @@ describe Twitter::User do
   describe "#status?" do
     it "returns true when status is set" do
       user = Twitter::User.new(:id => 7505382, :status => {:id => 25938088801})
-      expect(user.status?).to be_true
+      expect(user.status?).to be true
     end
     it "returns false when status is not set" do
       user = Twitter::User.new(:id => 7505382)
-      expect(user.status?).to be_false
+      expect(user.status?).to be false
     end
   end
 
@@ -325,11 +325,11 @@ describe Twitter::User do
   describe "#website?" do
     it "returns true when the url is set" do
       user = Twitter::User.new(:id => 7505382, :url => "https://github.com/sferik")
-      expect(user.website?).to be_true
+      expect(user.website?).to be true
     end
     it "returns false when the url is not set" do
       user = Twitter::User.new(:id => 7505382)
-      expect(user.website?).to be_false
+      expect(user.website?).to be false
     end
   end