twitter 4.4.0 → 4.4.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+4.4.1
+-----
+* [Do not modify `Thread.abort_on_exception`](https://github.com/sferik/twitter/commit/6de998ced1f3dce97a24e500ecf2348192ae9316)
+
 4.4.0
 -----
 * [Add `Twitter::API::FriendsAndFollowers#friends` and `Twitter::API::FriendsAndFollowers#followers`](https://github.com/sferik/twitter/commit/03e1512a8e5e589771414aaf46db34718f1469ce) ([@tibbon](https://twitter.com/tibbon))

data/CONTRIBUTING.md

@@ -12,7 +12,7 @@ Here are some ways *you* can contribute:
 * by writing or editing documentation
 * by writing specifications
 * by writing code (**no patch is too small**: fix typos, add comments, clean up
-inconsistent whitespace)
+  inconsistent whitespace)
 * by refactoring code
 * by fixing [issues][]
 * by reviewing patches
@@ -40,11 +40,13 @@ Ideally, a bug report should include a pull request with failing specs.
 6. Run `bundle exec rake spec`. If your specs fail, return to step 5.
 7. Run `open coverage/index.html`. If your changes are not completely covered
    by your tests, return to step 3.
-8. Add documentation for your feature or bug fix.
-9. Run `bundle exec rake yard`. If your changes are not 100% documented, go
-   back to step 8.
-10. Add, commit, and push your changes.
-11. [Submit a pull request.][pr]
+8  Run `RUBYOPT=W2 bundle exec rake spec 2>&1 | grep twitter`. If your changes
+   produce any warnings, return to step 5.
+9. Add documentation for your feature or bug fix.
+10. Run `bundle exec rake yard`. If your changes are not 100% documented, go
+    back to step 9.
+11. Commit and push your changes.
+12. [Submit a pull request.][pr]
 
 [fork]: http://help.github.com/fork-a-repo/
 [branch]: http://learn.github.com/p/branching.html

data/README.md

@@ -371,7 +371,7 @@ Here are some fun facts about this library:
 
 * It is implemented in just 2,000 lines of Ruby code
 * With over 4,000 lines of specs, the spec-to-code ratio is over 2:1
-* The spec suite contains 700 examples and runs in about 2 seconds
+* The spec suite contains over 700 examples and runs in about 5 seconds
 * It has 100% C0 code coverage (the tests execute every line of
   source code at least once)
 * It is comprehensive: you can request all documented Twitter REST API
@@ -405,6 +405,22 @@ implementation, you will be personally responsible for providing patches in a
 timely fashion. If critical issues for a particular implementation exist at the
 time of a major release, support for that Ruby version may be dropped.
 
+## Versioning
+
+This library aims to adhere to [Semantic Versioning 2.0.0][semver]. Violations
+of this scheme should be reported as bugs. Specifically, if a minor or patch
+version is released that breaks backward compatibility, that version should be
+immediately yanked and/or a new version should be immediately released that
+restores compatibility. Breaking changes to the public API will only be
+introduced with new major versions. As a result of this policy, you can (and
+should) specify a dependency on this gem using the [Pessimistic Version
+Constraint][pvc] with two digits of precision. For example:
+
+    spec.add_dependency 'twitter', '~> 4.0'
+
+[semver]: http://semver.org/
+[pvc]: http://docs.rubygems.org/read/chapter/16#page74
+
 ## Additional Notes
 This will be the last major version of this library to support Ruby 1.8.
 Requiring Ruby 1.9 will allow us to [remove][class_variable_get]

data/lib/twitter.rb

@@ -1,5 +1,34 @@
+require 'twitter/action_factory'
 require 'twitter/client'
 require 'twitter/configurable'
+require 'twitter/configuration'
+require 'twitter/cursor'
+require 'twitter/default'
+require 'twitter/direct_message'
+require 'twitter/entity'
+require 'twitter/entity/hashtag'
+require 'twitter/entity/url'
+require 'twitter/entity/user_mention'
+require 'twitter/geo_factory'
+require 'twitter/language'
+require 'twitter/list'
+require 'twitter/media_factory'
+require 'twitter/metadata'
+require 'twitter/oembed'
+require 'twitter/place'
+require 'twitter/profile_banner'
+require 'twitter/rate_limit'
+require 'twitter/relationship'
+require 'twitter/saved_search'
+require 'twitter/search_results'
+require 'twitter/settings'
+require 'twitter/size'
+require 'twitter/source_user'
+require 'twitter/suggestion'
+require 'twitter/target_user'
+require 'twitter/trend'
+require 'twitter/tweet'
+require 'twitter/user'
 
 module Twitter
   class << self

data/lib/twitter/action/follow.rb

@@ -1,6 +1,5 @@
 require 'twitter/base'
 require 'twitter/creatable'
-require 'twitter/user'
 
 module Twitter
   module Action

data/lib/twitter/action/list_member_added.rb

@@ -1,7 +1,5 @@
 require 'twitter/base'
 require 'twitter/creatable'
-require 'twitter/list'
-require 'twitter/user'
 
 module Twitter
   module Action

data/lib/twitter/action/mention.rb

@@ -1,7 +1,5 @@
 require 'twitter/base'
 require 'twitter/creatable'
-require 'twitter/tweet'
-require 'twitter/user'
 
 module Twitter
   module Action

data/lib/twitter/action/tweet.rb

@@ -1,7 +1,5 @@
 require 'twitter/base'
 require 'twitter/creatable'
-require 'twitter/tweet'
-require 'twitter/user'
 
 module Twitter
   module Action

data/lib/twitter/api/friends_and_followers.rb

@@ -282,10 +282,7 @@ module Twitter
       #   Twitter.followers('sferik')
       #   Twitter.followers(7505382)    # Same as above
       def followers(*args)
-        options = extract_options!(args)
-        merge_user!(options, args.pop || screen_name)
-        merge_default_cursor!(options)
-        cursor_from_response(:users, Twitter::User, :get, "/1.1/followers/list.json", options)
+        friends_or_followers_from_response(:get, "/1.1/followers/list.json", args)
       end
 
       # Returns a cursored collection of user objects for every user the specified user is following (otherwise known as their "friends").
@@ -316,12 +313,23 @@ module Twitter
       #   Twitter.friends('sferik')
       #   Twitter.friends(7505382)    # Same as above
       def friends(*args)
+        friends_or_followers_from_response(:get, "/1.1/friends/list.json", args)
+      end
+      alias following friends
+
+    private
+
+      # @param request_method [Symbol]
+      # @param path [String]
+      # @param args [Array]
+      # @return [Array<Integer>]
+      def friends_or_followers_from_response(request_method, path, args)
         options = extract_options!(args)
-        merge_user!(options, args.pop || screen_name)
         merge_default_cursor!(options)
-        cursor_from_response(:users, Twitter::User, :get, "/1.1/friends/list.json", options)
+        merge_user!(options, args.pop || screen_name)
+        cursor_from_response(:users, Twitter::User, request_method, path, options, calling_method)
       end
-      alias following friends
+
     end
   end
 end

data/lib/twitter/api/places_and_geo.rb

@@ -12,7 +12,7 @@ module Twitter
       # @rate_limited Yes
       # @authentication_required Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
-      # @param place_id [String] A place in the world. These IDs can be retrieved from {Twitter::API::Geo#reverse_geocode}.
+      # @param place_id [String] A place in the world. These IDs can be retrieved from {Twitter::API::PlacesAndGeo#reverse_geocode}.
       # @param options [Hash] A customizable set of options.
       # @return [Twitter::Place] The requested place.
       # @example Return all the information about Twitter HQ
@@ -41,7 +41,7 @@ module Twitter
         geo_collection_from_response(:get, "/1.1/geo/reverse_geocode.json", options)
       end
 
-      # Search for places that can be attached to a {Twitter::API::Statuses#update}
+      # Search for places that can be attached to a {Twitter::API::Tweets#update}
       #
       # @see https://dev.twitter.com/docs/api/1.1/get/geo/search
       # @rate_limited Yes
@@ -68,7 +68,7 @@ module Twitter
       # Locates places near the given coordinates which are similar in name
       #
       # @see https://dev.twitter.com/docs/api/1.1/get/geo/similar_places
-      # @note Conceptually, you would use this method to get a list of known places to choose from first. Then, if the desired place doesn't exist, make a request to {Twitter::API::Geo#place} to create a new one. The token contained in the response is the token necessary to create a new place.
+      # @note Conceptually, you would use this method to get a list of known places to choose from first. Then, if the desired place doesn't exist, make a request to {Twitter::API::PlacesAndGeo#place} to create a new one. The token contained in the response is the token necessary to create a new place.
       # @rate_limited Yes
       # @authentication_required Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
@@ -95,7 +95,7 @@ module Twitter
       # @param options [Hash] A customizable set of options.
       # @option options [String] :name The name a place is known as.
       # @option options [String] :contained_within This is the place_id which you would like to restrict the search results to. Setting this value means only places within the given place_id will be found.
-      # @option options [String] :token The token found in the response from {Twitter::API::Geo#places_similar}.
+      # @option options [String] :token The token found in the response from {Twitter::API::PlacesAndGeo#places_similar}.
       # @option options [Float] :lat The latitude to search around. This option will be ignored unless it is inside the range -90.0 to +90.0 (North is positive) inclusive. It will also be ignored if there isn't a corresponding :long option.
       # @option options [Float] :long The longitude to search around. The valid range for longitude is -180.0 to +180.0 (East is positive) inclusive. This option will be ignored if outside that range, if it is not a number, if geo_enabled is disabled, or if there not a corresponding :lat option.
       # @option options [String] :"attribute:street_address" This option searches for places which have this given street address. There are other well-known and application-specific attributes available. Custom attributes are also permitted.
@@ -110,7 +110,7 @@ module Twitter
 
       # @param request_method [Symbol]
       # @param path [String]
-      # @param options [Hash]
+      # @param params [Hash]
       # @return [Array]
       def geo_collection_from_response(request_method, path, params={})
         collection_from_array(Twitter::Place, send(request_method.to_sym, path, params)[:body][:result][:places])

data/lib/twitter/api/timelines.rb

@@ -88,7 +88,6 @@ module Twitter
       # @authentication_required Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
       # @return [Array<Twitter::Tweet>]
-      # @param user [Integer, String, Twitter::User] A Twitter user ID, screen name, or object.
       # @param options [Hash] A customizable set of options.
       # @option options [Integer] :since_id Returns results with an ID greater than (that is, more recent than) the specified ID.
       # @option options [Integer] :max_id Returns results with an ID less than (that is, older than) or equal to the specified ID.
@@ -99,8 +98,8 @@ module Twitter
       # @example Return the 20 most recent retweets posted by the authenticating user
       #   Twitter.retweeted_by_me
       def retweeted_by_me(options={})
-        retweets_from_timeline(options) do |options|
-          user_timeline(options)
+        retweets_from_timeline(options) do |opts|
+          user_timeline(opts)
         end
       end
 
@@ -146,8 +145,8 @@ module Twitter
       # @example Return the 20 most recent retweets posted by users followed by the authenticating user
       #   Twitter.retweeted_to_me
       def retweeted_to_me(options={})
-        retweets_from_timeline(options) do |options|
-          home_timeline(options)
+        retweets_from_timeline(options) do |opts|
+          home_timeline(opts)
         end
       end
 

data/lib/twitter/api/tweets.rb

@@ -119,7 +119,7 @@ module Twitter
       # @option options [Integer] :in_reply_to_status_id The ID of an existing status that the update is in reply to.
       # @option options [Float] :lat The latitude of the location this tweet refers to. This option will be ignored unless it is inside the range -90.0 to +90.0 (North is positive) inclusive. It will also be ignored if there isn't a corresponding :long option.
       # @option options [Float] :long The longitude of the location this tweet refers to. The valid ranges for longitude is -180.0 to +180.0 (East is positive) inclusive. This option will be ignored if outside that range, if it is not a number, if geo_enabled is disabled, or if there not a corresponding :lat option.
-      # @option options [String] :place_id A place in the world. These IDs can be retrieved from {Twitter::API::Geo#reverse_geocode}.
+      # @option options [String] :place_id A place in the world. These IDs can be retrieved from {Twitter::API::PlacesAndGeo#reverse_geocode}.
       # @option options [String] :display_coordinates Whether or not to put a pin on the exact coordinates a tweet has been sent from.
       # @option options [Boolean, String, Integer] :trim_user Each tweet returned in a timeline will include a user object with only the author's numerical ID when set to true, 't' or 1.
       # @example Update the authenticating user's status
@@ -195,7 +195,7 @@ module Twitter
       # @option options [Integer] :in_reply_to_status_id The ID of an existing Tweet that the update is in reply to.
       # @option options [Float] :lat The latitude of the location this tweet refers to. This option will be ignored unless it is inside the range -90.0 to +90.0 (North is positive) inclusive. It will also be ignored if there isn't a corresponding :long option.
       # @option options [Float] :long The longitude of the location this tweet refers to. The valid ranges for longitude is -180.0 to +180.0 (East is positive) inclusive. This option will be ignored if outside that range, if it is not a number, if geo_enabled is disabled, or if there not a corresponding :lat option.
-      # @option options [String] :place_id A place in the world. These IDs can be retrieved from {Twitter::API::Geo#reverse_geocode}.
+      # @option options [String] :place_id A place in the world. These IDs can be retrieved from {Twitter::API::PlacesAndGeo#reverse_geocode}.
       # @option options [String] :display_coordinates Whether or not to put a pin on the exact coordinates a tweet has been sent from.
       # @option options [Boolean, String, Integer] :trim_user Each tweet returned in a timeline will include a user object with only the author's numerical ID when set to true, 't' or 1.
       # @example Update the authenticating user's status

data/lib/twitter/api/users.rb

@@ -158,9 +158,10 @@ module Twitter
       # @authentication_required Requires user context
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
       # @return [Array] Numeric user ids the authenticating user is blocking.
-      # @param options [Hash] A customizable set of options.
       # @example Return an array of numeric user ids the authenticating user is blocking
       #   Twitter.blocking_ids
+      # @overload block(options={})
+      #   @param options [Hash] A customizable set of options.
       def blocked_ids(*args)
         ids_from_response(:get, "/1.1/blocks/ids.json", args)
       end
@@ -247,9 +248,8 @@ module Twitter
       #   @option options [Symbol, String] :method Requests users via a GET request instead of the standard POST request if set to ':get'.
       #   @option options [Boolean] :include_entities The tweet entities node will be disincluded when set to false.
       #   @example Return extended information for @sferik and @pengwynn
-      #     Twitter.users('sferik', 'pengwynn', :method => :get)  # Retrieve users with a GET request
-      #     Twitter.users(7505382, 14100886, {:method => :get})   # Same as above
-      #     Twitter.users(7505382, 14100886, {:method => :get, :include_entities => false}) # See Twitter API documentation
+      #     Twitter.users('sferik', 'pengwynn', :method => :get) # Retrieve users with a GET request
+      #     Twitter.users(7505382, 14100886, :method => :get)    # Same as above
       def users(*args)
         options = extract_options!(args)
         method = options.delete(:method) || :post
@@ -394,7 +394,7 @@ module Twitter
       # @raise [Twitter::Error::Unauthorized] Error raised when supplied user credentials are not valid.
       # @raise [Twitter::Error::UnprocessableEntity] Error raised when the image could not be resized or is too large.
       # @return [nil]
-      # @param image [File] The Base64-encoded or raw image data being uploaded as the user's new profile banner.
+      # @param banner [File] The Base64-encoded or raw image data being uploaded as the user's new profile banner.
       # @param options [Hash] A customizable set of options.
       # @option options [Integer] :width The width of the preferred section of the image being uploaded in pixels. Use with height, offset_left, and offset_top to select the desired region of the image to use.
       # @option options [Integer] :height The height of the preferred section of the image being uploaded in pixels. Use with width, offset_left, and offset_top to select the desired region of the image to use.

data/lib/twitter/api/utils.rb

@@ -24,7 +24,6 @@ module Twitter
       # @param request_method [Symbol]
       # @param path [String]
       # @param params [Hash]
-      # @param options [Hash]
       # @return [Array]
       def collection_from_response(klass, request_method, path, params={})
         collection_from_array(klass, send(request_method.to_sym, path, params)[:body])
@@ -34,7 +33,6 @@ module Twitter
       # @param request_method [Symbol]
       # @param path [String]
       # @param params [Hash]
-      # @param options [Hash]
       # @return [Object]
       def object_from_response(klass, request_method, path, params={})
         response = send(request_method.to_sym, path, params)
@@ -68,7 +66,7 @@ module Twitter
       # @param request_method [Symbol]
       # @param path [String]
       # @param params [Hash]
-      # @param options [Hash]
+      # @param method_name [Symbol]
       # @return [Twitter::Cursor]
       def cursor_from_response(collection_name, klass, request_method, path, params={}, method_name=calling_method)
         response = send(request_method.to_sym, path, params)

data/lib/twitter/configurable.rb

@@ -1,5 +1,3 @@
-require 'twitter/default'
-
 module Twitter
   module Configurable
     attr_writer :consumer_key, :consumer_secret, :oauth_token, :oauth_token_secret

data/lib/twitter/configuration.rb

@@ -1,5 +1,4 @@
 require 'twitter/base'
-require 'twitter/size'
 
 module Twitter
   class Configuration < Twitter::Base

data/lib/twitter/core_ext/enumerable.rb

@@ -1,23 +1,10 @@
 module Enumerable
 
   def threaded_map
-    abort_on_exception do
-      threads = []
-      each do |object|
-        threads << Thread.new { yield object }
-      end
-      threads.map(&:value)
+    threads = map do |object|
+      Thread.new { yield object }
     end
-  end
-
-private
-
-  def abort_on_exception
-    initial_abort_on_exception = Thread.abort_on_exception
-    Thread.abort_on_exception ||= true
-    yield
-  ensure
-    Thread.abort_on_exception = initial_abort_on_exception
+    threads.map(&:value)
   end
 
 end

data/lib/twitter/direct_message.rb

@@ -1,6 +1,5 @@
 require 'twitter/creatable'
 require 'twitter/identity'
-require 'twitter/user'
 
 module Twitter
   class DirectMessage < Twitter::Identity

data/lib/twitter/error.rb

@@ -1,5 +1,3 @@
-require 'twitter/rate_limit'
-
 module Twitter
   # Custom error class for rescuing from all Twitter errors
   class Error < StandardError

data/lib/twitter/list.rb

@@ -1,6 +1,5 @@
 require 'twitter/creatable'
 require 'twitter/identity'
-require 'twitter/user'
 
 module Twitter
   class List < Twitter::Identity

data/lib/twitter/media/photo.rb

@@ -1,5 +1,4 @@
 require 'twitter/identity'
-require 'twitter/size'
 
 module Twitter
   module Media

data/lib/twitter/place.rb

@@ -1,4 +1,3 @@
-require 'twitter/geo_factory'
 require 'twitter/identity'
 
 module Twitter

data/lib/twitter/profile_banner.rb

@@ -1,5 +1,4 @@
 require 'twitter/base'
-require 'twitter/size'
 
 module Twitter
   class ProfileBanner < Twitter::Base

data/lib/twitter/relationship.rb

@@ -1,6 +1,4 @@
 require 'twitter/base'
-require 'twitter/source_user'
-require 'twitter/target_user'
 
 module Twitter
   class Relationship < Twitter::Base

data/lib/twitter/request/multipart_with_file.rb

@@ -3,17 +3,12 @@ require 'faraday'
 module Twitter
   module Request
     class MultipartWithFile < Faraday::Middleware
-      CONTENT_TYPE = 'Content-Type'.freeze
-      class << self
-        attr_accessor :mime_type
-        mime_type = 'multipart/form-data'.freeze
-      end
+      CONTENT_TYPE = 'Content-Type'
 
       def call(env)
         env[:body].each do |key, value|
           if value.respond_to?(:to_io)
             env[:body][key] = Faraday::UploadIO.new(value, mime_type(value.path), value.path)
-            env[:request_headers][CONTENT_TYPE] = self.class.mime_type
           end
         end if env[:body].is_a?(::Hash)
         @app.call(env)

data/lib/twitter/search_results.rb

@@ -1,5 +1,4 @@
 require 'twitter/base'
-require 'twitter/tweet'
 
 module Twitter
   class SearchResults < Twitter::Base

data/lib/twitter/settings.rb

@@ -1,5 +1,4 @@
 require 'twitter/base'
-require 'twitter/place'
 
 module Twitter
   class Settings < Twitter::Base

data/lib/twitter/suggestion.rb

@@ -1,5 +1,4 @@
 require 'twitter/base'
-require 'twitter/user'
 
 module Twitter
   class Suggestion < Twitter::Base

data/lib/twitter/tweet.rb

@@ -1,14 +1,6 @@
 require 'twitter/creatable'
-require 'twitter/entity/hashtag'
-require 'twitter/entity/url'
-require 'twitter/entity/user_mention'
 require 'twitter/exceptable'
-require 'twitter/geo_factory'
 require 'twitter/identity'
-require 'twitter/media_factory'
-require 'twitter/metadata'
-require 'twitter/place'
-require 'twitter/user'
 
 module Twitter
   class Tweet < Twitter::Identity

data/lib/twitter/user.rb

@@ -1,7 +1,6 @@
 require 'twitter/basic_user'
 require 'twitter/creatable'
 require 'twitter/exceptable'
-require 'twitter/tweet'
 
 module Twitter
   class User < Twitter::BasicUser

data/lib/twitter/version.rb

@@ -2,7 +2,7 @@ module Twitter
   class Version
     MAJOR = 4 unless defined? Twitter::Version::MAJOR
     MINOR = 4 unless defined? Twitter::Version::MINOR
-    PATCH = 0 unless defined? Twitter::Version::PATCH
+    PATCH = 1 unless defined? Twitter::Version::PATCH
     PRE = nil unless defined? Twitter::Version::PRE
 
     class << self

data/spec/twitter/client_spec.rb

@@ -3,9 +3,7 @@ require 'helper'
 describe Twitter::Client do
 
   subject do
-    client = Twitter::Client.new(:consumer_key => "CK", :consumer_secret => "CS", :oauth_token => "OT", :oauth_token_secret => "OS")
-    client.class_eval{public *Twitter::Client.private_instance_methods}
-    client
+    Twitter::Client.new(:consumer_key => "CK", :consumer_secret => "CS", :oauth_token => "OT", :oauth_token_secret => "OS")
   end
 
   context "with module configuration" do
@@ -112,10 +110,10 @@ describe Twitter::Client do
 
   describe "#connection" do
     it "looks like Faraday connection" do
-      expect(subject.connection).to respond_to(:run_request)
+      expect(subject.send(:connection)).to respond_to(:run_request)
     end
     it "memoizes the connection" do
-      c1, c2 = subject.connection, subject.connection
+      c1, c2 = subject.send(:connection), subject.send(:connection)
       expect(c1.object_id).to eq c2.object_id
     end
   end
@@ -133,18 +131,18 @@ describe Twitter::Client do
     end
     it "catches Faraday errors" do
       subject.stub!(:connection).and_raise(Faraday::Error::ClientError.new("Oops"))
-      expect{subject.request(:get, "/path")}.to raise_error Twitter::Error::ClientError
+      expect{subject.send(:request, :get, "/path")}.to raise_error Twitter::Error::ClientError
     end
     it "catches MultiJson::DecodeError errors" do
       subject.stub!(:connection).and_raise(MultiJson::DecodeError.new("unexpected token", [], "<!DOCTYPE html>"))
-      expect{subject.request(:get, "/path")}.to raise_error Twitter::Error::DecodeError
+      expect{subject.send(:request, :get, "/path")}.to raise_error Twitter::Error::DecodeError
     end
   end
 
   describe "#auth_header" do
     it "creates the correct auth headers" do
       uri = "/1.1/direct_messages.json"
-      authorization = subject.auth_header(:get, uri)
+      authorization = subject.send(:auth_header, :get, uri)
       expect(authorization.options[:signature_method]).to eq "HMAC-SHA1"
       expect(authorization.options[:version]).to eq "1.0"
       expect(authorization.options[:consumer_key]).to eq "CK"

data/spec/twitter/error/client_error_spec.rb

@@ -20,24 +20,4 @@ describe Twitter::Error::ClientError do
     end
   end
 
-  context "when response status is 404 from lookup" do
-    context "using a post request" do
-      before do
-        stub_post("/1.1/users/lookup.json").with(:body => {:screen_name => "not_on_twitter"}).to_return(:status => 404, :body => fixture('no_user_matches.json'))
-      end
-      it "raises Twitter::Error::NotFound" do
-        expect{@client.users('not_on_twitter')}.to raise_error Twitter::Error::NotFound
-      end
-    end
-
-    context "using a get request" do
-      before do
-        stub_get("/1.1/users/lookup.json").with(:query => {:screen_name => "not_on_twitter"}).to_return(:status => 404, :body => fixture('no_user_matches.json'))
-      end
-      it "raises Twitter::Error::NotFound" do
-        expect{@client.users('not_on_twitter', :method => :get)}.to raise_error Twitter::Error::NotFound
-      end
-    end
-  end
-
 end

data/spec/twitter/geo/point_spec.rb

@@ -28,7 +28,7 @@ describe Twitter::Geo::Point do
 
   describe "#latitude" do
     it "returns the latitude" do
-      expect(@point.latitude).to eq -122.399983
+      expect(@point.latitude).to eq(-122.399983)
     end
   end
 

data/spec/twitter/tweet_spec.rb

@@ -122,7 +122,7 @@ describe Twitter::Tweet do
     end
     it "warns when not set" do
       Twitter::Tweet.new(:id => 28669546014).hashtags
-      expect($stderr.string).to match /To get hashtags, you must pass `:include_entities => true` when requesting the Twitter::Tweet\./
+      expect($stderr.string).to match(/To get hashtags, you must pass `:include_entities => true` when requesting the Twitter::Tweet\./)
     end
   end
 
@@ -138,7 +138,7 @@ describe Twitter::Tweet do
     end
     it "warns when not set" do
       Twitter::Tweet.new(:id => 28669546014).media
-      expect($stderr.string).to match /To get media, you must pass `:include_entities => true` when requesting the Twitter::Tweet\./
+      expect($stderr.string).to match(/To get media, you must pass `:include_entities => true` when requesting the Twitter::Tweet\./)
     end
   end
 
@@ -269,7 +269,7 @@ describe Twitter::Tweet do
     end
     it "warns when not set" do
       Twitter::Tweet.new(:id => 28669546014).urls
-      expect($stderr.string).to match /To get urls, you must pass `:include_entities => true` when requesting the Twitter::Tweet\./
+      expect($stderr.string).to match(/To get urls, you must pass `:include_entities => true` when requesting the Twitter::Tweet\./)
     end
   end
 
@@ -322,7 +322,7 @@ describe Twitter::Tweet do
     end
     it "warns when not set" do
       Twitter::Tweet.new(:id => 28669546014).user_mentions
-      expect($stderr.string).to match /To get user mentions, you must pass `:include_entities => true` when requesting the Twitter::Tweet\./
+      expect($stderr.string).to match(/To get user mentions, you must pass `:include_entities => true` when requesting the Twitter::Tweet\./)
     end
   end
 

data/twitter.gemspec

@@ -4,12 +4,12 @@ require File.expand_path('../lib/twitter/version', __FILE__)
 Gem::Specification.new do |spec|
   spec.add_dependency 'faraday', '~> 0.8'
   spec.add_dependency 'multi_json', '~> 1.3'
-  spec.add_dependency 'simple_oauth', '~> 0.1.6'
-  spec.add_development_dependency 'oj'
+  spec.add_dependency 'simple_oauth', '~> 0.2'
+  spec.add_development_dependency 'json'
+  spec.add_development_dependency 'kramdown'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'pry-nav'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'redcarpet'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'timecop'

metadata

@@ -1,15 +1,10 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: twitter
-version: !ruby/object:Gem::Version 
-  hash: 47
+version: !ruby/object:Gem::Version
   prerelease: 
-  segments: 
-  - 4
-  - 4
-  - 0
-  version: 4.4.0
+  version: 4.4.1
 platform: ruby
-authors: 
+authors:
 - John Nunemaker
 - Wynn Netherland
 - Erik Michaels-Ober
@@ -17,208 +12,226 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-11-30 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: faraday
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+date: 2012-12-08 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 27
-        segments: 
-        - 0
-        - 8
-        version: "0.8"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+    none: false
+  name: faraday
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: multi_json
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.8'
     none: false
-    requirements: 
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 9
-        segments: 
-        - 1
-        - 3
-        version: "1.3"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+    none: false
+  name: multi_json
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: simple_oauth
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
     none: false
-    requirements: 
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 0
-        - 1
-        - 6
-        version: 0.1.6
+      - !ruby/object:Gem::Version
+        version: '0.2'
+    none: false
+  name: simple_oauth
   type: :runtime
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: oj
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.2'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+  name: json
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: pry
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: kramdown
   type: :development
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
-  name: pry-nav
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: pry
   type: :development
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
-  name: rake
   prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: pry-nav
   type: :development
-  version_requirements: *id007
-- !ruby/object:Gem::Dependency 
-  name: redcarpet
   prerelease: false
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: rake
   type: :development
-  version_requirements: *id008
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: rspec
   type: :development
-  version_requirements: *id009
-- !ruby/object:Gem::Dependency 
-  name: simplecov
   prerelease: false
-  requirement: &id010 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: simplecov
   type: :development
-  version_requirements: *id010
-- !ruby/object:Gem::Dependency 
-  name: timecop
   prerelease: false
-  requirement: &id011 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: timecop
   type: :development
-  version_requirements: *id011
-- !ruby/object:Gem::Dependency 
-  name: webmock
   prerelease: false
-  requirement: &id012 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: webmock
   type: :development
-  version_requirements: *id012
-- !ruby/object:Gem::Dependency 
-  name: yard
   prerelease: false
-  requirement: &id013 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  name: yard
   type: :development
-  version_requirements: *id013
+  prerelease: false
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
 description: A Ruby interface to the Twitter API.
-email: 
+email:
 - nunemaker@gmail.com
 - wynn.netherland@gmail.com
 - sferik@gmail.com
 - steve.richert@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .yardopts
 - CHANGELOG.md
 - CONTRIBUTING.md
@@ -353,7 +366,6 @@ files:
 - spec/fixtures/media_timeline.json
 - spec/fixtures/members.json
 - spec/fixtures/memberships.json
-- spec/fixtures/no_user_matches.json
 - spec/fixtures/not_acceptable.json
 - spec/fixtures/not_following.json
 - spec/fixtures/not_found.json
@@ -458,41 +470,31 @@ files:
 - spec/twitter/user_spec.rb
 - spec/twitter_spec.rb
 homepage: http://sferik.github.com/twitter/
-licenses: 
+licenses:
 - MIT
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 23
-      segments: 
-      - 1
-      - 3
-      - 6
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
       version: 1.3.6
+  none: false
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: A Ruby interface to the Twitter API.
-test_files: 
+test_files:
 - spec/fixtures/about_me.json
 - spec/fixtures/activity_summary.json
 - spec/fixtures/all.json
@@ -530,7 +532,6 @@ test_files:
 - spec/fixtures/media_timeline.json
 - spec/fixtures/members.json
 - spec/fixtures/memberships.json
-- spec/fixtures/no_user_matches.json
 - spec/fixtures/not_acceptable.json
 - spec/fixtures/not_following.json
 - spec/fixtures/not_found.json

data/spec/fixtures/no_user_matches.json

@@ -1 +0,0 @@
-{"errors":[{"code":17,"message":"No user matches for specified terms"}]}