twitter-bootstrap-rails 3.2.0 → 5.0.0

data/spec/lib/breadcrumbs_spec.rb

@@ -18,7 +18,7 @@ describe Twitter::Bootstrap::Breadcrumbs do
     add_breadcrumb :base_i18n, '/base_i18n'
 
     def breadcrumbs
-      @breadcrumbs
+      @__bs_breadcrumbs
     end
   end
 
@@ -46,29 +46,54 @@ describe Twitter::Bootstrap::Breadcrumbs do
     end
   end
 
-  before do
-    options = { :scope => [:breadcrumbs, 'test'] }
-    [:class_i18n, :instance_i18n, :show, :symbolized].each do |name|
-      I18n.expects(:t).with(name, options).returns(name.to_s)
+  describe 'Breadcrumbs generation' do
+
+    before do
+      options = { :scope => [:breadcrumbs, 'test'] }
+      [:class_i18n, :instance_i18n, :show, :symbolized].each do |name|
+        I18n.expects(:t).with(name, options).returns(name.to_s)
+      end
+
+      name = :base_i18n
+      options = { :scope => [:breadcrumbs, 'base_test'] }
+      I18n.expects(:t).with(name, options).returns(name)
+
+      @controller = TestController.new
+      @controller.process(:show)
     end
 
-    name = :base_i18n
-    options = { :scope => [:breadcrumbs, 'base_test'] }
-    I18n.expects(:t).with(name, options).returns(name)
+    it "have breadcrumbs" do
+      [:base, :base_i18n, :class, :class_i18n, :instance, :instance_i18n, :test_model, :symbolized].each do |name|
+        path = "/#{name}"
+        idx = @controller.breadcrumbs.index { |b| b[:name] == name.to_s && b[:url] == path }
+        expect(idx).to be, -> { name }
+      end
 
-    @controller = TestController.new
-    @controller.process(:show)
+      idx = @controller.breadcrumbs.index { |b| b[:name] == "show" && b[:url] == '' }
+      expect(idx).to be
+    end
   end
 
-  it "have breadcrumbs" do
-    [:base, :base_i18n, :class, :class_i18n, :instance, :instance_i18n, :test_model, :symbolized].each do |name|
-      path = "/#{name}"
-      idx = @controller.breadcrumbs.index { |b| b[:name] == name.to_s && b[:url] == path }
-      idx.should be, -> { name }
+  describe 'BreadcrumbsOnRails compatibility' do
+    class SomeController < AbstractController::Base
+    end
+    let(:logger) { double('logger').as_null_object }
+    before { allow(::Rails).to receive(:logger).and_return(logger) }
+
+    context 'when BreadcrumbsOnRails is defined' do
+      before do
+        stub_const('BreadcrumbsOnRails', 1)
+        expect(defined?(::BreadcrumbsOnRails)).to be_truthy
+        expect(logger).to receive(:info).with /BreadcrumbsOnRails detected/
+        SomeController.send(:include, Twitter::Bootstrap::Breadcrumbs)
+      end
+
+      it 'does not define aliases' do
+        expect(SomeController).to respond_to :add_bootstrap_breadcrumb
+        expect(SomeController).not_to respond_to :add_breadcrumb
+      end
     end
 
-    idx = @controller.breadcrumbs.index { |b| b[:name] == "show" && b[:url] == '' }
-    idx.should be
   end
 
 end

data/spec/lib/twitter_bootstrap_rails/badge_label_helper_spec.rb

@@ -10,15 +10,21 @@ include BadgeLabelHelper
 
 describe BadgeLabelHelper, :type => :helper do
   it "should return a basic bootstrap badge" do
-    expect(badge('test').gsub(/\s/, '').downcase)
+    expect(badge('New!').gsub(/\s/, '').downcase)
       .to eql(BASIC_BADGE.gsub(/\s/, '').downcase)
   end
 
   it "should return a bootstrap badge with class" do
-    expect(badge('waning', :warning).gsub(/\s/, '').downcase)
+    expect(badge('2', :warning).gsub(/\s/, '').downcase)
       .to eql(BADGE_WITH_CLASS.gsub(/\s/, '').downcase)
   end
+
+  it "should take a Number as its first parameter" do
+  	expect(badge(12).gsub(/\s/, '').downcase)
+  	.to eql(BADGE_WITH_NUMBER_PARAM.gsub(/\s/, '').downcase)
+  end
 end
 
-BASIC_BADGE = %{<span class="badge">test</span>}
-BADGE_WITH_CLASS = %{<span class="badge badge-warning">waning</span>}
+BASIC_BADGE = %{<span class="badge">New!</span>}
+BADGE_WITH_CLASS = %{<span class="badge badge-warning">2</span>}
+BADGE_WITH_NUMBER_PARAM = %{<span class="badge">12</span>}

data/spec/lib/twitter_bootstrap_rails/bootstrap_flash_helper_spec.rb

@@ -0,0 +1,128 @@
+# encoding: utf-8
+require 'spec_helper'
+require 'action_view'
+require 'active_support'
+require_relative '../../../app/helpers/bootstrap_flash_helper'
+
+include ActionView::Helpers
+include ActionView::Context
+include BootstrapFlashHelper
+
+describe BootstrapFlashHelper, type: :helper do
+  before do
+    allow(self).to receive(:uri_state) { :inactive }
+    allow(self).to receive(:root_url) { '/' }
+  end
+
+  describe "bootstrap_flash" do
+    it "should not return anything without flashes" do
+      allow(self).to receive(:flash) { {} }
+
+      element = bootstrap_flash
+
+      expect(element).to eql("")
+    end
+
+    it "should work with a notice" do
+      allow(self).to receive(:flash) { {notice: "Hello"} }
+
+      element = bootstrap_flash
+
+      expect(element).to have_tag(:div,
+        text: "×Hello",
+        with: {class: "alert fade in alert-success"}) {
+
+        with_tag(:button,
+          text: "×",
+          with: {
+            class: "close",
+            "data-dismiss" => "alert"
+          }
+        )
+
+      }
+    end
+
+    it "should work with a notice and an extra class" do
+      allow(self).to receive(:flash) { {notice: "Hello"} }
+
+      element = bootstrap_flash(class: "extra-class")
+
+      expect(element).to have_tag(:div,
+        text: "×Hello",
+        with: {class: "alert fade in alert-success extra-class"}) {
+
+        with_tag(:button,
+          text: "×",
+          with: {
+            class: "close",
+            "data-dismiss" => "alert"
+          }
+        )
+
+      }
+    end
+
+    it "should work with a notice and an extra class and an extra attribute" do
+      allow(self).to receive(:flash) { {notice: "Hello"} }
+
+      element = bootstrap_flash(class: "extra-class", "data-no-transition-cache" => true)
+
+      expect(element).to have_tag(:div,
+        text: "×Hello",
+        with: {
+          class: "alert fade in alert-success extra-class",
+          "data-no-transition-cache" => true
+        }) {
+
+        with_tag(:button,
+          text: "×",
+          with: {
+            class: "close",
+            "data-dismiss" => "alert"
+          }
+        )
+
+      }
+    end
+
+    it "should escape javascript if not marked as safe by user" do
+      allow(self).to receive(:flash) { {notice: "<script>alert(1)</script>"} }
+
+      element = bootstrap_flash
+
+      expect(element).to have_tag(:div,
+                                  text: "×<script>alert(1)</script>",
+                                  with: {class: "alert fade in alert-success"}) {
+                           with_tag(:button,
+                                    text: "×",
+                                    with: {
+                                        class: "close",
+                                        "data-dismiss" => "alert"
+                                    }
+                           )
+                         }
+    end
+
+    it "should not escape a link if marked as safe by user" do
+      allow(self).to receive(:flash) { {notice: "<a href='example.com'>awesome link!</a>".html_safe} }
+
+      element = bootstrap_flash
+
+      expect(element).to have_tag(:div,
+                                  text: "×awesome link!",
+                                  with: {class: "alert fade in alert-success"}) { [
+                             with_tag(:button,
+                                      text: "×",
+                                      with: {
+                                          class: "close",
+                                          "data-dismiss" => "alert"
+                                      }
+                             ),
+                             with_tag(:a,
+                                      text: 'awesome link!')
+                         ]
+                         }
+    end
+  end
+end

data/spec/lib/twitter_bootstrap_rails/form_errors_helper_spec.rb

@@ -0,0 +1,148 @@
+# encoding: utf-8
+require 'spec_helper'
+require 'action_view'
+require 'active_support'
+require 'rspec/active_model/mocks'
+
+require_relative '../../../app/helpers/form_errors_helper'
+
+include ActionView::Helpers
+include ActionView::Context
+include FormErrorsHelper
+
+describe FormErrorsHelper, :type => :helper do
+
+  before do
+    @base_errors = ['base error message', 'nasty error']
+    @base_error = 'one base error'
+
+
+    @title_errors = ["can't be blank", 'is too short (minimum is 5 characters)']
+    @title_error = "can't be blank"
+
+    @errors = double('errors')
+    @new_post =  mock_model( 'Post' )
+    allow(@new_post).to receive_messages(:errors => @errors)
+    allow(self).to receive_messages(:post_path => '/post/1')
+    allow(self).to receive_messages(:protect_against_forgery? => false)
+    allow(self).to receive_messages(:polymorphic_path => '')
+
+    @default_class = 'help-block'
+    @default_error_class = 'has-error'
+  end
+
+
+  describe 'error[:base] is a string' do
+
+    before do
+      allow(@errors).to receive(:[]).with(:base).and_return(@base_error)
+    end
+
+    it 'should render base error on :base key' do
+      form_for(@new_post) do |builder|
+        expect(builder.error_span(:base)).to have_tag("div.#{@default_error_class}") do
+          with_tag("span.#{@default_class}", :text => @base_error)
+        end
+      end
+    end
+
+  end
+
+
+  describe 'when there is only one error on base' do
+
+    before do
+      allow(@errors).to receive(:[]).with(:base).and_return(@base_error)
+    end
+
+    it 'should render base error on :base key' do
+      form_for(@new_post) do |builder|
+        expect(builder.error_span(:base)).to have_tag("div.#{@default_error_class}") do
+          with_tag("span.#{@default_class}", :text => @base_error)
+        end
+      end
+    end
+
+  end
+
+  describe 'when there is only one error on title' do
+
+    before do
+      allow(@errors).to receive(:[]).with(:title).and_return(@title_error)
+    end
+
+    it 'should render base errors join with comma' do
+      form_for(@new_post) do |builder|
+        expect(builder.error_span(:title)).to have_tag("div.#{@default_error_class}") do
+          with_tag("span.#{@default_class}", :text => @title_error)
+        end
+      end
+    end
+  end
+
+
+
+  describe 'when there is more than one error on title' do
+
+    before do
+      allow(@errors).to receive(:[]).with(:title).and_return(@title_errors)
+    end
+
+    it 'should render base errors join with comma' do
+      form_for(@new_post) do |builder|
+        expect(builder.error_span(:title)).to have_tag("div.#{@default_error_class}") do
+          with_tag("span.#{@default_class}", :text => @title_errors.join(', '))
+        end
+      end
+    end
+  end
+
+
+  describe 'when there are no errors' do
+    before do
+      allow(@errors).to receive(:[]).with(:title).and_return(nil)
+    end
+
+    it 'should return nil' do
+      form_for(@new_post) do |builder|
+        expect(builder.error_span(:title)).to be_nil
+      end
+    end
+  end
+
+  describe 'when :error_class option is passed' do
+    let(:error_class) { 'has_warning' }
+
+    before do
+      allow(@errors).to receive(:[]).with(:title).and_return(@title_error)
+    end
+
+    it "should render with passed error class " do
+      form_for(@new_post) do |builder|
+        expect(builder.error_span(:title, :error_class => error_class))
+        .to have_tag("div.#{error_class}") do
+          with_tag("span.#{@default_class}", :text => @title_error)
+        end
+      end
+    end
+  end
+
+  describe 'when :error_class option is passed' do
+    let(:span_class) { 'help-inline' }
+
+    before do
+      allow(@errors).to receive(:[]).with(:title).and_return(@title_error)
+    end
+
+    it "should render with passed error class " do
+      form_for(@new_post) do |builder|
+        expect(builder.error_span(:title, :span_class => span_class))
+        .to have_tag("div.#{@default_error_class}") do
+          with_tag("span.#{span_class}", :text => @title_error)
+        end
+      end
+    end
+
+  end
+
+end

data/spec/lib/twitter_bootstrap_rails/glyph_helper_spec.rb

@@ -0,0 +1,24 @@
+# encoding: utf-8
+require 'spec_helper'
+require 'action_view'
+require 'active_support'
+require_relative '../../../app/helpers/glyph_helper'
+
+include ActionView::Helpers
+include ActionView::Context
+include GlyphHelper
+
+describe GlyphHelper, :type => :helper do
+  it "should return a basic bootstrap glyph" do
+    expect(glyph(:thumbs_up).gsub(/\s/, '').downcase)
+      .to eql(BASIC_GLYPH.gsub(/\s/, '').downcase)
+  end
+
+  it "should return a bootstrap glyph with span" do
+    expect(glyph(:thumbs_up, {:tag => :span}).gsub(/\s/, '').downcase)
+      .to eql(GLYPH_WITH_SPAN.gsub(/\s/, '').downcase)
+  end
+end
+
+BASIC_GLYPH = %{<iclass=\"glyphiconglyphicon-thumbs-up\"></i>}
+GLYPH_WITH_SPAN = %{<spanclass=\"glyphiconglyphicon-thumbs-up\"></span>}

data/spec/lib/twitter_bootstrap_rails/modal_helper_spec.rb

@@ -36,12 +36,12 @@ describe ModalHelper, :type => :helper do
   end
 
   it 'renders a cancel button' do
-    expect(modal_cancel_button("Cancel", :href => "#modal", :data => {:dismiss => 'modal'}).gsub(/\n/, "")).to eql MODAL_CANCEL_BUTTON.gsub(/\n/, "")
+    expect(modal_cancel_button("Cancel", :data => {:dismiss => 'modal'}, :href => "#modal").gsub(/\n/, "")).to eql MODAL_CANCEL_BUTTON.gsub(/\n/, "")
   end
 end
 
 BASIC_MODAL = <<-HTML
-<div class=\"bootstrap-modal modal fade\" id=\"modal\"><div class=\"modal-dialog \"><div class=\"modal-content\"><div class=\"modal-header\"><button class=\"close\" data-dismiss=\"true\" aria-hidden=\"true\">&times;</button><h4 class=\"modal-title\"></h4></div><div class=\"modal-body\"></div><div class=\"modal-footer\"></div></div></div></div>
+<div class=\"bootstrap-modal modal fade\" id=\"modal\"><div class=\"modal-dialog \"><div class=\"modal-content\"><div class=\"modal-header\"><button class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&times;</button><h4 class=\"modal-title\">Modal header</h4></div><div class=\"modal-body\">This is the body</div><div class=\"modal-footer\"><button class="btn">Save</button></div></div></div></div>
 HTML
 
 MODAL_HEADER_WITHOUT_CLOSE = <<-HTML

data/spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb

@@ -82,44 +82,94 @@ describe NavbarHelper, :type => :helper do
 
   describe "menu_group" do
     it "should return a ul with the class 'nav'" do
-      ele = menu_group do
+      element = menu_group do
         menu_item("Home", "/") + menu_item("Products", "/products")
       end
-      expect(ele).to eql '<ul class="nav navbar-nav "><li><a href="/">Home</a></li><li><a href="/products">Products</a></li></ul>'
+
+      expect(element).to have_tag(:ul, with: {class: "nav navbar-nav"}) {
+        with_tag(:li) {
+          with_tag(:a, text: "Home", with: {href: "/"})
+        }
+        with_tag(:li) {
+          with_tag(:a, text: "Products", with: {href: "/products"})
+        }
+      }
     end
 
-    it "should return a ul with class .navbar-left when passed the {:pull => :left} option" do
-      ele = menu_group(:pull => :left) do
+    it "should return a ul with class .navbar-left when passed the {pull: :left} option" do
+      element = menu_group(pull: :left) do
         menu_item("Home", "/")
       end
-      expect(ele).to eql('<ul class="nav navbar-nav navbar-left"><li><a href="/">Home</a></li></ul>')
+
+      expect(element).to have_tag(:ul, with: {class: "nav navbar-nav navbar-left"}) {
+        with_tag(:li) {
+          with_tag(:a, text: "Home", with: {href: "/"})
+        }
+      }
     end
   end
 
   describe "menu_item" do
     it "should return a link within an li tag" do
       allow(self).to receive(:current_page?) { false }
-      expect(menu_item("Home", "/")).to eql('<li><a href="/">Home</a></li>')
+
+      element = menu_item("Home", "/")
+      expect(element).to have_tag(:li) {
+        with_tag(:a, text: "Home", with: { href: "/" })
+      }
     end
+
     it "should return the link with class 'active' if on current page" do
       allow(self).to receive(:uri_state) { :active }
-      expect(menu_item("Home", "/")).to eql('<li class="active"><a href="/">Home</a></li>')
+
+      element = menu_item("Home", "/")
+      expect(element).to have_tag(:li, with: {class: "active"}) {
+        with_tag(:a, text: "Home", with: { href: "/" })
+      }
     end
+
     it "should pass any other options through to the link_to method" do
-      self.stub("uri_state").and_return(:active)
-      expect(menu_item("Log out", "/users/sign_out", :class => "home_link", :method => :delete)).to eql('<li class="active"><a class="home_link" data-method="delete" href="/users/sign_out" rel="nofollow">Log out</a></li>')
+      allow(self).to receive_message_chain("uri_state").and_return(:active)
+
+      element = menu_item("Log out", "/users/sign_out", class: "home_link", method: :delete)
+      expect(element).to have_tag(:li, with: {class: "active"}) {
+        with_tag(:a, text: "Log out", with: {
+          href: "/users/sign_out",
+          class: "home_link",
+          rel: "nofollow",
+          "data-method" => "delete"
+        })
+      }
     end
+
     it "should pass a block but no name if a block is present" do
       allow(self).to receive(:current_page?) { false }
-      expect(menu_item("/"){content_tag("i", "", :class => "icon-home") + " Home"}).to eql('<li><a href="/"><i class="icon-home"></i> Home</a></li>')
+
+      element = menu_item("/"){ content_tag("i", "", :class => "icon-home") + " Home" }
+      expect(element).to have_tag(:li) {
+        with_tag(:i, with: { class: "icon-home"})
+        with_tag(:a, text: " Home", with: { href: "/"})
+      }
     end
+
     it "should work with just a block" do
       allow(self).to receive(:current_page?) { false }
-      expect(menu_item{ content_tag("i", "", :class => "icon-home") + " Home" }).to eql('<li><a href="#"><i class="icon-home"></i> Home</a></li>')
+
+      element = menu_item{ content_tag("i", "", :class => "icon-home") + " Home" }
+      expect(element).to have_tag(:li) {
+        with_tag(:i, with: { class: "icon-home"})
+        with_tag(:a, text: " Home", with: { href: "#"})
+      }
     end
+
     it "should return the link with class 'active' if on current page with a block" do
       allow(self).to receive(:uri_state) { :active }
-      expect(menu_item("/"){ content_tag("i", "", :class => "icon-home") + " Home" }).to eql('<li class="active"><a href="/"><i class="icon-home"></i> Home</a></li>')
+
+      element = menu_item("/"){ content_tag("i", "", :class => "icon-home") + " Home" }
+      expect(element).to have_tag(:li, with: {class: "active"}) {
+        with_tag(:i, with: { class: "icon-home"})
+        with_tag(:a, text: " Home", with: { href: "/"})
+      }
     end
   end
 

data/spec/spec_helper.rb

@@ -14,4 +14,8 @@ require 'twitter-bootstrap-rails'
 require 'abstract_controller'
 require 'action_controller'
 require 'mocha/api'
-require 'pry'
+require 'pry'
+
+RSpec.configure do |config|
+  config.include RSpecHtmlMatchers
+end