twitter-ads 6.0.1 → 9.0.0

data/spec/fixtures/line_items_load.json

@@ -24,7 +24,6 @@
     "currency": "USD",
     "created_at": "2011-07-11T20:36:11Z",
     "updated_at": "2011-09-04T19:39:51Z",
-    "include_sentiment": null,
     "campaign_id": "2wap7",
     "deleted": false
   },

data/spec/fixtures/tailored_audiences_all.json

@@ -14,6 +14,7 @@
       ],
       "audience_type": "WEB",
       "id": "abc2",
+      "owner_account_id": "18ce54uhdu0",
       "reasons_not_targetable": [
         "TOO_SMALL"
       ],
@@ -33,6 +34,7 @@
       ],
       "audience_type": "CRM",
       "id": "abc1",
+      "owner_account_id": "18ce54uhdu0",
       "reasons_not_targetable": [],
       "list_type": "DEVICE_ID",
       "created_at": "2014-05-22T17:37:12Z",
@@ -50,6 +52,7 @@
       ],
       "audience_type": "CRM",
       "id": "abc3",
+      "owner_account_id": "18ce54uhdu0",
       "reasons_not_targetable": [
         "TOO_SMALL"
       ],

data/spec/fixtures/targeted_audiences.json

@@ -0,0 +1,33 @@
+{
+    "request": {
+      "params": {
+        "account_id": "2iqph",
+        "tailored_audience_id": "abc2"
+      }
+    },
+    "next_cursor": null,
+    "data": [
+      {
+        "campaign_id": "59hod",
+        "campaign_name": "test-campaign",
+        "line_items": [
+          {
+            "id": "5gzog",
+            "name": "test-line-item",
+            "servable": true
+          }
+        ]
+      },
+      {
+        "campaign_id": "arja7",
+        "campaign_name": "Untitled campaign",
+        "line_items": [
+          {
+            "id": "bjw1q",
+            "name": null,
+            "servable": true
+          }
+        ]
+      }
+    ]
+}  

data/spec/spec_helper.rb

@@ -3,12 +3,10 @@
 
 unless RUBY_PLATFORM =~ /java/ || RUBY_ENGINE =~ /rbx/
   require 'simplecov'
-  require 'codeclimate-test-reporter'
 
   SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
     [
-      SimpleCov::Formatter::HTMLFormatter,
-      CodeClimate::TestReporter::Formatter
+      SimpleCov::Formatter::HTMLFormatter
     ]
   )
 
@@ -22,7 +20,6 @@ require 'rubocop'
 require 'faker'
 
 require 'webmock/rspec'
-WebMock.disable_net_connect!(allow: 'codeclimate.com')
 
 require 'twitter-ads'
 include TwitterAds

data/spec/twitter-ads/account_spec.rb

@@ -240,22 +240,22 @@ describe TwitterAds::Account do
 
   end
 
-  describe '#tailored_audiences' do
+  describe '#custom_audiences' do
 
     before(:each) do
-      resource_collection = "#{ADS_API}/accounts/#{account.id}/tailored_audiences"
-      stub_fixture(:get, :tailored_audiences_all, resource_collection)
+      resource_collection = "#{ADS_API}/accounts/#{account.id}/custom_audiences"
+      stub_fixture(:get, :custom_audiences_all, resource_collection)
 
-      resource = "#{ADS_API}/accounts/#{account.id}/tailored_audiences/abc2"
-      stub_fixture(:get, :tailored_audiences_load, /#{resource}\?.*/)
+      resource = "#{ADS_API}/accounts/#{account.id}/custom_audiences/abc2"
+      stub_fixture(:get, :custom_audiences_load, /#{resource}\?.*/)
     end
 
     context 'with an id specified' do
 
-      it 'successfully loads the specified tailored audience' do
-        result = account.tailored_audiences('abc2')
+      it 'successfully loads the specified custom audience' do
+        result = account.custom_audiences('abc2')
         expect(result).not_to be_nil
-        expect(result.class).to eq(TwitterAds::TailoredAudience)
+        expect(result.class).to eq(TwitterAds::CustomAudience)
         expect(result.id).to eq('abc2')
       end
 
@@ -263,11 +263,11 @@ describe TwitterAds::Account do
 
     context 'without an id specified' do
 
-      it 'succesfully returns a cursor with all tailored audiences' do
-        result = account.tailored_audiences
+      it 'succesfully returns a cursor with all custom audiences' do
+        result = account.custom_audiences
         expect(result.to_a.size).to eq(3)
         expect(result.class).to eq(TwitterAds::Cursor)
-        expect(result.first.class).to eq(TwitterAds::TailoredAudience)
+        expect(result.first.class).to eq(TwitterAds::CustomAudience)
         expect(result.first.id).to eq('abc2')
       end
 

data/spec/twitter-ads/audiences/{tailored_audience_spec.rb → custom_audience_spec.rb}

@@ -3,7 +3,7 @@
 
 require 'spec_helper'
 
-describe TwitterAds::TailoredAudience do
+describe TwitterAds::CustomAudience do
 
   before(:each) do
     stub_fixture(:get, :accounts_all, "#{ADS_API}/accounts")
@@ -31,11 +31,12 @@ describe TwitterAds::TailoredAudience do
     deleted
     audience_size
     audience_type
-    metadata
     partner_source
     reasons_not_targetable
     targetable
     targetable_types
+    permission_level
+    owner_account_id
   )
 
   write = %w(name list_type)

data/spec/twitter-ads/campaign/line_item_spec.rb

@@ -30,18 +30,21 @@ describe TwitterAds::LineItem do
     name
     campaign_id
     advertiser_domain
+    android_app_store_identifier
+    audience_expansion
     categories
-    charge_by
-    include_sentiment
+    pay_by
     objective
     entity_status
     primary_web_event_tag
     product_type
     placements
-    bid_unit
+    bid_strategy
     automatically_select_bid
     bid_amount_local_micro
     total_budget_amount_local_micro
+    goal
+    ios_app_store_identifier
   )
   include_examples 'object property check', read, write
 

data/spec/twitter-ads/campaign/targeting_criteria_spec.rb

@@ -30,6 +30,7 @@ describe TwitterAds::TargetingCriteria do
     line_item_id
     targeting_type
     targeting_value
+    operator_type
     tailored_audience_expansion
   )
 

data/spec/twitter-ads/creative/media_creative_spec.rb

@@ -25,7 +25,7 @@ describe TwitterAds::Creative::MediaCreative do
 
   # check model properties
   subject { described_class.new(account) }
-  read  = %w(id created_at updated_at deleted approval_status serving_status)
+  read  = %w(id created_at updated_at deleted approval_status entity_status)
   write = %w(account_media_id line_item_id landing_url)
   include_examples 'object property check', read, write
 

data/spec/twitter-ads/creative/promoted_tweet_spec.rb

@@ -41,6 +41,24 @@ describe TwitterAds::Creative::PromotedTweet do
       expect { subject.save }.to raise_error(TwitterAds::ClientError)
     end
 
+    it 'sets params[:tweet_ids] from params[:tweet_id]' do
+      request = double('request')
+      response = double('response')
+      allow(response).to receive(:body).and_return({ data: [{}] })
+      allow(request).to receive(:perform).and_return(response)
+      expected_params = { params: { line_item_id: '12345', tweet_ids: 99999999999999999999 } }
+
+      expect(Request).to receive(:new).with(
+        client,
+        :post,
+        "/#{TwitterAds::API_VERSION}/accounts/#{account.id}/promoted_tweets",
+        expected_params
+      ).and_return(request)
+
+      subject.line_item_id = '12345'
+      subject.tweet_id = 99999999999999999999
+      subject.save
+    end
   end
 
 end

data/spec/twitter-ads/targeting/audience_summary_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+# Copyright (C) 2019 Twitter, Inc.
+
+require 'spec_helper'
+
+describe TwitterAds::AudienceSummary do
+
+  before(:each) do
+    stub_fixture(:get, :accounts_all, "#{ADS_API}/accounts")
+    stub_fixture(:get, :accounts_load, "#{ADS_API}/accounts/2iqph")
+    stub_fixture(:post, :audience_summary, "#{ADS_API}/accounts/2iqph/audience_summary")
+  end
+
+  let(:client) do
+    Client.new(
+      Faker::Lorem.characters(15),
+      Faker::Lorem.characters(40),
+      "123456-#{Faker::Lorem.characters(40)}",
+      Faker::Lorem.characters(40)
+    )
+  end
+
+  let(:account) { client.accounts.first }
+  let(:params) {
+    {
+      targeting_criteria: [{
+        targeting_type: 'LOCATION',
+        targeting_value: '96683cc9126741d1'
+      }]
+    }
+  }
+
+  # check model properties
+  subject { described_class.fetch(account, params) }
+
+  it 'has all the correct properties' do
+    expect(subject[:audience_size][:min]).to eq(41133600)
+    expect(subject[:audience_size][:max]).to eq(50274400)
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: twitter-ads
 version: !ruby/object:Gem::Version
-  version: 6.0.1
+  version: 9.0.0
 platform: ruby
 authors:
 - John Babich
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-26 00:00:00.000000000 Z
+date: 2021-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -57,9 +57,11 @@ files:
 - bin/twitter-ads
 - lib/twitter-ads.rb
 - lib/twitter-ads/account.rb
-- lib/twitter-ads/audiences/tailored_audience.rb
+- lib/twitter-ads/audiences/custom_audience.rb
+- lib/twitter-ads/campaign/advertiser_business_categories.rb
 - lib/twitter-ads/campaign/app_list.rb
 - lib/twitter-ads/campaign/campaign.rb
+- lib/twitter-ads/campaign/content_categories.rb
 - lib/twitter-ads/campaign/funding_instrument.rb
 - lib/twitter-ads/campaign/iab_category.rb
 - lib/twitter-ads/campaign/line_item.rb
@@ -69,6 +71,7 @@ files:
 - lib/twitter-ads/campaign/tweet.rb
 - lib/twitter-ads/client.rb
 - lib/twitter-ads/creative/account_media.rb
+- lib/twitter-ads/creative/cards.rb
 - lib/twitter-ads/creative/cards_fetch.rb
 - lib/twitter-ads/creative/draft_tweet.rb
 - lib/twitter-ads/creative/image_app_download_card.rb
@@ -101,10 +104,8 @@ files:
 - lib/twitter-ads/restapi.rb
 - lib/twitter-ads/settings/tax.rb
 - lib/twitter-ads/settings/user.rb
-- lib/twitter-ads/targeting/reach_estimate.rb
+- lib/twitter-ads/targeting/audience_summary.rb
 - lib/twitter-ads/targeting_criteria/app_store_category.rb
-- lib/twitter-ads/targeting_criteria/behavior.rb
-- lib/twitter-ads/targeting_criteria/behavior_taxonomy.rb
 - lib/twitter-ads/targeting_criteria/conversation.rb
 - lib/twitter-ads/targeting_criteria/device.rb
 - lib/twitter-ads/targeting_criteria/event.rb
@@ -123,8 +124,11 @@ files:
 - spec/fixtures/accounts_load.json
 - spec/fixtures/app_lists_all.json
 - spec/fixtures/app_lists_load.json
+- spec/fixtures/audience_summary.json
 - spec/fixtures/campaigns_all.json
 - spec/fixtures/campaigns_load.json
+- spec/fixtures/custom_audiences_all.json
+- spec/fixtures/custom_audiences_load.json
 - spec/fixtures/funding_instruments_all.json
 - spec/fixtures/funding_instruments_load.json
 - spec/fixtures/line_items_all.json
@@ -137,7 +141,7 @@ files:
 - spec/fixtures/promoted_tweets_load.json
 - spec/fixtures/reach_estimate.json
 - spec/fixtures/tailored_audiences_all.json
-- spec/fixtures/tailored_audiences_load.json
+- spec/fixtures/targeted_audiences.json
 - spec/fixtures/tweet_previews.json
 - spec/fixtures/videos_all.json
 - spec/fixtures/videos_load.json
@@ -146,10 +150,9 @@ files:
 - spec/spec_helper.rb
 - spec/support/helpers.rb
 - spec/twitter-ads/account_spec.rb
-- spec/twitter-ads/audiences/tailored_audience_spec.rb
+- spec/twitter-ads/audiences/custom_audience_spec.rb
 - spec/twitter-ads/campaign/app_list_spec.rb
 - spec/twitter-ads/campaign/line_item_spec.rb
-- spec/twitter-ads/campaign/reach_estimate_spec.rb
 - spec/twitter-ads/campaign/targeting_criteria_spec.rb
 - spec/twitter-ads/campaign/tweet_spec.rb
 - spec/twitter-ads/client_spec.rb
@@ -161,6 +164,7 @@ files:
 - spec/twitter-ads/placements_spec.rb
 - spec/twitter-ads/rate_limit_spec.rb
 - spec/twitter-ads/retry_count_spec.rb
+- spec/twitter-ads/targeting/audience_summary_spec.rb
 - spec/twitter-ads/utils_spec.rb
 - twitter-ads.gemspec
 homepage: https://github.com/twitterdev/twitter-ruby-ads-sdk
@@ -182,53 +186,55 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 2.6.0
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: The officially supported Twitter Ads API SDK for Ruby.
 test_files:
-- spec/spec_helper.rb
-- spec/twitter-ads/retry_count_spec.rb
-- spec/twitter-ads/audiences/tailored_audience_spec.rb
-- spec/twitter-ads/cursor_spec.rb
-- spec/twitter-ads/account_spec.rb
-- spec/twitter-ads/client_spec.rb
-- spec/twitter-ads/rate_limit_spec.rb
-- spec/twitter-ads/placements_spec.rb
-- spec/twitter-ads/campaign/targeting_criteria_spec.rb
-- spec/twitter-ads/campaign/app_list_spec.rb
-- spec/twitter-ads/campaign/reach_estimate_spec.rb
-- spec/twitter-ads/campaign/line_item_spec.rb
-- spec/twitter-ads/campaign/tweet_spec.rb
-- spec/twitter-ads/creative/tweet_previews_spec.rb
-- spec/twitter-ads/creative/media_creative_spec.rb
-- spec/twitter-ads/creative/promoted_tweet_spec.rb
-- spec/twitter-ads/creative/promoted_account_spec.rb
-- spec/twitter-ads/utils_spec.rb
-- spec/shared/properties.rb
-- spec/support/helpers.rb
-- spec/fixtures/line_items_load.json
-- spec/fixtures/promotable_users_all.json
-- spec/fixtures/reach_estimate.json
+- spec/fixtures/accounts_all.json
 - spec/fixtures/accounts_features.json
-- spec/fixtures/videos_all.json
+- spec/fixtures/accounts_load.json
+- spec/fixtures/app_lists_all.json
+- spec/fixtures/app_lists_load.json
+- spec/fixtures/audience_summary.json
+- spec/fixtures/campaigns_all.json
+- spec/fixtures/campaigns_load.json
+- spec/fixtures/custom_audiences_all.json
+- spec/fixtures/custom_audiences_load.json
+- spec/fixtures/funding_instruments_all.json
+- spec/fixtures/funding_instruments_load.json
 - spec/fixtures/line_items_all.json
+- spec/fixtures/line_items_load.json
+- spec/fixtures/no_content.json
 - spec/fixtures/placements.json
+- spec/fixtures/promotable_users_all.json
 - spec/fixtures/promotable_users_load.json
-- spec/fixtures/tweet_previews.json
-- spec/fixtures/tailored_audiences_all.json
 - spec/fixtures/promoted_tweets_all.json
-- spec/fixtures/funding_instruments_load.json
-- spec/fixtures/tailored_audiences_load.json
-- spec/fixtures/app_lists_load.json
 - spec/fixtures/promoted_tweets_load.json
-- spec/fixtures/funding_instruments_all.json
-- spec/fixtures/campaigns_load.json
-- spec/fixtures/app_lists_all.json
-- spec/fixtures/accounts_load.json
-- spec/fixtures/no_content.json
-- spec/fixtures/campaigns_all.json
-- spec/fixtures/accounts_all.json
+- spec/fixtures/reach_estimate.json
+- spec/fixtures/tailored_audiences_all.json
+- spec/fixtures/targeted_audiences.json
+- spec/fixtures/tweet_previews.json
+- spec/fixtures/videos_all.json
 - spec/fixtures/videos_load.json
 - spec/quality_spec.rb
+- spec/shared/properties.rb
+- spec/spec_helper.rb
+- spec/support/helpers.rb
+- spec/twitter-ads/account_spec.rb
+- spec/twitter-ads/audiences/custom_audience_spec.rb
+- spec/twitter-ads/campaign/app_list_spec.rb
+- spec/twitter-ads/campaign/line_item_spec.rb
+- spec/twitter-ads/campaign/targeting_criteria_spec.rb
+- spec/twitter-ads/campaign/tweet_spec.rb
+- spec/twitter-ads/client_spec.rb
+- spec/twitter-ads/creative/media_creative_spec.rb
+- spec/twitter-ads/creative/promoted_account_spec.rb
+- spec/twitter-ads/creative/promoted_tweet_spec.rb
+- spec/twitter-ads/creative/tweet_previews_spec.rb
+- spec/twitter-ads/cursor_spec.rb
+- spec/twitter-ads/placements_spec.rb
+- spec/twitter-ads/rate_limit_spec.rb
+- spec/twitter-ads/retry_count_spec.rb
+- spec/twitter-ads/targeting/audience_summary_spec.rb
+- spec/twitter-ads/utils_spec.rb