twitch-bot 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 97bde27ec4cc411f28c30523554adb7ad7a0d6dc3cf717704f1db493a507b3d8
-  data.tar.gz: e485c169f546a94351cfad4243cff63e56dd098326cec70ef1a1628e5e4052b8
+  metadata.gz: 8e4f03406f61c87e0daa72edc415d45fe13acfe5b33514c75a2028c119d52212
+  data.tar.gz: 2e5336cff0e7304f91725d05ec7ff5e813ad54a0127554d0f3349d72d435d5d7
 SHA512:
-  metadata.gz: 92caf967720585dc8d0c09ea9a2505bdb1d28b1b856287dc6bdb4d16ab0daac1b243a63c11b93817ece43920d7b70be657383787c0ec3c107fffb9ad4b772643
-  data.tar.gz: a27bd67581b402f6cfe84dbb4f467ff19b090c4c5969d0c6e9c6fc2864fa965702b8dcb06b4602ea28636bc4065e19bda4e8aa9215f20086daeaf82f1e955f0c
+  metadata.gz: e634d550cbd5b2dfb8f80216f11284c015aa9e6e78cb9a08557af848b92f1505f8ac66c70270ce5329aa6eccc2bc3b2f8fba39b690032f5b7e7c8d0941a5fe1f
+  data.tar.gz: cc44b72bb4656a743321e5da2596da419e8eb078e759bea9742cfffa5a2047156caae7588a4cc3a3fcb7e302999a92b00c07a7531a9105d22137bc5a44268d04

data/.env.dist

@@ -0,0 +1 @@
+REDIS_URL=redis://localhost:6379

data/.github/workflows/main.yml

@@ -26,8 +26,7 @@ jobs:
       run: |
         bundle exec rake test
       env:
-        REDIS_HOST: redis
-        REDIS_PORT: 6379
+        REDIS_URL: 'redis://redis:6379'
 
   release:
     if: startsWith(github.ref, 'refs/tags/v')

data/.gitignore

@@ -16,3 +16,4 @@
 
 # rspec failure tracking
 .rspec_status
+.env

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog Twitch::Bot
 
+## v4.0.1
+
+* [FIXED] Fixed test crash due to incomplete DotEnv initialization.
+
 ## v4.0.0
 
 * [BREAKING] Using `REDIS_HOST` and `REDIS_PORT` for the connection details in `Twitch::Bot::Memory::Redis` was a bad choice. Providers like Heroku use a combined `REDIS_URL` instead. So do we now. (Alternatively, there's still the way via the `Config` object.)

data/lib/twitch/bot/memory/redis.rb

@@ -25,15 +25,17 @@ module Twitch
         attr_reader :client, :redis
 
         def connect_db
-          url = ENV["REDIS_URL"] || redis_config_url
+          url = redis_config_url || ENV["REDIS_URL"]
           ::Redis.new(url: url)
         end
 
         def redis_config_url
           config = client.config
-          host = config.setting("redis_host") || "localhost"
-          port = config.setting("redis_port") || 6379
-          "redis://#{host}:#{port}"
+          if config.setting("redis_host")
+            host = config.setting("redis_host") || "localhost"
+            port = config.setting("redis_port") || 6379
+            "redis://#{host}:#{port}"
+          end
         end
       end
     end

data/lib/twitch/bot/version.rb

@@ -2,6 +2,6 @@
 
 module Twitch
   module Bot
-    VERSION = "4.0.0"
+    VERSION = "4.0.1"
   end
 end

data/spec/spec_helper.rb

@@ -3,6 +3,10 @@
 require "bundler/setup"
 require "rspec/core"
 require "pry-byebug"
+
+require "dotenv"
+Dotenv.load(".env")
+
 require_relative "../lib/twitch/bot"
 
 RSpec.configure do |config|

data/spec/twitch/bot/memory/redis_spec.rb

@@ -2,7 +2,7 @@
 
 RSpec.describe Twitch::Bot::Memory::Redis do
   describe "#store" do
-    it "works with default connection details" do
+    it "works with ENV connection details" do
       config = Twitch::Bot::Config.new(
         settings: {
           bot_user: "testuser",
@@ -18,44 +18,27 @@ RSpec.describe Twitch::Bot::Memory::Redis do
 
       expect(mem.retrieve("foo")).to eq "bar"
     end
-  end
-
-  it "works with ENV connection details" do
-    ENV["REDIS_URL"] = "redis://localhost:6379"
-    config = Twitch::Bot::Config.new(
-      settings: {
-        bot_user: "testuser",
-      },
-    )
-    client = Twitch::Bot::Client.new(
-      config: config,
-      channel: "testchannel",
-    )
-    mem = described_class.new(client: client)
-
-    mem.store("foo", "bar")
-
-    expect(mem.retrieve("foo")).to eq "bar"
-  end
 
-  it "works with config connection details" do
-    config = Twitch::Bot::Config.new(
-      settings: {
-        bot_user: "testuser",
-        redis: {
-          host: "localhost",
-          port: 6379,
+    it "works with config connection details" do
+      url = URI.parse(ENV["REDIS_URL"])
+      config = Twitch::Bot::Config.new(
+        settings: {
+          bot_user: "testuser",
+          redis: {
+            host: url.host,
+            port: url.port,
+          },
         },
-      },
-    )
-    client = Twitch::Bot::Client.new(
-      config: config,
-      channel: "testchannel",
-    )
-    mem = described_class.new(client: client)
+      )
+      client = Twitch::Bot::Client.new(
+        config: config,
+        channel: "testchannel",
+      )
+      mem = described_class.new(client: client)
 
-    mem.store("foo", "bar")
+      mem.store("foo", "bar")
 
-    expect(mem.retrieve("foo")).to eq "bar"
+      expect(mem.retrieve("foo")).to eq "bar"
+    end
   end
 end

data/twitch-bot.gemspec

@@ -25,9 +25,8 @@ Gem::Specification.new do |spec|
   spec.add_dependency "redis", "~> 4.1"
 
   spec.add_development_dependency "bundler", "~> 2.0"
+  spec.add_development_dependency "dotenv"
   spec.add_development_dependency "freistil-rubocop"
-  spec.add_development_dependency "guard", "~> 2.16"
-  spec.add_development_dependency "guard-rspec", "~> 4.7"
   spec.add_development_dependency "pry-byebug", "~> 3.0"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "reek"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: twitch-bot
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Jochen Lillich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-28 00:00:00.000000000 Z
+date: 2020-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: freistil-rubocop
+  name: dotenv
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,33 +53,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.16'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.16'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: freistil-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -188,6 +174,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".editorconfig"
+- ".env.dist"
 - ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"