twitch-bot 3.2.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 593044bf44aec13e9f1c91329ea6a32500315809cf03c10c847c3eb571d84b04
-  data.tar.gz: 19eac94cc9374a36af56528dbdce6a6969c57157034c6474a65e6e1550a8cbab
+  metadata.gz: 97bde27ec4cc411f28c30523554adb7ad7a0d6dc3cf717704f1db493a507b3d8
+  data.tar.gz: e485c169f546a94351cfad4243cff63e56dd098326cec70ef1a1628e5e4052b8
 SHA512:
-  metadata.gz: 40e85ac406718f664c217c1c3dcf681cb5c58d03a95856c7f6063b27d478e7b014b8fe53b364f536e756ae7f52be631c0fe543c140e1b9200b5a01675b261d91
-  data.tar.gz: 63cb2c49bbbf0be7b71a5f81f56fcdc96fcff8af6e5a15d12084181edde63898e77633260c83450a15a46bb5f3587b71c727b95b570ba8a306d453cdedb84554
+  metadata.gz: 92caf967720585dc8d0c09ea9a2505bdb1d28b1b856287dc6bdb4d16ab0daac1b243a63c11b93817ece43920d7b70be657383787c0ec3c107fffb9ad4b772643
+  data.tar.gz: a27bd67581b402f6cfe84dbb4f467ff19b090c4c5969d0c6e9c6fc2864fa965702b8dcb06b4602ea28636bc4065e19bda4e8aa9215f20086daeaf82f1e955f0c

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog Twitch::Bot
 
+## v4.0.0
+
+* [BREAKING] Using `REDIS_HOST` and `REDIS_PORT` for the connection details in `Twitch::Bot::Memory::Redis` was a bad choice. Providers like Heroku use a combined `REDIS_URL` instead. So do we now. (Alternatively, there's still the way via the `Config` object.)
+
 ## v3.2.1
 
 * [FIXED] The Terminal adapter now returns all messages from the channel owner, allowing to test privileged functionality in dev mode.

data/lib/twitch/bot/memory/redis.rb

@@ -25,12 +25,15 @@ module Twitch
         attr_reader :client, :redis
 
         def connect_db
+          url = ENV["REDIS_URL"] || redis_config_url
+          ::Redis.new(url: url)
+        end
+
+        def redis_config_url
           config = client.config
-          host = config.setting("redis_host") ||
-            ENV["REDIS_HOST"] || "localhost"
-          port = config.setting("redis_port") ||
-            ENV["REDIS_PORT"] || 6379
-          ::Redis.new(host: host, port: port)
+          host = config.setting("redis_host") || "localhost"
+          port = config.setting("redis_port") || 6379
+          "redis://#{host}:#{port}"
         end
       end
     end

data/lib/twitch/bot/version.rb

@@ -2,6 +2,6 @@
 
 module Twitch
   module Bot
-    VERSION = "3.2.1"
+    VERSION = "4.0.0"
   end
 end

data/spec/twitch/bot/memory/redis_spec.rb

@@ -2,7 +2,7 @@
 
 RSpec.describe Twitch::Bot::Memory::Redis do
   describe "#store" do
-    it "persists a value for a key" do
+    it "works with default connection details" do
       config = Twitch::Bot::Config.new(
         settings: {
           bot_user: "testuser",
@@ -19,4 +19,43 @@ RSpec.describe Twitch::Bot::Memory::Redis do
       expect(mem.retrieve("foo")).to eq "bar"
     end
   end
+
+  it "works with ENV connection details" do
+    ENV["REDIS_URL"] = "redis://localhost:6379"
+    config = Twitch::Bot::Config.new(
+      settings: {
+        bot_user: "testuser",
+      },
+    )
+    client = Twitch::Bot::Client.new(
+      config: config,
+      channel: "testchannel",
+    )
+    mem = described_class.new(client: client)
+
+    mem.store("foo", "bar")
+
+    expect(mem.retrieve("foo")).to eq "bar"
+  end
+
+  it "works with config connection details" do
+    config = Twitch::Bot::Config.new(
+      settings: {
+        bot_user: "testuser",
+        redis: {
+          host: "localhost",
+          port: 6379,
+        },
+      },
+    )
+    client = Twitch::Bot::Client.new(
+      config: config,
+      channel: "testchannel",
+    )
+    mem = described_class.new(client: client)
+
+    mem.store("foo", "bar")
+
+    expect(mem.retrieve("foo")).to eq "bar"
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: twitch-bot
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 4.0.0
 platform: ruby
 authors:
 - Jochen Lillich