twisty_puzzles 0.0.2 → 0.0.7

data/lib/twisty_puzzles/coordinate.rb

@@ -90,7 +90,7 @@ module TwistyPuzzles
       base_coordinate = Coordinate.from_indices(
         part.solved_face, cube_size, *part.base_index_on_face(cube_size, incarnation_index)
       )
-      other_face_symbols = part.corresponding_part.face_symbols[1..-1]
+      other_face_symbols = part.corresponding_part.face_symbols[1..]
       match_coordinate_internal(base_coordinate, other_face_symbols)
     end
 
@@ -99,7 +99,7 @@ module TwistyPuzzles
     def self.solved_positions(part, cube_size, incarnation_index)
       solved_coordinate = solved_position(part, cube_size, incarnation_index)
       other_coordinates =
-        part.face_symbols[1..-1].map.with_index do |f, i|
+        part.face_symbols[1..].map.with_index do |f, i|
           face = Face.for_face_symbol(f)
           # The reverse is important for edge like parts. We are not in the same position as usual
           # solved pieces would be.
@@ -109,7 +109,7 @@ module TwistyPuzzles
           base_coordinate = Coordinate.from_indices(face, cube_size, *base_indices)
           other_face_symbols = [part.face_symbols[0]] +
                                part.corresponding_part.face_symbols[1...i + 1] +
-                               part.corresponding_part.face_symbols[i + 2..-1]
+                               part.corresponding_part.face_symbols[i + 2..]
           match_coordinate_internal(base_coordinate, other_face_symbols)
         end
       [solved_coordinate] + other_coordinates
@@ -276,7 +276,7 @@ module TwistyPuzzles
       @native = native
     end
 
-    attr_reader :native
+    attr_reader :native, :coordinate
 
     private_class_method :new
 
@@ -311,7 +311,5 @@ module TwistyPuzzles
     def face
       @face ||= Face.for_face_symbol(@native.face)
     end
-
-    attr_reader :coordinate
   end
 end

data/lib/twisty_puzzles/cube.rb

@@ -97,7 +97,7 @@ module TwistyPuzzles
     end
 
     def inspect
-      self.class.to_s + '(' + @face_symbols.map(&:to_s).join(', ') + ')'
+      "#{self.class}(#{@face_symbols.map(&:to_s).join(', ')})"
     end
 
     def to_s
@@ -365,7 +365,7 @@ module TwistyPuzzles
     attr_reader :corresponding_part
 
     def inspect
-      self.class.to_s + '(' + face_symbol.to_s + ', ' + @corresponding_part.inspect + ')'
+      "#{self.class}(#{face_symbol}, #{@corresponding_part.inspect})"
     end
 
     def rotate_by(_number)
@@ -532,7 +532,7 @@ module TwistyPuzzles
 
     def self.create_for_face_symbols(face_symbols)
       piece_candidates =
-        face_symbols[1..-1].permutation.map do |cs|
+        face_symbols[1..].permutation.map do |cs|
           new([face_symbols[0]] + cs)
         end
       find_only(piece_candidates, &:valid?)

data/lib/twisty_puzzles/cube_move.rb

@@ -139,8 +139,6 @@ module TwistyPuzzles
       end
     end
 
-    # rubocop:disable Metrics/PerceivedComplexity
-    # rubocop:disable Metrics/CyclomaticComplexity
     def prepend_fat_move(other, cube_size)
       if same_fat_block?(other)
         merge_with_same_fat_block(other)
@@ -156,8 +154,6 @@ module TwistyPuzzles
         Algorithm.move(other.inner_fat_mslice_move(cube_size))
       end
     end
-    # rubocop:enable Metrics/CyclomaticComplexity
-    # rubocop:enable Metrics/PerceivedComplexity
 
     def prepend_slice_move(other, cube_size)
       return unless same_axis?(other)

data/lib/twisty_puzzles/cube_move_parser.rb

@@ -14,29 +14,29 @@ module TwistyPuzzles
   class CubeMoveParser < AbstractMoveParser
     REGEXP =
       begin
-                      axes_part = "(?<axis_name>[#{AbstractMove::AXES.join}])"
-                      face_names = CubeConstants::FACE_NAMES.join
-                      fat_move_part =
-                        "(?<width>\\d*)(?<fat_face_name>[#{face_names}])w"
-                      normal_move_part = "(?<face_name>[#{face_names}])"
-                      downcased_face_names = face_names.downcase
-                      maybe_fat_maybe_slice_move_part =
-                        "(?<maybe_fat_face_maybe_slice_name>[#{downcased_face_names}])"
-                      slice_move_part =
-                        "(?<slice_index>\\d+)(?<slice_name>[#{downcased_face_names}])"
-                      mslice_move_part =
-                        "(?<mslice_name>[#{AbstractMove::SLICE_FACES.keys.join}])"
-                      move_part = "(?:#{axes_part}|" \
-                                  "#{fat_move_part}|" \
-                                  "#{normal_move_part}|" \
-                                  "#{maybe_fat_maybe_slice_move_part}|" \
-                                  "#{slice_move_part}|#{mslice_move_part})"
-                      direction_names =
-                        AbstractDirection::POSSIBLE_DIRECTION_NAMES.flatten
-                      direction_names.sort_by! { |e| -e.length }
-                      direction_part = "(?<direction>#{direction_names.join('|')})"
-                      Regexp.new("#{move_part}#{direction_part}")
-                    end
+        axes_part = "(?<axis_name>[#{AbstractMove::AXES.join}])"
+        face_names = CubeConstants::FACE_NAMES.join
+        fat_move_part =
+          "(?<width>\\d*)(?<fat_face_name>[#{face_names}])w"
+        normal_move_part = "(?<face_name>[#{face_names}])"
+        downcased_face_names = face_names.downcase
+        maybe_fat_maybe_slice_move_part =
+          "(?<maybe_fat_face_maybe_slice_name>[#{downcased_face_names}])"
+        slice_move_part =
+          "(?<slice_index>\\d+)(?<slice_name>[#{downcased_face_names}])"
+        mslice_move_part =
+          "(?<mslice_name>[#{AbstractMove::SLICE_FACES.keys.join}])"
+        move_part = "(?:#{axes_part}|" \
+                    "#{fat_move_part}|" \
+                    "#{normal_move_part}|" \
+                    "#{maybe_fat_maybe_slice_move_part}|" \
+                    "#{slice_move_part}|#{mslice_move_part})"
+        direction_names =
+          AbstractDirection::POSSIBLE_DIRECTION_NAMES.flatten
+        direction_names.sort_by! { |e| -e.length }
+        direction_part = "(?<direction>#{direction_names.join('|')})"
+        Regexp.new("#{move_part}#{direction_part}")
+      end
 
     MOVE_TYPE_CREATORS = [
       MoveTypeCreator.new(%i[axis_face direction], Rotation),

data/lib/twisty_puzzles/cube_print_helper.rb

@@ -41,9 +41,10 @@ module TwistyPuzzles
     end
 
     def maybe_reverse(reverse_mode, stuff)
-      if reverse_mode == :reverse
+      case reverse_mode
+      when :reverse
         stuff.reverse
-      elsif reverse_mode == :keep
+      when :keep
         stuff
       else
         raise
@@ -102,7 +103,7 @@ module TwistyPuzzles
       face_symbol_info = FACE_SYMBOL_INFOS[face_symbol]
       stickers = cube_state.sticker_array(face)
       center_color = color_character(stickers[0], color_mode)
-      corner_colors = stickers[1..-1].map { |c| color_character(c, color_mode) }
+      corner_colors = stickers[1..].map { |c| color_character(c, color_mode) }
       permuted_corner_colors =
         apply_permutation(corner_colors, face_symbol_info.skewb_corner_permutation)
       raise unless corner_colors.length == 4

data/lib/twisty_puzzles/parser.rb

@@ -185,14 +185,14 @@ module TwistyPuzzles # rubocop:disable Style/Documentation
     end
   end
 
-  def parse_commutator(alg_string, complete_parse = true)
+  def parse_commutator(alg_string, complete_parse: true)
     parser = Parser.new(alg_string, CubeMoveParser::INSTANCE)
     commutator = parser.parse_commutator
     parser.check_eos('commutator') if complete_parse
     commutator
   end
 
-  def parse_cube_algorithm(alg_string, complete_parse = true)
+  def parse_cube_algorithm(alg_string, complete_parse: true)
     parser = Parser.new(alg_string, CubeMoveParser::INSTANCE)
     algorithm = parser.parse_algorithm
     parser.check_eos('algorithm') if complete_parse
@@ -206,7 +206,7 @@ module TwistyPuzzles # rubocop:disable Style/Documentation
   alias parse_algorithm parse_cube_algorithm
   alias parse_move parse_cube_move
 
-  def parse_skewb_algorithm(alg_string, notation, complete_parse = true)
+  def parse_skewb_algorithm(alg_string, notation, complete_parse: true)
     parser = Parser.new(alg_string, SkewbMoveParser.new(notation))
     algorithm = parser.parse_algorithm
     parser.check_eos('algorithm') if complete_parse

data/lib/twisty_puzzles/rotation.rb

@@ -62,6 +62,7 @@ module TwistyPuzzles
       [self, alternative].include?(other)
     end
 
+    # rubocop:disable Metrics/AbcSize
     def prepend_rotation(other, _cube_size)
       if same_axis?(other)
         direction = translated_direction(other.axis_face)
@@ -74,6 +75,7 @@ module TwistyPuzzles
         Algorithm.move(Rotation.new(remaining_face, CubeDirection::DOUBLE))
       end
     end
+    # rubocop:enable Metrics/AbcSize
 
     def prepend_fat_m_slice_move(_other, _cube_size)
       nil

data/lib/twisty_puzzles/skewb_move.rb

@@ -12,6 +12,7 @@ module TwistyPuzzles
       raise TypeError unless axis_corner.is_a?(Corner)
       raise TypeError unless direction.is_a?(SkewbDirection)
 
+      super()
       @axis_corner = axis_corner.rotate_face_up(axis_corner.faces.min_by(&:piece_index))
       @direction = direction
     end

data/lib/twisty_puzzles/skewb_move_parser.rb

@@ -18,6 +18,7 @@ module TwistyPuzzles
     def initialize(notation)
       raise TypeError unless notation.is_a?(SkewbNotation)
 
+      super()
       @notation = notation
     end
 

data/lib/twisty_puzzles/skewb_notation.rb

@@ -10,9 +10,11 @@ module TwistyPuzzles
   # Class that represents one notation for Skewb moves, e.g. Sarahs notation or fixed
   # corner notation.
   class SkewbNotation
+    # rubocop:disable Metrics/AbcSize
     def initialize(name, move_corner_pairs)
       raise TypeError unless name.is_a?(String)
 
+      super()
       check_move_corner_pairs(move_corner_pairs)
       @name = name
       @move_to_corner = move_corner_pairs.to_h.freeze
@@ -26,7 +28,9 @@ module TwistyPuzzles
         end.freeze
       freeze
     end
+    # rubocop:enable Metrics/AbcSize
 
+    # rubocop:disable Metrics/CyclomaticComplexity
     def check_move_corner_pairs(move_corner_pairs)
       move_corner_pairs.each do |m|
         raise ArgumentError unless m.length == 2
@@ -37,6 +41,7 @@ module TwistyPuzzles
 
       check_corner_coverage(move_corner_pairs.map(&:last))
     end
+    # rubocop:enable Metrics/CyclomaticComplexity
 
     def check_corner_coverage(corners)
       corner_closure = corners + corners.map(&:diagonal_opposite)
@@ -49,6 +54,7 @@ module TwistyPuzzles
     end
 
     attr_reader :name, :move_strings, :non_zero_moves
+
     private_class_method :new
 
     def self.fixed_corner
@@ -103,7 +109,7 @@ module TwistyPuzzles
         move_to_string(m, reversed_rotations)
       end.join(' ')
       new_tail_rotations = reversed_rotations.reverse! +
-                           algorithm.moves[algorithm.length - num_tail_rotations..-1]
+                           algorithm.moves[algorithm.length - num_tail_rotations..]
       cancelled_rotations = Algorithm.new(new_tail_rotations).cancelled(3)
       cancelled_rotations.empty? ? alg_string : "#{alg_string} #{cancelled_rotations}"
     end

data/lib/twisty_puzzles/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TwistyPuzzles
-  VERSION = '0.0.2'
+  VERSION = '0.0.7'
 end

metadata

@@ -1,11 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: twisty_puzzles
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.7
 platform: ruby
 authors:
 - Bernhard F. Brodowsky
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
 date: 2020-04-21 00:00:00.000000000 Z
@@ -112,16 +112,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -164,7 +164,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email: bernhard.brodowsky@gmail.com
 executables: []
 extensions:
@@ -176,7 +176,28 @@ files:
 - CODE_OF_CONDUCT.md
 - LICENSE
 - README.md
+- ext/twisty_puzzles/native/cube_algorithm.c
+- ext/twisty_puzzles/native/cube_algorithm.h
+- ext/twisty_puzzles/native/cube_average.c
+- ext/twisty_puzzles/native/cube_average.h
+- ext/twisty_puzzles/native/cube_coordinate.c
+- ext/twisty_puzzles/native/cube_coordinate.h
+- ext/twisty_puzzles/native/cube_state.c
+- ext/twisty_puzzles/native/cube_state.h
 - ext/twisty_puzzles/native/extconf.rb
+- ext/twisty_puzzles/native/face_symbols.c
+- ext/twisty_puzzles/native/face_symbols.h
+- ext/twisty_puzzles/native/native.c
+- ext/twisty_puzzles/native/skewb_algorithm.c
+- ext/twisty_puzzles/native/skewb_algorithm.h
+- ext/twisty_puzzles/native/skewb_coordinate.c
+- ext/twisty_puzzles/native/skewb_coordinate.h
+- ext/twisty_puzzles/native/skewb_layer_fingerprint.c
+- ext/twisty_puzzles/native/skewb_layer_fingerprint.h
+- ext/twisty_puzzles/native/skewb_state.c
+- ext/twisty_puzzles/native/skewb_state.h
+- ext/twisty_puzzles/native/utils.c
+- ext/twisty_puzzles/native/utils.h
 - lib/twisty_puzzles.rb
 - lib/twisty_puzzles/abstract_direction.rb
 - lib/twisty_puzzles/abstract_move.rb
@@ -224,7 +245,7 @@ metadata:
   homepage_uri: https://github.com/Lykos/twisty_puzzles
   source_code_uri: https://github.com/Lykos/twisty_puzzles
   changelog_uri: https://github.com/Lykos/twisty_puzzles/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -232,16 +253,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
 summary: Gem for my cube_trainer rails app. Some things are better left in a separate
   gem with no rails, e.g. native extensions. The main purpose is to support my Rails