twirp-rails 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9dcf037d0a667d0d0279eb44e44f83b14483921b93c087bccf212e2961d97e82
-  data.tar.gz: ebd43a7b27ee04d31a5e07daa23af429003a9c6ecce93a241e7c76e54f402a34
+  metadata.gz: ee27c7c874d0d00a2af30d47d7e717e1d702bb5efc0d06c0d3046a57d1391c3d
+  data.tar.gz: d2644368846f960c4a2b91aca62651dd4f526fea098fc56cbc2ed0a4ff0446f2
 SHA512:
-  metadata.gz: eece932d46ad2dd988db38915d7e89e3a559072f82799a03fda573c531d66135e4e534f486235443be1f2cf1d682cc51b5ae9da29d3bc5e051f2f850f0a1f58a
-  data.tar.gz: ad9efed9706d6ff118a98228c27cab0cdb02cfb05cd98461047e98a2ad01f2930c3ff5c1fb8770f57ca2dc3c4aa42c79ee11267f9707ad0a9217228d1983ec2c
+  metadata.gz: e7ae120cbd5ad07199042c4066d5fb3815e7c05d417075ae9807fade9d4dbea598e343a2fdb7428b37eba3bcd1f9d4192b6e644b993d675783e68ab91355b5d7
+  data.tar.gz: 010c624299e0cdf5507c1afa4900493a93b42c8cb9e93fd774bb4218e3e77e5e0fb90dad346a47d1f23ddb63c8d490a93ce6b597cbccb755eb03ca959351b5bc

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+# v0.1.1 / 2019-04-27
+
+## Enhancements
+
+* Add catch-all handler at the bottom of routes to rescue `bad_route case.
+* Printing all rpc endpoints, instead of printing routes per service.
+
+# v0.1.0 / 2019-04-26
+
+Initial release

data/README.md

@@ -10,7 +10,8 @@ Twirp for Rails
 $ bin/rails routes
 
 Prefix Verb URI Pattern                           Controller#Action
-       POST /twirp/HelloService(.:format)         hello#hello,hi,greet
+            /twirp/HelloService/Greet             hello
+            /twirp/HelloService/Hi                hello
 ```
 
 ## Installation
@@ -33,7 +34,7 @@ Or install it yourself as:
 
 After insalled, put the configuration file as follows:
 
-```
+```ruby
 # config/initializers/twirp_rails.rb
 
 Twirp::Rails.configuration do |c|
@@ -46,7 +47,7 @@ end
 
 Add the line `use_twirp` in `config/routes.rb`.  By this, you can tell Rails app what endpoints to be served.
 
-```
+```ruby
 # config/routes.rb
 
 Rails.application.routes.draw do
@@ -58,13 +59,13 @@ end
 
 Next, let's link handlers(a.k.a controllers) with services. `bind` method can bind them.
 
-```
+```ruby
 class HelloHandler
   include Twirp::Rails::Helpers
 
   bind HelloService
 
-  def hello(_req, _env)
+  def greet(_req, _env)
     HelloResponse.new(message: 'hello')
   end
 end
@@ -76,7 +77,8 @@ So now corresponding routes will be defined.
 $ bin/rails routes
 
 Prefix Verb URI Pattern                           Controller#Action
-       POST /twirp/HelloService(.:format)         hello#hello,hi,greet
+            /twirp/HelloService/Greet             hello
+            /twirp/HelloService/Hi                hello
 ```
 
 ## Development

data/lib/twirp/rails/routes.rb

@@ -15,12 +15,13 @@ module Twirp
         REMOVABLE_SUFFIX_RE = /(_handler|_controller)\z/
 
         def inspect
-          handler = instance_variable_get(:@handler).class.name.underscore.sub(REMOVABLE_SUFFIX_RE, '')
-          methods = self.class.rpcs.values.map { |h| h[:ruby_method].to_s }.sort.join(',')
-          [handler, methods].join('#')
+          instance_variable_get(:@handler).class.name.underscore.sub(REMOVABLE_SUFFIX_RE, '')
         end
       end
 
+      # A null hanlder to cause a bad_route error by unexpected rpc call, instead of raising a routing error by Rails.
+      class CatchAllHandler; end
+
       def self.install!
         ActionDispatch::Routing::Mapper.send :include, Twirp::Rails::Routes::Helper
       end
@@ -36,8 +37,17 @@ module Twirp
         routes.scope options[:scope] || 'twirp' do
           @services.each do |service|
             service.extend Inspectable
-            @routes.mount service, at: service.full_name
+            service.class.rpcs.values.each do |h|
+              rpc_method = h[:rpc_method]
+              path = service.full_name + '/' + rpc_method.to_s
+              @routes.match path, to: service, format: false, via: :all
+            end
           end
+
+          # Set catch-all route
+          null_service = ::Twirp::Service.new(CatchAllHandler.new)
+          null_service.extend Inspectable
+          routes.mount null_service, at: '/'
         end
       end
     end

data/lib/twirp/rails/version.rb

@@ -1,5 +1,5 @@
 module Twirp
   module Rails
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: twirp-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Nobuhiro Nikushi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-26 00:00:00.000000000 Z
+date: 2019-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -90,6 +90,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md