twirp-on-rails 1.0.1.pre → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2925a659b9c79db0bfced51d9f8e8c3c86a9c9b4977f64611f7f57d7b2597c00
-  data.tar.gz: 56abcb2fa1e40241eef7f3199529bf4a83971f82358f679526a38b482c12cb79
+  metadata.gz: 5f09ec24234c61ab85dc6ab6e03768c16e4fa7110fe5e5771240ca94633996eb
+  data.tar.gz: 569db17177ad607e4de0a9f94cf380857c48e408f5e7937ed951bd549d5a0431
 SHA512:
-  metadata.gz: 28a1b6ec586b9e129a64390a5e727aee495a2c624d74ca9b94ac0a1548b5fd36d4951a6e1bc256ca560ea3909a45c4e637dce401a8a77953d2faa6628644674e
-  data.tar.gz: 661c948ab6ca8b80d83fd882581d4e1246e541aebb2416e62fcafa1f202454453d8ccd7dadcb9ef0b6b8171eefef68aa19794d647595d2fe1a49e7c35fd8a0d4
+  metadata.gz: 542712540c037f4be6ac5f322f45f72a44f55705eb813f941769317afcb17ce1853089524cdf725c61bad411fc73a8ae8be7428a8b3846df6ae9604581d5f90e
+  data.tar.gz: be401e0761378d95a08bc4d493582450cf5e979e288f578d63c25dd00a69bcc7033b16f77fb31bf0100c2dc1c5a7007fe1c69a8140410b0b4ee5f2238ecfd499

data/.standard.yml

@@ -2,3 +2,6 @@ ruby_version: 2.7
 plugins:
   - standard-performance
   - standard-rails
+ignore:
+  - '**/*_pb.rb'
+  - '**/*_twirp.rb' 

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [1.1.0] - 2024-09-12
+
+- Respect package namespace when looking for handlers.
+
 ## [0.1.0] - 2022-12-23
 
 - Initial release

data/Gemfile

@@ -10,6 +10,6 @@ gem "rake"
 gem "debug"
 gem "rspec-rails"
 gem "sqlite3", "~> 1.4"
-gem "standard"
+gem "standard", ">= 1.35.1"
 gem "standard-performance"
 gem "standard-rails"

data/README.md

@@ -86,7 +86,26 @@ end
 
 Each handler method should return the appropriate Protobuf, or a `Twirp::Error`.
 
-TODO: Give more examples of both
+#### Packages and Namespacing
+
+Handlers can live in directories that reflect the service's package. For example, `haberdasher.proto` defines:
+
+```protobuf
+package twirp.example.haberdasher;
+```
+
+You can use the full path, or because many projects have only one namespace, we also let you skip the namespace for simplicity:
+
+We look for the handler in either location:
+
+`app/handlers/twirp/example/haberdasher/haberdasher_service_handler.rb` defines `Twirp::Example::Haberdasher::HaberdasherServiceHandler`
+
+or
+
+`app/handlers/haberdasher_service_handler.rb` defines `HaberdasherServiceHandler`
+
+
+TODO: Give more examples of handlers
 
 ### Familiar Callbacks
 

data/lib/twirp/rails/dispatcher.rb

@@ -4,7 +4,13 @@ module Twirp
   module Rails
     class Dispatcher
       def initialize(service_class)
-        @service_handler = "#{service_class.service_name}Handler".constantize
+        # Check for a handler in the service's namespace, or in the root namespace
+        # e.g. Twirp::Example::Cobbler::CobblerHandler or ::CobblerHandler
+        @service_handler = if Object.const_defined?("#{service_class.module_parent}::#{service_class.service_name}Handler")
+          "#{service_class.module_parent}::#{service_class.service_name}Handler".constantize
+        else
+          "#{service_class.service_name}Handler".constantize
+        end
       end
 
       def respond_to_missing?(method, *)

data/lib/twirp/rails/rack/conditional_post.rb

@@ -32,7 +32,7 @@ module Twirp
           when "POST"
             status, headers, body = response = @app.call(env)
             # Rack 3 settles on only allowing lowercase headers
-            if Rack.release < "3.0"
+            if ::Rack.release < "3.0"
               headers = ::Rack::Utils::HeaderHash[headers]
             end
 
@@ -40,7 +40,7 @@ module Twirp
               response[0] = 304
               headers.delete(::Rack::CONTENT_TYPE)
               headers.delete(::Rack::CONTENT_LENGTH)
-              response[2] = Rack::BodyProxy.new([]) do
+              response[2] = ::Rack::BodyProxy.new([]) do
                 body.close if body.respond_to?(:close)
               end
             end

data/lib/twirp/rails/version.rb

@@ -2,6 +2,6 @@
 
 module Twirp
   module Rails
-    VERSION = "1.0.1.pre"
+    VERSION = "1.1.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: twirp-on-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.1.pre
+  version: 1.1.0
 platform: ruby
 authors:
 - Daniel Morrison
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-05-20 00:00:00.000000000 Z
+date: 2024-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -88,7 +88,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.9
+rubygems_version: 3.5.16
 signing_key: 
 specification_version: 4
 summary: Use Twirp RPC with Rails