twingly-search 5.1.2 → 5.3.1

data/spec/livefeed/client_spec.rb

@@ -40,7 +40,7 @@ module Twingly::LiveFeed
 
         it do
           expect { subject }
-            .to raise_error(AuthError, "No API key has been provided.")
+            .to raise_error(AuthenticationError, "No API key has been provided.")
         end
       end
 
@@ -62,7 +62,7 @@ module Twingly::LiveFeed
             end
           end
 
-          it "should not raise an AuthError" do
+          it "should not raise an AuthenticationError" do
             expect { subject }.not_to raise_exception
           end
 

data/spec/livefeed/error_spec.rb

@@ -13,6 +13,7 @@ module Twingly::LiveFeed
         let(:code) { 401 }
 
         it { is_expected.to be_a(AuthError) }
+        it { is_expected.to be_a(AuthenticationError) }
       end
 
       context "when given code 400" do

data/spec/livefeed/parser_spec.rb

@@ -306,15 +306,15 @@ module Twingly::LiveFeed
       context "with an unauthorized api key result" do
         let(:fixture) { :unauthorized_api_key }
 
-        it "should raise AuthError" do
-          expect { subject }.to raise_error(AuthError)
+        it "should raise AuthenticationError" do
+          expect { subject }.to raise_error(AuthenticationError)
         end
       end
 
       context "with an empty api key result" do
         let(:fixture) { :empty_api_key }
 
-        it "should raise AuthError" do
+        it "should raise QueryError" do
           expect { subject }.to raise_error(QueryError)
         end
       end

data/spec/livefeed/post_spec.rb

@@ -23,4 +23,51 @@ module Twingly::LiveFeed
     it { should respond_to :blog_rank }
     it { should respond_to :authority }
   end
+
+  describe "#to_h" do
+    let(:post) do
+      document = Fixture.livefeed_get(:valid)
+      result = Parser.new.parse(document)
+
+      result.posts.first
+    end
+
+    let(:post_hash) do
+      post.to_h
+    end
+
+    attributes = %i[
+      id
+      author
+      url
+      title
+      text
+      location_code
+      language_code
+      coordinates
+      links
+      tags
+      images
+      indexed_at
+      published_at
+      reindexed_at
+      inlinks_count
+      blog_id
+      blog_name
+      blog_url
+      blog_rank
+      authority
+    ]
+
+    it do
+      expect(post_hash.keys).to match_array(attributes)
+    end
+
+    attributes.each do |key|
+      describe "#to_h[:#{key}]" do
+        subject { post_hash[key] }
+        it { is_expected.to eq(post.public_send(key)) }
+      end
+    end
+  end
 end

data/spec/livefeed/result_spec.rb

@@ -2,17 +2,31 @@ require 'spec_helper'
 
 module Twingly::LiveFeed
   describe Result do
-    it { should respond_to :posts }
-    it { should respond_to :ts }
-    it { should respond_to :from }
-    it { should respond_to :number_of_posts }
-    it { should respond_to :max_number_of_posts }
-    it { should respond_to :first_post }
-    it { should respond_to :last_post }
-    it { should respond_to :next_timestamp }
+    instance_methods = [
+      :posts,
+      :ts,
+      :from,
+      :number_of_posts,
+      :max_number_of_posts,
+      :first_post,
+      :last_post,
+      :next_timestamp,
+    ]
+
+    instance_methods.each do |method|
+      it { should respond_to method }
+    end
 
     context "before query has populated responses" do
       its(:posts) { should be_empty }
     end
+
+    describe "#inspect" do
+      subject { described_class.new.inspect }
+
+      instance_methods.each do |method|
+        it { should match(/ #{Regexp.quote(method)}[,=]/) }
+      end
+    end
   end
 end

data/spec/parser_spec.rb

@@ -326,16 +326,24 @@ describe Parser do
     context "with a nonexistent api key result" do
       let(:fixture) { :nonexistent_api_key }
 
-      it "should raise AuthError" do
+      it "should raise QueryError" do
         expect { subject }.to raise_error(QueryError)
       end
     end
 
+    context "with an unauthenticated api key result" do
+      let(:fixture) { :unauthenticated_api_key }
+
+      it "should raise AuthenticationError" do
+        expect { subject }.to raise_error(AuthenticationError)
+      end
+    end
+
     context "with an unauthorized api key result" do
       let(:fixture) { :unauthorized_api_key }
 
-      it "should raise AuthError" do
-        expect { subject }.to raise_error(AuthError)
+      it "should raise AuthenticationError" do
+        expect { subject }.to raise_error(AuthorizationError)
       end
     end
 

data/spec/post_spec.rb

@@ -23,6 +23,7 @@ describe Post do
   it { should respond_to :blog_url }
   it { should respond_to :blog_rank }
   it { should respond_to :authority }
+  it { should respond_to :to_h }
 
   deprecated_methods = %i(summary indexed published outlinks)
   deprecated_methods.each do |method_name|
@@ -33,4 +34,51 @@ describe Post do
       end
     end
   end
+
+  describe "#to_h" do
+    let(:post) do
+      document = Fixture.get(:minimal_valid)
+      result = Parser.new.parse(document)
+
+      result.posts.first
+    end
+
+    let(:post_hash) do
+      post.to_h
+    end
+
+    attributes = %i[
+      id
+      author
+      url
+      title
+      text
+      location_code
+      language_code
+      coordinates
+      links
+      tags
+      images
+      indexed_at
+      published_at
+      reindexed_at
+      inlinks_count
+      blog_id
+      blog_name
+      blog_url
+      blog_rank
+      authority
+    ]
+
+    it do
+      expect(post_hash.keys).to match_array(attributes)
+    end
+
+    attributes.each do |key|
+      describe "#to_h[:#{key}]" do
+        subject { post_hash[key] }
+        it { is_expected.to eq(post.public_send(key)) }
+      end
+    end
+  end
 end

data/spec/query_spec.rb

@@ -91,7 +91,7 @@ describe Query do
       let(:time) { Time.parse(timestamp) }
 
       it "should not change timezone" do
-        expect(subject.request_parameters.fetch(:q)).to include("2016-02-09T09:01:22Z")
+        expect(subject.request_parameters.fetch(:q)).to include("2016-02-09T09:01:22")
       end
 
       it "should not modify the given time object" do
@@ -117,7 +117,7 @@ describe Query do
       let(:time) { Time.parse(timestamp) }
 
       it "should convert to UTC" do
-        expect(subject.request_parameters.fetch(:q)).to include("2016-02-09T04:01:22Z")
+        expect(subject.request_parameters.fetch(:q)).to include("2016-02-09T04:01:22")
       end
 
       it "should not modify the given time object" do
@@ -158,7 +158,7 @@ describe Query do
       let(:time) { Time.parse(timestamp) }
 
       it "should not change timezone" do
-        expect(subject.request_parameters.fetch(:q)).to include("end-date:2016-02-09T09:01:22Z")
+        expect(subject.request_parameters.fetch(:q)).to include("end-date:2016-02-09T09:01:22")
       end
 
       it "should not modify the given time object" do
@@ -184,7 +184,7 @@ describe Query do
       let(:time) { Time.parse(timestamp) }
 
       it "should convert to UTC" do
-        expect(subject.request_parameters.fetch(:q)).to include("end-date:2016-02-09T04:01:22Z")
+        expect(subject.request_parameters.fetch(:q)).to include("end-date:2016-02-09T04:01:22")
       end
 
       it "should not modify the given time object" do
@@ -219,9 +219,9 @@ describe Query do
       expect(subject.request_parameters.fetch(:q)).to include("lang:en")
     end
 
-    it "should encode url paramters" do
+    it "should encode url parameters" do
       subject.end_time = Time.parse("2013-12-28 09:01:22 UTC")
-      expect(subject.url_parameters).to include('end-date%3A2013-12-28T09%3A01%3A22Z')
+      expect(subject.url_parameters).to include('end-date%3A2013-12-28T09%3A01%3A22')
     end
   end
 

data/spec/result_spec.rb

@@ -5,15 +5,29 @@ require 'uri'
 include Twingly::Search
 
 describe Result do
-  it { should respond_to :posts }
-  it { should respond_to :number_of_matches_returned }
-  it { should respond_to :number_of_matches_total }
-  it { should respond_to :seconds_elapsed }
-  it { should respond_to :all_results_returned? }
-  it { should respond_to :incomplete? }
+  instance_methods = [
+    :posts,
+    :number_of_matches_returned,
+    :number_of_matches_total,
+    :seconds_elapsed,
+    :all_results_returned?,
+    :incomplete?,
+  ]
+
+  instance_methods.each do |method|
+    it { should respond_to method }
+  end
 
   context "before query has populated responses" do
     its(:posts) { should be_empty }
     its(:all_results_returned?) { should be_truthy }
   end
+
+  describe "#inspect" do
+    subject { described_class.new.inspect }
+
+    instance_methods.each do |method|
+      it { should match(/ #{Regexp.quote(method)}[,=]/) }
+    end
+  end
 end

data/twingly-search-api-ruby.gemspec

@@ -13,18 +13,20 @@ Gem::Specification.new do |spec|
   spec.summary       = "Ruby API client for Twingly Search"
   spec.description   = "Twingly Search is a product from Twingly AB"
   spec.license       = 'MIT'
-  spec.required_ruby_version = ">= 2.1.0"
+  spec.required_ruby_version = ">= 2.5.0"
 
   spec.files         = `git ls-files`.split($/)
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "faraday",  ['>= 0.9.2', '< 0.10']
+  spec.add_dependency "faraday",  [">= 0.9.2", "< 2.0"]
   spec.add_dependency "nokogiri", "~> 1.0"
   spec.add_development_dependency "rspec", "~> 3"
   spec.add_development_dependency "rspec-its", "~> 1"
-  spec.add_development_dependency "vcr", "~> 2.6"
-  spec.add_development_dependency "webmock", "~> 1.0"
-  spec.add_development_dependency "rake", "~> 11"
-  spec.add_development_dependency "yard", "~> 0.8"
+  spec.add_development_dependency "vcr", "~> 4.0"
+  spec.add_development_dependency "webmock", "~> 3.4"
+  spec.add_development_dependency "rake", "~> 12"
+  spec.add_development_dependency "yard", [">= 0.9.11", "< 1.0.0"]
+  spec.add_development_dependency "memory_profiler", "~> 0.9"
+  spec.add_development_dependency "rubocop", "~> 0.66.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: twingly-search
 version: !ruby/object:Gem::Version
-  version: 5.1.2
+  version: 5.3.1
 platform: ruby
 authors:
 - Twingly AB
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-05-29 00:00:00.000000000 Z
+date: 2021-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -19,7 +19,7 @@ dependencies:
         version: 0.9.2
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 0.9.2
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -78,56 +78,90 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.4'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11'
+        version: '12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11'
+        version: '12'
 - !ruby/object:Gem::Dependency
   name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.9.11
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.9.11
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: memory_profiler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.66.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.66.0
 description: Twingly Search is a product from Twingly AB
 email:
 - support@twingly.com
@@ -135,8 +169,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci-build-and-install-gem.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -161,6 +196,11 @@ files:
 - lib/twingly/search/query.rb
 - lib/twingly/search/result.rb
 - lib/twingly/search/version.rb
+- profiler/fixtures/vcr_cassettes/blog_livefeed_100.yml
+- profiler/fixtures/vcr_cassettes/blog_search_100.yml
+- profiler/profile_helper.rb
+- profiler/profile_livefeed.rb
+- profiler/profile_search.rb
 - spec/client_spec.rb
 - spec/error_spec.rb
 - spec/fixtures/incomplete_result.xml
@@ -175,6 +215,7 @@ files:
 - spec/fixtures/non_xml_result.xml
 - spec/fixtures/nonexistent_api_key_result.xml
 - spec/fixtures/service_unavailable_result.xml
+- spec/fixtures/unauthenticated_api_key_result.xml
 - spec/fixtures/unauthorized_api_key_result.xml
 - spec/fixtures/undefined_error_result.xml
 - spec/fixtures/valid_coordinates_result.xml
@@ -199,7 +240,7 @@ homepage: https://github.com/twingly/twingly-search-api-ruby
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -207,16 +248,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Ruby API client for Twingly Search
 test_files:
@@ -234,6 +274,7 @@ test_files:
 - spec/fixtures/non_xml_result.xml
 - spec/fixtures/nonexistent_api_key_result.xml
 - spec/fixtures/service_unavailable_result.xml
+- spec/fixtures/unauthenticated_api_key_result.xml
 - spec/fixtures/unauthorized_api_key_result.xml
 - spec/fixtures/undefined_error_result.xml
 - spec/fixtures/valid_coordinates_result.xml
@@ -253,4 +294,3 @@ test_files:
 - spec/result_spec.rb
 - spec/spec_helper.rb
 - spec/vcr_setup.rb
-has_rdoc: