twimage 0.0.5 → 0.0.8

data/README.md

@@ -14,11 +14,20 @@ Instantiate the appropriate service and give it the standard URL returned by tha
     
 Twimage will create a Ruby tempfile with the image. To get the tempfile:
 
-    result.image
+    result.tempfile
     
 Save the image to your local system, upload to S3, etc. As soon as there are no more references to the
 tempfile in your code it will be unlinked (deleted). Enjoy!
 
+## Support
+
+Twimage currently supports the following services:
+
+* twitpic - http://twitpic.com
+* yfrog - http://yfrog.com
+
 ## Contributing
 
-To add a parser, fork this repo and then send me a pull request, that's it!
+To add a parser, fork this repo and then send me a pull request. Your parser should make a reasonable attempt to
+retrieve the highest resolution image possible and return errors if the service URL returns a 404 or the proper 
+image tag couldn't be found (see twitpic.rb for an example).

data/lib/twimage.rb

@@ -8,6 +8,7 @@ $:.unshift(File.dirname(__FILE__)) unless
   
 require 'twimage/base'
 require 'twimage/twitpic'
+require 'twimage/yfrog'
 require 'twimage/version'
 
 module Twimage

data/lib/twimage/twitpic.rb

@@ -3,8 +3,9 @@ module Twimage
     
     def initialize(service_url)
       @service_url = service_url
+      full_res_service_url = @service_url + '/full'
       begin
-        image_tag = Nokogiri::HTML(open(@service_url)).css('#photo-display').first
+        image_tag = Nokogiri::HTML(open(full_res_service_url)).css('body > img').first
       rescue OpenURI::HTTPError
         raise ServiceURLInvalid, "The service URL #{@service_url} was not found (returned a 404)"
       end

data/lib/twimage/version.rb

@@ -1,3 +1,3 @@
 module Twimage
-  VERSION = "0.0.5"
+  VERSION = "0.0.8"
 end

data/lib/twimage/yfrog.rb

@@ -0,0 +1,22 @@
+module Twimage
+  class Yfrog < Twimage::Base
+    
+    def initialize(service_url)
+      @service_url = service_url
+      full_res_service_url = @service_url.gsub(/\.com/, '.com/z')
+      begin
+        image_tag = Nokogiri::HTML(open(full_res_service_url)).css('#the-image img').first
+      rescue OpenURI::HTTPError
+        raise ServiceURLInvalid, "The service URL #{@service_url} was not found (returned a 404)"
+      end
+      
+      if image_tag
+        @image_url = image_tag['src']
+        super
+      else
+        raise ImageNotFound, "The service URL #{@service_url} did not contain an identifiable image"
+      end
+    end
+    
+  end
+end

metadata

@@ -2,7 +2,7 @@
 name: twimage
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.5
+  version: 0.0.8
 platform: ruby
 authors: 
 - Rob Cameron
@@ -54,6 +54,7 @@ files:
 - lib/twimage/base.rb
 - lib/twimage/twitpic.rb
 - lib/twimage/version.rb
+- lib/twimage/yfrog.rb
 - twimage.gemspec
 has_rdoc: true
 homepage: ""