twilio-ruby 5.0.0.rc26 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db8a11cb848a053910d7aa5812a8c15f474505cc
-  data.tar.gz: 91ca06f98099e83fbe7b5226d159cb3e52a5fadf
+  metadata.gz: c6a6f5e9d921db6048332ae4913809af14e3ea8a
+  data.tar.gz: 6a3634728a3446a9bbe70d4da8cbaf5df29e00f2
 SHA512:
-  metadata.gz: e1deca7186f4c386f31eaaa26922fac2a0f82f9463aa2360553b48ff6c9b7e1ef10055a40dd0f394538aae15905d1c5b90a89f213ea95a2121d3ed9c56e90544
-  data.tar.gz: 95bca3058f5c672ea891799c2d3358914b789c8c4984615172f34988019c9f7a6b5be4fd4aa48f3d165fe808bb0b7de4b4b065b7c0694f10d928a8e9c5f40884
+  metadata.gz: 3f866e4c93cc5bd0f58648eda34acf840b4859052f4e26967001b4fd5874accdda13a198f61bb1c5c50bcea968cb8071b9bddbcd528c0e922dcd7ca39640531d
+  data.tar.gz: e28c9d8b3f51a160ed850ff21a3cf9720b1604fe2e9b580326ee71faf0cf177d343f160c49ce055242cb6f98a82d939a3a26828dd8a886b6058f33efaddd6b6a

data/.rubocop.yml

@@ -0,0 +1,21 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  TargetRubyVersion: 2.0
+  Exclude:
+    - 'lib/twilio-ruby/rest/**/*'
+    - 'spec/integration/**/*'
+
+Metrics/LineLength:
+  Max: 120
+  Exclude:
+    - 'spec/**/*'
+
+Metrics/ClassLength:
+  Max: 175
+
+Metrics/MethodLength:
+  Max: 25
+
+Metrics/ParameterLists:
+  Max: 20

data/.rubocop_todo.yml

@@ -0,0 +1,187 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-07-07 14:30:20 -0700 using RuboCop version 0.49.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+Layout/ExtraSpacing:
+  Exclude:
+    - 'twilio-ruby.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
+Layout/IndentHeredoc:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Layout/SpaceAroundOperators:
+  Exclude:
+    - 'spec/jwt/client_capability_spec.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Exclude:
+    - 'spec/jwt/access_token_spec.rb'
+    - 'spec/jwt/client_capability_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/TrailingWhitespace:
+  Exclude:
+    - 'lib/twilio-ruby/jwt/jwt.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'Rakefile'
+    - 'spec/rack/twilio_webhook_authentication_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/twilio-ruby.rb'
+    - 'lib/twilio-ruby/framework/page.rb'
+    - 'spec/holodeck/holodeck.rb'
+
+# Offense count: 1
+# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
+Lint/UselessAccessModifier:
+  Exclude:
+    - 'lib/twilio-ruby/jwt/access_token.rb'
+
+# Offense count: 14
+Lint/UselessAssignment:
+  Exclude:
+    - 'spec/rack/twilio_webhook_authentication_spec.rb'
+
+# Offense count: 3
+Metrics/AbcSize:
+  Max: 28
+
+# Offense count: 24
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 349
+
+# Offense count: 53
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 249
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/RedundantMatch:
+  Exclude:
+    - 'lib/twilio-ruby/framework/domain.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: braces, no_braces, context_dependent
+Style/BracesAroundHashParameters:
+  Exclude:
+    - 'spec/framework/serialize_spec.rb'
+    - 'spec/jwt/access_token_spec.rb'
+    - 'spec/jwt/client_capability_spec.rb'
+    - 'spec/rack/twilio_webhook_authentication_spec.rb'
+    - 'spec/twiml/voice_response_spec.rb'
+
+# Offense count: 35
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Style/FileName:
+  Exclude:
+    - 'lib/twilio-ruby.rb'
+
+# Offense count: 3
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/twilio-ruby/framework/page.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+    - 'spec/jwt/access_token_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Exclude:
+    - 'lib/twilio-ruby/framework/serialize.rb'
+
+# Offense count: 16
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'lib/twilio-ruby/framework/domain.rb'
+    - 'lib/twilio-ruby/framework/helper.rb'
+    - 'lib/twilio-ruby/framework/version.rb'
+    - 'spec/rack/twilio_webhook_authentication_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'spec/framework/serialize_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize, SupportedStyles.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: AllowNamedUnderscoreVariables.
+Style/TrailingUnderscoreVariable:
+  Exclude:
+    - 'spec/jwt/access_token_spec.rb'
+    - 'spec/jwt/client_capability_spec.rb'
+    - 'spec/jwt/task_router_spec.rb'
+
+# Offense count: 15
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/VariableName:
+  Exclude:
+    - 'spec/jwt/client_capability_spec.rb'
+    - 'spec/jwt/task_router_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, MinSize, WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  EnforcedStyle: brackets

data/.travis.yml

@@ -0,0 +1,13 @@
+sudo: false
+language: ruby
+cache: bundler
+bundler_args: --without development
+rvm:
+  - ruby-head
+  - 2.4.0
+  - 2.3.0
+  - 2.2.0
+  - 2.1.0
+  - 2.0.0
+matrix:
+  fast_finish: true

data/CHANGES.md

@@ -1,5 +1,9 @@
 twilio-ruby changelog
 =====================
+[2017-07-13] Version 5.0.0
+--------------------------------
+- Moving to General Availability
+
 [2017-07-07] Version 5.0.0.rc26
 --------------------------------
 **Api**

data/Gemfile

@@ -3,8 +3,8 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
-  gem 'rake', '~> 10.1'
-  gem 'rspec', '~> 3.0'
   gem 'fakeweb', '~> 1.3'
   gem 'rack', '~> 1.3'
+  gem 'rake', '~> 10.1'
+  gem 'rspec', '~> 3.0'
 end

data/Makefile

@@ -1,15 +1,22 @@
+.PHONY: test lint-changed lint
+
+CHANGED_RUBY_FILES = $(shell git status --porcelain | grep ".rb" | awk -F ' ' '{print $2}' | tr '\n' ' ')
+
 install:
 	bundle install; bundle exec rake install
 
 test-install:
 	bundle install
 
-test:
+test: lint
 	bundle exec rake spec
 
 docs:
 	yard doc
 
+lint:
+	rubocop --cache true --parallel
+
 authors:
 	echo "Authors\n=======\n\nA huge thanks to all of our contributors:\n\n" > AUTHORS.md
 	git log --raw | grep "^Author: " | cut -d ' ' -f2- | cut -d '<' -f1 | sed 's/^/- /' | sort | uniq >> AUTHORS.md

data/Rakefile

@@ -22,14 +22,10 @@ task :deploy, [:version] => [:spec, :authors] do |t, args|
     increment = version_parts.pop
     increment_prefix = increment.split(/\d/)[0]
 
-    if increment_prefix
-      increment = increment[increment_prefix.length..-1]
-    end
+    increment = increment[increment_prefix.length..-1] if increment_prefix
 
     increment = increment.to_i + 1
-    if increment_prefix
-      increment = "#{increment_prefix}#{increment}"
-    end
+    increment = "#{increment_prefix}#{increment}" if increment_prefix
 
     version = [*version_parts, increment].join('.')
   else
@@ -65,4 +61,4 @@ SRC
 
   # Push the tags
   `git push --tags`
-end
+end

data/examples/examples.rb

@@ -31,7 +31,7 @@ end
 
 # get a particular call and list its recording urls
 @client.calls('CAXXXXXXX').recordings.each do |r|
-    puts r.wav
+  puts r.wav
 end
 
 # make a new outgoing call. returns a call object just like calls.get
@@ -79,7 +79,7 @@ puts @client.messages('SMXXXXXXXX').fetch.body
 
 # print some available numbers
 @client.available_phone_numbers('US').local.list.each do |num|
-
+  puts num
 end
 
 @numbers = @client.available_phone_numbers('US').local.list(area_code: '908')
@@ -89,9 +89,7 @@ end
 @client.incoming_phone_numbers.create(phone_number: @numbers[0].phone_number)
 
 # update an existing phone number's voice url
-@client.incoming_phone_numbers('PNxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx').update(
-    voice_url: 'http://example.com/voice'
-)
+@client.incoming_phone_numbers('PNxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx').update(voice_url: 'http://example.com/voice')
 
 # decommission an existing phone number
 numbers = @client.incoming_phone_numbers.list(friendly_name: 'A Fabulous Friendly Name')
@@ -110,8 +108,10 @@ conference = @client.conferences('CFxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx').fetch
 end
 
 # update a conference participant
-@client.conferences('CFxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
-    .participants('CAxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx').update(muted: 'true')
+@client
+  .conferences('CFxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
+  .participants('CAxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
+  .update(muted: 'true')
 
 ################ QUEUES ###################
 
@@ -125,11 +125,13 @@ end
 @queue = @client.queues('QQxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx').fetch
 @members = @queue.members
 
-#list members
+# list members
 @members.list.each do |m|
   puts m.wait_time
 end
 
 # dequeue a particular user and run twiml at a specific url
-@client.queues('QQxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
-    .members('CAxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx').update(url: 'http://myapp.com/deque', method: 'POST')
+@client
+  .queues('QQxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
+  .members('CAxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
+  .update(url: 'http://myapp.com/deque', method: 'POST')

data/examples/{print-call-log.rb → print_call_log.rb}

@@ -12,13 +12,13 @@ auth_token = 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy'
 # set up a client
 client = Twilio::REST::Client.new(account_sid, auth_token)
 
-calls = client.calls.page()
+calls = client.calls.page
 
-begin
+loop do
   calls.each do |call|
     price = call.price || '0.00' # since apparently prices can be nil...
     puts call.sid + "\t" + call.from + "\t" + call.to + "\t" + price.to_s
   end
   calls = calls.next_page
-end while not calls.nil?
-
+  break if calls.nil?
+end

data/lib/rack/twilio_webhook_authentication.rb

@@ -31,17 +31,16 @@ module Rack
       params = request.post? ? request.POST : {}
       auth_token = @auth_token || get_auth_token(params['AccountSid'])
       validator = Twilio::Security::RequestValidator.new(auth_token)
-      signature = env['HTTP_X_TWILIO_SIGNATURE'] || ""
+      signature = env['HTTP_X_TWILIO_SIGNATURE'] || ''
       if validator.validate(original_url, params, signature)
         @app.call(env)
       else
         [
           403,
-          {'Content-Type' => 'text/plain'},
+          { 'Content-Type' => 'text/plain' },
           ['Twilio Request Validation Failed.']
         ]
       end
     end
   end
-
 end

data/lib/twilio-ruby/framework/domain.rb

@@ -14,12 +14,8 @@ module Twilio
         "#{@base_url.chomp('/')}/#{uri.chomp('/').gsub(/^\//, '')}"
       end
 
-      def request(method, uri, params={}, data={}, headers={}, auth=nil, timeout=nil)
-        if uri.match(/^http/)
-          url = uri
-        else
-          url = self.absolute_url(uri)
-        end
+      def request(method, uri, params = {}, data = {}, headers = {}, auth = nil, timeout = nil)
+        url = uri.match(/^http/) ? uri : absolute_url(uri)
 
         @client.request(
           @host,

data/lib/twilio-ruby/framework/error.rb

@@ -26,6 +26,5 @@ module Twilio
         "[HTTP #{status_code}] #{code} : #{message}"
       end
     end
-
   end
 end

data/lib/twilio-ruby/framework/helper.rb

@@ -6,4 +6,4 @@ module Twilio
       "#{left}/#{right}"
     end
   end
-end
+end

data/lib/twilio-ruby/framework/page.rb

@@ -1,29 +1,30 @@
 module Twilio
   module REST
+    # Page Base Class
     class Page
       include Enumerable
 
       META_KEYS = [
-          'end',
-          'first_page_uri',
-          'next_page_uri',
-          'last_page_uri',
-          'page',
-          'page_size',
-          'previous_page_uri',
-          'total',
-          'num_pages',
-          'start',
-          'uri'
-      ]
+        'end',
+        'first_page_uri',
+        'next_page_uri',
+        'last_page_uri',
+        'page',
+        'page_size',
+        'previous_page_uri',
+        'total',
+        'num_pages',
+        'start',
+        'uri'
+      ].freeze
 
       def initialize(version, response)
-        payload = self.process_response(response)
+        payload = process_response(response)
 
         @version = version
         @payload = payload
         @solution = {}
-        @records = self.load_page(payload)
+        @records = load_page(payload)
       end
 
       def process_response(response)
@@ -40,12 +41,10 @@ module Twilio
         else
           keys = payload.keys
           key = keys - META_KEYS
-          if key.size == 1
-            return payload[key.first]
-          end
+          return payload[key.first] if key.size == 1
         end
 
-        raise Twilio::REST::TwilioError.new('Page Records can not be deserialized')
+        raise Twilio::REST::TwilioError, 'Page Records can not be deserialized'
       end
 
       def previous_page_url
@@ -69,28 +68,28 @@ module Twilio
       end
 
       def get_instance(payload)
-        raise Twilio::REST::TwilioError.new('Page.get_instance() must be implemented in the derived class')
+        raise Twilio::REST::TwilioError, 'Page.get_instance() must be implemented in the derived class'
       end
 
       def previous_page
-        return nil unless self.previous_page_url
+        return nil unless previous_page_url
 
-        response = @version.domain.request('GET', self.previous_page_url)
+        response = @version.domain.request('GET', previous_page_url)
 
         self.class.new(@version, response, @solution)
       end
 
       def next_page
-        return nil unless self.next_page_url
+        return nil unless next_page_url
 
-        response = @version.domain.request('GET', self.next_page_url)
+        response = @version.domain.request('GET', next_page_url)
 
         self.class.new(@version, response, @solution)
       end
 
       def each
         @records.each do |record|
-          yield self.get_instance(record)
+          yield get_instance(record)
         end
       end
 
@@ -100,4 +99,3 @@ module Twilio
     end
   end
 end
-