twilio-ruby 5.0.0.rc26 → 5.0.0

data/lib/twilio-ruby/rest/video/v1/room/recording.rb

@@ -84,16 +84,6 @@ module Twilio
             # When passed a block, yields RoomRecordingInstance records from the API.
             # This operation lazily loads records as efficiently as possible until the limit
             # is reached.
-            # @param [room_recording.Status] status The status
-            # @param [String] source_sid The source_sid
-            # @param [Time] date_created_after The date_created_after
-            # @param [Time] date_created_before The date_created_before
-            # @param [Integer] limit Upper limit for the number of records to return.                  stream()
-            #  guarantees to never return more than limit.                  Default is no limit
-            # @param [Integer] page_size Number of records to fetch per request, when                       not set will use
-            #  the default value of 50 records.                      If no page_size is defined
-            #                       but a limit is defined, stream() will attempt to read the
-            #                       limit with the most efficient page size, i.e. min(limit, 1000)
             def each
               limits = @version.read_limits
 
@@ -161,7 +151,6 @@ module Twilio
             # @param [Version] version Version that contains the resource
             # @param [Response] response Response from the API
             # @param [Hash] solution Path solution for the resource
-            # @param [String] room_sid The room_sid
             # @return [RoomRecordingPage] RoomRecordingPage
             def initialize(version, response, solution)
               super(version, response)
@@ -275,7 +264,6 @@ module Twilio
             ##
             # Generate an instance context for the instance, the context is capable of
             # performing various actions.  All instance actions are proxied to the context
-            # @param [Version] version Version that contains the resource
             # @return [RoomRecordingContext] RoomRecordingContext for this RoomRecordingInstance
             def context
               unless @instance_context
@@ -288,58 +276,86 @@ module Twilio
               @instance_context
             end
 
+            ##
+            # @return [String] The account_sid
             def account_sid
               @properties['account_sid']
             end
 
+            ##
+            # @return [room_recording.Status] The status
             def status
               @properties['status']
             end
 
+            ##
+            # @return [Time] The date_created
             def date_created
               @properties['date_created']
             end
 
+            ##
+            # @return [String] The sid
             def sid
               @properties['sid']
             end
 
+            ##
+            # @return [String] The source_sid
             def source_sid
               @properties['source_sid']
             end
 
+            ##
+            # @return [String] The size
             def size
               @properties['size']
             end
 
+            ##
+            # @return [room_recording.Type] The type
             def type
               @properties['type']
             end
 
+            ##
+            # @return [String] The duration
             def duration
               @properties['duration']
             end
 
+            ##
+            # @return [room_recording.Format] The container_format
             def container_format
               @properties['container_format']
             end
 
+            ##
+            # @return [room_recording.Codec] The codec
             def codec
               @properties['codec']
             end
 
+            ##
+            # @return [Hash] The grouping_sids
             def grouping_sids
               @properties['grouping_sids']
             end
 
+            ##
+            # @return [String] The room_sid
             def room_sid
               @properties['room_sid']
             end
 
+            ##
+            # @return [String] The url
             def url
               @properties['url']
             end
 
+            ##
+            # @return [String] The links
             def links
               @properties['links']
             end

data/lib/twilio-ruby/security/request_validator.rb

@@ -1,7 +1,6 @@
 module Twilio
   module Security
     class RequestValidator
-
       def initialize(auth_token = nil)
         @auth_token = auth_token || Twilio.auth_token
         raise ArgumentError, 'Auth token is required' if @auth_token.nil?
@@ -31,7 +30,7 @@ module Twilio
 
         res = 0
         b.each_byte { |byte| res |= byte ^ l.shift }
-        res == 0
+        res.zero?
       end
 
       # `ActionController::Parameters` no longer, as of Rails 5, inherits

data/lib/twilio-ruby/twiml/messaging_response.rb

@@ -1,10 +1,9 @@
 module Twilio
   module TwiML
-
     # Messaging TwiML Response
     class MessagingResponse < TwiML
       # Create a new <Response>
-      def initialize()
+      def initialize
         super()
         self.name = 'Response'
         yield(self) if block_given?
@@ -23,15 +22,7 @@ module Twilio
       #
       # == Returns:
       # A <Response> element with a <Message> child element
-      def message(
-        body: nil,
-        to: nil,
-        from: nil,
-        method: nil,
-        action: nil,
-        status_callback: nil,
-        **keyword_args)
-
+      def message(body: nil, to: nil, from: nil, method: nil, action: nil, status_callback: nil, **keyword_args)
         message = Message.new(
           body: body,
           to: to,
@@ -43,8 +34,7 @@ module Twilio
         )
 
         yield(message) if block_given?
-
-        self.append(message)
+        append(message)
       end
 
       # Create an <Redirect> element
@@ -57,7 +47,7 @@ module Twilio
       # == Returns:
       # A <Response> element with an <Redirect> child element
       def redirect(url, method: nil, **keyword_args)
-        self.append(Redirect.new(url, method: method, **keyword_args))
+        append(Redirect.new(url, method: method, **keyword_args))
       end
     end
 
@@ -73,9 +63,7 @@ module Twilio
       # A <Message> element
       def initialize(body: nil, **keyword_args)
         super(**keyword_args)
-        if !(body.nil?)
-          @value = body
-        end
+        @value = body unless body.nil?
         yield(self) if block_given?
       end
 
@@ -88,7 +76,7 @@ module Twilio
       # == Returns:
       # A <Message> element with a <Body> child element
       def body(body)
-        self.append(Body.new(body))
+        append(Body.new(body))
       end
 
       # Create a <Media> element
@@ -100,7 +88,7 @@ module Twilio
       # == Returns:
       # A <Message> element with a <Media> child element
       def media(url)
-        self.append(Media.new(url))
+        append(Media.new(url))
       end
     end
 

data/lib/twilio-ruby/twiml/twiml.rb

@@ -5,12 +5,13 @@ module Twilio
     class TwiMLError < StandardError
     end
 
+    # TwiML Base Class
     class TwiML
       # Generate getter/setter methods
       attr_accessor :name
       attr_accessor :indent
 
-      alias_method :to_xml, :to_s
+      alias to_xml to_s
 
       def initialize(indent: false, **keyword_args)
         @name = self.class.name.split('::').last
@@ -20,9 +21,7 @@ module Twilio
         @attrs = {}
 
         keyword_args.each do |key, val|
-          if !(val.nil?)
-            @attrs[TwiML.to_lower_camel_case(key)] = val
-          end
+          @attrs[TwiML.to_lower_camel_case(key)] = val unless val.nil?
         end
       end
 
@@ -33,13 +32,13 @@ module Twilio
       end
 
       def to_s(xml_declaration = true)
-        xml = self.xml.to_s(:indent => self.indent)
+        xml = self.xml.to_s(indent: indent)
 
         return ('<?xml version="1.0" encoding="UTF-8"?>' + xml) if xml_declaration
         xml
       end
 
-      def xml()
+      def xml
         # create XML element
         elem = LibXML::XML::Node.new(@name, @value)
 
@@ -48,11 +47,8 @@ module Twilio
         keys.each do |key|
           value = @attrs[key]
 
-          if (value.is_a?(TrueClass) || value.is_a?(FalseClass))
-            elem[key] = value.to_s.downcase
-          else
-            elem[key] = value.to_s
-          end
+          value_is_boolean = value.is_a?(TrueClass) || value.is_a?(FalseClass)
+          elem[key] = value_is_boolean ? value.to_s.downcase : value.to_s
         end
 
         @verbs.each do |verb|
@@ -63,9 +59,7 @@ module Twilio
       end
 
       def append(verb)
-        if !(verb.is_a?(TwiML))
-          raise TwiMLError.new "Only appending of TwiML is allowed"
-        end
+        raise TwiMLError, 'Only appending of TwiML is allowed' unless verb.is_a?(TwiML)
 
         @verbs << verb
         self

data/lib/twilio-ruby/twiml/voice_response.rb

@@ -1,12 +1,11 @@
 module Twilio
   module TwiML
-
     # Voice TwiML Response
     class VoiceResponse < TwiML
       # Create a new <Response>
-      def initialize()
+      def initialize
         super()
-        self.name = 'Response'
+        @name = 'Response'
         yield(self) if block_given?
       end
 
@@ -29,37 +28,37 @@ module Twilio
       # == Returns:
       # A <Response> element with a <Dial> child element
       def dial(
-          number: nil,
-          action: nil,
-          method: nil,
-          timeout: nil,
-          hangup_on_star: nil,
-          time_limit: nil,
-          caller_id: nil,
-          record: nil,
-          trim: nil,
-          recording_status_callback: nil,
-          recording_status_callback_method: nil,
-          **keyword_args)
+        number: nil,
+        action: nil,
+        method: nil,
+        timeout: nil,
+        hangup_on_star: nil,
+        time_limit: nil,
+        caller_id: nil,
+        record: nil,
+        trim: nil,
+        recording_status_callback: nil,
+        recording_status_callback_method: nil,
+        **keyword_args
+      )
 
         dial = Dial.new(
-            number: number,
-            action: action,
-            method: method,
-            timeout: timeout,
-            hangup_on_star: hangup_on_star,
-            time_limit: time_limit,
-            caller_id: caller_id,
-            record: record,
-            trim: trim,
-            recording_status_callback: recording_status_callback,
-            recording_status_callback_method: recording_status_callback_method,
-            **keyword_args
+          number: number,
+          action: action,
+          method: method,
+          timeout: timeout,
+          hangup_on_star: hangup_on_star,
+          time_limit: time_limit,
+          caller_id: caller_id,
+          record: record,
+          trim: trim,
+          recording_status_callback: recording_status_callback,
+          recording_status_callback_method: recording_status_callback_method,
+          **keyword_args
         )
 
         yield(dial) if block_given?
-
-        self.append(dial)
+        append(dial)
       end
 
       # Create an <Echo> element
@@ -70,7 +69,7 @@ module Twilio
       # == Returns:
       # A <Response> element with an <Echo> child element
       def echo(**keyword_args)
-        self.append(Echo.new(**keyword_args))
+        append(Echo.new(**keyword_args))
       end
 
       # Create an <Enqueue> element
@@ -93,7 +92,8 @@ module Twilio
         wait_url: nil,
         wait_url_method: nil,
         workflow_sid: nil,
-        **keyword_args)
+        **keyword_args
+      )
 
         enqueue = Enqueue.new(
           name,
@@ -106,8 +106,7 @@ module Twilio
         )
 
         yield(enqueue) if block_given?
-
-        self.append(enqueue)
+        append(enqueue)
       end
 
       # Create a <Gather> element
@@ -140,7 +139,8 @@ module Twilio
         hints: nil,
         barge_in: nil,
         acknowledge_sound_url: nil,
-        **keyword_args)
+        **keyword_args
+      )
 
         gather = Gather.new(
           action: action,
@@ -158,24 +158,23 @@ module Twilio
         )
 
         yield(gather) if block_given?
-
-        self.append(gather)
+        append(gather)
       end
 
       # Create a <Hangup> element
       #
       # == Returns:
       # A <Response> element with a <Hangup> child element
-      def hangup()
-        self.append(Hangup.new)
+      def hangup
+        append(Hangup.new)
       end
 
       # Create a <Leave> element
       #
       # == Returns:
       # A <Response> element with a <Leave> child element
-      def leave()
-        self.append(Leave.new)
+      def leave
+        append(Leave.new)
       end
 
       # Create a <Pause> element
@@ -186,7 +185,7 @@ module Twilio
       # == Returns:
       # A <Response> element with a <Pause> child element
       def pause(length: nil)
-        self.append(Pause.new(length: length))
+        append(Pause.new(length: length))
       end
 
       # Create a <Play> element
@@ -200,11 +199,11 @@ module Twilio
       # == Returns:
       # A <Response> element with a <Play> child element
       def play(url: nil, loop: nil, digits: nil, **keyword_args)
-        self.append(Play.new(
-          url: url,
-          loop: loop,
-          digits: digits,
-          **keyword_args
+        append(Play.new(
+                 url: url,
+                 loop: loop,
+                 digits: digits,
+                 **keyword_args
         ))
       end
 
@@ -238,20 +237,21 @@ module Twilio
         recording_status_callback_method: nil,
         transcribe: nil,
         transcribe_callback: nil,
-        **keyword_args)
-        self.append(Record.new(
-          action: action,
-          method: method,
-          timeout: timeout,
-          finish_on_key: finish_on_key,
-          max_length: max_length,
-          play_beep: play_beep,
-          trim: trim,
-          recording_status_callback: recording_status_callback,
-          recording_status_callback_method: recording_status_callback_method,
-          transcribe: transcribe,
-          transcribe_callback: transcribe_callback,
-          **keyword_args
+        **keyword_args
+      )
+        append(Record.new(
+                 action: action,
+                 method: method,
+                 timeout: timeout,
+                 finish_on_key: finish_on_key,
+                 max_length: max_length,
+                 play_beep: play_beep,
+                 trim: trim,
+                 recording_status_callback: recording_status_callback,
+                 recording_status_callback_method: recording_status_callback_method,
+                 transcribe: transcribe,
+                 transcribe_callback: transcribe_callback,
+                 **keyword_args
         ))
       end
 
@@ -265,7 +265,7 @@ module Twilio
       # == Returns:
       # A <Response> element with a <Redirect> child element
       def redirect(url, method: nil, **keyword_args)
-        self.append(Redirect.new(url, method: method, **keyword_args))
+        append(Redirect.new(url, method: method, **keyword_args))
       end
 
       # Create a <Reject> element
@@ -277,7 +277,7 @@ module Twilio
       # == Returns:
       # A <Response> element with a <Reject> child element
       def reject(reason: nil, **keyword_args)
-        self.append(Reject.new(reason: reason, **keyword_args))
+        append(Reject.new(reason: reason, **keyword_args))
       end
 
       # Create a <Say> element
@@ -292,12 +292,12 @@ module Twilio
       # == Returns:
       # A <Response> element with a <Say> child element
       def say(body, loop: nil, language: nil, voice: nil, **keyword_args)
-        self.append(Say.new(
-          body,
-          loop: loop,
-          language: language,
-          voice: voice,
-          **keyword_args
+        append(Say.new(
+                 body,
+                 loop: loop,
+                 language: language,
+                 voice: voice,
+                 **keyword_args
         ))
       end
 
@@ -314,22 +314,15 @@ module Twilio
       #
       # == Returns:
       # A <Response> element with a <Sms> child element
-      def sms(
-        body,
-        to: nil,
-        from: nil,
-        method: nil,
-        action: nil,
-        status_callback: nil,
-        **keyword_args)
-        self.append(Sms.new(
-          body,
-          to: to,
-          from: from,
-          method: method,
-          action: action,
-          status_callback: status_callback,
-          **keyword_args
+      def sms(body, to: nil, from: nil, method: nil, action: nil, status_callback: nil, **keyword_args)
+        append(Sms.new(
+                 body,
+                 to: to,
+                 from: from,
+                 method: method,
+                 action: action,
+                 status_callback: status_callback,
+                 **keyword_args
         ))
       end
     end
@@ -346,9 +339,7 @@ module Twilio
       # A <Dial> element
       def initialize(number: nil, **keyword_args)
         super(**keyword_args)
-        if !(number.nil?)
-          @value = number
-        end
+        @value = number unless number.nil?
         yield(self) if block_given?
       end
 
@@ -372,15 +363,16 @@ module Twilio
         status_callback_event: nil,
         status_callback_method: nil,
         status_callback: nil,
-        **keyword_args)
-        self.append(Client.new(
-          name,
-          method: method,
-          url: url,
-          status_callback_event: status_callback_event,
-          status_callback_method: status_callback_method,
-          status_callback: status_callback,
-          **keyword_args
+        **keyword_args
+      )
+        append(Client.new(
+                 name,
+                 method: method,
+                 url: url,
+                 status_callback_event: status_callback_event,
+                 status_callback_method: status_callback_method,
+                 status_callback: status_callback,
+                 **keyword_args
         ))
       end
 
@@ -424,25 +416,26 @@ module Twilio
         status_callback_method: nil,
         recording_status_callback: nil,
         recording_status_callback_method: nil,
-        **keyword_args)
-        self.append(Conference.new(
-          name,
-          muted: muted,
-          start_conference_on_enter: start_conference_on_enter,
-          end_conference_on_exit: end_conference_on_exit,
-          max_participants: max_participants,
-          beep: beep,
-          record: record,
-          trim: trim,
-          wait_url: wait_url,
-          wait_method: wait_method,
-          event_callback_url: event_callback_url,
-          status_callback: status_callback,
-          status_callback_event: status_callback_event,
-          status_callback_method: status_callback_method,
-          recording_status_callback: recording_status_callback,
-          recording_status_callback_method: recording_status_callback_method,
-          **keyword_args
+        **keyword_args
+      )
+        append(Conference.new(
+                 name,
+                 muted: muted,
+                 start_conference_on_enter: start_conference_on_enter,
+                 end_conference_on_exit: end_conference_on_exit,
+                 max_participants: max_participants,
+                 beep: beep,
+                 record: record,
+                 trim: trim,
+                 wait_url: wait_url,
+                 wait_method: wait_method,
+                 event_callback_url: event_callback_url,
+                 status_callback: status_callback,
+                 status_callback_event: status_callback_event,
+                 status_callback_method: status_callback_method,
+                 recording_status_callback: recording_status_callback,
+                 recording_status_callback_method: recording_status_callback_method,
+                 **keyword_args
         ))
       end
 
@@ -468,16 +461,17 @@ module Twilio
         status_callback: nil,
         status_callback_event: nil,
         status_callback_method: nil,
-        **keyword_args)
-        self.append(Number.new(
-          number,
-          send_digits: send_digits,
-          url: url,
-          method: method,
-          status_callback: status_callback,
-          status_callback_event: status_callback_event,
-          status_callback_method: status_callback_method,
-          **keyword_args
+        **keyword_args
+      )
+        append(Number.new(
+                 number,
+                 send_digits: send_digits,
+                 url: url,
+                 method: method,
+                 status_callback: status_callback,
+                 status_callback_event: status_callback_event,
+                 status_callback_method: status_callback_method,
+                 **keyword_args
         ))
       end
 
@@ -499,14 +493,15 @@ module Twilio
         method: nil,
         reservation_sid: nil,
         post_work_activity_sid: nil,
-        **keyword_args)
-        self.append(Queue.new(
-          queue_name,
-          url: url,
-          method: method,
-          reservation_sid: reservation_sid,
-          post_work_activity_sid: post_work_activity_sid,
-          **keyword_args
+        **keyword_args
+      )
+        append(Queue.new(
+                 queue_name,
+                 url: url,
+                 method: method,
+                 reservation_sid: reservation_sid,
+                 post_work_activity_sid: post_work_activity_sid,
+                 **keyword_args
         ))
       end
 
@@ -519,7 +514,7 @@ module Twilio
       # == Returns:
       # A <Dial> element with a <Sim> child element
       def sim(sid, **keyword_args)
-        self.append(Sim.new(sid, **keyword_args))
+        append(Sim.new(sid, **keyword_args))
       end
 
       # Create a <Sip> element
@@ -546,17 +541,18 @@ module Twilio
         status_callback: nil,
         status_callback_event: nil,
         status_callback_method: nil,
-        **keyword_args)
-        self.append(Sip.new(
-          uri,
-          username: username,
-          password: password,
-          url: url,
-          method: method,
-          status_callback: status_callback,
-          status_callback_event: status_callback_event,
-          status_callback_method: status_callback_method,
-          **keyword_args
+        **keyword_args
+      )
+        append(Sip.new(
+                 uri,
+                 username: username,
+                 password: password,
+                 url: url,
+                 method: method,
+                 status_callback: status_callback,
+                 status_callback_event: status_callback_event,
+                 status_callback_method: status_callback_method,
+                 **keyword_args
         ))
       end
     end
@@ -640,6 +636,7 @@ module Twilio
         @value = sid
       end
     end
+
     # <Sip> element
     class Sip < TwiML
       # Create a <Sip> element
@@ -695,7 +692,7 @@ module Twilio
       # == Returns:
       # An <Enqueue> element with a <Task> child element
       def task(attributes, **keyword_args)
-        self.append(Task.new(attributes, **keyword_args))
+        append(Task.new(attributes, **keyword_args))
       end
     end
 
@@ -711,11 +708,7 @@ module Twilio
       # A <Task> element
       def initialize(attributes, **keyword_args)
         super(**keyword_args)
-        if attributes.is_a?(String)
-          @value = attributes
-        else
-          @value = JSON.generate(attributes)
-        end
+        @value = attributes.is_a?(String) ? attributes : JSON.generate(attributes)
       end
     end
 
@@ -745,18 +738,13 @@ module Twilio
       #
       # == Returns:
       # A <Gather> element with a <Say> child element
-      def say(
-        body,
-        loop: nil,
-        language: nil,
-        voice: nil,
-        **keyword_args)
-        self.append(Say.new(
-          body,
-          loop: loop,
-          language: language,
-          voice: voice,
-          **keyword_args
+      def say(body, loop: nil, language: nil, voice: nil, **keyword_args)
+        append(Say.new(
+                 body,
+                 loop: loop,
+                 language: language,
+                 voice: voice,
+                 **keyword_args
         ))
       end
 
@@ -771,11 +759,11 @@ module Twilio
       # == Returns:
       # A <Gather> element with a <Play> child element
       def play(url: nil, loop: nil, digits: nil, **keyword_args)
-        self.append(Play.new(
-          url: url,
-          loop: loop,
-          digits: digits,
-          **keyword_args
+        append(Play.new(
+                 url: url,
+                 loop: loop,
+                 digits: digits,
+                 **keyword_args
         ))
       end
 
@@ -787,7 +775,7 @@ module Twilio
       # == Returns:
       # A <Gather> element with a <Pause> child element
       def pause(length: nil)
-        self.append(Pause.new(length: length))
+        append(Pause.new(length: length))
       end
     end