twilio-ruby 5.5.1 → 5.58.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: eaaec1537e9280b3a86d17fda7a991a6c0ff8d01
-  data.tar.gz: e365ee3bac63b9d792907603d85ed0d9627ad30d
+SHA256:
+  metadata.gz: e167e2f47babb9e5652b385ede76e80463adea6014e4f9792128e33404760e5c
+  data.tar.gz: 957a9a74c168c72927875320f8217d7c596b0d90a65dab5ed5ce5c2dd65862b9
 SHA512:
-  metadata.gz: 7c889d445a72c113d5713683e3b6d4ff08fb2d6645f4a641fc14116c6382ae3625725afc52733c05fc314169e5a5324c56c7bc4944a1ae4bdaca3d5761968636
-  data.tar.gz: ec0baa1b0a491546577d4d094472e36ec1aa7932d851e55331f6723514ee72778069f812c543a025b535ad46772a809cda65564d47736d864228c1f15020f261
+  metadata.gz: 43aef4541bc88db9f74877d012a55fc052891051ccbdc9360357af66c876cd11d2e48398fbf6ea617513a40f6f2f9bc721da6345c01971007b6484a06346046c
+  data.tar.gz: a099337f9ae57f2954bab11add9d43a29773ac77f3429f693a6f7845fdf5099147f1d2c1423dccc7d01e302f66e7ea2c86bb2f17c0fd35400fdb70533da1f66d

data/.dockerignore

@@ -0,0 +1 @@
+Gemfile.lock

data/.gitignore

@@ -3,9 +3,14 @@
 !.rubocop_todo.yml
 !.rubocop.yml
 !.travis.yml
+!.dockerignore
 pkg/*
 doc/*
 Gemfile.lock
 *.gem
 bin
 docs/_build
+*.bak
+*.iml
+
+coverage

data/.rubocop.yml

@@ -1,24 +1,34 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.0
+  TargetRubyVersion: 2.6
   Exclude:
     - 'lib/twilio-ruby/rest/**/*'
     - 'spec/integration/**/*'
     - 'lib/twilio-ruby/version.rb'
     - 'lib/twilio-ruby/twiml/**/*'
     - 'lib/twilio-ruby/util/configuration.rb'
+    - 'vendor/**/*'
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
   Exclude:
     - 'spec/**/*'
 
+Style/BlockDelimiters:
+  Exclude:
+    - 'spec/**/*'
+
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - 'spec/**/*'
+
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
+    - twilio-ruby.gemspec
 
-Metrics/AbcSize:
+Layout/HeredocIndentation:
   Enabled: false
 
 Metrics/ClassLength:
@@ -38,3 +48,12 @@ Metrics/PerceivedComplexity:
 
 Metrics/CyclomaticComplexity:
   Enabled: false
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-07-07 14:30:20 -0700 using RuboCop version 0.49.1.
+# on 2020-04-29 14:57:47 -0500 using RuboCop version 0.82.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -8,29 +8,44 @@
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
+# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
+# Include: **/*.gemspec
+Gemspec/OrderedDependencies:
+  Exclude:
+    - 'twilio-ruby.gemspec'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
   Exclude:
     - 'twilio-ruby.gemspec'
 
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterGuardClause:
+  Exclude:
+    - 'lib/rack/twilio_webhook_authentication.rb'
+    - 'lib/twilio-ruby/framework/serialize.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Layout/IndentHeredoc:
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
+Layout/ExtraSpacing:
   Exclude:
-    - 'Rakefile'
+    - 'twilio-ruby.gemspec'
 
 # Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
 Layout/SpaceAroundOperators:
   Exclude:
     - 'spec/jwt/client_capability_spec.rb'
 
 # Offense count: 8
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
 # SupportedStylesForEmptyBraces: space, no_space
 Layout/SpaceInsideHashLiteralBraces:
@@ -40,25 +55,18 @@ Layout/SpaceInsideHashLiteralBraces:
 
 # Offense count: 1
 # Cop supports --auto-correct.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'lib/twilio-ruby/jwt/jwt.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Exclude:
-    - 'Rakefile'
     - 'spec/rack/twilio_webhook_authentication_spec.rb'
 
 # Offense count: 4
 # Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
 Lint/UnusedMethodArgument:
   Exclude:
     - 'lib/twilio-ruby.rb'
-    - 'lib/twilio-ruby/framework/page.rb'
+    - 'lib/twilio-ruby/framework/rest/page.rb'
     - 'spec/holodeck/holodeck.rb'
 
 # Offense count: 1
@@ -72,64 +80,82 @@ Lint/UselessAssignment:
   Exclude:
     - 'spec/rack/twilio_webhook_authentication_spec.rb'
 
-# Offense count: 3
-Metrics/AbcSize:
-  Max: 28
-
-# Offense count: 24
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/BlockLength:
-  Max: 349
-
-# Offense count: 53
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 249
-
 # Offense count: 1
-# Cop supports --auto-correct.
-Performance/RedundantMatch:
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Naming/FileName:
   Exclude:
-    - 'lib/twilio-ruby/framework/domain.rb'
+    - 'lib/twilio-ruby.rb'
 
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
+# Offense count: 2
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
+  Exclude:
+    - 'lib/twilio-ruby/security/request_validator.rb'
+
+# Offense count: 19
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, camelCase
+Naming/VariableName:
   Exclude:
-    - 'spec/framework/serialize_spec.rb'
-    - 'spec/jwt/access_token_spec.rb'
     - 'spec/jwt/client_capability_spec.rb'
-    - 'spec/rack/twilio_webhook_authentication_spec.rb'
-    - 'spec/twiml/voice_response_spec.rb'
+    - 'spec/jwt/task_router_spec.rb'
 
-# Offense count: 35
+# Offense count: 39
 Style/Documentation:
   Enabled: false
 
 # Offense count: 1
-# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
-# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
-Style/FileName:
+# Cop supports --auto-correct.
+Style/Encoding:
   Exclude:
-    - 'lib/twilio-ruby.rb'
+    - 'twilio-ruby.gemspec'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Exclude:
+    - 'spec/spec_helper.rb'
+    - 'twilio-ruby.gemspec'
+
+# Offense count: 23
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
 
 # Offense count: 3
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
-    - 'lib/twilio-ruby/framework/page.rb'
+    - 'lib/twilio-ruby/framework/rest/page.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
 Style/HashSyntax:
   Exclude:
     - 'spec/jwt/access_token_spec.rb'
 
+# Offense count: 12
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/twilio-ruby/framework/rest/page.rb'
+    - 'lib/twilio-ruby/framework/rest/version.rb'
+    - 'lib/twilio-ruby/jwt/access_token.rb'
+    - 'lib/twilio-ruby/jwt/client_capability.rb'
+    - 'lib/twilio-ruby/jwt/jwt.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/RedundantFreeze:
+  Exclude:
+    - 'lib/twilio-ruby/jwt/task_router.rb'
+
 # Offense count: 2
 # Cop supports --auto-correct.
 Style/RedundantSelf:
@@ -138,31 +164,24 @@ Style/RedundantSelf:
 
 # Offense count: 16
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
 Style/RegexpLiteral:
   Exclude:
-    - 'lib/twilio-ruby/framework/domain.rb'
-    - 'lib/twilio-ruby/framework/helper.rb'
-    - 'lib/twilio-ruby/framework/version.rb'
+    - 'lib/twilio-ruby/framework/rest/domain.rb'
+    - 'lib/twilio-ruby/framework/rest/helper.rb'
+    - 'lib/twilio-ruby/framework/rest/version.rb'
     - 'spec/rack/twilio_webhook_authentication_spec.rb'
 
-# Offense count: 3
+# Offense count: 5
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Exclude:
     - 'spec/framework/serialize_spec.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: MinSize, SupportedStyles.
-# SupportedStyles: percent, brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
-
-# Offense count: 13
+# Offense count: 14
 # Cop supports --auto-correct.
 # Configuration parameters: AllowNamedUnderscoreVariables.
 Style/TrailingUnderscoreVariable:
@@ -172,16 +191,8 @@ Style/TrailingUnderscoreVariable:
     - 'spec/jwt/task_router_spec.rb'
 
 # Offense count: 15
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: snake_case, camelCase
-Style/VariableName:
-  Exclude:
-    - 'spec/jwt/client_capability_spec.rb'
-    - 'spec/jwt/task_router_spec.rb'
-
-# Offense count: 3
 # Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles, MinSize, WordRegex.
+# Configuration parameters: MinSize, WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
   EnforcedStyle: brackets

data/.travis.yml

@@ -1,21 +1,56 @@
-sudo: false
 language: ruby
 cache: bundler
-bundler_args: --without development
-
+bundler_args: "--without development"
 rvm:
-  - ruby-head
-  - 2.4.0
-  - 2.3.0
-  - 2.2.0
-  - 2.1
-  - 2.0.0
-  - jruby-9.1.9.0
-
+- ruby-head
+- jruby-9.2
+- 2.4
+- 2.5
+- 2.6
+- 2.7
+- 3.0
+services:
+- docker
+install: make install
+script:
+- make test
+- if [[ "$TRAVIS_BRANCH" == "main"  ||  "$TRAVIS_BRANCH" == "travis" ]] && [ "$TRAVIS_PULL_REQUEST"
+  == "false" ]; then echo "${DOCKER_PASSWORD}" | docker login -u "${DOCKER_USERNAME}"
+  --password-stdin; fi
 matrix:
+  include:
+    - language: ruby
+      rvm: '3.0'
+      # The below workaround is necessary because of the branch coverage inclusion in simplecov 0.18+
+      # more discussion here - https://community.sonarsource.com/t/ruby-coverage-simplecov-json-file-does-not-work/20909/7
+      after_success:
+        - ruby -rjson -e 'sqube = JSON.load(File.read("coverage/.resultset.json"))["RSpec"]["coverage"].transform_values {|lines| lines["lines"]}; total = { "RSpec" => { "coverage" => sqube, "timestamp" => Time.now.to_i }}; puts JSON.dump(total)' > coverage/.resultset.sonarqube.json
+        - sonar-scanner
+  allow_failures:
+  - rvm: ruby-head
   fast_finish: true
-
-before_install:
-  # Bundler on Travis may be too out of date
-  # Update bundler to a recent version.
-  - gem install bundler
+deploy:
+- provider: script
+  script: make docker-build && make docker-push
+  skip_cleanup: true
+  on:
+    tags: true
+    rvm: '2.4'
+- provider: rubygems
+  api_key: "$RUBYGEMS_APIKEY"
+  on:
+    tags: true
+    rvm: '2.4'
+notifications:
+  slack:
+    if: branch = main
+    on_pull_requests: false
+    on_success: never
+    on_failure: change
+    rooms:
+      secure: HG7rC5VSDOZiLCkpTsC4ZImh1k59OPi6YEjYKhdGXItybLHa6Yh5C42WvSx3kVW3SeyLOm1CiaMv+pbBZUXStXYsl8eH69MbEZimhDWsPs/m+bh+gEISov22WNUs3ZfUqIXMIb6v18oXPp2Qa1gX5LUEAGoSxHWNmCAcHayWl7M=
+addons:
+  sonarcloud:
+    organization: twilio
+    token:
+      secure: OSEahx/yO/r9PdjXbASwJt+ogphxkDDpnlajWNCBTc+hoiEurGP/12CN0oQi7+iishIgIowqo5J9/+m1BQfsAv4fKST+t6mSazx27udiiM9am03lhviW8QSG6STADvtq6uJRqTXMk3WehoSidNRYXamVdCoBbqxCSaMX8MbMsN8=