twilio-ruby 5.10.3 → 5.10.4

data/lib/twilio-ruby/rest/taskrouter/v1/workspace/workspace_statistics.rb

@@ -76,7 +76,7 @@ module Twilio
 
             ##
             # Fetch a WorkspaceStatisticsInstance
-            # @param [String] minutes Filter cumulative statistics by up to ‘x’ minutes in the
+            # @param [String] minutes Filter cumulative statistics by up to 'x' minutes in the
             #   past. This is helpful for statistics for the last 15 minutes, 240 minutes (4
             #   hours), and 480 minutes (8 hours) to see trends. Defaults to 15 minutes.
             # @param [Time] start_date Filter cumulative statistics by a start date. This is
@@ -187,7 +187,7 @@ module Twilio
 
             ##
             # Fetch a WorkspaceStatisticsInstance
-            # @param [String] minutes Filter cumulative statistics by up to ‘x’ minutes in the
+            # @param [String] minutes Filter cumulative statistics by up to 'x' minutes in the
             #   past. This is helpful for statistics for the last 15 minutes, 240 minutes (4
             #   hours), and 480 minutes (8 hours) to see trends. Defaults to 15 minutes.
             # @param [Time] start_date Filter cumulative statistics by a start date. This is

data/lib/twilio-ruby/rest/trunking/v1/trunk.rb

@@ -49,7 +49,12 @@ module Twilio
           #   on, all calls going through this trunk will be secure using SRTP for media and
           #   TLS for signalling. If turned off, then RTP will be used for media. See [Secure
           #   Trunking](https://www.twilio.com/docs/sip-trunking/getting-started#securetrunking) for more information.
-          # @param [Boolean] cnam_lookup_enabled The cnam_lookup_enabled
+          # @param [Boolean] cnam_lookup_enabled The Caller ID Name (CNAM) lookup setting
+          #   for this trunk. If turned on, all inbound calls to this SIP Trunk from the
+          #   United States and Canada will automatically perform a CNAM Lookup and display
+          #   Caller ID data on your phone. See
+          #   [CNAM](https://www.twilio.com/docs/sip-trunking#CNAM) Lookups for more
+          #   information.
           # @return [TrunkInstance] Newly created TrunkInstance
           def create(friendly_name: :unset, domain_name: :unset, disaster_recovery_url: :unset, disaster_recovery_method: :unset, recording: :unset, secure: :unset, cnam_lookup_enabled: :unset)
             data = Twilio::Values.of({
@@ -256,7 +261,12 @@ module Twilio
           #   on, all calls going through this trunk will be secure using SRTP for media and
           #   TLS for signalling. If turned off, then RTP will be used for media. See [Secure
           #   Trunking](https://www.twilio.com/docs/sip-trunking/getting-started#securetrunking) for more information.
-          # @param [Boolean] cnam_lookup_enabled The cnam_lookup_enabled
+          # @param [Boolean] cnam_lookup_enabled The Caller ID Name (CNAM) lookup setting
+          #   for this trunk. If turned on, all inbound calls to this SIP Trunk from the
+          #   United States and Canada will automatically perform a CNAM Lookup and display
+          #   Caller ID data on your phone. See
+          #   [CNAM](https://www.twilio.com/docs/sip-trunking#CNAM) Lookups for more
+          #   information.
           # @return [TrunkInstance] Updated TrunkInstance
           def update(friendly_name: :unset, domain_name: :unset, disaster_recovery_url: :unset, disaster_recovery_method: :unset, recording: :unset, secure: :unset, cnam_lookup_enabled: :unset)
             data = Twilio::Values.of({
@@ -446,7 +456,7 @@ module Twilio
           end
 
           ##
-          # @return [Boolean] The cnam_lookup_enabled
+          # @return [Boolean] The Caller ID Name (CNAM) lookup setting for this trunk.
           def cnam_lookup_enabled
             @properties['cnam_lookup_enabled']
           end
@@ -532,7 +542,12 @@ module Twilio
           #   on, all calls going through this trunk will be secure using SRTP for media and
           #   TLS for signalling. If turned off, then RTP will be used for media. See [Secure
           #   Trunking](https://www.twilio.com/docs/sip-trunking/getting-started#securetrunking) for more information.
-          # @param [Boolean] cnam_lookup_enabled The cnam_lookup_enabled
+          # @param [Boolean] cnam_lookup_enabled The Caller ID Name (CNAM) lookup setting
+          #   for this trunk. If turned on, all inbound calls to this SIP Trunk from the
+          #   United States and Canada will automatically perform a CNAM Lookup and display
+          #   Caller ID data on your phone. See
+          #   [CNAM](https://www.twilio.com/docs/sip-trunking#CNAM) Lookups for more
+          #   information.
           # @return [TrunkInstance] Updated TrunkInstance
           def update(friendly_name: :unset, domain_name: :unset, disaster_recovery_url: :unset, disaster_recovery_method: :unset, recording: :unset, secure: :unset, cnam_lookup_enabled: :unset)
             context.update(

data/lib/twilio-ruby/twiml/twiml.rb

@@ -1,24 +1,24 @@
 require 'nokogiri'
 
-##
-# This code was generated by
-# \ / _    _  _|   _  _
-#  | (_)\/(_)(_|\/| |(/_  v1.0.0
-#       /       /
-# 
-# frozen_string_literal: true
-
 module Twilio
   module TwiML
     class TwiMLError < StandardError; end
 
-    class Comment
-      def initialize(body)
-        @body = body
+    class LeafNode
+      def initialize(content)
+        @content = content
       end
+    end
 
+    class Comment < LeafNode
       def xml(document)
-        Nokogiri::XML::Comment.new(document, @body)
+        Nokogiri::XML::Comment.new(document, @content)
+      end
+    end
+
+    class Text < LeafNode
+      def xml(document)
+        Nokogiri::XML::Text.new(@content, document)
       end
     end
 
@@ -78,7 +78,7 @@ module Twilio
         end
 
         def append(verb)
-          unless verb.is_a?(TwiML) || verb.is_a?(Comment)
+          unless verb.is_a?(TwiML) || verb.is_a?(LeafNode)
               raise TwiMLError, 'Only appending of TwiML is allowed'
           end
 
@@ -90,7 +90,26 @@ module Twilio
           append(Comment.new(body))
         end
 
+        def add_text(content)
+          append(Text.new(content))
+        end
+
+        def add_child(name, value=nil, **keyword_args)
+          node = GenericNode.new(name, value, **keyword_args)
+
+          yield node if block_given?
+          append(node)
+        end
+
       alias to_xml to_s
     end
+
+    class GenericNode < TwiML
+      def initialize(name, value, **keyword_args)
+        super(**keyword_args)
+        @name = name
+        @value = value
+      end
+    end
   end
 end

data/lib/twilio-ruby/version.rb

@@ -1,3 +1,3 @@
 module Twilio
-    VERSION = '5.10.3'
+    VERSION = '5.10.4'
 end

data/spec/integration/api/v2010/account/application_spec.rb

@@ -187,14 +187,11 @@ describe 'Application' do
           ],
           "end": 0,
           "first_page_uri": "/2010-04-01/Accounts/ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Applications.json?PageSize=1&Page=0",
-          "last_page_uri": "/2010-04-01/Accounts/ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Applications.json?PageSize=1&Page=35",
           "next_page_uri": null,
-          "num_pages": 36,
-          "page": 0,
-          "page_size": 1,
           "previous_page_uri": null,
+          "page_size": 1,
+          "page": 0,
           "start": 0,
-          "total": 36,
           "uri": "/2010-04-01/Accounts/ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Applications.json?PageSize=1&Page=0"
       }
       ]
@@ -214,14 +211,11 @@ describe 'Application' do
           "applications": [],
           "end": 0,
           "first_page_uri": "/2010-04-01/Accounts/ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Applications.json?PageSize=1&Page=0",
-          "last_page_uri": "/2010-04-01/Accounts/ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Applications.json?PageSize=1&Page=35",
-          "next_page_uri": null,
-          "num_pages": 36,
-          "page": 0,
-          "page_size": 1,
           "previous_page_uri": null,
+          "page_size": 1,
           "start": 0,
-          "total": 36,
+          "next_page_uri": null,
+          "page": 0,
           "uri": "/2010-04-01/Accounts/ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Applications.json?PageSize=1&Page=0"
       }
       ]

data/spec/rest/client_spec.rb

@@ -47,3 +47,15 @@ describe Twilio::REST::TrunkingClient do
     expect { Twilio::REST::TrunkingClient.new }.to raise_error(Twilio::REST::ObsoleteError)
   end
 end
+
+describe Twilio::REST::Client do
+  it 'successfully validates the working SSL certificate' do
+    @holodeck.mock Twilio::Response.new(200, '')
+    expect { @client.validate_ssl_certificate }.not_to raise_error
+  end
+
+  it 'fails to validate broken SSL certificates' do
+    @holodeck.mock Twilio::Response.new(504, '')
+    expect { @client.validate_ssl_certificate }.to raise_error(Twilio::REST::RestError)
+  end
+end

data/spec/twiml/messaging_response_spec.rb

@@ -26,6 +26,32 @@ describe Twilio::TwiML::MessagingResponse do
       expect(twiml.to_xml).to match(/<!--This is awesome-->/)
     end
 
+    it 'should allow text nodes' do
+      expected_doc = parse <<-XML
+        <Response>Look no tags</Response>
+      XML
+      twiml = Twilio::TwiML::MessagingResponse.new
+      twiml.add_text 'Look no tags'
+      expect(parse(twiml)).to be_equivalent_to(expected_doc).respecting_element_order
+    end
+
+    it 'should allow generic child nodes' do
+      expected_doc = parse <<-XML
+        <Response>
+          <message tag="global">
+            <bold>Hello</bold>
+          </alexa>
+        </Response>
+      XML
+
+      twiml = Twilio::TwiML::MessagingResponse.new
+      twiml.add_child('message', tag: 'global') do |custom|
+        custom.add_child('bold', 'Hello')
+      end
+
+      expect(parse(twiml)).to be_equivalent_to(expected_doc).respecting_element_order
+    end
+
     it 'should allow populated response' do
       expected_doc = parse <<-XML
         <Response>

data/spec/twiml/voice_response_spec.rb

@@ -36,6 +36,31 @@ describe Twilio::TwiML::VoiceResponse do
       expect(twiml.to_xml).to match(/<!--This is awesome-->/)
     end
 
+    it 'should allow text nodes' do
+      expected_doc = parse <<-XML
+        <Response>Look no tags</Response>
+      XML
+      twiml = Twilio::TwiML::VoiceResponse.new
+      twiml.add_text 'Look no tags'
+      expect(parse(twiml)).to be_equivalent_to(expected_doc).respecting_element_order
+    end
+
+    it 'should allow generic child nodes' do
+      expected_doc = parse <<-XML
+        <Response>
+          <alexa omnipresent="true">
+            <purchase>Kindle</purchase>
+          </alexa>
+        </Response>
+      XML
+
+      twiml = Twilio::TwiML::VoiceResponse.new
+      twiml.add_child('alexa', omnipresent: 'true') do |alexa|
+        alexa.add_child('purchase', 'Kindle')
+      end
+
+      expect(parse(twiml)).to be_equivalent_to(expected_doc).respecting_element_order
+    end
     it 'should allow populated response' do
       expected_doc = parse <<-XML
         <Response>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: twilio-ruby
 version: !ruby/object:Gem::Version
-  version: 5.10.3
+  version: 5.10.4
 platform: ruby
 authors:
 - Twilio API Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-05 00:00:00.000000000 Z
+date: 2018-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jwt
@@ -752,7 +752,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: The official library for communicating with the Twilio REST API, building