twilio-ruby 5.1.2 → 5.2.0

data/lib/twilio-ruby/rest/taskrouter/v1/workspace/workflow.rb

@@ -467,6 +467,13 @@ module Twilio
               values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
               "<Twilio.Taskrouter.V1.WorkflowInstance #{values}>"
             end
+
+            ##
+            # Provide a detailed, user friendly representation
+            def inspect
+              values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+              "<Twilio.Taskrouter.V1.WorkflowInstance #{values}>"
+            end
           end
         end
       end

data/lib/twilio-ruby/rest/taskrouter/v1/workspace/workflow/workflow_statistics.rb

@@ -221,6 +221,13 @@ module Twilio
                 values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
                 "<Twilio.Taskrouter.V1.WorkflowStatisticsInstance #{values}>"
               end
+
+              ##
+              # Provide a detailed, user friendly representation
+              def inspect
+                values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+                "<Twilio.Taskrouter.V1.WorkflowStatisticsInstance #{values}>"
+              end
             end
           end
         end

data/lib/twilio-ruby/rest/taskrouter/v1/workspace/workspace_statistics.rb

@@ -204,6 +204,13 @@ module Twilio
               values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
               "<Twilio.Taskrouter.V1.WorkspaceStatisticsInstance #{values}>"
             end
+
+            ##
+            # Provide a detailed, user friendly representation
+            def inspect
+              values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+              "<Twilio.Taskrouter.V1.WorkspaceStatisticsInstance #{values}>"
+            end
           end
         end
       end

data/lib/twilio-ruby/rest/trunking/v1/trunk.rb

@@ -570,6 +570,13 @@ module Twilio
             values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
             "<Twilio.Trunking.V1.TrunkInstance #{values}>"
           end
+
+          ##
+          # Provide a detailed, user friendly representation
+          def inspect
+            values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+            "<Twilio.Trunking.V1.TrunkInstance #{values}>"
+          end
         end
       end
     end

data/lib/twilio-ruby/rest/trunking/v1/trunk/credential_list.rb

@@ -337,6 +337,13 @@ module Twilio
               values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
               "<Twilio.Trunking.V1.CredentialListInstance #{values}>"
             end
+
+            ##
+            # Provide a detailed, user friendly representation
+            def inspect
+              values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+              "<Twilio.Trunking.V1.CredentialListInstance #{values}>"
+            end
           end
         end
       end

data/lib/twilio-ruby/rest/trunking/v1/trunk/ip_access_control_list.rb

@@ -337,6 +337,13 @@ module Twilio
               values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
               "<Twilio.Trunking.V1.IpAccessControlListInstance #{values}>"
             end
+
+            ##
+            # Provide a detailed, user friendly representation
+            def inspect
+              values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+              "<Twilio.Trunking.V1.IpAccessControlListInstance #{values}>"
+            end
           end
         end
       end

data/lib/twilio-ruby/rest/trunking/v1/trunk/origination_url.rb

@@ -422,6 +422,13 @@ module Twilio
               values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
               "<Twilio.Trunking.V1.OriginationUrlInstance #{values}>"
             end
+
+            ##
+            # Provide a detailed, user friendly representation
+            def inspect
+              values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+              "<Twilio.Trunking.V1.OriginationUrlInstance #{values}>"
+            end
           end
         end
       end

data/lib/twilio-ruby/rest/trunking/v1/trunk/phone_number.rb

@@ -470,6 +470,13 @@ module Twilio
               values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
               "<Twilio.Trunking.V1.PhoneNumberInstance #{values}>"
             end
+
+            ##
+            # Provide a detailed, user friendly representation
+            def inspect
+              values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+              "<Twilio.Trunking.V1.PhoneNumberInstance #{values}>"
+            end
           end
         end
       end

data/lib/twilio-ruby/rest/video/v1/recording.rb

@@ -375,6 +375,13 @@ module Twilio
             values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
             "<Twilio.Video.V1.RecordingInstance #{values}>"
           end
+
+          ##
+          # Provide a detailed, user friendly representation
+          def inspect
+            values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+            "<Twilio.Video.V1.RecordingInstance #{values}>"
+          end
         end
       end
     end

data/lib/twilio-ruby/rest/video/v1/room.rb

@@ -33,8 +33,9 @@ module Twilio
           # @param [Boolean] record_participants_on_connect The
           #   record_participants_on_connect
           # @param [room.VideoCodec] video_codecs The video_codecs
+          # @param [String] media_region The media_region
           # @return [RoomInstance] Newly created RoomInstance
-          def create(enable_turn: :unset, type: :unset, unique_name: :unset, status_callback: :unset, status_callback_method: :unset, max_participants: :unset, record_participants_on_connect: :unset, video_codecs: :unset)
+          def create(enable_turn: :unset, type: :unset, unique_name: :unset, status_callback: :unset, status_callback_method: :unset, max_participants: :unset, record_participants_on_connect: :unset, video_codecs: :unset, media_region: :unset)
             data = Twilio::Values.of({
                 'EnableTurn' => enable_turn,
                 'Type' => type,
@@ -44,6 +45,7 @@ module Twilio
                 'MaxParticipants' => max_participants,
                 'RecordParticipantsOnConnect' => record_participants_on_connect,
                 'VideoCodecs' => video_codecs,
+                'MediaRegion' => media_region,
             })
 
             payload = @version.create(
@@ -480,6 +482,13 @@ module Twilio
             values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
             "<Twilio.Video.V1.RoomInstance #{values}>"
           end
+
+          ##
+          # Provide a detailed, user friendly representation
+          def inspect
+            values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+            "<Twilio.Video.V1.RoomInstance #{values}>"
+          end
         end
       end
     end

data/lib/twilio-ruby/rest/video/v1/room/recording.rb

@@ -373,6 +373,13 @@ module Twilio
               values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
               "<Twilio.Video.V1.RoomRecordingInstance #{values}>"
             end
+
+            ##
+            # Provide a detailed, user friendly representation
+            def inspect
+              values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+              "<Twilio.Video.V1.RoomRecordingInstance #{values}>"
+            end
           end
         end
       end

data/lib/twilio-ruby/rest/wireless/v1/command.rb

@@ -368,6 +368,13 @@ module Twilio
             values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
             "<Twilio.Wireless.V1.CommandInstance #{values}>"
           end
+
+          ##
+          # Provide a detailed, user friendly representation
+          def inspect
+            values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+            "<Twilio.Wireless.V1.CommandInstance #{values}>"
+          end
         end
       end
     end

data/lib/twilio-ruby/rest/wireless/v1/rate_plan.rb

@@ -453,6 +453,13 @@ module Twilio
             values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
             "<Twilio.Wireless.V1.RatePlanInstance #{values}>"
           end
+
+          ##
+          # Provide a detailed, user friendly representation
+          def inspect
+            values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+            "<Twilio.Wireless.V1.RatePlanInstance #{values}>"
+          end
         end
       end
     end

data/lib/twilio-ruby/rest/wireless/v1/sim.rb

@@ -549,6 +549,13 @@ module Twilio
             values = @params.map{|k, v| "#{k}: #{v}"}.join(" ")
             "<Twilio.Wireless.V1.SimInstance #{values}>"
           end
+
+          ##
+          # Provide a detailed, user friendly representation
+          def inspect
+            values = @properties.map{|k, v| "#{k}: #{v}"}.join(" ")
+            "<Twilio.Wireless.V1.SimInstance #{values}>"
+          end
         end
       end
     end

data/lib/twilio-ruby/rest/wireless/v1/sim/usage_record.rb

@@ -233,6 +233,12 @@ module Twilio
             def to_s
               "<Twilio.Wireless.V1.UsageRecordInstance>"
             end
+
+            ##
+            # Provide a detailed, user friendly representation
+            def inspect
+              "<Twilio.Wireless.V1.UsageRecordInstance>"
+            end
           end
         end
       end

data/lib/twilio-ruby/version.rb

@@ -1,3 +1,3 @@
 module Twilio
-    VERSION = '5.1.2'
+    VERSION = '5.2.0'
 end

data/spec/framework/request_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Twilio::Request do
+  before do
+    @request = Twilio::Request.new('host',
+                                   'port',
+                                   'POST',
+                                   'url',
+                                   { 'param-key' => 'param-value', 'param-keytwo' => 'param-valuetwo' },
+                                   { 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
+                                   { 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
+                                   ['a', 'b'],
+                                   'timeout')
+  end
+
+  it 'should initialize readers correctly' do
+    expect(@request.host).to eq('host')
+    expect(@request.port).to eq('port')
+    expect(@request.method).to eq('POST')
+    expect(@request.url).to eq('url')
+    expect(@request.params).to eq('param-key' => 'param-value', 'param-keytwo' => 'param-valuetwo')
+    expect(@request.data).to eq('data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo')
+    expect(@request.headers).to eq('header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo')
+    expect(@request.auth).to eq(['a', 'b'])
+    expect(@request.timeout).to eq('timeout')
+  end
+
+  it 'should be represented correctly' do
+    expected_string = %((a,b) POST url?param-key=param-value&param-keytwo=param-valuetwo) +
+                      %(\n-d "data-key"="data-value") +
+                      %(\n-d "data-keytwo"="data-valuetwo") +
+                      %(\n-H "header-key": "header-value") +
+                      %(\n-H "header-keytwo": "header-valuetwo")
+    expect(@request.to_s).to eq(expected_string)
+  end
+end

data/spec/http/http_client_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+require 'rack/mock'
+
+describe Twilio::HTTP::Client do
+  before do
+    @client = Twilio::HTTP::Client.new
+  end
+
+  it 'should contain a last response' do
+    expect(Faraday).to receive(:new).and_return(Faraday::Connection.new)
+    allow_any_instance_of(Faraday::Connection).to receive(:send).and_return(double('response', status: 301, body: {}))
+
+    @client.request('host', 'port', 'GET', 'url', nil, nil, {}, ['a', 'b'])
+
+    expect(@client.last_response).to_not be_nil
+    expect(@client.last_response.is_a?(Twilio::Response)).to be(true)
+    expect(@client.last_response.status_code).to eq(301)
+  end
+
+  it 'should contain a last request' do
+    expect(Faraday).to receive(:new).and_return(Faraday::Connection.new)
+    allow_any_instance_of(Faraday::Connection).to receive(:send).and_return(double('response', status: 301, body: {}))
+
+    @client.request('host',
+                    'port',
+                    'GET',
+                    'url',
+                    { 'param-key' => 'param-value' },
+                    { 'data-key' => 'data-value' },
+                    { 'header-key' => 'header-value' },
+                    ['a', 'b'],
+                    'timeout')
+
+    expect(@client.last_request).to_not be_nil
+    expect(@client.last_request.is_a?(Twilio::Request)).to be(true)
+    expect(@client.last_request.host).to eq('host')
+    expect(@client.last_request.port).to eq('port')
+    expect(@client.last_request.method).to eq('GET')
+    expect(@client.last_request.url).to eq('url')
+    expect(@client.last_request.params).to eq('param-key' => 'param-value')
+    expect(@client.last_request.data).to eq('data-key' => 'data-value')
+    expect(@client.last_request.headers).to eq('header-key' => 'header-value')
+    expect(@client.last_request.auth).to eq(['a', 'b'])
+    expect(@client.last_request.timeout).to eq('timeout')
+  end
+
+  it 'should contain a last response for 5XX status classes' do
+    expect(Faraday).to receive(:new).and_return(Faraday::Connection.new)
+    allow_any_instance_of(Faraday::Connection).to receive(:send).and_return(double('response', status: 500, body: {}))
+
+    @client.request('host', 'port', 'GET', 'url', nil, nil, {}, ['a', 'b'])
+    expect(@client.last_response).to_not be_nil
+    expect(@client.last_request.host).to eq('host')
+    expect(@client.last_request.port).to eq('port')
+    expect(@client.last_request.method).to eq('GET')
+    expect(@client.last_request.url).to eq('url')
+    expect(@client.last_request.params).to be_nil
+    expect(@client.last_request.data).to be_nil
+    expect(@client.last_request.headers).to eq({})
+    expect(@client.last_request.auth).to eq(['a', 'b'])
+    expect(@client.last_request.timeout).to be_nil
+    expect(@client.last_response.is_a?(Twilio::Response)).to be(true)
+    expect(@client.last_response.status_code).to eq(500)
+  end
+
+  it 'should contain a last_response but no response on a connection error' do
+    expect(Faraday).to receive(:new).and_return(Faraday::Connection.new)
+    allow_any_instance_of(Faraday::Connection).to receive(:send).and_raise(Faraday::ConnectionFailed.new('BOOM'))
+
+    expect { @client.request('host', 'port', 'GET', 'url', nil, nil, {}, ['a', 'b']) }.to raise_exception(Faraday::ConnectionFailed)
+    expect(@client.last_response).to be_nil
+    expect(@client.last_request).to_not be_nil
+    expect(@client.last_request.host).to eq('host')
+    expect(@client.last_request.port).to eq('port')
+    expect(@client.last_request.method).to eq('GET')
+    expect(@client.last_request.url).to eq('url')
+    expect(@client.last_request.params).to be_nil
+    expect(@client.last_request.data).to be_nil
+    expect(@client.last_request.headers).to eq({})
+    expect(@client.last_request.auth).to eq(['a', 'b'])
+    expect(@client.last_request.timeout).to be_nil
+  end
+
+  describe 'last_response' do
+    let(:last_response) { Twilio::Response.new(200, 'body') }
+  end
+  it 'previous last_response should be cleared' do
+    expect(Faraday).to receive(:new).and_return(Faraday::Connection.new)
+    allow_any_instance_of(Faraday::Connection).to receive(:send).and_raise(Faraday::ConnectionFailed.new('BOOM'))
+    expect { @client.request('host', 'port', 'GET', 'url', nil, nil, {}, ['a', 'b']) }.to raise_exception(Faraday::ConnectionFailed)
+    expect(@client.last_response).to be_nil
+  end
+end

data/spec/integration/accounts/v1/credential/public_key_spec.rb

@@ -8,7 +8,7 @@ require 'spec_helper.rb'
 
 describe 'PublicKey' do
   it "can read" do
-    @holodeck.mock(Twilio::TwilioResponse.new(500, ''))
+    @holodeck.mock(Twilio::Response.new(500, ''))
 
     expect {
       @client.accounts.v1.credentials \
@@ -24,7 +24,7 @@ describe 'PublicKey' do
   end
 
   it "receives read_empty responses" do
-    @holodeck.mock(Twilio::TwilioResponse.new(
+    @holodeck.mock(Twilio::Response.new(
         200,
       %q[
       {
@@ -49,7 +49,7 @@ describe 'PublicKey' do
   end
 
   it "receives read_full responses" do
-    @holodeck.mock(Twilio::TwilioResponse.new(
+    @holodeck.mock(Twilio::Response.new(
         200,
       %q[
       {
@@ -83,7 +83,7 @@ describe 'PublicKey' do
   end
 
   it "can create" do
-    @holodeck.mock(Twilio::TwilioResponse.new(500, ''))
+    @holodeck.mock(Twilio::Response.new(500, ''))
 
     expect {
       @client.accounts.v1.credentials \
@@ -102,7 +102,7 @@ describe 'PublicKey' do
   end
 
   it "receives create responses" do
-    @holodeck.mock(Twilio::TwilioResponse.new(
+    @holodeck.mock(Twilio::Response.new(
         201,
       %q[
       {
@@ -123,7 +123,7 @@ describe 'PublicKey' do
   end
 
   it "can fetch" do
-    @holodeck.mock(Twilio::TwilioResponse.new(500, ''))
+    @holodeck.mock(Twilio::Response.new(500, ''))
 
     expect {
       @client.accounts.v1.credentials \
@@ -139,7 +139,7 @@ describe 'PublicKey' do
   end
 
   it "receives fetch responses" do
-    @holodeck.mock(Twilio::TwilioResponse.new(
+    @holodeck.mock(Twilio::Response.new(
         200,
       %q[
       {
@@ -160,7 +160,7 @@ describe 'PublicKey' do
   end
 
   it "can update" do
-    @holodeck.mock(Twilio::TwilioResponse.new(500, ''))
+    @holodeck.mock(Twilio::Response.new(500, ''))
 
     expect {
       @client.accounts.v1.credentials \
@@ -176,7 +176,7 @@ describe 'PublicKey' do
   end
 
   it "receives update responses" do
-    @holodeck.mock(Twilio::TwilioResponse.new(
+    @holodeck.mock(Twilio::Response.new(
         200,
       %q[
       {
@@ -197,7 +197,7 @@ describe 'PublicKey' do
   end
 
   it "can delete" do
-    @holodeck.mock(Twilio::TwilioResponse.new(500, ''))
+    @holodeck.mock(Twilio::Response.new(500, ''))
 
     expect {
       @client.accounts.v1.credentials \
@@ -213,7 +213,7 @@ describe 'PublicKey' do
   end
 
   it "receives delete responses" do
-    @holodeck.mock(Twilio::TwilioResponse.new(
+    @holodeck.mock(Twilio::Response.new(
         204,
       nil,
     ))