twilio-ruby 3.12.3 → 3.13.0

data/lib/twilio-ruby/rest/outgoing_caller_ids.rb

@@ -2,7 +2,7 @@ module Twilio
   module REST
     class OutgoingCallerIds < ListResource
       def add(phone_number)
-        create :phone_number => phone_number
+        create phone_number: phone_number
       end
       alias :verify :add
 

data/lib/twilio-ruby/rest/queues/members.rb

@@ -22,7 +22,7 @@ module Twilio
 
     class Member < InstanceResource
       def dequeue(url, method='POST')
-        update :url => url, :method => method
+        update url: url, method: method
       end
     end
   end

data/lib/twilio-ruby/rest/sip.rb

@@ -3,9 +3,7 @@ module Twilio
     class Sip < InstanceResource
       def initialize(path, client, params={})
         super
-        resource :domains, 
-            :ip_access_control_lists,
-            :credential_lists
+        resource :domains, :ip_access_control_lists, :credential_lists
       end
     end
   end

data/lib/twilio-ruby/rest/utils.rb

@@ -4,7 +4,10 @@ module Twilio
 
       def twilify(something)
         if something.is_a? Hash
-          Hash[*something.to_a.map! {|a| [twilify(a[0]).to_sym, a[1]]}.flatten(1)]
+          something = something.to_a
+          something = something.map { |a| [twilify(a[0]).to_sym, a[1]] }
+          something = something.flatten(1)
+          Hash[*something]
         else
           something.to_s.split('_').map! do |s|
             [s[0,1].capitalize, s[1..-1]].join
@@ -14,9 +17,14 @@ module Twilio
 
       def detwilify(something)
         if something.is_a? Hash
-          Hash[*something.to_a.map! {|pair| [detwilify(pair[0]).to_sym, pair[1]]}.flatten]
+          something = *something.to_a
+          something.map! { |pair| [detwilify(pair[0]).to_sym, pair[1]] }
+          something = something.flatten
+          Hash[something]
         else
-          something.to_s.gsub(/[A-Z][a-z]*/) {|s| "_#{s.downcase}"}.gsub(/^_/, '')
+          something = something.to_s
+          something = something.gsub(/[A-Z][a-z]*/) { |s| "_#{s.downcase}" }
+          something.gsub(/^_/, '')
         end
       end
 

data/lib/twilio-ruby/util/capability.rb

@@ -15,20 +15,20 @@ module Twilio
 
       def allow_client_incoming(client_name)
         @client_name = client_name # stash for use in outgoing
-        scope_params = {'clientName' => client_name}
+        scope_params = { 'clientName' => client_name }
         @capabilities << scope_uri_for('client', 'incoming', scope_params)
       end
 
       def allow_client_outgoing(app_sid, params = {})
         @allow_client_outgoing = true
-        @outgoing_scope_params = {'appSid' => app_sid}
+        @outgoing_scope_params = { 'appSid' => app_sid }
         unless params.empty?
           @outgoing_scope_params['appParams'] = url_encode params
         end
       end
 
       def allow_event_stream(filters = {})
-        scope_params = {'path' => '/2010-04-01/Events'}
+        scope_params = { 'path' => '/2010-04-01/Events' }
         scope_params['params'] = filters unless filters.empty?
         @capabilities << scope_uri_for('stream', 'subscribe', scope_params)
       end
@@ -45,7 +45,7 @@ module Twilio
         # build the outgoing scope lazily so that we can use @client_name
         if @allow_client_outgoing
           params = @outgoing_scope_params
-          params.merge!({'clientName' => @client_name}) if @client_name
+          params.merge!('clientName' => @client_name) if @client_name
           capabilities << scope_uri_for('client', 'outgoing', params)
         end
 

data/lib/twilio-ruby/version.rb

@@ -1,3 +1,3 @@
 module Twilio
-  VERSION = '3.12.3'
+  VERSION = '3.13.0'
 end

data/spec/rack/twilio_webhook_authentication_spec.rb

@@ -22,7 +22,9 @@ describe Rack::TwilioWebhookAuthentication do
 
   describe 'calling against one path' do
     before do
-      @middleware = Rack::TwilioWebhookAuthentication.new(@app, 'ABC', /\/voice/)
+      @middleware = Rack::TwilioWebhookAuthentication.new(
+        @app, 'ABC', /\/voice/
+      )
     end
 
     it 'should not intercept when the path doesn\'t match' do
@@ -33,14 +35,18 @@ describe Rack::TwilioWebhookAuthentication do
     end
 
     it 'should allow a request through if it validates' do
-      expect_any_instance_of(Twilio::Util::RequestValidator).to receive(:validate).and_return(true)
+      expect_any_instance_of(Twilio::Util::RequestValidator).to(
+        receive(:validate).and_return(true)
+      )
       request = Rack::MockRequest.env_for('/voice')
       status, headers, body = @middleware.call(request)
       expect(status).to be(200)
     end
 
     it 'should short circuit a request to 403 if it does not validate' do
-      expect_any_instance_of(Twilio::Util::RequestValidator).to receive(:validate).and_return(false)
+      expect_any_instance_of(Twilio::Util::RequestValidator).to(
+        receive(:validate).and_return(false)
+      )
       request = Rack::MockRequest.env_for('/voice')
       status, headers, body = @middleware.call(request)
       expect(status).to be(403)
@@ -49,7 +55,9 @@ describe Rack::TwilioWebhookAuthentication do
 
   describe 'calling against many paths' do
     before do
-      @middleware = Rack::TwilioWebhookAuthentication.new(@app, 'ABC', /\/voice/, /\/sms/)
+      @middleware = Rack::TwilioWebhookAuthentication.new(
+        @app, 'ABC', /\/voice/, /\/sms/
+      )
     end
 
     it 'should not intercept when the path doesn\'t match' do
@@ -60,14 +68,18 @@ describe Rack::TwilioWebhookAuthentication do
     end
 
     it 'shold allow a request through if it validates' do
-      expect_any_instance_of(Twilio::Util::RequestValidator).to receive(:validate).and_return(true)
+      expect_any_instance_of(Twilio::Util::RequestValidator).to(
+        receive(:validate).and_return(true)
+      )
       request = Rack::MockRequest.env_for('/sms')
       status, headers, body = @middleware.call(request)
       expect(status).to be(200)
     end
 
     it 'should short circuit a request to 403 if it does not validate' do
-      expect_any_instance_of(Twilio::Util::RequestValidator).to receive(:validate).and_return(false)
+      expect_any_instance_of(Twilio::Util::RequestValidator).to(
+        receive(:validate).and_return(false)
+      )
       request = Rack::MockRequest.env_for('/sms')
       status, headers, body = @middleware.call(request)
       expect(status).to be(403)

data/spec/rest/account_spec.rb

@@ -8,17 +8,23 @@ describe Twilio::REST::Account do
 
   it 'sets up incoming phone numbers resources object' do
     expect(@account).to respond_to(:incoming_phone_numbers)
-    expect(@account.incoming_phone_numbers.instance_variable_get('@path')).to eq('someUri/IncomingPhoneNumbers')
+    expect(@account.incoming_phone_numbers.instance_variable_get('@path')).to(
+      eq('someUri/IncomingPhoneNumbers')
+    )
   end
 
   it 'sets up an available phone numbers resources object' do
     expect(@account).to respond_to(:available_phone_numbers)
-    expect(@account.available_phone_numbers.instance_variable_get('@path')).to eq('someUri/AvailablePhoneNumbers')
+    expect(@account.available_phone_numbers.instance_variable_get('@path')).to(
+      eq('someUri/AvailablePhoneNumbers')
+    )
   end
 
   it 'sets up an outgoing caller ids resources object' do
     expect(@account).to respond_to(:outgoing_caller_ids)
-    expect(@account.outgoing_caller_ids.instance_variable_get('@path')).to eq('someUri/OutgoingCallerIds')
+    expect(@account.outgoing_caller_ids.instance_variable_get('@path')).to eq(
+      'someUri/OutgoingCallerIds'
+    )
   end
 
   it 'sets up a calls resources object' do
@@ -28,12 +34,16 @@ describe Twilio::REST::Account do
 
   it 'sets up a conferences resources object' do
     expect(@account).to respond_to(:conferences)
-    expect(@account.conferences.instance_variable_get('@path')).to eq('someUri/Conferences')
+    expect(@account.conferences.instance_variable_get('@path')).to eq(
+      'someUri/Conferences'
+    )
   end
 
   it 'sets up a queues resources object' do
     expect(@account).to respond_to(:queues)
-    expect(@account.queues.instance_variable_get('@path')).to eq('someUri/Queues')
+    expect(@account.queues.instance_variable_get('@path')).to eq(
+      'someUri/Queues'
+    )
   end
 
   it 'sets up a sms resource object' do
@@ -43,16 +53,22 @@ describe Twilio::REST::Account do
 
   it 'sets up a recordings resources object' do
     expect(@account).to respond_to(:recordings)
-    expect(@account.recordings.instance_variable_get('@path')).to eq('someUri/Recordings')
+    expect(@account.recordings.instance_variable_get('@path')).to eq(
+      'someUri/Recordings'
+    )
   end
 
   it 'sets up a transcriptions resources object' do
     expect(@account).to respond_to(:transcriptions)
-    expect(@account.transcriptions.instance_variable_get('@path')).to eq('someUri/Transcriptions')
+    expect(@account.transcriptions.instance_variable_get('@path')).to eq(
+      'someUri/Transcriptions'
+    )
   end
 
   it 'sets up a notifications resources object' do
     expect(@account).to respond_to(:notifications)
-    expect(@account.notifications.instance_variable_get('@path')).to eq('someUri/Notifications')
+    expect(@account.notifications.instance_variable_get('@path')).to eq(
+      'someUri/Notifications'
+    )
   end
 end

data/spec/rest/call_spec.rb

@@ -8,11 +8,15 @@ describe Twilio::REST::Call do
 
   it 'sets up a recordings resources object' do
     expect(@call).to respond_to(:recordings)
-    expect(@call.recordings.instance_variable_get('@path')).to eq('someUri/Recordings')
+    expect(@call.recordings.instance_variable_get('@path')).to eq(
+      'someUri/Recordings'
+    )
   end
 
   it 'sets up a notifications resources object' do
     expect(@call).to respond_to(:notifications)
-    expect(@call.notifications.instance_variable_get('@path')).to eq('someUri/Notifications')
+    expect(@call.notifications.instance_variable_get('@path')).to eq(
+      'someUri/Notifications'
+    )
   end
 end

data/spec/rest/client_spec.rb

@@ -61,14 +61,14 @@ describe Twilio::REST::Client do
   end
 
   it 'should not raise an error if the response body is empty' do
-    FakeWeb.register_uri(:any, %r/api\.twilio\.com/, :body => '')
+    FakeWeb.register_uri(:any, %r/api\.twilio\.com/, body: '')
     twilio = Twilio::REST::Client.new('someSid', 'someToken')
     Twilio::REST::IncomingPhoneNumber.new('/phone_number', twilio).delete
   end
 
   it 'should not raise an error if the response body is nil' do
-    response = double(:response, :body => nil)
-    connection = double(:connection, :request => response)
+    response = double(:response, body: nil)
+    connection = double(:connection, request: response)
     twilio = Twilio::REST::Client.new('someSid', 'someToken')
     twilio.instance_variable_set(:@connection, connection)
     Twilio::REST::IncomingPhoneNumber.new('/phone_number', twilio).delete
@@ -89,22 +89,28 @@ describe Twilio::REST::Client do
   end
 
   it 'should set up the requested ssl verification ca_file if provided' do
-    twilio = Twilio::REST::Client.new('someSid', 'someToken', :ssl_ca_file => '/path/to/ca/file')
+    twilio = Twilio::REST::Client.new(
+      'someSid', 'someToken', ssl_ca_file: '/path/to/ca/file'
+    )
     connection = twilio.instance_variable_get('@connection')
     expect(connection.ca_file).to eq('/path/to/ca/file')
   end
 
-  it 'should set up the proper http ssl connection when a different domain is given' do
-    twilio = Twilio::REST::Client.new('someSid', 'someToken', :host => 'api.faketwilio.com')
+  it 'should set up the proper http ssl connection when a different ' \
+     'domain is given' do
+    twilio = Twilio::REST::Client.new(
+      'someSid', 'someToken', host: 'api.faketwilio.com'
+    )
     connection = twilio.instance_variable_get('@connection')
     expect(connection.address).to eq('api.faketwilio.com')
     expect(connection.port).to eq(443)
     expect(connection.use_ssl?).to eq(true)
   end
 
-  it 'should adjust the open and read timeouts on the underlying Net::HTTP object when asked' do
+  it 'should adjust the open and read timeouts on the underlying Net::HTTP ' \
+     'object when asked' do
     timeout = rand(30)
-    twilio = Twilio::REST::Client.new('someSid', 'someToken', :timeout => timeout)
+    twilio = Twilio::REST::Client.new('someSid', 'someToken', timeout: timeout)
     connection = twilio.instance_variable_get('@connection')
     expect(connection.port).to eq(443)
     expect(connection.use_ssl?).to eq(true)
@@ -112,8 +118,14 @@ describe Twilio::REST::Client do
     expect(connection.read_timeout).to eq(timeout)
   end
 
-  it 'should set up the proper http ssl connection when a proxy_host is given' do
-    twilio = Twilio::REST::Client.new('someSid', 'someToken', :host => 'api.faketwilio.com', :proxy_addr => 'localhost')
+  it 'should set up the proper http ssl connection when a proxy_host is ' \
+     'given' do
+    twilio = Twilio::REST::Client.new(
+      'someSid',
+      'someToken',
+      host: 'api.faketwilio.com',
+      proxy_addr: 'localhost'
+    )
     connection = twilio.instance_variable_get('@connection')
     expect(connection.proxy?).to eq(true)
     expect(connection.proxy_address).to eq('localhost')
@@ -123,8 +135,15 @@ describe Twilio::REST::Client do
     expect(connection.use_ssl?).to eq(true)
   end
 
-  it 'should set up the proper http ssl connection when a proxy_host and proxy_port are given' do
-    twilio = Twilio::REST::Client.new('someSid', 'someToken', :host => 'api.faketwilio.com', :proxy_addr => 'localhost', :proxy_port => 13128)
+  it 'should set up the proper http ssl connection when a proxy_host and ' \
+     'proxy_port are given' do
+    twilio = Twilio::REST::Client.new(
+      'someSid',
+      'someToken',
+      host: 'api.faketwilio.com',
+      proxy_addr: 'localhost',
+      proxy_port: 13128
+    )
     connection = twilio.instance_variable_get('@connection')
     expect(connection.proxy?).to eq(true)
     expect(connection.proxy_address).to eq('localhost')
@@ -137,13 +156,17 @@ describe Twilio::REST::Client do
   it 'should set up an accounts resources object' do
     twilio = Twilio::REST::Client.new('someSid', 'someToken')
     expect(twilio).to respond_to(:accounts)
-    expect(twilio.accounts.instance_variable_get('@path')).to eq('/2010-04-01/Accounts')
+    expect(twilio.accounts.instance_variable_get('@path')).to eq(
+      '/2010-04-01/Accounts'
+    )
   end
 
   it 'should set up an account object with the given sid' do
     twilio = Twilio::REST::Client.new('someSid', 'someToken')
     expect(twilio).to respond_to(:account)
-    expect(twilio.account.instance_variable_get('@path')).to eq('/2010-04-01/Accounts/someSid')
+    expect(twilio.account.instance_variable_get('@path')).to eq(
+      '/2010-04-01/Accounts/someSid'
+    )
   end
 
   [

data/spec/rest/conference_spec.rb

@@ -4,6 +4,8 @@ describe Twilio::REST::Conference do
   it 'should set up a participants resources object' do
     conference = Twilio::REST::Conference.new('someUri', 'someClient')
     expect(conference).to respond_to(:participants)
-    expect(conference.participants.instance_variable_get('@path')).to eq('someUri/Participants')
+    expect(conference.participants.instance_variable_get('@path')).to eq(
+      'someUri/Participants'
+    )
   end
 end

data/spec/rest/instance_resource_spec.rb

@@ -8,7 +8,7 @@ describe Twilio::REST::InstanceResource do
   end
 
   it 'should set up object properties if passed' do
-    params = {'SomeKey' => 'someValue'}
+    params = { 'SomeKey' => 'someValue' }
     resource = Twilio::REST::InstanceResource.new('uri', 'client', params)
     expect(resource.some_key).to eq('someValue')
   end

data/spec/rest/numbers_spec.rb

@@ -13,12 +13,16 @@ describe Twilio::REST::Country do
 
   it 'sets up a toll_free resources object' do
     expect(@country).to respond_to(:toll_free)
-    expect(@country.toll_free.instance_variable_get('@path')).to eq('someUri/TollFree')
+    expect(@country.toll_free.instance_variable_get('@path')).to eq(
+      'someUri/TollFree'
+    )
   end
 
   it 'sets up a mobile resources object' do
     expect(@country).to respond_to(:mobile)
-    expect(@country.mobile.instance_variable_get('@path')).to eq('someUri/Mobile')
+    expect(@country.mobile.instance_variable_get('@path')).to eq(
+      'someUri/Mobile'
+    )
   end
 
 end
@@ -26,21 +30,29 @@ end
 describe Twilio::REST::NumberType do
 
   before do
-    @incoming_phone_numbers = Twilio::REST::IncomingPhoneNumbers.new('someUri', 'someClient')
+    @incoming_phone_numbers = Twilio::REST::IncomingPhoneNumbers.new(
+      'someUri', 'someClient'
+    )
   end
 
   it 'sets up a local resources object' do
     expect(@incoming_phone_numbers).to respond_to(:local)
-    expect(@incoming_phone_numbers.local.instance_variable_get('@path')).to eq('someUri/Local')
+    expect(@incoming_phone_numbers.local.instance_variable_get('@path')).to eq(
+      'someUri/Local'
+    )
   end
 
   it 'sets up a toll_free resources object' do
     expect(@incoming_phone_numbers).to respond_to(:toll_free)
-    expect(@incoming_phone_numbers.toll_free.instance_variable_get('@path')).to eq('someUri/TollFree')
+    expect(@incoming_phone_numbers.toll_free.instance_variable_get('@path')).to(
+      eq('someUri/TollFree')
+    )
   end
 
   it 'sets up a mobile resources object' do
     expect(@incoming_phone_numbers).to respond_to(:mobile)
-    expect(@incoming_phone_numbers.mobile.instance_variable_get('@path')).to eq('someUri/Mobile')
+    expect(@incoming_phone_numbers.mobile.instance_variable_get('@path')).to eq(
+      'someUri/Mobile'
+    )
   end
 end

data/spec/rest/queue_spec.rb

@@ -4,6 +4,8 @@ describe Twilio::REST::Queue do
   it 'should set up a members resources object' do
     queue = Twilio::REST::Queue.new('someUri', 'someClient')
     expect(queue).to respond_to(:members)
-    expect(queue.members.instance_variable_get('@path')).to eq('someUri/Members')
+    expect(queue.members.instance_variable_get('@path')).to eq(
+      'someUri/Members'
+    )
   end
 end

data/spec/rest/recording_spec.rb

@@ -4,6 +4,8 @@ describe Twilio::REST::Recording do
   it 'should set up a transcriptions resources object' do
     call = Twilio::REST::Recording.new('someUri', 'someClient')
     expect(call).to respond_to(:transcriptions)
-    expect(call.transcriptions.instance_variable_get('@path')).to eq('someUri/Transcriptions')
+    expect(call.transcriptions.instance_variable_get('@path')).to eq(
+      'someUri/Transcriptions'
+    )
   end
 end