twilio-rails 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da8b95ee1335c01291ebff65ac9a32b77b7fc749057878b849a1638b477e52db
-  data.tar.gz: 5c67a75eb4a2bf6ff43a71d3c6528540219698dea50e68b7d96b3d3f79b13224
+  metadata.gz: e5bf8143247d793c1fde606c166165114365e54f1e5f4f33aa3642ca58563e97
+  data.tar.gz: f6b35b2bce17b4240ea2f63705e095dedea6aacf9d321321719462126419d6c1
 SHA512:
-  metadata.gz: 78aa3a4b1a34ff2d574bac9b5d9ec0f1e10ae298150a2649e147ad98234e9449e371a8329acb9c9b3cbf104208a8c4950c7d70166ae488e5ca1aa0bb3d5d84d9
-  data.tar.gz: 20703a2e24787e490321ae035b09f0f6c15613063839767e531f2e3f2bf48c18e3b3708208c7c81f3517e182ee4b637dab54c5e7b093bb8ff6cbb2b034641c45
+  metadata.gz: 1cafe99962f6610985140f2f8a553bf7521c67cb449be1ead374245f94d66b6bfca04e7200d7c9421f8d0c522eee1d543ffe41983ba80df3e5a41141021df75b
+  data.tar.gz: 345023826a58a7bd9718a5ef1ed5ef06114027f01082a3c5a56b9c50824c4ad028b69f8293794e0d428a1e70c1d062b01367ef48b29aac45f74e8b0135ce35a0

data/README.md

@@ -8,8 +8,18 @@ The `twilio-rails` gem is an opinionated Rails engine and a framework for buildi
 The most powerful ability of this engine is to build phone trees (think of calling customer service and pressing 2 for account information or whatever) using a simple Ruby DSL.
 
 What does this mean in practice? **Call and find out!**
-* In Canada: 📞 **(204) 800-7772**
-* In the US: 📞 **(631) 800-7772**
+
+The [`twilio-rails-example`](https://github.com/kmcphillips/twilio-rails-example) app is running here:
+
+* **🇨🇦 Calling from Canada:** 📞 (204) 800-7772
+* **🇺🇸 Calling from the US:** 📞 (631) 800-7772
+* **Internationally:** [Sorry, not yet supported](https://github.com/kmcphillips/twilio-rails#limitations-and-known-issues)
+
+There is also a more fun but less cleanly organized [`dial-a-haiku`](https://github.com/kmcphillips/dial-a-haiku) running here:
+* **🇨🇦 Calling from Canada:** 📞 (249) 444-2458 / (249)44-HAIKU
+* **🇺🇸 Calling from the US:** 📞 (341) 444-2458 / (341)44-HAIKU
+* **Internationally:** [Sorry, not yet supported](https://github.com/kmcphillips/twilio-rails#limitations-and-known-issues)
+
 
 ## Documentation
 
@@ -103,10 +113,11 @@ Both are explained in detail below.
 
 ### Example app
 
-An example Rails app demonstrating the framework is available at [`twilio-rails-example`](https://github.com/kmcphillips/twilio-rails-example). It can be run locally with some minimal configuration, or can be reached as a working Twilio app by calling:
+An example Rails app demonstrating the framework is available at [`twilio-rails-example`](https://github.com/kmcphillips/twilio-rails-example). The seteps to go from new Rails app to running Twilio application are broken down into well documented commits. It's a great place to learn and experiment. It can be run locally with some minimal configuration, or can be reached as a working Twilio app by calling:
 
-* In Canada: 📞 **(204) 800-7772**
-* In the US: 📞 **(631) 800-7772**
+* **🇨🇦 Calling from Canada:** 📞 (204) 800-7772
+* **🇺🇸 Calling from the US:** 📞 (631) 800-7772
+* **Internationally:** [Sorry, not yet supported](https://github.com/kmcphillips/twilio-rails#limitations-and-known-issues)
 
 
 ## How it works
@@ -274,7 +285,7 @@ prompt :record_your_feedback,
 
 The above `gather:` with `type: :voice` example will finish reading the message and then record the phone caller's speech for 30 seconds or until they press the `#` pound key. The phone tree will then immediately execute the `after:`, while the framework continues to handle the audio recording asynchronously. When Twilio makes it available, the audio file of the recording will be downloaded and stored as an ActiveStorage attachment in a `Recording` model as `response.recording`. If the `transcribe:` option is set to `true`, the voice in the recording will also attempt to be transcribed as text and stored as `response.transcription`. Importantly though, **neither are guaranteed to arrive or will arrive immediately**. In practice they both usually arrive within a few seconds, but can sometimes be blank or missing if the caller is silent or garbled. There is a cost to transcription so it can be disabled, and the `profanity_filter:` defaults to false and will just *** out any profanity in the transcription.
 
-Finally, the `gather:` can also accept `type: :speech` which is a specialzed model designed to identify voice in realtime. It will provide the `response.transcription` field immediately, making it available in the `after:` proc or in the next prompt. But the tradeoffs are that it does not provide a recording, there is a time gap of a few seconds between prompts, and it is more expensive. See the [Twilio documentation for specifics](https://www.twilio.com/docs/voice/twiml/gather#speechmodel). The keys it expects match the documentation, `speech_model:`, `speech_timeout:`, `language:` (defaults to "en-US"), and `encanced:` (defaults to false).
+Finally, the `gather:` can also accept `type: :speech` which is a specialzed model designed to identify voice in realtime. It will provide the `response.transcription` field immediately, making it available in the `after:` proc or in the next prompt. But the tradeoffs are that it does not provide a recording, there is a time gap of a few seconds between prompts, and it is more expensive. See the [Twilio documentation for specifics](https://www.twilio.com/docs/voice/twiml/gather#speechmodel). The keys it expects match the documentation, `speech_model:`, `speech_timeout:`, `language:` (defaults to "en-US"), and `enhanced:` (defaults to false).
 
 ```ruby
 prompt :what_direction_should_we_go,
@@ -308,7 +319,7 @@ prompt :what_direction_should_we_go,
   }
 ```
 
-To inspect the implementation and get further detail, most of the magic happens in [`Twilio::Rails::Phone::Tree`](lib/twilio/rails/phone/tree.rb) and the operations under [`Twilio::Rails::Phone::Twiml`](app/operations/twilio/rails/phone/twiml/) where the DSL is defined and then converted inbot [TwiML](https://www.twilio.com/docs/voice/twiml).
+To inspect the implementation and get further detail, most of the magic happens in [`Twilio::Rails::Phone::Tree`](lib/twilio/rails/phone/tree.rb) and the operations under [`Twilio::Rails::Phone::Twiml`](app/operations/twilio/rails/phone/twiml/) where the DSL is defined and then converted into [TwiML](https://www.twilio.com/docs/voice/twiml).
 
 
 ### Make an outgoing phone call
@@ -326,7 +337,7 @@ Twilio::Phone::StartCallOperation.call(
 
 ### SMS responders
 
-> **Warning**
+> [!IMPORTANT]
 > Due to how Twilio makes API calls into the application for SMS messages, SMS responders require Rails sessions to be enabled and setup in order to handle SMS messages.
 
 Twilio provides a hook for incoming SMS messages and can send SMS messages to any phone number. This gem provides a simple method for handling SMS conversations, though it does not provide a full stateful tree structure.
@@ -365,13 +376,8 @@ phone_caller = Twilio::Rails::FindOrCreatePhoneCallerOperation.call(phone_number
 
 All errors are subclasses of [`Twilio::Rails::Error`](lib/twilio/rails.rb). They are grouped under [`Twilio::Rails::Phone::Error`](lib/twilio/rails/phone.rb) and [`Twilio::Rails::SMS::Error`](lib/twilio/rails/sms.rb), and then further specialized from there.
 
-There is a configuration option to add an exception notifier in some important places in the framework. It will never catch or handle exceptions.
+There are a few places where exceptions are notified from inside the framework using `::Rails.error.report`. They are never rescued or handled. See the [Rails documentation](https://api.rubyonrails.org/classes/ActiveSupport/ErrorReporter.html) for how to use the error reporter.
 
-```ruby
-config.exception_notifier = ->(exception, message, context, exception_binding) {
-  # Send an email or use some kind of service etc.
-}
-```
 
 ### The rest of the documentation
 

data/app/controllers/twilio/rails/phone_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     class PhoneController < ApplicationController
@@ -10,6 +11,9 @@ module Twilio
         respond_to do |format|
           format.xml do
             phone_call = Twilio::Rails::Phone::CreateOperation.call(params: params_hash, tree: tree)
+          rescue
+            render xml: Twilio::Rails::Phone::Twiml::InvalidPhoneNumberOperation.call(tree: tree)
+          else
             render xml: Twilio::Rails::Phone::Twiml::GreetingOperation.call(phone_call_id: phone_call.id, tree: tree)
           end
         end
@@ -39,7 +43,7 @@ module Twilio
           format.xml do
             phone_call = Twilio::Rails::Phone::FindOperation.call(params: params_hash)
             phone_call = Twilio::Rails::Phone::UpdateOperation.call(phone_call_id: phone_call.id, params: params_hash)
-            response = Twilio::Rails::Phone::UpdateResponseOperation.call(phone_call_id: phone_call.id, response_id: params[:response_id].to_i, params: params_hash)
+            Twilio::Rails::Phone::UpdateResponseOperation.call(phone_call_id: phone_call.id, response_id: params[:response_id].to_i, params: params_hash)
             render xml: Twilio::Rails::Phone::Twiml::PromptResponseOperation.call(phone_call_id: phone_call.id, tree: tree, response_id: params[:response_id].to_i, params: params_hash)
           end
         end
@@ -70,7 +74,7 @@ module Twilio
         respond_to do |format|
           format.xml do
             phone_call = Twilio::Rails::Phone::FindOperation.call(params: params_hash)
-            phone_call = Twilio::Rails::Phone::UpdateOperation.call(phone_call_id: phone_call.id, params: params_hash)
+            Twilio::Rails::Phone::UpdateOperation.call(phone_call_id: phone_call.id, params: params_hash)
 
             head :ok
           end

data/app/controllers/twilio/rails/sms_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     class SMSController < ::Twilio::Rails::ApplicationController
@@ -10,7 +11,7 @@ module Twilio
         respond_to do |format|
           format.xml do
             if spam?
-              render xml: Twilio::Rails::SMS::Twiml::ErrorOperation.call()
+              render xml: Twilio::Rails::SMS::Twiml::ErrorOperation.call
             else
               if session[:sms_conversation_id].present?
                 conversation = Twilio::Rails::SMS::FindOperation.call(sms_conversation_id: session[:sms_conversation_id])
@@ -29,10 +30,10 @@ module Twilio
         respond_to do |format|
           format.xml do
             if params[:message_id].present?
-              message = Twilio::Rails::SMS::UpdateMessageOperation.call(message_id: params[:message_id].to_i, params: params_hash)
+              Twilio::Rails::SMS::UpdateMessageOperation.call(message_id: params[:message_id].to_i, params: params_hash)
             else
               message = Twilio::Rails::SMS::FindMessageOperation.call(params: params_hash)
-              message = Twilio::Rails::SMS::UpdateMessageOperation.call(message_id: message.id, params: params_hash)
+              Twilio::Rails::SMS::UpdateMessageOperation.call(message_id: message.id, params: params_hash)
             end
 
             head :ok
@@ -46,14 +47,14 @@ module Twilio
         if params["AccountSid"] != Twilio::Rails.config.account_sid
           respond_to do |format|
             format.xml do
-              render xml: Twilio::Rails::SMS::Twiml::ErrorOperation.call()
+              render xml: Twilio::Rails::SMS::Twiml::ErrorOperation.call
             end
           end
         end
       end
 
       def spam?
-        Twilio::Rails.config.spam_filter && Twilio::Rails.config.spam_filter.call(params)
+        Twilio::Rails.config.spam_filter&.call(params)
       end
 
       def params_hash

data/app/jobs/twilio/rails/phone/attach_recording_job.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone

data/app/jobs/twilio/rails/phone/finished_call_job.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone

data/app/jobs/twilio/rails/phone/unanswered_call_job.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone

data/app/operations/twilio/rails/application_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     class ApplicationOperation < ActiveOperation::Base
@@ -8,7 +9,7 @@ module Twilio
         executable.call
         @operation_runtime_stop = Process.clock_gettime(Process::CLOCK_MONOTONIC)
 
-        ::Twilio::Rails.config.logger.tagged(self.class) { |l| l.info("execution time #{ instance.operation_runtime_seconds } seconds")}
+        ::Twilio::Rails.config.logger.tagged(self.class) { |l| l.info("execution time #{instance.operation_runtime_seconds} seconds") }
       end
 
       protected

data/app/operations/twilio/rails/find_or_create_phone_caller_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     # Finds and returns a {Twilio::Rails::Models::PhoneCaller} by phone number, or creates a new one if it does not
@@ -22,7 +23,7 @@ module Twilio
       private
 
       def valid_phone_number
-        Twilio::Rails::Formatter.coerce_to_valid_phone_number(phone_number)
+        Twilio::Rails::PhoneNumberFormatter.coerce(phone_number)
       end
     end
   end

data/app/operations/twilio/rails/phone/attach_recording_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -12,7 +13,7 @@ module Twilio
 
           if !recording.audio.attached?
             if recording.url.blank?
-              raise Twilio::Rails::Phone::Error, "[AttachRecordingOperation] Has a blank URL and cannot be fetched recording_id=#{ recording.id }"
+              raise Twilio::Rails::Phone::Error, "[AttachRecordingOperation] Has a blank URL and cannot be fetched recording_id=#{recording.id}"
             end
 
             response = Faraday.get(recording.url)
@@ -21,7 +22,7 @@ module Twilio
               recording.audio.attach(io: StringIO.new(response.body), filename: "recording.wav", content_type: "audio/wav")
               recording.save!
             else
-              raise Twilio::Rails::Phone::Error, "[AttachRecordingOperation] Failed to fetch recording recording_id=#{ recording.id } HTTP#{ response.status } from #{ recording.url }"
+              raise Twilio::Rails::Phone::Error, "[AttachRecordingOperation] Failed to fetch recording recording_id=#{recording.id} HTTP#{response.status} from #{recording.url}"
             end
           end
         end

data/app/operations/twilio/rails/phone/base_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone

data/app/operations/twilio/rails/phone/create_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -16,19 +17,19 @@ module Twilio
             from_number: params["Caller"].presence || params["From"].presence,
             from_city: params["CallerCity"].presence || params["FromCity"].presence,
             from_province: params["CallerState"].presence || params["FromState"].presence,
-            from_country: params["CallerCountry"].presence || params["FromCountry"].presence,
+            from_country: params["CallerCountry"].presence || params["FromCountry"].presence
           )
 
           phone_caller = Twilio::Rails::FindOrCreatePhoneCallerOperation.call(phone_number: phone_call.from_number)
 
           if !phone_caller
-            error_message = if !Twilio::Rails::Formatter.valid_north_american_phone_number?(phone_call.from_number)
+            error_message = if !Twilio::Rails::PhoneNumberFormatter.valid?(phone_call.from_number)
               "The phone number is invalid."
             else
               "The phone caller could not be persisted or retrieved."
             end
 
-            raise Twilio::Rails::Phone::Error, "Failed to handle incoming Twilio phone call. #{ error_message } phone_number=#{ phone_call.from_number } call_sid=#{ params["CallSid"] }"
+            raise Twilio::Rails::Phone::Error, "Failed to handle incoming Twilio phone call. #{error_message} phone_number=#{phone_call.from_number} call_sid=#{params["CallSid"]}"
           end
 
           phone_call.phone_caller = phone_caller
@@ -36,11 +37,13 @@ module Twilio
 
           phone_call
         rescue => e
-          Twilio::Rails.notify_exception(e,
-            message: "Failed to handle incoming Twilio phone call.",
-            context: { params: params, tree: tree },
-            exception_binding: binding
-          )
+          ::Rails.error.report(e,
+            handled: false,
+            context: {
+              message: "Failed to handle incoming Twilio phone call.",
+              params: params,
+              tree: tree
+            })
           raise
         end
       end

data/app/operations/twilio/rails/phone/find_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone

data/app/operations/twilio/rails/phone/finished_call_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -8,7 +9,7 @@ module Twilio
             Twilio::Rails.config.logger.tagged(self.class) { |l| l.warn("Skipping duplicate finished call job") }
           else
             phone_call.update!(finished: true)
-            phone_call.tree.finished_call.call(phone_call) if phone_call.tree.finished_call
+            phone_call.tree.finished_call&.call(phone_call)
           end
         end
       end

data/app/operations/twilio/rails/phone/receive_recording_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -10,12 +11,12 @@ module Twilio
           response = phone_call.responses.find(response_id)
 
           if phone_call.recordings.sid(params["RecordingSid"]).any?
-            Twilio::Rails.config.logger.tagged(self.class) { |l| l.warn("duplicate recording for response_id=#{ response.id } recording_sid=#{ params["RecordingSid"] }") }
+            Twilio::Rails.config.logger.tagged(self.class) { |l| l.warn("duplicate recording for response_id=#{response.id} recording_sid=#{params["RecordingSid"]}") }
           else
             recording = phone_call.recordings.build(
               recording_sid: params["RecordingSid"],
               url: params["RecordingUrl"],
-              duration: params["RecordingDuration"].presence,
+              duration: params["RecordingDuration"].presence
             )
             recording.save!
 

data/app/operations/twilio/rails/phone/start_call_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -21,31 +22,32 @@ module Twilio
             "CallSid" => nil,
             "direction" => "outbound",
             "To" => from,
-            "From" => to,
+            "From" => to
           }
 
           begin
             sid = Twilio::Rails::Client.start_call(url: tree.outbound_url, to: to, from: from, answering_machine_detection: answering_machine_detection)
             params["CallSid"] = sid
           rescue Twilio::REST::TwilioError => e
-            Twilio::Rails.notify_exception(e,
-              message: "Failed to start Twilio phone call. Got REST error response.",
-              context: { params: params },
-              exception_binding: binding
-            )
+            ::Rails.error.report(e,
+              handled: false,
+              context: {
+                message: "Failed to start Twilio phone call. Got REST error response.",
+                params: params
+              })
             raise
           rescue => e
-            Twilio::Rails.notify_exception(e,
-              message: "Failed to start Twilio phone call. Got unknown error.",
-              context: { params: params },
-              exception_binding: binding
-            )
+            ::Rails.error.report(e,
+              handled: false,
+              context: {
+                message: "Failed to start Twilio phone call. Got unknown error.",
+                params: params
+              })
             raise
           end
 
           # TODO: I think this may be a race condition
-          phone_call = Twilio::Rails::Phone::CreateOperation.call(params: params, tree: tree)
-          phone_call
+          Twilio::Rails::Phone::CreateOperation.call(params: params, tree: tree)
         end
       end
     end

data/app/operations/twilio/rails/phone/twiml/after_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -27,7 +28,7 @@ module Twilio
               end
             end
 
-            Twilio::Rails.config.logger.info("after_twiml: #{twiml_response.to_s}")
+            Twilio::Rails.config.logger.info("after_twiml: #{twiml_response}")
             twiml_response.to_s
           end
         end

data/app/operations/twilio/rails/phone/twiml/base_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -20,17 +21,17 @@ module Twilio
               message = message.call(response) if message.is_a?(Proc)
               message = Twilio::Rails::Phone::Tree::Message.new(**message) if message.is_a?(Hash)
               next if message.blank?
-              message = Twilio::Rails::Phone::Tree::Message.new(say: message, voice: tree.config[:voice]) if message.is_a?(String)
+              message = Twilio::Rails::Phone::Tree::Message.new(say: message, voice: voice) if message.is_a?(String)
 
-              raise Twilio::Rails::Phone::InvalidTreeError "unknown message #{ message } is a #{ message.class }" unless message.is_a?(Twilio::Rails::Phone::Tree::Message)
+              raise Twilio::Rails::Phone::InvalidTreeError "unknown message #{message} is a #{message.class}" unless message.is_a?(Twilio::Rails::Phone::Tree::Message)
 
               # TODO: if we want to make a transcript of sent messages this is where we would record outgoing messages
 
               if message.say?
                 value = message.value
                 value = message.value.call(response) if message.value.is_a?(Proc)
-                twiml.say(voice: message.voice || tree.config[:voice], message: value) do |say|
-                  message.block.call(say) if message.block
+                twiml.say(voice: message.voice || voice, message: value) do |say|
+                  message.block&.call(say)
                 end
               elsif message.play?
                 value = message.value
@@ -39,10 +40,15 @@ module Twilio
               elsif message.pause?
                 twiml.pause(length: message.value)
               else
-                raise Twilio::Rails::Phone::InvalidTreeError, "unknown message #{ message }"
+                raise Twilio::Rails::Phone::InvalidTreeError, "unknown message #{message}"
               end
             end
           end
+
+          # @return [String] the voice to use for the TwiML response if configured on the tree.
+          def voice
+            tree.config[:voice] if tree
+          end
         end
       end
     end

data/app/operations/twilio/rails/phone/twiml/error_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -12,7 +13,7 @@ module Twilio
             add_messages(twiml, message_set: messages, response: phone_call.responses.build) if messages
             twiml.hangup
 
-            Twilio::Rails.config.logger.info("error_twiml: #{twiml.to_s}")
+            Twilio::Rails.config.logger.info("error_twiml: #{twiml}")
             twiml.to_s
           end
         end

data/app/operations/twilio/rails/phone/twiml/greeting_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -7,8 +8,8 @@ module Twilio
           input :tree, accepts: Twilio::Rails::Phone::Tree, type: :keyword, required: true
 
           def execute
-            if !phone_caller.valid_north_american_phone_number? && tree.config[:invalid_phone_number]
-              Twilio::Rails::Phone::Twiml::ErrorOperation.call(phone_call_id: phone_call.id, tree: tree, messages: tree.config[:invalid_phone_number])
+            if !phone_caller.valid_phone_number? && tree.config[:invalid_phone_number]
+              Twilio::Rails::Phone::Twiml::InvalidPhoneNumberOperation.call(phone_call_id: phone_call.id, tree: tree)
             else
               after = tree.greeting
               after = Twilio::Rails::Phone::Tree::After.new(after.proc.call(phone_call.responses.build)) if after.proc

data/app/operations/twilio/rails/phone/twiml/invalid_phone_number_operation.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module Twilio
+  module Rails
+    module Phone
+      module Twiml
+        class InvalidPhoneNumberOperation < Twilio::Rails::Phone::Twiml::BaseOperation
+          input :tree, accepts: Twilio::Rails::Phone::Tree, type: :keyword, required: true
+          input :phone_call_id, accepts: Integer, type: :keyword, required: false, default: nil
+
+          def execute
+            twiml = Twilio::TwiML::VoiceResponse.new
+            messages = tree.config[:invalid_phone_number] || []
+            response = phone_call.responses.build if phone_call_id
+            add_messages(twiml, message_set: messages, response: response)
+            twiml.hangup
+
+            Twilio::Rails.config.logger.info("error_twiml: #{twiml}")
+            twiml.to_s
+          end
+        end
+      end
+    end
+  end
+end

data/app/operations/twilio/rails/phone/twiml/prompt_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -12,7 +13,7 @@ module Twilio
 
             response = phone_call.responses.find(response_id)
             prompt = tree.prompts[response.prompt_handle]
-            raise Twilio::Rails::Phone::InvalidTreeError, "cannot find #{ response.prompt_handle } in #{ tree.name }" unless prompt
+            raise Twilio::Rails::Phone::InvalidTreeError, "cannot find #{response.prompt_handle} in #{tree.name}" unless prompt
 
             twiml_response = Twilio::TwiML::VoiceResponse.new do |twiml|
               unless prompt.gather&.interrupt?
@@ -30,7 +31,7 @@ module Twilio
                   input: "dtmf",
                   num_digits: prompt.gather.args[:number],
                   timeout: prompt.gather.args[:timeout],
-                  action_on_empty_result: false,
+                  action_on_empty_result: false
                 }
 
                 args[:finish_on_key] = prompt.gather.args[:finish_on_key] if prompt.gather.args[:finish_on_key]
@@ -57,7 +58,7 @@ module Twilio
                   ),
                   recording_status_callback: ::Twilio::Rails::Engine.routes.url_helpers.phone_receive_recording_path(
                     response_id: response.id
-                  ),
+                  )
                 }
 
                 if prompt.gather.args[:transcribe]
@@ -79,7 +80,7 @@ module Twilio
                   timeout: prompt.gather.args[:timeout],
                   action_on_empty_result: true,
                   language: prompt.gather.args[:language].presence || "en-US",
-                  enhanced: !!prompt.gather.args[:enhanced],
+                  enhanced: !!prompt.gather.args[:enhanced]
                 }
 
                 args[:speech_timeout] = prompt.gather.args[:speech_timeout] if prompt.gather.args[:speech_timeout]
@@ -98,7 +99,7 @@ module Twilio
               end
             end
 
-            Twilio::Rails.config.logger.info("prompt_twiml: #{twiml_response.to_s}")
+            Twilio::Rails.config.logger.info("prompt_twiml: #{twiml_response}")
             twiml_response.to_s
           end
         end

data/app/operations/twilio/rails/phone/twiml/prompt_response_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -15,7 +16,7 @@ module Twilio
             response = Twilio::Rails::Phone::UpdateResponseOperation.call(params: params, response_id: response.id, phone_call_id: phone_call.id)
 
             prompt = tree.prompts[response.prompt_handle]
-            raise Twilio::Rails::Phone::InvalidTreeError, "cannot find #{ response.prompt_handle } in #{ tree.name }" unless prompt
+            raise Twilio::Rails::Phone::InvalidTreeError, "cannot find #{response.prompt_handle} in #{tree.name}" unless prompt
 
             after = prompt.after
             after = Twilio::Rails::Phone::Tree::After.new(after.proc.call(response)) if after.proc

data/app/operations/twilio/rails/phone/twiml/request_validation_failure_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone

data/app/operations/twilio/rails/phone/twiml/timeout_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -20,12 +21,12 @@ module Twilio
                 twiml.hangup
               end
 
-              Twilio::Rails.config.logger.info("final timeout on phone_call##{ phone_call.id }")
-              Twilio::Rails.config.logger.info("timeout_twiml: #{twiml_response.to_s}")
+              Twilio::Rails.config.logger.info("final timeout on phone_call##{phone_call.id}")
+              Twilio::Rails.config.logger.info("timeout_twiml: #{twiml_response}")
               twiml_response.to_s
             else
               prompt = tree.prompts[response.prompt_handle]
-              raise Twilio::Rails::Phone::InvalidTreeError, "cannot find #{ response.prompt_handle } in #{ tree.name }" unless prompt
+              raise Twilio::Rails::Phone::InvalidTreeError, "cannot find #{response.prompt_handle} in #{tree.name}" unless prompt
 
               after = prompt.after
               after = Twilio::Rails::Phone::Tree::After.new(after.proc.call(response)) if after.proc
@@ -36,7 +37,7 @@ module Twilio
 
           private
 
-          def final_timeout?(last_response, count: )
+          def final_timeout?(last_response, count:)
             responses = phone_call.responses.final_timeout_check(count: count, prompt_handle: last_response.prompt_handle)
 
             responses.count == count && responses.all? { |r| r.timeout? }

data/app/operations/twilio/rails/phone/unanswered_call_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone
@@ -13,7 +14,7 @@ module Twilio
             Twilio::Rails.config.logger.tagged(self.class) { |l| l.warn("Skipping duplicate unanswered call job") }
           else
             phone_call.update!(unanswered: true)
-            phone_call.tree.unanswered_call.call(phone_call) if phone_call.tree.unanswered_call
+            phone_call.tree.unanswered_call&.call(phone_call)
           end
         end
       end

data/app/operations/twilio/rails/phone/update_operation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Twilio
   module Rails
     module Phone