twiglet 3.7.2 → 3.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fdfe6db753dcf115b7965ff0cfd9682e23694b43765fd69cdd64986e7fc51d41
-  data.tar.gz: fb110c32f6b4556efd1eb3f4ff673ca7b2e975008973ad296445389d2372a8c8
+  metadata.gz: 1cdc9271dfb49fa3e76ebd4684c2b6ad6164aba6a67c6586ebbd6c13c59d9070
+  data.tar.gz: 77d75cab942109f1d6895d7cf92179df48d8ecccef266beb9bff8d11dc1f942a
 SHA512:
-  metadata.gz: 7d0add22464cd885a861d2d7c5e85d7b7e2a444cb4516c26c261ea9992b1e2988a2a7e47d17d4d123d8131b34198af2d084350c2aa7262b44db513fccc33ea11
-  data.tar.gz: d9772fd14f86d73b17c25a0b4f469b1ff9248ecba733d0d09d31be1d6c6c69c01a2e4d8e1152d68b2b8fce57f1acb13745ae45d5069846df38119663ea8262ae
+  metadata.gz: 46b45ee3e218bf6499264f930d1aa8c4d60200c6b73e444400f640a764f29873eb4c3c49bf86c711cf38faf2c36b7b00005729e87b374180dfa6c214fd47d1bb
+  data.tar.gz: dc62148dac2c6b797eacc86b01b001f54c643732256fbd682adb369eeb522ed6379849ca623fa3e658e7972c6c781149d047423251100e7c4251f84e0702ebd5

data/lib/twiglet/error_serialiser.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module Twiglet
+  class ErrorSerialiser
+    def serialise_error(error)
+      error_fields = {
+        error: {
+          type: error.class.to_s,
+          message: error.message
+        }
+      }
+      add_stack_trace(error_fields, error)
+    end
+
+    private
+
+    def add_stack_trace(hash_to_add_to, error)
+      hash_to_add_to[:error][:stack_trace] = error.backtrace if error.backtrace
+      hash_to_add_to
+    end
+  end
+end

data/lib/twiglet/formatter.rb

@@ -34,7 +34,7 @@ module Twiglet
         ecs: {
           version: '1.5.0'
         },
-        "@timestamp": @now.call.iso8601(3),
+        '@timestamp': @now.call.iso8601(3),
         service: {
           name: @service_name
         },

data/lib/twiglet/logger.rb

@@ -6,6 +6,7 @@ require_relative 'formatter'
 require_relative '../hash_extensions'
 require_relative 'message'
 require_relative 'validator'
+require_relative 'error_serialiser'
 
 module Twiglet
   class Logger < ::Logger
@@ -87,19 +88,9 @@ module Twiglet
     private
 
     def error_message(error, message = nil)
-      error_fields = {
-        error: {
-          type: error.class.to_s,
-          message: error.message
-        }
-      }
-      add_stack_trace(error_fields, error)
+      error_hash = Twiglet::ErrorSerialiser.new.serialise_error(error)
       message = error.message if message.nil? || message.empty?
-      Message.new(message).merge(error_fields)
-    end
-
-    def add_stack_trace(hash_to_add_to, error)
-      hash_to_add_to[:error][:stack_trace] = error.backtrace if error.backtrace
+      Message.new(message).merge(error_hash)
     end
   end
 end

data/lib/twiglet/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Twiglet
-  VERSION = '3.7.2'
+  VERSION = '3.8.0'
 end

data/test/error_serialiser_test.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'minitest/autorun'
+require 'minitest/mock'
+require_relative '../lib/twiglet/error_serialiser'
+
+describe Twiglet::ErrorSerialiser do
+  describe 'logging an exception' do
+    it 'should log an error with backtrace' do
+      1 / 0
+    rescue StandardError => e
+      error_hash = Twiglet::ErrorSerialiser.new.serialise_error(e)
+      assert_equal 'divided by 0', error_hash[:error][:message]
+      assert_equal 'ZeroDivisionError', error_hash[:error][:type]
+      assert_match 'test/error_serialiser_test.rb', error_hash[:error][:stack_trace].first
+    end
+  end
+end

data/test/hash_extensions_test.rb

@@ -17,7 +17,7 @@ describe HashExtensions do
       log: {
         level: 'error'
       },
-      "@timestamp": '2020-05-09T15:13:20.736Z'
+      '@timestamp': '2020-05-09T15:13:20.736Z'
     }
 
     expected = actual.to_nested
@@ -26,8 +26,8 @@ describe HashExtensions do
 
   it 'should convert keys with . into nested objects' do
     actual = {
-      "service.name": 'petshop',
-      "log.level": 'error'
+      'service.name': 'petshop',
+      'log.level': 'error'
     }
 
     nested = actual.to_nested
@@ -38,10 +38,10 @@ describe HashExtensions do
 
   it 'should group nested objects' do
     actual = {
-      "service.name": 'petshop',
-      "service.id": 'ps001',
-      "service.version": '0.9.1',
-      "log.level": 'error'
+      'service.name': 'petshop',
+      'service.id': 'ps001',
+      'service.version': '0.9.1',
+      'log.level': 'error'
     }
 
     nested = actual.to_nested
@@ -54,10 +54,10 @@ describe HashExtensions do
 
   it 'should cope with more than two levels' do
     actual = {
-      "http.request.method": 'get',
-      "http.request.body.bytes": 112,
-      "http.response.bytes": 1564,
-      "http.response.status_code": 200
+      'http.request.method': 'get',
+      'http.request.body.bytes': 112,
+      'http.response.bytes': 1564,
+      'http.response.status_code': 200
     }
 
     nested = actual.to_nested

data/test/logger_test.rb

@@ -63,7 +63,7 @@ describe Twiglet::Logger do
         ecs: {
           version: '1.5.0'
         },
-        "@timestamp": '2020-05-11T15:01:01.000Z',
+        '@timestamp': '2020-05-11T15:01:01.000Z',
         service: {
           name: 'petshop'
         },
@@ -269,19 +269,19 @@ describe Twiglet::Logger do
       @logger.info({ message: 'there' })
 
       expected_output =
-        '{"ecs":{"version":"1.5.0"},"@timestamp":"2020-05-11T15:01:01.000Z",'\
-        '"service":{"name":"petshop"},"log":{"level":"debug"},"message":"hi"}'\
-        "\n"\
-        '{"ecs":{"version":"1.5.0"},"@timestamp":"2020-05-11T15:01:01.000Z",'\
-        '"service":{"name":"petshop"},"log":{"level":"info"},"message":"there"}'\
-        "\n"\
+        '{"ecs":{"version":"1.5.0"},"@timestamp":"2020-05-11T15:01:01.000Z",' \
+        '"service":{"name":"petshop"},"log":{"level":"debug"},"message":"hi"}' \
+        "\n" \
+        '{"ecs":{"version":"1.5.0"},"@timestamp":"2020-05-11T15:01:01.000Z",' \
+        '"service":{"name":"petshop"},"log":{"level":"info"},"message":"there"}' \
+        "\n" \
 
       assert_equal expected_output, @buffer.string
     end
 
     it 'should work with mixed string and symbol properties' do
       log = {
-        "trace.id": '1c8a5fb2-fecd-44d8-92a4-449eb2ce4dcb'
+        'trace.id': '1c8a5fb2-fecd-44d8-92a4-449eb2ce4dcb'
       }
       event = {}
       log['event'] = event
@@ -404,7 +404,7 @@ describe Twiglet::Logger do
         ecs: {
           version: '1.5.0'
         },
-        "@timestamp": '2020-05-11T15:01:01.000Z',
+        '@timestamp': '2020-05-11T15:01:01.000Z',
         service: {
           name: 'petshop'
         },
@@ -460,11 +460,11 @@ describe Twiglet::Logger do
     it 'should be able to convert dotted keys to nested objects' do
       @logger.debug(
         {
-          "trace.id": '1c8a5fb2-fecd-44d8-92a4-449eb2ce4dcb',
+          'trace.id': '1c8a5fb2-fecd-44d8-92a4-449eb2ce4dcb',
           message: 'customer bought a dog',
-          "pet.name": 'Barker',
-          "pet.species": 'dog',
-          "pet.breed": 'Bitsa'
+          'pet.name': 'Barker',
+          'pet.species': 'dog',
+          'pet.breed': 'Bitsa'
         }
       )
       log = read_json(@buffer)
@@ -479,10 +479,10 @@ describe Twiglet::Logger do
     it 'should be able to mix dotted keys and nested objects' do
       @logger.debug(
         {
-          "trace.id": '1c8a5fb2-fecd-44d8-92a4-449eb2ce4dcb',
+          'trace.id': '1c8a5fb2-fecd-44d8-92a4-449eb2ce4dcb',
           message: 'customer bought a dog',
           pet: { name: 'Barker', breed: 'Bitsa' },
-          "pet.species": 'dog'
+          'pet.species': 'dog'
         }
       )
       log = read_json(@buffer)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: twiglet
 version: !ruby/object:Gem::Version
-  version: 3.7.2
+  version: 3.8.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-11 00:00:00.000000000 Z
+date: 2023-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json-schema
@@ -113,6 +113,7 @@ files:
 - examples/rack/request_logger.rb
 - examples/rack/request_logger_test.rb
 - lib/hash_extensions.rb
+- lib/twiglet/error_serialiser.rb
 - lib/twiglet/formatter.rb
 - lib/twiglet/logger.rb
 - lib/twiglet/message.rb
@@ -120,6 +121,7 @@ files:
 - lib/twiglet/validator.rb
 - lib/twiglet/version.rb
 - mkdocs.yml
+- test/error_serialiser_test.rb
 - test/formatter_test.rb
 - test/hash_extensions_test.rb
 - test/logger_test.rb